Commit Graph

19178 Commits

Author SHA1 Message Date
Sonia Aguilar
718401d250
Alerting: Add smart type selection when creating a new alert rule (#71071)
* Add smart type selection when creating a new alert rule

* Auto switch when switch button has not been clicked yet

* remove unnecessay code after the last refacgtor

* Refactor

* Remove unneeded prop

* Move SmartAlertTypeDetector to its own file

* Fix tests

* Refactor: new useSetExpressionAndDataSource hook

* Fix expressions not been propagated when switching from one type to another

* Change texts

* Update tests

* Update text in switch button

* Update texts and tests

* Refactor: move code to getCanSwitch new method

* Move smart alert after queries and remove auto-switch

* Remove expressions and restore them when switching between grafana and cloud type

* Rename previous expression state

* Fix tests

* Add data source name for data source-managed alert selection

* Update reducer when changing cloud data source

* PR review suggestions

* PR review suggestions 2nd part

* PR review suggestions 3th part

* Fix canSwitch

* Update texts on smart alert

---------

Co-authored-by: Virginia Cepeda <virginia.cepeda@grafana.com>
2023-07-13 17:02:47 +02:00
Laura Benz
bb48417ba0
refactor: remove cta for users with reading rights (#71380)
* refactor: remove cta for users with reading rights

* feat: add tests

* refactor: replace folder uid

* refactor: replace folder uid
2023-07-13 17:00:28 +02:00
Gilles De Mey
0be9658064
Alerting: Adds support for toggling common labels (#71497) 2023-07-13 17:00:49 +03:00
Esteban Beltran
0db1d16c09
Plugins: Make datasource instances live targets for the sandbox (#71472) 2023-07-13 15:44:52 +02:00
Esteban Beltran
78efef4ac0
Plugins: App plugins running inside a sandbox div will have height 100% (#71453) 2023-07-13 14:59:20 +02:00
Andrej Ocenas
7ccd73c9ef
DataLinks: Fix bug where links which use built in variables could be hidden (#71372) 2023-07-13 14:38:07 +02:00
Gilles De Mey
bd9b0d6d82
Alerting: Support spaces in alert names for creating silence links (#71280) 2023-07-13 14:24:25 +02:00
Gábor Farkas
98f4bbf7fa
logs: context small improvements (#71546)
adjusted page size
normalize logrow refid
add tracking
2023-07-13 12:18:26 +00:00
Ezequiel Victorero
290deca2eb
Dashboards: Save tags on dashboard creation (#71394)
Dashboards: save tags on dashboard creation
2023-07-13 09:10:46 -03:00
Kristina
0083b2e346
Explore: Support display of multiple tables (#70935)
* Explore: Display multiple tables

* Fix tests

* Add multi table test

* Use refID and not weird custom key

* Remove tempo changes

* Consolidate/clean up some table frame logic

* clean up some code, have meta text in panel
2023-07-13 06:44:42 -05:00
Joey
76a83dd540
Traces: Add inline validation and greater precision to duration fields in span filters (#71404)
* Add inline validation to span filters

* Update filter spans by duration precision

* Update IntervalInput props

* Update validation

* Update span filters

* Update props

* Update test

* Update defaults and duration aria labels
2023-07-13 10:48:31 +01:00
Levente Balogh
324b33146a
Datasources: Pass down the edit-form errors (#69830)
feat: pass the error to the event handler
2023-07-13 11:31:02 +02:00
Sofia Papagiannaki
32ff712e98
Swagger: Fix response for the search users endpoint (#71272)
* Regenerate OpenAPI specs for fetching the latest changes

* Fix swagger annotations for search users API
2023-07-13 11:35:03 +03:00
Andres Martinez Gotor
9990d5025d
Chore: Embed CSV files with the test data source (#71435) 2023-07-13 09:34:40 +02:00
Gábor Farkas
1f55003db2
logs: make sure log-row-react-keys are always unique (#71279) 2023-07-13 08:01:55 +02:00
Sven Grossmann
8a38b5ea3c
Logs: Fix table/logs header toggle (#71485)
fix table header
2023-07-13 07:52:07 +02:00
Nathan Marrs
bd4f8fd280
Chore: Remove console.log from heatmap util file (#71515) 2023-07-12 17:12:36 -07:00
Leon Sorokin
46c5e5417b
Heatmap: Build cell colors during data prep instead of render (#71509) 2023-07-12 18:23:30 -05:00
Ludovic Viaud
5099e88227
Transformation redesign (#70834)
Transformation redesign
2023-07-12 18:35:49 +02:00
Kevin Yu
ee28e9320c
Cloudwatch Logs: Update language definition for Monaco editor (#71402) 2023-07-12 09:25:24 -07:00
Jo
9b22342b91
Auth: Move LDAP debug to Authentication menu (#71285)
* move LDAP page to Authentication

* tweak Auth menu showing permissions
2023-07-12 18:15:02 +02:00
Ashley Harrison
ad3d7d5e94
NestedFolderPicker: Truncate overflowing text, fix selected state (#71444)
* truncate overflowing text, fix selected state

* ensure search state is always clean when opening the overlay
2023-07-12 14:55:27 +01:00
Sven Grossmann
7e4e743a42
Logs: Add experimental table visualisation in Explore (#71120)
* add table visualisation for logs

* add `logsExploreTableVisualisation` feature flag

* add feature flag to visualisation switch

* fix english

* improve state when no data is present

* improve margin

* add missing prop to test

* add tests

* fix logs table height

* fix linting

* move visualisation toggle

* add field config overrides

* update tests

* fix explore test

* fix explore test

* add missing header and revert test changes

* use timefield from logsFrame.ts

* add TODO

* move to new file

* hide fields that should be hidden

* add test to hide fields

* remove unused lines
2023-07-12 15:52:42 +02:00
Juan Cabanas
88bb4a778d
Dashboards: POC split between visualizations and widgets (#70850) 2023-07-12 10:09:22 -03:00
Ihor Yeromin
d9057c010c
A11y: Fix keyboard accessibility in LayerDragDropList (#71386)
fix(a11y): drag and drop layer list
2023-07-12 14:14:12 +02:00
Gábor Farkas
fdb8257007
Elasticsearch: Fix histogram colors in backend mode (#71442)
elastic: backend-mode: fix histogram colors
2023-07-12 13:59:51 +02:00
Sonia Aguilar
82a5770376
Alerting: Fix state in expressions footer (#71441)
Fix state in expressions footer
2023-07-12 13:44:39 +02:00
Torkel Ödegaard
e7797ac439
SceneDashboard: Adds menu to panels, a start for inspect drawer state (#71194)
* Began work on panel menu

* SceneDashboard: Basic state handling for inspect panel

* Switched to using scene url sync instead

* Updated

* Update comment on hack

* Fixed url synnc issues and more / better DashboardsLoader tests

* Progress on test

* Updates

* Progress

* Progress

* Update

* Update

* Update

* Update

* Update scenes lib

* Update

* Update

---------

Co-authored-by: Dominik Prokop <dominik.prokop@grafana.com>
2023-07-12 13:37:26 +02:00
Ashley Harrison
580345306b
Nested folders: Only show edit title button if user has permissions (#71426)
only show edit title button if user has permissions
2023-07-12 11:07:16 +01:00
Ashley Harrison
29ed310af9
Nested folder picker: Move options into overlay (#71042)
* move options into overlay

* add some unit tests

* Update public/app/features/browse-dashboards/components/BrowseActions/MoveModal.tsx

Co-authored-by: Tobias Skarhed <1438972+tskarhed@users.noreply.github.com>

* minor refactoring based on review comments

* just pass in uid

---------

Co-authored-by: Tobias Skarhed <1438972+tskarhed@users.noreply.github.com>
2023-07-12 10:37:08 +01:00
Torkel Ödegaard
dc71d36958
AppChromeService: Fixes update to breadcrumb parent URL (#71410)
AppChromeService: Fixes update to parent url
2023-07-12 10:34:13 +02:00
Joey
6615418df8
Tracing: Show next/prev buttons when span filters are collapsed (#71025)
* Show next/prev buttons when span filters are collapsed

* Update test

* Remove imports

* Update lint

* Prettier

* Update test

* Update styling
2023-07-12 07:52:07 +01:00
Kevin Yu
a2a890e85b
Cloudwatch: Add comment and regexp to TokenTypes interface (#71399)
* Cloudwatch: Add comment and regexp to TokenTypes interface

* fix lint
2023-07-11 14:43:08 -07:00
Ashley Harrison
2650aa5600
Internationalization: Correctly generate plural forms (#71341)
* user essentials mob! 🔱

lastFile:public/locales/pseudo-LOCALE/grafana.json

* user essentials mob! 🔱

* user essentials mob! 🔱

lastFile:contribute/internationalization.md

* user essentials mob! 🔱

lastFile:contribute/internationalization.md

* move pseudo generation to precommit hook if en-US file is modified

Co-authored-by: L-M-K-B <48948963+L-M-K-B@users.noreply.github.com>
Co-authored-by: tskarhed <1438972+tskarhed@users.noreply.github.com>

* fix unit tests

---------

Co-authored-by: Joao Silva <joao.silva@grafana.com>
Co-authored-by: joshhunt <josh@trtr.co>
Co-authored-by: Roxana Turc <anamaria-roxana.turc@grafana.com>
Co-authored-by: eledobleefe <laura.fernandez@grafana.com>
Co-authored-by: L-M-K-B <48948963+L-M-K-B@users.noreply.github.com>
Co-authored-by: tskarhed <1438972+tskarhed@users.noreply.github.com>
2023-07-11 16:37:01 +01:00
Joao Silva
2b379ba7ea
Forms: Remove usage of sass styles in Group By and Reduce Transformations (#71223) 2023-07-11 15:48:23 +01:00
Sven Grossmann
9ddba37dbc
Logs: Fix nanosecond partition in log context (#71346)
* add ts partition

* fix setting wrong loadingstate

* improve setContext

* update context and test
2023-07-11 16:20:41 +02:00
RoxanaAnamariaTurc
7fdf855932
I18n: Outstanding navigation strings (#71208)
* I18n: Outstanding navigation strings

* Resolving conflicts
2023-07-11 15:10:50 +01:00
Josh Hunt
2e5f733d2d
Dashboards: Fix frontend exception when backend fails to save dashboard (#71144) 2023-07-11 13:33:09 +00:00
RoxanaAnamariaTurc
535b5659e4
I18n: Outstanding navigation strings marked up for translation (#71281) 2023-07-11 14:13:46 +01:00
Andrej Ocenas
6f102ccad0
Flamegraph: Remove feature toggle for sandwich view and color schemes (#71305) 2023-07-11 14:58:43 +02:00
Matias Chomicki
b8fbeb084a
Logs: Display log row menu cell on displayed fields (#71300)
* LogRowMenuCell: create component

* LogRowMessage: use new LogRowMenuCell component

* LogRowMessage: turn into functional component

* LogRowMenuCell: memoize component

* LogRowMessage: remove cx

* LogMessage: create component from function

* LogRowMessageDisplayedFields: turn into component

* LogRowMessageDisplayedFields: add LogRowMenuCell

* LogRowMessageDisplayedFields: rename prop and pass missing context prop

* LogRowMessageDisplayedFields: add unit test
2023-07-11 14:50:53 +02:00
Ivan Ortega Alba
699e499cc7
Variables: Page refreshes hitting enter to select a variable value (#70996) 2023-07-11 12:30:08 +02:00
Gilles De Mey
82f0ef6871
Alerting: Add support for additional colors in MetaText (#71299)
add support for additional colors in MetaText
2023-07-11 11:11:25 +02:00
Giuseppe Guerra
9945c02405
Connections console: Add Angular badge for Angular plugins (#70789)
* Angular deprecation: Add Angular badge in plugin catalog page

* Angular deprecation: Add alert in plugin details page

* Angular deprecation: Disable install button if for Angular plugins

* removed extra console.log

* Add tests for Angular badge

* Add tests for PluginDetailsAngularDeprecation

* Add tests for InstallControlsButton

* Add tests for ExternallyManagedButton

* Table tests

* Catalog: Update angular deprecation message

* PR review feedback

* Update tests

* Update copy for angular tooltip and alert

* Update tests

* Fix test warnings

* Fix angularDetected not being set for remote catalog plugins

* Dynamic alert text based on grafana config

* Connections: Add Angular badge to Angular plugins

* Add test for connections console angular badge

* Fix tests

* Fix tests

* Moved tests

* PR review: Use ternary operator instead of &&

* Fixes to how to use Card component

* comment out desc

* Do not use deprecated theme.v1 and theme.typography.size

* pr review feedback

---------

Co-authored-by: Torkel Ödegaard <torkel@grafana.com>
2023-07-11 10:12:09 +02:00
Sven Grossmann
212239aedb
LogContext: Fix a bug where multiple logs with similar nanosecond timestamps were loaded too often (#71319)
fix bug with multiple ns logs
2023-07-11 10:00:10 +02:00
Joey
a56a279c67
Traces: Filtering by span id (#71275)
* Filter by span id

* Update test
2023-07-11 08:59:36 +01:00
Joey
f98f6ea391
Tracing: Make show filters only keyboard accessible (#70890)
* Make show filters only keyboard accessible

* Update test

* Update styling
2023-07-11 08:05:11 +01:00
Matthew Jacobson
e3787de470
Alerting: Fix Alertmanager change detection for receivers with secure settings (#71307)
* Alerting: Make ApplyAlertmanagerConfiguration only decrypt/encrypt new/changed secure settings

Previously, ApplyAlertmanagerConfiguration would decrypt and re-encrypt all secure settings. However, this caused re-encrypted secure settings to be included in the raw configuration when applied to the embedded alertmanager, resulting in changes to the hash. Consequently, even if no actual modifications were made, saving any alertmanager configuration triggered an apply/restart and created a new historical entry in the database.

To address the issue, this modifies ApplyAlertmanagerConfiguration, which is called by POST `api/alertmanager/grafana/config/api/v1/alerts`, to decrypt and re-encrypt only new and updated secure settings. Unchanged secure settings are loaded directly from the database without alteration.

We determine whether secure settings have changed based on the following (already in-use) assumption: Only new or updated secure settings are provided via the POST `api/alertmanager/grafana/config/api/v1/alerts` request, while existing unchanged settings are omitted.

* Ensure saving a grafana-managed contact point will only send new/changed secure settings

Previously, when saving a grafana-managed contact point, empty string values were transmitted for all unset secure settings. This led to potential backend issues, as it assumed that only newly added or updated secure settings would be provided.

To address this, we now exclude empty ('', null, undefined) secure settings, unless there was a pre-existing entry in secureFields for that specific setting. In essence, this means we only transmit an empty secure setting if a previously configured value was cleared.

* Fix linting

* refactor omitEmptyUnlessExisting

* fixup

---------

Co-authored-by: Gilles De Mey <gilles.de.mey@gmail.com>
2023-07-11 08:23:07 +02:00
Ryan McKinley
09cc63329f
XYChart: Improve base options setup (#67878) 2023-07-10 17:54:01 -07:00
Ihor Yeromin
4206a4d16a
Dashboard: Slider overlapping with right input field (#71282)
* fix(slider): input field left margin

* fix(slider): use theme spacing variable

Co-authored-by: Joao Silva <100691367+JoaoSilvaGrafana@users.noreply.github.com>

---------

Co-authored-by: Joao Silva <100691367+JoaoSilvaGrafana@users.noreply.github.com>
2023-07-10 21:36:37 +02:00