Misi
d411ce2664
Auth: Use sessionStorage instead of cookie for automatic redirection ( #92759 )
...
* WIP: working as expected, has to be tested
* Rename query param, small changes
* Remove unused code
* Address feedback
* Cleanup
* Use the feature toggle to control the behaviour
* Use the toggle on the FE too
* Prevent the extra redirect/reload
Co-authored-by: Josh Hunt <joshhunt@users.noreply.github.com >
* Return to login if user is not authenticated
* Add tracking issue
* Align BE redirect constructor to locationSvc
2024-09-24 18:38:09 +02:00
Syerikjan Kh
715ee35abc
RBAC: Check forceLogin inside CanAdminPlugins ( #93449 )
2024-09-20 09:35:58 -04:00
Jan-Otto Kröpke
e2bce38a79
App Plugins: Allow resource handle to define Cache-Control Header ( #92559 )
2024-09-17 10:28:38 +02:00
Adela Almasan
f64b121ddb
Canvas: Allow API calls to grafana origin ( #91822 )
...
* allow post URL
* check for config
* allow relative paths
* add allowed internal pattern; add checks for method
* update defaults.ini
* add custom header
* update config comment
* use globbing, switch to older middleware - deprecated call
* add codeowner
* update to use current api, add test
* update fall through logic
* Update pkg/middleware/validate_action_url.go
Co-authored-by: Dan Cech <dcech@grafana.com >
* Update pkg/middleware/validate_action_url.go
Co-authored-by: Dan Cech <dcech@grafana.com >
* add more tests
* Update pkg/middleware/validate_action_url_test.go
Co-authored-by: Dan Cech <dcech@grafana.com >
* fix request headers
* add additional tests for all verbs
* fix request headers++
* throw error when method is unknown
---------
Co-authored-by: Ryan McKinley <ryantxu@gmail.com >
Co-authored-by: Brian Gann <bkgann@gmail.com >
Co-authored-by: Brian Gann <briangann@users.noreply.github.com >
Co-authored-by: Dan Cech <dcech@grafana.com >
2024-09-10 10:45:27 -04:00
Todd Treece
733ae1f099
Chore: Skip gzip for apiserver routes ( #92245 )
2024-08-21 23:47:58 +03:00
Karl Persson
8bcd9c2594
Identity: Remove typed id ( #91801 )
...
* Refactor identity struct to store type in separate field
* Update ResolveIdentity to take string representation of typedID
* Add IsIdentityType to requester interface
* Use IsIdentityType from interface
* Remove usage of TypedID
* Remote typedID struct
* fix GetInternalID
2024-08-13 10:18:28 +02:00
Kevin Minehart
c326d865c5
RBAC: Allow plugins to use scoped actions ( #90946 )
...
Co-authored-by: gamab <gabriel.mabille@grafana.com >
2024-07-25 17:22:42 +03:00
Ryan McKinley
9db3bc926e
Identity: Rename "namespace" to "type" in the requester interface ( #90567 )
2024-07-25 12:52:14 +03:00
Charandas
c210617735
K8s: use contexthandler in standalone handler chain ( #90102 )
2024-07-08 12:22:10 -07:00
Dave Henderson
7ac757afcb
infra(tracing): Fix span naming order-of-operations bug ( #90025 )
2024-07-04 07:05:14 -04:00
Dave Henderson
4ec4994e89
infra(tracing): Always end started spans ( #90016 )
...
Signed-off-by: Dave Henderson <dave.henderson@grafana.com >
2024-07-03 16:25:57 -04:00
Marcus Andersson
04f39457cf
Chore: Remove sensitive information from presigned URLs prior to logging ( #87035 )
...
Co-authored-by: Will Browne <wbrowne@users.noreply.github.com >
Co-authored-by: Dan Cech <dcech@grafana.com >
Co-authored-by: Andres Martinez Gotor <andres.martinez@grafana.com >
2024-06-24 14:53:42 +02:00
Dave Henderson
3bbc821131
Metrics: Add ability to disable classic histogram for HTTP metric ( #88315 )
...
metrics: Add ability to disable classic histogram for HTTP metric
Signed-off-by: Dave Henderson <dave.henderson@grafana.com >
2024-06-18 15:37:44 -04:00
Ryan McKinley
99d8025829
Chore: Move identity and errutil to apimachinery module ( #89116 )
2024-06-13 07:11:35 +03:00
Timur Olzhabayev
4761326568
Fix: Proper plugin logo loading depending on staging ( #88247 )
...
* making logos respect the staging
* making it work when served from subfolders
* fixing helper test
2024-05-27 10:26:30 +02:00
Karl Persson
c4cfee8d96
User: support setting org and help flags though update function ( #86535 )
...
* User: Support setting active org through update function
* User: add support to update help flags through update function
2024-04-29 08:53:05 +02:00
Karl Persson
0fa983ad8e
AuthN: Use typed namespace id inside authn package ( #86048 )
...
* authn: Use typed namespace id inside package
2024-04-24 09:57:34 +02:00
Alex Khomenko
44e1bce55a
Feature toggles: Remove dashboardEmbed toggle ( #86587 )
2024-04-19 12:48:08 +02:00
carrychair
0913324668
Chore: Remove repetitive words ( #84132 )
...
remove repetitive words
Signed-off-by: carrychair <linghuchong404@gmail.com >
2024-03-11 08:55:18 -04:00
김은빈
96dfb385ca
Grafana: Replace magic number with a constant variable in response status ( #80132 )
...
* Chore: Replace response status with const var
* Apply suggestions from code review
Co-authored-by: Sofia Papagiannaki <1632407+papagian@users.noreply.github.com >
* Add net/http import
---------
Co-authored-by: Sofia Papagiannaki <1632407+papagian@users.noreply.github.com >
2024-02-27 18:39:51 +02:00
Torkel Ödegaard
8f36f905ee
SceneSolo: Minor fixes ( #82289 )
...
* SceneSolo: Minor fixes
* remove logging
2024-02-12 16:23:12 +01:00
Carl Bergquist
c9de794d7f
instrumentation: these features have been enabled for a while ( #81617 )
...
Signed-off-by: bergquist <carl.bergquist@gmail.com >
2024-02-06 00:29:41 -08:00
Marcus Efraimsson
6768c6c059
Chore: Remove public vars in setting package ( #81018 )
...
Removes the public variable setting.SecretKey plus some other ones.
Introduces some new functions for creating setting.Cfg.
2024-01-23 12:36:22 +01:00
Torkel Ödegaard
e924627659
Frontend: Reload the browser when backend configuration/assets change ( #79057 )
...
* Detect frontend asset changes
* Update
* merge main
* Frontend: Detect new assets / versions / config changes (#79258 )
* avoid first check
* Updates and add tests
* Update
* Update
* Updated code
* refine
* use context
---------
Co-authored-by: Ryan McKinley <ryantxu@gmail.com >
2024-01-04 08:00:07 +01:00
Will Browne
0b511aaace
Plugins: Add backend check for app page role access ( #78269 )
...
* add backend check for roles
* tidy
* fix tests
* incorporate rbac
* fix linter
* apply PR feedback
* add tests
* fix logic
* add comment
* apply PR feedback
2023-12-18 16:12:46 +01:00
Ezequiel Victorero
864d91ed3e
Export: Remove no-store headers in pdf and image previews ( #78844 )
2023-12-18 09:21:57 -03:00
Torkel Ödegaard
ed128ea964
Frontend: Foundations for multi tenant frontend ( #78815 )
...
* Frontend: Foundations for multi tenant frontend
* improve manifest parsing for multi-tenant frontend (#78876 )
* add test
* add test
* ??
* Updates
* Added cache
* test cleanup
* lint
* fix test
* fix error templates
* cleanup
* remove copy
* revert changes to list testdata
* comment cleanup
* prepare integration tests
* Remove integrety
---------
Co-authored-by: Ryan McKinley <ryantxu@gmail.com >
2023-12-05 08:34:22 +01:00
Oscar Kilhed
4c4f11f4b3
Avatar: Allow browser caching of /avatar/ ( #78314 )
...
don't set no-store headers to /avatar/
2023-11-22 17:41:54 +01:00
Ryan McKinley
f69fd3726b
FeatureToggles: Add context and and an explicit global check ( #78081 )
2023-11-14 12:50:27 -08:00
Gabriel MABILLE
420fb56fda
RBAC: Fix plugins pages access-control ( #76321 )
...
* RBAC: Fix plugins pages access-control
* Better comment
Co-authored-by: Ieva <ieva.vasiljeva@grafana.com >
* Add a small comment on connections/datasources routes
---------
Co-authored-by: Ieva <ieva.vasiljeva@grafana.com >
2023-10-12 10:46:43 +02:00
Jo
dcd0c6b11e
Identity: Unfurl OrgID in pkg/services to allow using identity.Requester interface ( #76113 )
...
Unfurl OrgID in pkg/services to allow using identity.Requester interface
2023-10-09 10:40:19 +02:00
Carl Bergquist
0fc403d116
Instrumentation: Enable native histograms for HTTP requests ( #75731 )
...
Signed-off-by: bergquist <carl.bergquist@gmail.com >
2023-10-03 20:23:55 +02:00
Marcus Efraimsson
e4c1a7a141
Tracing: Standardize on otel tracing ( #75528 )
2023-10-03 14:54:20 +02:00
Carl Bergquist
3c8cea0764
instrumentation: rename team to grafana_team to improve alert routing. ( #75860 )
...
Signed-off-by: bergquist <carl.bergquist@gmail.com >
2023-10-03 12:25:01 +02:00
Karl Persson
7a38090bc0
AuthN: Fix namespaces for anonymous and render ( #75661 )
...
* AuthN: remove IsAnonymous from identity struct and set correct namespace for anonymous and render
* Don't parse user id for render namespace
2023-09-29 09:10:33 +02:00
Marcus Efraimsson
0128d0403f
Tracing: Use tracing.InitializeTracerForTest ( #75479 )
2023-09-27 09:51:57 +02:00
Carl Bergquist
e5fbc4a4cd
web: add slo group to request meta ( #74765 )
...
Signed-off-by: bergquist <carl.bergquist@gmail.com >
2023-09-22 11:52:28 +03:00
Marcus Efraimsson
8ee43f3705
Instrumentation: Add status_source label to request metrics/logs ( #74114 )
...
Ref #68480
Co-authored-by: Giuseppe Guerra <giuseppe.guerra@grafana.com >
2023-09-11 12:13:13 +02:00
Ryan McKinley
025b2f3011
Chore: use any rather than interface{} ( #74066 )
2023-08-30 18:46:47 +03:00
Carl Bergquist
bd7523381e
web: removes unused function from request metadata ( #73910 )
...
Signed-off-by: bergquist <carl.bergquist@gmail.com >
2023-08-28 13:40:21 +02:00
Marcus Efraimsson
040b7d2571
Chore: Add errutils helpers ( #73577 )
...
Add helpers for the errutil package in favor of errutil.NewBase.
2023-08-22 12:52:24 +02:00
Carl Bergquist
243b757168
Middleware: Add team metadata to HTTP handlers ( #71010 )
...
Signed-off-by: bergquist <carl.bergquist@gmail.com >
2023-08-16 15:05:19 +02:00
Karl Persson
e53e22ef2a
Contexthandler: Remove code that is no longer used ( #73101 )
...
* Contexthandler: remove dead code
* Contexthandler: Add tests
* Update pkg/tests/api/alerting/api_alertmanager_test.go
Co-authored-by: Jo <joao.guerreiro@grafana.com >
---------
Co-authored-by: Jo <joao.guerreiro@grafana.com >
2023-08-09 15:17:59 +02:00
Karl Persson
144e4887ee
Auth: Use authn.Service for all tests ( #72921 )
...
* Dashboards: Fix tests when authn broker is enabled.
StarService was not configured for tests, the call was guarded by !c.IsSignedIn
* Change default to be anon user to match expectations from tests
* OAuth: rewrite tests to work with authn.Service
* Setup template renderer by default
* Extract cookie options from cfg instead of relying on global variables
* Fix test to work with authn service
* Middleware: rewrite auth tests
* Remvoe session cookie if we cannot refresh access token
2023-08-09 08:54:52 +02:00
Ben Sully
51c94bccd7
api: ignore /api/gnet proxy when gzipping responses ( #71437 )
...
This PR adds /api/gnet to the list of ignored paths in the gzip middleware.
Without this, when gzip is enabled (`server.enable_gzip = true`), responses
from the gnet proxy are double compressed: once by grafana.com and once by
Grafana itself. With this change we only do one round of compression for these
endpoints.
To test this out, try a request like this with `server.enable_gzip = true`
(after setting `GCOM_TOKEN` to a valid grafana.com token; you may need to
change the 'bsull' slug, too):
curl -v --user admin:admin \
-H "X-Api-Key: $GCOM_TOKEN" \
-H 'Accept-Encoding: gzip' \
localhost:3000/api/gnet/instances/bsull/provisioned-plugins/grafana-ml-app | gzip -d
Note that there are two Content-Encoding: gzip headers before this PR, and
the output is still compressed even after the `gzip -d`. After this PR things
look as expected.
2023-07-13 07:51:25 +01:00
Alex Khomenko
420b19e0e4
Dashboards: Add dashboard embed route ( #69596 )
...
* Dashboard embed: Set up route
* Dashboard embed: Cleanup
* Dashboard embed: Separate routes
* Dashboard embed: Render dashboard page
* Dashboard embed: Add toolbar
* Dashboard embed: Send JSON on save
* Dashboard embed: Add JSON param
* Dashboard embed: Make the dashboard editable
* Fix sending dashboard to remote server
* Add notifications
* Add "dashboardEmbed" feature toggle
* Use the toggle
* Update toggles
* Add toggle on backend
* Add get JSON endpoint
* Add drawer
* Close drawer on success
* Update toggles
* Cleanup
* Update toggle
* Allow embedding for the d-embed url
* Allow embedding via custom X-Allow-Embedding header
* Use callbackUrl
* Cleanup
* Update public/app/features/dashboard/containers/EmbeddedDashboardPage.tsx
Co-authored-by: kay delaney <45561153+kaydelaney@users.noreply.github.com >
* Use theme for spacing
* Update toggles
* Update public/app/features/dashboard/components/EmbeddedDashboard/SaveDashboardForm.tsx
Co-authored-by: Polina Boneva <13227501+polibb@users.noreply.github.com >
* Add select data source modal
---------
Co-authored-by: kay delaney <45561153+kaydelaney@users.noreply.github.com >
Co-authored-by: Polina Boneva <13227501+polibb@users.noreply.github.com >
2023-07-06 17:43:20 +03:00
Jo
d6c468c1c2
Auth: Add empty role definition ( #64694 )
...
* Allow setting role as None
Co-authored-by: gamab <gabi.mabs@gmail.com >
Seeking for places where role.None would be used
Co-authored-by: Jguer <joao.guerreiro@grafana.com >
Adding None role to the frontend
Co-authored-by: Jguer <joao.guerreiro@grafana.com >
unify org role declaration and remove from add permission
fix backend test
fix backend lint
* remove role none from frontend
* Simplify checks
Co-authored-by: Kalle Persson <kalle.persson@grafana.com >
* nits
---------
Co-authored-by: Kalle Persson <kalle.persson@grafana.com >
2023-07-06 15:40:06 +02:00
Michael Mandrus
66d2214c3b
Config: Add configuration option to define custom user-facing general error message for certain error types ( #70023 )
...
---------
Co-authored-by: Summer Wollin <summer.wollin@grafana.com >
Co-authored-by: Christopher Moyer <35463610+chri2547@users.noreply.github.com >
Co-authored-by: Arati R. <33031346+suntala@users.noreply.github.com >
2023-06-16 10:46:47 -05:00
Ieva
4980b64274
RBAC: Remove legacy ac from authorization middleware ( #68898 )
...
remove legacy AC fallback from RBAC middleware, and some unused auth logic
2023-05-24 09:49:42 +01:00
Carl Bergquist
692bb9ed1a
Instrumentation: Add support for instrumenting database queries ( #66022 )
...
Signed-off-by: bergquist <carl.bergquist@gmail.com >
Co-authored-by: Christopher Moyer <35463610+chri2547@users.noreply.github.com >
2023-04-28 15:19:06 +02:00