Alexander Emelin
7aee0deb38
live: log error on dashboard subscribe ( #35095 )
2021-06-02 18:02:54 +03:00
Marcus Efraimsson
d953e200f0
Chore: Refactor short url api test ( #35051 )
...
Use a mock of the short URL service rather than real one which requires database access.
Ref #34696
2021-06-01 20:34:59 +02:00
Carl Bergquist
f432fbd793
Instrumentation: add more tracing in the auth context handler. ( #34939 )
...
ref https://github.com/grafana/grafana/issues/29489
Signed-off-by: bergquist <carl.bergquist@gmail.com>
2021-05-31 21:39:28 +02:00
Ganesh Vernekar
a23674ef99
Alerting: Migrate tags as labels and not annotations ( #34990 )
...
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
2021-05-31 19:47:17 +05:30
Ganesh Vernekar
7c25465b3a
Alerting: Migrate paused alerts to silences ( #34898 )
...
* Alerting: Migrate paused alerts to silences
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
* Fix lint
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
2021-05-31 17:30:58 +05:30
Sofia Papagiannaki
355be158b7
[Alerting]: fix/cleanup API examples ( #34588 )
2021-05-31 11:18:29 +03:00
Chip Wolf
badec6c6ad
Alerting: Add support for configuring avatar URL for the Discord notifier ( #33355 )
...
Co-authored-by: achatterjee-grafana <70489351+achatterjee-grafana@users.noreply.github.com>
2021-05-28 23:00:21 +02:00
ying-jeanne
b391e43472
[Dashboard] Revert feature toggle trimdefaults ( #34888 )
...
* Revert "solve comments and retrigger the test"
This reverts commit f08d2d9ecacc09ceb85346fe8ed5963b3ceee16e3b7f3b8e15b9c62608768e4c4d7c93d01cfcc2ed
2021-05-28 22:29:30 +02:00
Owen Diehl
cc38613ba4
alerting: fixes per-receiver metric cardinality ( #34915 )
2021-05-28 12:31:23 -04:00
Owen Diehl
9aca032d10
Alerting/consistent api errors ( #34858 )
...
* consolidates alertmanager api errors
* util & testing consistent errors
* consistent errors for rest of ngalert apis
* updates expected errors in testware
* bump ci
* linting
* unrelated: dashboard.go lint
2021-05-28 11:55:03 -04:00
Kyle Brandt
b47e7d12e6
Alerting: Extract values from MD expr alerts ( #34757 )
...
When using mulit-dimensional Grafana managed alerts (e.g. SSE math) extract refIds values and labels so they can be shown in the notification and dashboards.
2021-05-28 11:04:20 -04:00
Ganesh Vernekar
ad6648b649
Alerting: Do no hard fail on finding discontinued channels on migration ( #34894 )
...
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
2021-05-28 16:06:30 +02:00
Alexander Emelin
b73d168753
live: fix log message ( #34879 )
2021-05-28 11:33:55 +02:00
Danilo Bargen
83a83de10a
Clarify that Threema Gateway Alerts support only Basic IDs ( #34828 )
...
Threema Gateway supports two types of IDs: Basic IDs (where the
encryption is managed by the API server) and End-to-End IDs (where the
keys are managed by the user).
This plugin currently does not support End-to-End IDs (since it's much
more complex to implement, because the encryption needs to happen
locally). Add a few clarifications to the UI.
Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com>
2021-05-28 08:54:55 +02:00
Alexander Emelin
6d750c000e
Live: max_connections option with strict default ( #34634 )
...
this should help Live to be enabled by default but still
do not affect setups with lots of simultenious users. To
properly handle many WS connections Grafana administrators
should tune infrastructure a bit - for example increase a
number of open files for a process. Will be in more details
in documentation.
2021-05-27 22:03:18 +03:00
Carl Bergquist
a10fa5cad3
Instrumentation: Start tracing database requests ( #34572 )
...
Signed-off-by: bergquist <carl.bergquist@gmail.com>
2021-05-27 13:55:33 +02:00
Domas
347273cdea
Alerting: check upstream response content type in lotex proxy ( #34760 )
2021-05-27 14:12:29 +03:00
Ryan McKinley
67028af99e
Live: check schema equality between push messages ( #34548 )
2021-05-27 12:55:42 +03:00
ying-jeanne
c59a2e1bcf
remove feature toggle + add libraryPaneldefinition ( #34488 )
...
* remove feature toggle + add libraryPaneldefinition
* update doc
* update comments
* Apply suggestions from code review
Co-authored-by: Diana Payton <52059945+oddlittlebird@users.noreply.github.com>
* fix typo
* remove post trim
* update api doc
* solve comments and retrigger the test
Co-authored-by: Diana Payton <52059945+oddlittlebird@users.noreply.github.com>
2021-05-27 11:14:58 +02:00
Joan López de la Franca Beltran
f601921670
Usage Stats: Make the UsageStatsService extension point more flexible ( #34778 )
...
* Usage Stats: Rename service to use a more idiomatic name
* Usage Stats: Update MetricsFunc definition and implementations
* Revert "Usage Stats: Rename service to use a more idiomatic name"
This reverts commit 910ecce3e8
2021-05-27 10:53:10 +02:00
David Parrott
20d356947c
set state correctly and test ( #34680 )
2021-05-26 11:37:42 -07:00
Alexander Emelin
4221f2d147
Live: grafana_live namespace for centrifuge prom metrics ( #34712 )
2021-05-26 10:12:24 -07:00
Ganesh Vernekar
d69c21acb6
NGAlert: Update the default template to include more URLs ( #34715 )
...
* NGAlert: Update the default template to include more URLs
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
* Fix tests
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
2021-05-26 16:49:39 +02:00
Ganesh Vernekar
b168223029
NGAlert: Add integration tests for remaining notification channels ( #34662 )
...
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
2021-05-26 16:33:55 +05:30
Marcus Andersson
e19b3df1a9
Alerting: added possibility to preview grafana managed alert rules. ( #34600 )
...
* starting to add eval logic.
* wip
* first version of test rule.
* reverted file.
* add info colum to result to show error or (with CC evalmatches)
* fix labels in evalmatch
* fix be test
* refactored using observables.
* moved widht/height div to outside panel rendere.
* adding docs api level.
* adding container styles to error div.
* increasing size of preview.
Co-authored-by: kyle <kyle@grafana.com>
2021-05-26 10:06:28 +02:00
Alexander Emelin
063e1b5ff5
Live: use latest changes in Go SDK to deal with streaming frames ( #34668 )
2021-05-25 10:29:02 -07:00
Owen Diehl
0e0ed43153
Alerting/testing promql extraction ( #34665 )
...
* promql compat for marshaling
* extracts upstream instant queries into data frame for alerting
* eval string parity
2021-05-25 11:54:50 -04:00
Emil Tullstedt
0f4806db8a
Access control: Rename predefined roles to fixed roles (code) ( #34469 )
...
* s/grafana:roles:/fixed:/
* Update free text references to predefined roles
2021-05-25 15:36:01 +02:00
Sofia Papagiannaki
b48832c0f7
[Alerting]: alertmanager notifier fixes ( #34575 )
2021-05-24 16:09:29 +03:00
Hugo Häggmark
7b17801047
LibraryPanels: Fixes error when importing plugin dashboard ( #34557 )
2021-05-24 09:31:34 +02:00
Hugo Häggmark
7204a64717
LibraryElements: Creates usage stats for panels and variables ( #34476 )
...
* LibraryPanels: Adds usage collection
* Refactor: renames Panel and Variable consts
* Chore: initialize stats
* Refactor: moves library element migrations to migration namespace
2021-05-24 06:11:01 +02:00
Sofia Papagiannaki
23939eab10
[Alerting]: namespace fixes ( #34470 )
...
* [Alerting]: forbid viewers for updating rules if viewers can edit
check for CanSave instead of CanEdit
* Clear ngalert tables when deleting the folder
* Apply suggestions from code review
* Log failure to check save permission
Co-authored-by: gotjosh <josue@grafana.com>
2021-05-20 15:49:33 +03:00
Ganesh Vernekar
95ee5f01b5
NGAlert: Do not pick a random default channel if no default exists ( #34465 )
...
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
2021-05-20 10:30:09 +02:00
gotjosh
7b04278834
Alerting: Opsgenie notification channel ( #34418 )
...
* Alerting: Opsgenie notification channel
This translate the opsgenie notification channel from the old alerting
system to the new alerting system with a few changes:
- The tag system has been replaced in favour of annotation.
- TBD
- TBD
Signed-off-by: Josue Abreu <josue@grafana.com>
* Fix template URL
* Bugfig: dont send resolved when autoClose is false
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
* Fix integration tests
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
* Fix URLs in all other channels
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
Co-authored-by: Ganesh Vernekar <ganeshvern@gmail.com>
2021-05-20 10:12:08 +02:00
Hugo Häggmark
740f1ab3e2
LibraryPanels: Fixes connections after dashboard import ( #34461 )
2021-05-20 09:40:23 +02:00
Hugo Häggmark
21d6f02dd3
LibraryElements: replaces is_folder=1 usages with correct dialect string ( #34453 )
2021-05-20 07:22:34 +02:00
Marcus Efraimsson
348e76fc8e
Datasource: Shared HTTP client provider for core backend data sources and any data source using the data source proxy ( #33439 )
...
Uses new httpclient package from grafana-plugin-sdk-go introduced
via grafana/grafana-plugin-sdk-go#328 .
Replaces the GetHTTPClient, GetTransport, GetTLSConfig methods defined
on DataSource model.
Longer-term the goal is to migrate core HTTP backend data sources to use the
SDK contracts and using httpclient.Provider for creating HTTP clients and such.
Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com>
2021-05-19 23:53:41 +02:00
David Parrott
7a83d1f9ff
Alerting resend delay for sending to notifiers ( #34312 )
...
* adds resend delay to avoid saturating notifier
* correct method signatures
* pr feedback
2021-05-19 22:15:09 +02:00
Owen Diehl
8f350bc353
actually register metrics this time ( #34444 )
2021-05-19 22:09:12 +02:00
Ganesh Vernekar
e52f718a87
NGAlert: Migrate old notification channel config ( #33846 )
...
* NGAlert: Migrate old notification channel config
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
* Copy the required structs and functions
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
* Fix lint
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
* Fix review comments and error on discontinued channels
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
* Use both ID and UID to map channels, attach UID to channels
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
* Fix lint
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
* Bug fixes
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
* Use alert table instead of dashboard for channel IDs
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
* Fix offline reviews: don't add empty receivers and routes, add receiver for unmigrated channels
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
* Handle multiple default channels, pick default from used channels
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
* Include default channels in all receivers
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
2021-05-19 21:10:12 +02:00
Ganesh Vernekar
533be16787
NGAlert: Add Threema notification channel ( #34159 )
...
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
2021-05-19 20:20:52 +02:00
Ganesh Vernekar
b2e84277a3
NGAlert: Add Kafka notification channel ( #34156 )
...
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
2021-05-19 20:02:09 +02:00
Ganesh Vernekar
ad1d0ae0bf
NGAlert: Add VictorOps notification channel ( #34161 )
...
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
2021-05-19 19:52:14 +02:00
Alexander Emelin
f0ef5e7dcb
Live: channel ID validation ( #34215 )
2021-05-19 20:47:53 +03:00
Ganesh Vernekar
fb9223ab42
NGAlert: Add Line notification channel ( #34157 )
...
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
2021-05-19 19:04:48 +02:00
Domas
54c33c6cdd
Alerting: update email template ( #34205 )
2021-05-19 18:58:31 +02:00
Ganesh Vernekar
01e0faf800
NGAlert: Add GoogleChat notification channel ( #34153 )
...
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
2021-05-19 18:24:04 +02:00
David Parrott
a0f175c7a5
also don't allow negative intervalseconds ( #34319 )
2021-05-19 09:05:32 -07:00
David Parrott
b9f4ec2030
Add discord notifier channel and test ( #34150 )
...
* Add discord notifier channel and test
* Correct payload
* remove print statement
* PR feedback and update due to changes in main
* Add discord notifier channel and test
* Correct payload
* remove print statement
* PR feedback and update due to changes in main
* update constructor and tests
* group imports sensibly
* Fix lint
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
Co-authored-by: Ganesh Vernekar <ganeshvern@gmail.com>
2021-05-19 17:31:55 +02:00
Sofia Papagiannaki
a79a4838b8
[Alerting]: Add Pushover integration with the alert manager ( #34371 )
...
* [Alerting]: Add Pushover integration with the alert manager
* lint
* Set boundary only for tests
* Remove title field
* fix imports
2021-05-19 16:48:46 +02:00
