Commit Graph

96 Commits

Author SHA1 Message Date
Joey Tawadrous
4ed7ff2ed1
Traces: APM table (#48654)
* APM table

* Remove unnecessary changes in Explore.tsx

* Enhancements

* Show empty table if filter returns no results for table

* Error checking

* Combine extra filter options

* Convert service map query to apm query for apm requests

* Simplify links

* Better query building

* Extract method and clean up

* Upgrade filter

* Self review

* Export method

* Update test

* Switch area-chart to lcd-gauge

* Remove AreaChartCell

* Colors, units and other UI upgrades

* Remove 2 queries and reuse existing queries

* Nested observables

* rate/error rate/duration links: open new pane with range query and exemplars turned on

* Align error rate values to rate values col according to span_name

* Rearrange code

* Several improvements

* Filter by span_name

* align the table col values to the same row name (rateName) across the table

* On click tempo link filter by span_name

* Filtering updates

* Ensure serviceQuery null is ok

* Update link expr

* Update duration p90 unit

* Tempo links case

* Update tests

* Self review

* Tests

* Empty state

* Remove some code

* Test: should build expr correctly

* Test: should build link expr correctly

* Test: should get rate aligned values correctly

* Test: should make apm request correctly

* Test: should make tempo link correctly

* Move apm table tests to its own describe

* Feature toggle

* Added to docs for APM table

* Add screenshot to APM table section in docs

* Add feature toggle to test

* Split queries and make method names clearer

* Doc changes

* Add back in config import removed by merge

* Update tempo link and tests

* Update filter

* Set field filterable: false

* Updated doc

* Remove @end from queries

* Add back in tempo link
2022-06-09 17:56:15 +01:00
Connor Lindsey
f9ddb8bf86
Explore: Download and upload service graphs for Tempo (#50260)
* Download service graph from inspect data tab

* Upload service graph

* Fix tests
2022-06-07 06:37:19 -06:00
Joey Tawadrous
9d5c0bec0f
Tempo: Add link to Tempo Search with node service selected (#49776)
* Node to tempo search with service selected

* Tests

* Update link text

* Update test
2022-06-03 10:38:13 +01:00
Connor Lindsey
3fff17af63
Tempo: Consider tempo search out of beta and remove beta badge and feature flags (#50030)
* Tempo: Remove beta notice and feature flag for search

* remove unused imports
2022-06-01 11:32:10 -06:00
Joey Tawadrous
dcccac6657
Traces: Feature tracking (#49767)
* Feature tracking for traces

* Mock runtime in test

* Update reportInteraction key
2022-06-01 10:28:45 +01:00
Ashley Harrison
216565aa00
Chore: Upgrade to jest 28 (#49679)
* bump packages to jest 28

* changes needed for jest 28

* map react-colorful as well

* use customResolver and fix last test

* don't need react-colorful installed if we're using a custom resolver

* return correct thing in mock

* remove watchPathIgnorePatterns since we don't have node_modules anymore
2022-05-30 14:14:34 +01:00
Joey Tawadrous
d463c3157c
Tempo: NativeSearch code simplification and cleanup (#49365)
* Cleanup and show loading for service/span name

* Method rename

* Simplify logic for getting options

* Simplify logic for setting/getting value

* Move getTags to own async

* Update tests

* Promise all

* Update const name
2022-05-23 20:32:40 +01:00
Connor Lindsey
ea1001f1f5
Tempo: Trim whitespace from trace id query (#49008) 2022-05-16 10:50:02 -06:00
Connor Lindsey
c1b5ea3e54
Tracing: Add trace to metrics config behind feature toggle (#46298)
* Add trace to metrics behind feature flag
2022-05-05 14:46:18 -06:00
Ashley Harrison
06d3c27bc1
Select: Portal menu by default (#48176)
* Remove menuShouldPortal from all <Select /> components

* fix unit tests

* leave menuShouldPortal as an escape hatch

* Fix import order
2022-05-04 15:12:59 +01:00
Joey Tawadrous
09634b518c
Traces Panel: Add new Traces Panel visualization (#47534)
* Panel

* Support tempo dash variables

* Support tempo explore variables

* Only show span links for explore

* Cleanup

* Added tests

* apply variables to search

* Tests for search variables

* Handling no data

* Interpolation and tests

* TracesPanel tests

* More tests

* Fix for backend test

* Manager integration test fix

* Traces doc and updated visualizations index doc

* Logs for this span

* Search, scrollToTop, other improvements

* Refactor to extract common code

* Removed TopOfViewRefType optional

* Remove topOfViewRef optional

* Removed another optional and fixed tests

* Test

* Only show search bar if trace

* Support traces panel in add to dashboard

* Self review

* Update betterer

* Linter fixes

* Updated traces doc

* Ahh, moved the for more info too

* Updated betterer.results

* Added new icon

* Updated expectedListResp.json
2022-05-03 17:42:36 +01:00
Joey Tawadrous
412dbc21e3
Traces: Filter by service/span name and operation in Tempo and Jaeger (#48209)
* Filter search options in Tempo

* Tests for filtering search options in Tempo

* Filter search options in Jaeger

* Tests for filtering search options in Jaeger

* Self review

* Fuzzy search
2022-04-29 09:52:11 +01:00
Connor Lindsey
0da50294fe
Service Graph: Display alert if no metrics found (#48214) 2022-04-26 11:43:18 -06:00
Connor Lindsey
4e6c3be7ab
Tracing: Add string unit to trace search results to prevent Infinity bug (#48206) 2022-04-26 07:09:40 -06:00
Josh Hunt
3c6e0e8ef8
Chore: ESlint import order (#44959)
* Add and configure eslint-plugin-import

* Fix the lint:ts npm command

* Autofix + prettier all the files

* Manually fix remaining files

* Move jquery code in jest-setup to external file to safely reorder imports

* Resolve issue caused by circular dependencies within Prometheus

* Update .betterer.results

* Fix missing // @ts-ignore

* ignore iconBundle.ts

* Fix missing // @ts-ignore
2022-04-22 14:33:13 +01:00
Ashley Harrison
d832bde270
Upgrade @testing-library/user-event to v14 (#47898)
* Update dependency @testing-library/user-event to v14

* everything is async...

* everything is async pt.2

* Fix cascader tests

* hack the yarn.lock file to remove the old version of @testing-library/dom

* some more fixes!

* MOAR FIXES

* more fixes

* remove a bunch of places where we're wrapping in act()

* down to 7 failing tests...

* Fix arrow tests

* Fix rest of NavBarItem tests

* Fix last tests

* Use {Enter} instead of {enter}

* Revert "Use {Enter} instead of {enter}"

This reverts commit e72453bb52.

* remove some unused act imports

* Fix LibraryPanelsSearch tests

* more stable test

* More consistent test...

Co-authored-by: Renovate Bot <bot@renovateapp.com>
2022-04-21 13:15:21 +01:00
Connor Lindsey
939a778111
NodeGraph: Detect dataframes more accurately based on fields (#47213)
* NodeGraph: Detect dataframes more accurately based on fields

* Make get fields case insensitive

* Update node graph docs
2022-04-13 17:18:40 +02:00
Connor Lindsey
1ed83eb9b2
Tracing: Add README files for tracing datasource plugins 2022-04-11 18:16:38 +02:00
Cat Perry
b5f2f3e710
Tempo: Traces to Logs - From viewing Tempo traces to displaying Splunk logs (#46855)
* Add functionality to see splunk logs via tempo trace view
2022-04-04 13:24:33 -07:00
Connor Lindsey
5a87d12e8c
Tempo: Download span references in data inspector (#47074)
* Tempo: Download span references in data inspector
2022-03-31 08:30:22 -06:00
Torkel Ödegaard
5f9cd7b875
Loki: Add aggregate by label support (#46965)
* Loki: Add aggregate by label support

* Label lookups now work for loki

* Fixed ts issue

* review comment fixed
2022-03-29 17:49:21 +02:00
Connor Lindsey
0da40b7f09
Tempo: Separate trace to logs and loki search datasource config (#46655)
* Tempo: Separate trace to logs and loki search datasource config

* Add getLokiSearchDS util and tests
2022-03-17 11:23:15 -06:00
Shachi Solanki
190757b3c6
Tempo / Trace Viewer: Support Span Links in Trace Viewer (#45632)
* Support Span Links in Trace Viewer

* Update ReferencesButton styles

* Remove datasource prop

Co-authored-by: Connor Lindsey <cblindsey3@gmail.com>
2022-02-25 11:14:13 -07:00
Connor Lindsey
af2d19b02e
Tracing: Add option to map tag names to log label names in trace to logs settings (#45178)
* Add mapped tags input to allow renaming tags in trace to logs settings

* Use mappedTags in createSpanLink

* Update traceToLogs docs

* Show 'add kv' button if no tags

* Update docs

* Default mappedTags to tag values
2022-02-22 23:17:45 +01:00
Cat Perry
fcd85951a7
Tempo: Switch out Select with AsyncSelect component to get loading state in Tempo Search (#45110)
* Replace Select with AsyncSelect to get loading state
2022-02-17 09:18:25 -08:00
Connor Lindsey
6e07b30048
Chore: Clean up logs and deprecated library in tracing tests (#45486)
* Fix logs and errors from tracing tests

* Refactor SpanBar to remove recompose

* Fix NodeGraph tests
2022-02-17 16:34:16 +01:00
Connor Lindsey
3da0434e64
Tempo: Update service graph linked queries to use rate_interval and group histogram (#45248) 2022-02-11 07:58:10 -07:00
Connor Lindsey
e94b7f45a1
Tempo: Fix visual service graph bug by setting upper bound for failed arc (#45009)
* Fix visual service graph bug by setting upper bound for failed arc calculation
2022-02-09 07:25:39 -07:00
renovate[bot]
d87cd6f26c
Update dependency prettier to v2.5.1 (#43473)
* Update dependency prettier to v2.5.1

* prettier fixes

* chore(toolkit): bump prettier to 2.5.1

* style(eslint): bump grafana config to 2.5.2 in core and toolkit

* style(mssql-datasource): fix no-inferrable-types eslint errors

Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Ashley Harrison <ashley.harrison@grafana.com>
Co-authored-by: Jack Westbrook <jack.westbrook@gmail.com>
2022-02-02 12:02:32 +00:00
Cat Perry
a86d7a5a90
Tempo: Show error if transformTrace() is passed bad data to parse to JSON (#44684)
* Surface errors if transformTrace() is passed bad data to parse
2022-02-01 14:39:09 -08:00
Connor Lindsey
de04f19c47
Tempo: Add request histogram to service graph datalink (#44671) 2022-02-01 10:41:14 -07:00
Tharun Rajendran
de1661e877
Tempo: Display start time in search results as relative time (#44568)
* Explore: modify tempo trace start time to human readable format in table output

Signed-off-by: tharun <rajendrantharun@live.com>

* add unit tests

Signed-off-by: tharun <rajendrantharun@live.com>
2022-01-31 15:07:43 +00:00
Connor Lindsey
45a435ad78
Tempo: Auto-clear results when changing query type (#44390)
* Auto-clear results when changing query type

* Move clear results to function
2022-01-28 07:49:43 -07:00
Connor Lindsey
17f7f0dc93
Tempo: Update service graph linked queries from totals to rates (#43866)
* Tempo: Update service graph linked queries from totals to rates

* Interpolate server name and interval
2022-01-13 16:28:20 +01:00
Connor Lindsey
ef12028a68
Tempo: Add time range to tempo search query behind a feature flag (#43811) 2022-01-10 07:38:40 -07:00
Connor Lindsey
3d6e9076c9
Tempo: Provide tag value completion items consistently (#43773) 2022-01-10 07:37:35 -07:00
Connor Lindsey
1a7567d8c7
Tempo: Filter available service graph filter values to most relevant options (#43728)
* Restrict service graph filter tag values to labels from service graph metrics
2022-01-06 07:09:31 -07:00
Andrej Ocenas
88d17c4998
Tempo: Don't show error when running query without traceId (#43676)
* Check for traceId and return EMPTY observable if no value

* Make sure we change status on complete

* Add tests

* Fix test
2022-01-05 19:34:09 +01:00
Connor Lindsey
dc92cee874
Tempo: Fix Otel span kind mapping in trace upload resultTransformer (#43168)
* Fix otel span kind mapping

* Parse span kind from enum string
2022-01-04 07:25:14 -07:00
Marcus Efraimsson
7d3bdb6d1b
Plugins: Set backend metadata property for core plugins (#43349)
Ref #42648
Ref #42781
2021-12-22 17:59:26 +01:00
Connor Lindsey
70c0a9d117
A11y: Fix Fastpass issues for tracing query editors and config pages (#42759)
* Add aria-labels to Jaeger config page

* Fix fastpass issues for Tempo config page

* Fix fastpass issues for other tracing query types like search
2021-12-17 11:49:21 -07:00
Connor Lindsey
f1101efcec
Tempo: Update tempo search to use tags query param (#42849)
* Update tempo search to use tags query param

* Remove unnecessary test
2021-12-14 07:41:46 -07:00
Ivana Huckova
9efd85a241
Tracing: Make query editors available in dashboard for Tempo and Zipkin (#41974)
* Tempo: Set query editor

* Zipkin: Set query editor

* Set metrics to true so the data source as shown in dashboard data source list
2021-11-22 12:07:38 +01:00
Andrej Ocenas
5cd4cde12a
Tempo: Add error details when json upload fails (#41803) 2021-11-18 10:35:09 +01:00
Ivana Huckova
47aab9adfa
Tracing: Fix upload JSON functionality (#41455)
* Tracing: Fix upload JSON

* Tracing: Add processes for each span

* Revert "Tracing: Add processes for each span"

This reverts commit 7c0558be83.

* Tracing: Add processes for each span

* Revert "Tracing: Add processes for each span"

This reverts commit 7c0558be83.
2021-11-12 14:33:30 +01:00
Andrej Ocenas
5cc9ff8b28
Tempo: Add filtering for service graph query (#41162)
* Add filter based on AdHocFilter element

* Add tests

* Cancel layout in case we have have new data or we unmount node graph

* Fix typing

* Fix test
2021-11-11 14:27:59 +01:00
Ivana Huckova
7bc27a3cfc
Tempo: Fix validation of float durations (#41400)
* Fix parsing of float numbers in validation

* Adjust test

* Update packages/grafana-data/src/datetime/durationutil.test.ts

* Update packages/grafana-data/src/datetime/durationutil.test.ts

* Remove us from placeholder
2021-11-10 13:48:38 +01:00
Andrej Ocenas
5f27959a5e
Tempo: Add links to nodes in Service Graph pointing to Prometheus metrics (#41135) 2021-11-03 15:56:39 +01:00
Giordano Ricci
218aed324f
Tempo: add info message about beut beta features (#41107) 2021-10-29 17:46:46 +02:00
Andrej Ocenas
73e66d97a5
Tempo: Add error metric to service graph (#40774)
* Add typings

* Query error metric for service graph
2021-10-22 16:37:41 +02:00