Commit Graph

1445 Commits

Author SHA1 Message Date
Leon Sorokin
09cef892a5
OptionsPicker: Use fuzzy search and improve ranking of matches (#79286) 2023-12-12 16:41:50 -06:00
Kristina
bc8ad7b6e5
Explore: Create menu for short link button (#77336)
* WIP first pass

* Change to toolbarbutton/buttonselect pattern

* Move to two toolbarbuttons with dropdown

* Justify text to the right of icons

* Fix betterer

* Fix styling and tests

* Add to docs

* Perist last clicked, add translations

* move styling to core component

* use label for tooltip, let parser combine panes in multiple params

* Explore: Panes encoding suggestions (#78210)

panes encoding suggestions

* WIP-add menu groups

* Get group actions working

* add icons and non-local last selected state

* Fix translations after merge

* Add categories to translation, tweak the verbiage

* Fix translation extraction

* Fix tests

* fix translation conflict

* Log if time is absolute

---------

Co-authored-by: Giordano Ricci <me@giordanoricci.com>
2023-12-12 09:55:03 -06:00
Joey
58c5e5c9dc
Tempo: Update the embedded flame graph labelSelector (#79061)
* Update the embedded flame graph labelSelector

* Update labelSelector
2023-12-08 09:44:51 +00:00
Galen Kistler
243c7583c9
Logs Panel: Table UI - Logs.tsx clean up mutation in react lifecycle (#78925)
* remove prop mutation in componentWillUnmount
2023-11-30 20:04:42 +00:00
Joey
ea3dda60ce
TraceView: Improve small screen design in TracePageSearchBar (#78807)
Improve small screen design in TracePageSearchBar
2023-11-30 10:26:52 +00:00
Galen Kistler
25c152c4d8
Logs panel: Logs table UI - add datasource type to events (#78850)
* add datasource type to logs table ui events

---------

Co-authored-by: Sven Grossmann <sven.grossmann@grafana.com>
2023-11-29 21:50:32 +02:00
Galen Kistler
f7ace22285
Logs Panel: Table UI - feedback link (#78354)
* Adds google form link to let users submit feedback on logs table UI

Co-authored-by: Ivana Huckova <30407135+ivanahuckova@users.noreply.github.com>
2023-11-29 19:28:55 +02:00
Galen Kistler
fd863cfc93
Logs Panel: Table UI - Misc UI tweaks (#78150)
* Miscellaneous UI tweaks for logs table UI in explore
2023-11-29 10:57:04 -06:00
Galen Kistler
faa29db241
Logs Panel: Table UI - Pull logs table into dashboard panel (#77757)
* Allows users to add a logs table in explore to a dashboard panel via the includeByName transformation
2023-11-29 10:01:28 -06:00
Neel
d177770560
TraceView: Fix cursor not matching visual guide in the timeline when resizing (#76587)
* Reset bounds on mouse leave event from trace graph

* trigger CI

---------

Co-authored-by: Andrej Ocenas <mr.ocenas@gmail.com>
2023-11-29 09:52:49 +01:00
Joey
a49e1ded8f
Tracing: Full text search (#78628)
* Full text search

* Tests
2023-11-28 13:29:04 +00:00
Matias Chomicki
630b8a30be
Popover menu: update tracking attributes + move under Explore/logs (#78739)
* Popover menu: update event tracking attributes

* Popover menu: move under explore/loggs

* Popover menu: narrow down support to only Explore app
2023-11-28 15:21:37 +02:00
Sven Grossmann
177496a686
Loki: Filter by labels based on the type of label (structured, indexed, parsed) (#78595)
* add label addition based on labeltype

* add `logRowToDataFrame`

* change to single row dataframe

* add documentation

* add tests for `LogDetailsRow`

* add tests for datasource

* remove row

* update tests

* fix tests

* PR comments

* removed comment

* add comment

* remove params

* remove unused jsdoc

* move `getLabelTypeFromFrame` to `languageUtils`

* add tests

* remove `refId` and use `frame`

* fix tests

* Update public/app/plugins/datasource/loki/modifyQuery.ts
2023-11-27 14:29:00 +01:00
Joey
4f46fb412c
Tempo: Embed flame graph in span details (#77537)
* Embed flame graph

* Update test

* Update test

* Use toggle

* Update test

* Add tests

* Use const

* Cleanup

* Update profile tag

* Move flame graph out of tags, remove request and other cleanup + tests

* Update test

* Set flame graph by profile id and simplify logic

* Cleanup and redrawListView

* Create/use feature toggle
2023-11-23 13:36:53 +00:00
Matias Chomicki
02068662c1
Logs: create DataSourceWithQueryModificationSupport + determine popover menu support (#78322)
* DataSourceWithQueryModificationSupportSupport: create interface

* Loki: implement DataSourceWithQueryModificationSupportSupport

* Elasticsearch: implement DataSourceWithQueryModificationSupportSupport

* DataSourceWithQueryModificationSupportSupport: add type guard

* DataSourceWithQueryModificationSupport: rename

* Check for nullish values in guards

* Logs container: replace support map with ds instances map

* Log rows: refactor deselection listener

* Formatting

* Formatting

* DataSourceWithQueryModificationSupport: add missing comment

* Logs container: update method name

* Logs container: check for query modification support

* Create QueryFixType

* QueryFixAction: move back to ds types

* getSupportedQueryModifications: update signature

* getSupportedQueryModifications: update signature
2023-11-23 11:04:23 +01:00
Galen Kistler
392a4342a8
Logs Panel: Table UI - Time range changes not reflecting in table (#78500)
* add hook to update selected dataframe when time range changes
2023-11-22 07:15:29 -06:00
Haris Rozajac
5b9097e7ff
Explore: Wrap RawPrometheusContainer with PanelChrome (#78084)
* Use LoadingState type for loading prop

* Fix test
2023-11-21 09:17:41 -07:00
kay delaney
9e11779921
Chore: Clean up usage of deprecated stylesFactory function (#78419) 2023-11-21 14:01:53 +00:00
Kristina
165de515cd
Explore: Default synced to true, only show synced status if panes are split (#77759)
* Default synced to true, only show synced status if panes are split

* Don’t default sync to true until split happens, handle syncing when init or history change sync happens

* Sync times if origin pane and new pane have the same range
2023-11-21 07:55:01 -06:00
Aditi Patel
bd6f8e6ef7
fix: Explore -Tables missing vertical spacing (#78149)
* fix: added vertical space to tables

* chore: used theme for spacing

* fix: extended themeable2

* test: fixed TableContainer test with theme
2023-11-21 12:20:57 +00:00
Torkel Ödegaard
d03b291eed
Explore: Fixes issue with adhoc filters when coming from dashboards (#78339) 2023-11-20 20:22:01 +01:00
Haris Rozajac
499915ff9a
Explore: Rename RichHistoryCard for clarity and consistency (#78358)
Rename for clarity and consistency
2023-11-20 07:16:08 -07:00
Giordano Ricci
53642b60ed
Explore: handle URLs parse errors (#77784)
* Explore: handle URLs parse errors

* minor modifications

* tentative fix

* update docs

* omit v0 params from the final url

* Apply suggestions from code review

Co-authored-by: Piotr Jamróz <pm.jamroz@gmail.com>

* remove safeParseJson, make parse return an object

---------

Co-authored-by: Piotr Jamróz <pm.jamroz@gmail.com>
2023-11-20 13:54:00 +00:00
Galen Kistler
1dec96ebe7
Logs Panel: Table UI - Multiple dataframes (queries) (#77589)
* Add dropdown to logs table UI to allow users to select which dataFrame to visualize in the table
2023-11-16 10:42:28 -06:00
Piotr Jamróz
3d4940cf85
QueryHistory: Improve test performance (#78255)
Improve performance
2023-11-16 15:06:37 +01:00
Matias Chomicki
9cb303c3f7
Log Rows: Added popover menu with filter options when a log line is selected (#75306)
* LogRow: detect text selection

* LogRow: refactor menu as component

* LogRow: add actions to menu

* LogRow: hack menu position

* Remove unsused imports

* LogRowMessage: remove popover code

* PopoverMenu: refactor

* LogRows: implement PopoverMenu at log rows level

* PopoverMenu: implement copy

* PopoverMenu: receive row model

* PopoverMenu: fix onClick capture issue

* Explore: add new filter methods and props for line filters

* PopoverMenu: use new filter props

* Explore: separate toggleable and non toggleable filters

* PopoverMenu: improve copy

* ModifyQuery: extend line filter with value argument

* PopoverMenu: close with escape

* Remove unused import

* Prettier

* PopoverMenu: remove label filter options

* LogRow: rename text selection handling prop

* Update test

* Remove unused import

* Popover menu: add unit test

* LogRows: update unit test

* Log row: hide the log row menu if the user is selecting text

* Log row: dont hide row menu if popover is not in scope

* Log rows: rename state variable

* Popover menu: allow menu to scroll

* Log rows: fix classname prop

* Log rows: close popover if mouse event comes from outside the log rows

* Declare new class using object style

* Fix style declaration

* Logs Popover Menu: add string filtering functions (#76757)

* Loki modifyQuery: add line does not contain query modification

* Elastic modifyQuery: implement line filters

* Modify query: change action name to not be loki specific

* Prettier

* Prettier

* Elastic: escape filter values

* Popover menu: create feature flag

* Log Rows: integrate logsRowsPopoverMenu flag

* Rename feature flag

* Popover menu: track interactions

* Prettier

* logRowsPopoverMenu: update stage

* Popover menu: add ds type to tracking data

* Log rows: move feature flag check

* Improve handle deselection
2023-11-16 11:48:10 +02:00
Kristina
1ebdf390e6
Correlations: Only show original field list in transformation field list (#78230)
Only show original field list in transformation field list
2023-11-15 15:06:36 -06:00
Haris Rozajac
2a675d5905
Explore: Refactor RichHistory.tsx into a functional component (#78144)
* Refactor to functional component

* Remove theme as it's unused
2023-11-15 07:15:55 -07:00
Galen Kistler
a18eee4093
Logs Panel: Table UI - Refactor to use includeByName transformation (#78070)
* remove excludeByName logic from LogsTable.tsx, migrate to includeByName. Update tests
2023-11-14 15:18:47 +02:00
Joey
c9faaf7600
Tempo: Fix missing deep span link (#77936)
* Fix span deep link not showing

* Update test
2023-11-13 11:10:19 +00:00
Andrej Ocenas
494a07b522
Flamegraph: Add collapsing for similar items in the stack (#77461) 2023-11-09 15:31:07 +01:00
Galen Kistler
13484928a1
Logs Panel: Table UI - Label names that are too long push out usage percentage in table column multi-select (#77824)
make checkbox sticky and scroll within label
2023-11-08 13:44:28 -06:00
Galen Kistler
0ae3cd6fa5
Logs Panel: Table UI - Query with few rows renders short table (#77653)
* remove height calculation based on row count
2023-11-07 17:22:11 +02:00
Galen Kistler
9e54012407
Logs Panel: Table UI - Add time and body fields to column selection in logs table visualization (#77468)
* add the ability to set visibility of time and body fields, set default of time and body fields when no other fields are selected
2023-11-07 16:00:06 +02:00
Esteban Beltran
0b03344baa
Chore: Update to typescript 5 (#76511)
* Update dependency typescript to v5

* Update yarn.lock

* Fix typescript errors

* Update typescript version sdk

* Revert useDescription.ts

* Fix ts errors

* Fix Typescript errors after Symbol.unscopables type change

* Fix colormanipulator errors

* Update packages/grafana-data/src/vector/FunctionalVector.ts

* Fix ts errors in dashboardmigrator

* Fix sandbox component typescript error

* Update yarn

* Update to typescript 5.2

* Fix typescript error

* update typescript/vscode patch/sdk/whatever

* fix ts errors in elasticsearch

* Fix two errors in alerting

* Fix error in dashboard-scene

* Fix errors in dashboard tests

* Fix errors in explore tests

* Fix error in plugins sandbox

* fix error in DashboardQueryRunner

* fix errors in grafana-data

* fix errors in PanelChrome story

* update betterer

* better fix for cloud monitoring

* fix error in reducer tester

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Zoltán Bedi <zoltan.bedi@gmail.com>
Co-authored-by: Josh Hunt <joshhunt@users.noreply.github.com>
Co-authored-by: joshhunt <josh@trtr.co>
2023-11-07 13:20:20 +00:00
Ivana Huckova
d4a257bc8e
Logs: Update logic to process logs dataPlane frame with labels field (#77708)
* Logs: Update dataplane logic to use labels instead of attributes

* Update Loki logs data plane data frame according to specs

* Remove only in test
2023-11-07 10:53:10 +01:00
Joey
de9ee2e127
Tempo: Update tag in span based on Pyroscope API (#77701)
* Update tags key

* Update link tags

* Update test
2023-11-07 08:45:09 +00:00
Andre Pereira
8aa5d470ca
Tempo: Fix streaming query restart after Grafana server reboot (#77614)
* Fix streaming query restart after Grafana server reboot

* TraceQL Search filter name improvements

* Add flag to enable streaming in tempo docker block

---------

Co-authored-by: Andrej Ocenas <mr.ocenas@gmail.com>
2023-11-06 18:29:59 +02:00
Kristina
9e0ca0d113
Correlations: Add transformations to Explore Editor (#75930)
* Add transformation add modal and use it

* Hook up saving

* Add transformation vars to var list, show added transformations

* Form validation

* Remove type assertion, start building out transformation data in helper (WIP)

* Style expression better, add delete logic

* Add ability to edit, additional styling on transformation card in helper

* simplify styling, conditionally run edit set up logic

* Keep more field information in function, integrate it with new editor

* Show default label on collapsed section, use deleteButton for confirmation of deleting transformations

* Change transformation add calculations from function to hook, add label to collapsed header, add transformation tooltip

* Make correlation and editor dirty state distinctive and integrate, WIP

* Track action pane for more detailed messaging/actions

* Better cancel modal logic

* Remove changes to adminsitration transformation editor

* Remove debugging line

* Remove unneeded comment

* Add in logic for closing editor mode

* Add tests for modal logic

* Use state to build vars list for helper

* WIP

* Fix labels and dirty state

* Fix bad message and stop exiting mode if discard action is performed

* Fix tests

* Update to not use unstable component and tweak default label
2023-11-02 15:09:30 -05:00
Giordano Ricci
7737226786
Explore: Fix support for angular based datasource editors (#77486) 2023-11-01 15:49:45 +00:00
Joey
c39e9a8f52
Tracing: Trace to profiles (#76670)
* Update Tempo devenv to include profiles

* Update devenv to scrape profiles from local services

* Cleanup devenv

* Fix issue with flame graph

* Add width prop to ProfileTypeCascader

* Add trace to profiles settings

* Add new spanSelector API

* Add spanSelector to query editor

* Update span link query

* Conditionally show span link

* Combine profile and spanProfile query types and run specific query type in backend based on spanSelector presence

* Update placeholder

* Create feature toggle

* Remove spanProfile query type

* Cleanup

* Use feeature toggle

* Update feature toggle

* Update devenv

* Update devenv

* Tests

* Tests

* Profiles for this span

* Styling

* Types

* Update type check

* Tidier funcs

* Add config links from dataframe

* Remove time shift

* Update tests

* Update range in test

* Simplify span link logic

* Update default keys

* Update pyro link

* Use const
2023-11-01 10:14:24 +00:00
Matias Chomicki
d7c50eb650
Logs: Deprecated showContextToggle in DataSourceWithLogsContextSupport (#77232)
* Logs: deprecate showContextToggle

* Logs: make row mandatory on showContextToggle prop

* DataSourceWithLogsContextSupport: make showContextToggle optional

* Loki: update test

* Update packages/grafana-data/src/types/logs.ts

Co-authored-by: Ivana Huckova <30407135+ivanahuckova@users.noreply.github.com>

* Prettier

* showContextToggle: update deprecation

---------

Co-authored-by: Ivana Huckova <30407135+ivanahuckova@users.noreply.github.com>
2023-10-31 13:37:44 +02:00
Andre Pereira
41d394c594
Trace View: Fix issue with critical path performance (#77373)
Store child spans in Map for faster access on critical path render
2023-10-30 14:26:33 +00:00
Matias Chomicki
564c8cd883
Log Context: Add Log Context support to mixed data sources (#76623)
* LogsContainer: implement data source feature check

* LogsContainer: improve check for normal data source mode

* LogsContainer: use updated reference to data source instance

* Formatting

* LogsContainer: compare uid to constant

* LogsContainer: rename variable
2023-10-30 15:40:17 +02:00
Andre Pereira
107cf0dc04
Trace View: Critical path highlighting (#76857)
* Added critical path computation code. Refactor some trace view code

* Refactor js to ts

* First implementation of critical path working

* Simplified code

* Added filter to show only critical path spans

* Lint and stuff

* Fixes and moving styling to object

* Betterer
2023-10-30 10:43:14 +00:00
siddhikhapare
8d2b3f973e
Rich history drawer: Translation added (#77088)
* query history translation added

* Recommended changes added
2023-10-30 11:36:08 +01:00
Giordano Ricci
dae49fbb34
Explore: Fix panes vertical scrollbar not being draggable (#77284)
Explore: Fix panes verticall scrollbar not being draggable
2023-10-30 08:56:26 +00:00
Giordano Ricci
bf554d121c
Explore: Avoid reinitializing graph on every query run (#77281) 2023-10-27 14:37:23 +01:00
Haris Rozajac
09e496acfd
Explore TraceView: Remove 'Scroll to top' button (#77158)
* Remove button from Explore but keep in plugins

* Remove topOfViewRef from trace view container
2023-10-27 07:19:43 -06:00
Matias Chomicki
46f331e284
Logs: remove toggleLabelsInLogsUI (#77264)
* toggleLabelsInLogsUI: remove flag

* Remove unused imports

* isFilterLabelActive: refId is not optional

* Revert "isFilterLabelActive: refId is not optional"

This reverts commit 008931b7e9.

* Revert method signature change

* Update tests

* Update tests
2023-10-27 13:00:49 +02:00