Marcus Efraimsson
baab021fec
Chore: Refactor usage of legacy data contracts ( #41218 )
...
Refactor usage of legacy data contracts. Moves legacy data contracts
to pkg/tsdb/legacydata package.
Refactor pkg/expr to be a proper service/dependency that can be provided
to wire to remove some unneeded dependencies to SSE in ngalert and other places.
Refactor pkg/expr to not use the legacydata,RequestHandler and use
backend.QueryDataHandler instead.
2021-11-10 11:52:16 +01:00
George Robinson
d6ed5d295e
Alerting: Fix NoDataFound for alert rules using the AND operator ( #41305 )
...
This commit fixes an issue in alerting where NoDataFound is false
when using the AND operator to compare two conditions in an alert
rule and one of the conditions has no data.
2021-11-10 10:28:49 +00:00
Alexander Emelin
e2ed140de2
Live: rename remote write backends to write configs ( #41467 )
2021-11-09 19:12:10 +03:00
Yuriy Tseretyan
24ad769831
Alerting: Fix flaky TestAlertInstanceOperations ( #41435 )
...
* use UID generator for text
2021-11-09 10:42:58 -05:00
Tania B
f6545ab8f4
Chore: Add current provider test for secrets service ( #41387 )
...
* Chore: Add current provider test for secrets service
* Refactor the test
* Fix linting issue
2021-11-09 16:40:37 +02:00
Alexander Emelin
78e9fe520b
Live: pipeline Loki output ( #41272 )
2021-11-09 13:10:43 +03:00
ying-jeanne
54de1078c8
remove the global log error/warn etc functions ( #41404 )
...
* remove the global log error/warn etc functions and use request context logger whenever possible
2021-11-08 17:56:56 +01:00
Katarina Yang
c4306f9b3e
Chore: add context to login ( #41316 )
...
* Chore: add context to login attempt file and tests
* Chore: add context
* Chore: add context to login and login tests
* Chore: continue adding context to login
* Chore: add context to login query
2021-11-08 15:53:51 +01:00
gotjosh
6220872633
Alerting: fix bug where user is able to access rules from namespaces user is not part of ( #41403 )
...
* Add fix
* Add tests
Co-authored-by: Yuriy Tseretyan <yuriy.tseretyan@grafana.com>
Co-authored-by: Armand Grillet <2117580+armandgrillet@users.noreply.github.com>
Co-authored-by: Jean-Philippe Quéméner <JohnnyQQQQ@users.noreply.github.com>
Co-authored-by: George Robinson <george.robinson@grafana.com>
2021-11-08 14:26:08 +01:00
Ryan McKinley
3489721ed6
api/ds/query: simplify data sources lookup for queries and expressions ( #41172 )
2021-11-05 08:12:55 -07:00
Agnès Toulet
3a6b8535b1
API: return resource ID when deleting datasource with UID and library element ( #41342 )
...
* API: return resource ID when deleting datasource and library element
* keep status codes consistent
* fix element ID
* add test
* improve response struct
* update endpoints documentation
* LibraryElementIDResponse -> DeleteLibraryElementResponse
2021-11-05 15:06:14 +01:00
Alexander Emelin
345f0b658d
Live: crud for remote write backends ( #40147 )
2021-11-05 12:13:40 +03:00
ying-jeanne
a404a311da
add context in the alert_notification ( #41307 )
2021-11-05 16:41:24 +08:00
Yuriy Tseretyan
610643a668
Alerting: Special alert instance if rule is in state NoData ( #40540 )
...
* do not suppress NoData state
* extract conversion of state to postable alert + tests
* create a special alert instance if nodata
* use NoData when converting from Keep Last State instead of Alerting
* add silence during migration if NoData is mapped to KeepLastState.
2021-11-04 16:42:34 -04:00
Yuriy Tseretyan
1b5b747885
Alerting: Additional Tests for State Manager ( #41291 )
...
* rename fakeInstanceStore to FakeInstanceStore
* update test for state manager to initialize instance store with FakeInstanceStore
2021-11-04 15:15:56 -04:00
Tania B
e81d434edf
Encryption: Extend secrets service to support registering key providers ( #40626 )
...
* Draft adding kms providers
* Rename defaultProvider to currentProvider
* Add getting current provider from config
* Remove comments
* Make current provider service struct field
* Add methods to secrets service
* Test getting current provider
* Implements missing methods for fake secrets service
* Remove accidental changes
* Fix linter issue
* Update configuration examples
* Rename CurrentProvider method
* Split service interface
* Update wire
Co-authored-by: spinillos <selenepinillos@gmail.com>
2021-11-04 19:25:01 +02:00
Tania B
5652bde447
Encryption: Use secrets service ( #40251 )
...
* Use secrets service in pluginproxy
* Use secrets service in pluginxontext
* Use secrets service in pluginsettings
* Use secrets service in provisioning
* Use secrets service in authinfoservice
* Use secrets service in api
* Use secrets service in sqlstore
* Use secrets service in dashboardshapshots
* Use secrets service in tsdb
* Use secrets service in datasources
* Use secrets service in alerting
* Use secrets service in ngalert
* Break cyclic dependancy
* Refactor service
* Break cyclic dependancy
* Add FakeSecretsStore
* Setup Secrets Service in sqlstore
* Fix
* Continue secrets service refactoring
* Fix cyclic dependancy in sqlstore tests
* Fix secrets service references
* Fix linter errors
* Add fake secrets service for tests
* Refactor SetupTestSecretsService
* Update setting up secret service in tests
* Fix missing secrets service in multiorg_alertmanager_test
* Use fake db in tests and sort imports
* Use fake db in datasources tests
* Fix more tests
* Fix linter issues
* Attempt to fix plugin proxy tests
* Pass secrets service to getPluginProxiedRequest in pluginproxy tests
* Fix pluginproxy tests
* Revert using secrets service in alerting and provisioning
* Update decryptFn in alerting migration
* Rename defaultProvider to currentProvider
* Use fake secrets service in alert channels tests
* Refactor secrets service test helper
* Update setting up secrets service in tests
* Revert alerting changes in api
* Add comments
* Remove secrets service from background services
* Convert global encryption functions into vars
* Revert "Convert global encryption functions into vars"
This reverts commit 498eb19859
2021-11-04 18:47:21 +02:00
Sofia Papagiannaki
603dae33d6
Fix test ( #41287 )
2021-11-04 12:22:33 +01:00
idafurjes
da5033f3fb
Chore: Add context to temp user ( #41284 )
...
* Add context to temp user
* Remove xorm and InTransaction
2021-11-04 11:17:07 +01:00
Emil Tullstedt
3b637f4b44
Access control: Redirect non-API calls ( #41100 )
2021-11-04 09:59:52 +01:00
Guilherme Caulada
5afaf8930c
Add monthlyActiveUsers to stats API and usage report ( #41289 )
...
Closes grafana/grafana-enterprise-partnerships-team#7
2021-11-03 18:59:05 -03:00
idafurjes
9340430723
Chore: Add alert ctx ( #41161 )
...
* Add context for alert
* Remove context.TODO
* Remove xorm
* Remove context.TODO
* Fix UsageStatsQuerier interface
2021-11-03 14:10:39 +01:00
idafurjes
47f6bb3583
Chore: Add context to org ( #40685 )
...
* Add context to org
* Rebase
* Fix rebase
2021-11-03 11:31:56 +01:00
Yuriy Tseretyan
8a88caaa71
Alerting: Rule evaluation loop refactoring ( #40238 )
...
* move evaluation function out of loop
* extract updateRule function
* isolate alertRule change. update returns new rule and the evaluation accepts the rule as argument
* extract retry loop into a function
* add function wide log context.
* refactor metrics + add tests + replace timeNow with schedule.clock
2021-11-02 17:04:13 -04:00
Santiago
6987ad7b4d
Fix issues with invalid Slack contact points ( #41062 )
...
* Add validation when creating/updating a contact point
* Change 201 status code for 200 (as it was before)
2021-11-02 10:11:19 -03:00
Marcus Efraimsson
f6be78b5ae
Chore: Propagate context for plugin settings ( #41166 )
...
Ref #36734
2021-11-02 13:42:55 +01:00
Marcus Efraimsson
1a89d97fed
Chore: Propagate context for preferences ( #41167 )
...
Ref #36734
2021-11-02 13:41:45 +01:00
Alexander Emelin
9c160413f6
Live: adopt latest fixes from gin route tree ( #41141 )
2021-11-01 20:02:03 +03:00
Will Browne
8157d3564b
remove println ( #41139 )
2021-11-01 14:55:07 +00:00
Serge Zaitsev
7b15cd0ed2
Chore: Refactor GoConvey in provisioning package ( #40892 )
...
* refactor goconvey in some provisioning subpackages
* fix goconvey in provisioning/datasources
* remove goconvey from notifiers subpackage
* finally resolve goconvey in dashboards subpackage
2021-11-01 11:31:55 +01:00
Will Browne
b80fbe03f0
Plugins: Refactor Plugin Management ( #40477 )
...
* add core plugin flow
* add instrumentation
* move func
* remove cruft
* support external backend plugins
* refactor + clean up
* remove comments
* refactor loader
* simplify core plugin path arg
* cleanup loggers
* move signature validator to plugins package
* fix sig packaging
* cleanup plugin model
* remove unnecessary plugin field
* add start+stop for pm
* fix failures
* add decommissioned state
* export fields just to get things flowing
* fix comments
* set static routes
* make image loading idempotent
* merge with backend plugin manager
* re-use funcs
* reorder imports + remove unnecessary interface
* add some TODOs + remove unused func
* remove unused instrumentation func
* simplify client usage
* remove import alias
* re-use backendplugin.Plugin interface
* re order funcs
* improve var name
* fix log statements
* refactor data model
* add logic for dupe check during loading
* cleanup state setting
* refactor loader
* cleanup manager interface
* add rendering flow
* refactor loading + init
* add renderer support
* fix renderer plugin
* reformat imports
* track errors
* fix plugin signature inheritance
* name param in interface
* update func comment
* fix func arg name
* introduce class concept
* remove func
* fix external plugin check
* apply changes from pm-experiment
* fix core plugins
* fix imports
* rename interface
* comment API interface
* add support for testdata plugin
* enable alerting + use correct core plugin contracts
* slim manager API
* fix param name
* fix filter
* support static routes
* fix rendering
* tidy rendering
* get tests compiling
* fix install+uninstall
* start finder test
* add finder test coverage
* start loader tests
* add test for core plugins
* load core + bundled test
* add test for nested plugin loading
* add test files
* clean interface + fix registering some core plugins
* refactoring
* reformat and create sub packages
* simplify core plugin init
* fix ctx cancel scenario
* migrate initializer
* remove Init() funcs
* add test starter
* new logger
* flesh out initializer tests
* refactoring
* remove unused svc
* refactor rendering flow
* fixup loader tests
* add enabled helper func
* fix logger name
* fix data fetchers
* fix case where plugin dir doesn't exist
* improve coverage + move dupe checking to loader
* remove noisy debug logs
* register core plugins automagically
* add support for renderer in catalog
* make private func + fix req validation
* use interface
* re-add check for renderer in catalog
* tidy up from moving to auto reg core plugins
* core plugin registrar
* guards
* copy over core plugins for test infra
* all tests green
* renames
* propagate new interfaces
* kill old manager
* get compiling
* tidy up
* update naming
* refactor manager test + cleanup
* add more cases to finder test
* migrate validator to field
* more coverage
* refactor dupe checking
* add test for plugin class
* add coverage for initializer
* split out rendering
* move
* fixup tests
* fix uss test
* fix frontend settings
* fix grafanads test
* add check when checking sig errors
* fix enabled map
* fixup
* allow manual setup of CM
* rename to cloud-monitoring
* remove TODO
* add installer interface for testing
* loader interface returns
* tests passing
* refactor + add more coverage
* support 'stackdriver'
* fix frontend settings loading
* improve naming based on package name
* small tidy
* refactor test
* fix renderer start
* make cloud-monitoring plugin ID clearer
* add plugin update test
* add integration tests
* don't break all if sig can't be calculated
* add root URL check test
* add more signature verification tests
* update DTO name
* update enabled plugins comment
* update comments
* fix linter
* revert fe naming change
* fix errors endpoint
* reset error code field name
* re-order test to help verify
* assert -> require
* pm check
* add missing entry + re-order
* re-check
* dump icon log
* verify manager contents first
* reformat
* apply PR feedback
* apply style changes
* fix one vs all loading err
* improve log output
* only start when no signature error
* move log
* rework plugin update check
* fix test
* fix multi loading from cfg.PluginSettings
* improve log output #2
* add error abstraction to capture errors without registering a plugin
* add debug log
* add unsigned warning
* e2e test attempt
* fix logger
* set home path
* prevent panic
* alternate
* ugh.. fix home path
* return renderer even if not started
* make renderer plugin managed
* add fallback renderer icon, update renderer badge + prevent changes when renderer is installed
* fix icon loading
* rollback renderer changes
* use correct field
* remove unneccessary block
* remove newline
* remove unused func
* fix bundled plugins base + module fields
* remove unused field since refactor
* add authorizer abstraction
* loader only returns plugins expected to run
* fix multi log output
2021-11-01 10:53:33 +01:00
Ryan McKinley
7319efe077
Dashboard: replace datasource name with a reference object ( #33817 )
...
Co-authored-by: Torkel Ödegaard <torkel@grafana.com>
Co-authored-by: Elfo404 <me@giordanoricci.com>
2021-10-29 10:57:24 -07:00
Yuriy Tseretyan
a1e1a728ad
Alerting: Update references to alertmanager ( #40904 )
...
* update module reference for alertmanager
* remove workaround
2021-10-29 10:03:51 -04:00
Marcus Efraimsson
2d2f7afbde
Chore: Propagate context for search ( #41010 )
...
Propagate context for search.Query, FindPersistedDashboardsQuery,
GetUserStarsQuery. Followup on context.TODO added by #40810 .
Ref #36734
2021-10-28 11:29:07 +02:00
Santiago
c9654c4bc0
Fix issues with Slack contact points ( #40953 )
...
* recipient validation regex modified, validation at creation/modification implemented
* Remove validation for recipient, fix tests
* Log level changed from Warn to Error
2021-10-27 13:58:37 -03:00
Guillaume GILL
7c5de96503
Auth: Omit all base64 paddings in JWT tokens for the JWT auth ( #35602 )
...
Omitting all base64 paddings (=) in JWT tokens.
Fixes #34496
2021-10-27 18:50:30 +02:00
Serge Zaitsev
995afa2221
Chore: Refactor GoConvey in auth package ( #40850 )
...
* refactor goconvey in auth package
* make linter happy
2021-10-27 16:08:21 +02:00
Selene
37cbed4b48
Rendering: Check if default image exists to avoid breaking reports if it's moved ( #40930 )
2021-10-27 16:08:03 +02:00
Will Browne
67449b95e9
dispatch with context where missing ( #40810 )
2021-10-27 15:57:06 +02:00
Serge Zaitsev
690849cfd6
Chore: Refactor GoConvey in services dashboards package ( #40895 )
2021-10-27 08:17:50 -05:00
Serge Zaitsev
00da702970
Chore: Refactor GoConvey in the guardian package ( #40898 )
2021-10-27 07:45:20 -05:00
Serge Zaitsev
24a74cd06e
Chore: Refactor GoConvey tests in alerting/conditions ( #40843 )
...
* refactor goconvery tests
* use more meaningful assertion
* use more meaningful assertions
2021-10-26 23:24:58 +02:00
Skye
bce1011361
Alerting: Option for Discord notifier to use webhook name ( #40463 )
...
* Added an option to discord notifier to use discord's webhook name (useful for customizing notifications).
* Support ngalert system with discord username toggle
* Added ngalert discord test
* Apply suggestions from code review
Co-authored-by: gotjosh <josue.abreu@gmail.com>
* Docs updated with discord username setting
* Fix api integration test
Co-authored-by: Marcus Efraimsson <marcus.efraimsson@gmail.com>
Co-authored-by: gotjosh <josue.abreu@gmail.com>
2021-10-26 14:55:10 -04:00
Yuriy Tseretyan
6709359148
Alerting: Tests for rule evaluation routine ( #40646 )
...
* add fake stores to record queries
2021-10-26 13:22:07 -04:00
Serge Zaitsev
125e284da2
Chore: Refactor GoConvey in notification service package ( #40897 )
...
* refactor goconvey in notification service package
* avoid return after t.skip
2021-10-26 18:08:04 +02:00
Serge Zaitsev
1f1162f1d8
Chore: Refactor GoConvey in teamguardian package ( #40896 )
...
* refactor goconvey in teamguardian package
* use proper order of parameters in equality assertion
Co-authored-by: ying-jeanne <74549700+ying-jeanne@users.noreply.github.com>
Co-authored-by: ying-jeanne <74549700+ying-jeanne@users.noreply.github.com>
2021-10-26 17:59:37 +02:00
ying-jeanne
681218275e
remove crit and trace ( #40320 )
2021-10-26 17:36:24 +02:00
Serge Zaitsev
5409c88fb8
Chore: Refactor GoConvey in alerting tests ( #40845 )
2021-10-26 13:15:09 +02:00
Jean-Philippe Quéméner
d1aefa1792
Alerting: fix ngalert alertmanager SQL Syntax Errors ( #40827 )
...
* test kvstore in intregration tests with different databases
* escape 'key' in delete query
* export quote and use it in kvstore
2021-10-25 11:53:41 +02:00
Santiago
1095f69740
Fix slack contact point panic (code review changes) ( #40770 )
...
* panic when unexpected Slack response fixed, tests added
* fix linting errors, add test
* Code review changes
* Apply PR comments
Co-authored-by: Armand Grillet <armand.grillet@outlook.com>
2021-10-22 17:23:22 +02:00
