Dimitris Sotirakis
258578766b
Alerting: Add checks for non supported units - disable defaulting to seconds ( #32477 )
...
* Add error handling for unknown units
* Fix test cases
* Add case for empty string
* Changed tests from convey to testify
* Fix lints
* Move regex vars
* Add regex as ng-patterns on alert_tab.html
* Update public/app/features/alerting/partials/alert_tab.html
Co-authored-by: Marcus Efraimsson <marcus.efraimsson@gmail.com>
* Update public/app/features/alerting/partials/alert_tab.html
Co-authored-by: Marcus Efraimsson <marcus.efraimsson@gmail.com>
* Make zero and empty string not throw errors
* Updated validation error comments
* Frequency should allow zero or empty strings
* use checkFrequency instead of ng-pattern
checkFrequency is not triggered if ng-pattern is defined.
* Extract getForValue func - add tests
* Fix linting
Co-authored-by: Marcus Efraimsson <marcus.efraimsson@gmail.com>
2021-04-12 15:53:51 +03:00
Arve Knudsen
65c1cb62a7
Chore: Move tsdbifaces.RequestHandler to plugins.DataRequestHandler ( #31897 )
...
* Backend: Move tsdbifaces.RequestHandler to plugins.DataRequestHandler
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
2021-03-12 18:26:07 +01:00
Arve Knudsen
b79e61656a
Introduce TSDB service ( #31520 )
...
* Introduce TSDB service
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
Co-authored-by: Erik Sundell <erik.sundell87@gmail.com>
Co-authored-by: Will Browne <will.browne@grafana.com>
Co-authored-by: Torkel Ödegaard <torkel@grafana.org>
Co-authored-by: Will Browne <wbrowne@users.noreply.github.com>
Co-authored-by: Zoltán Bedi <zoltan.bedi@gmail.com>
2021-03-08 07:02:49 +01:00
Arve Knudsen
9593d57914
Chore: Enable errorlint linter ( #29227 )
...
* Enable errorlint linter
* Handle wrapped errors
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
Co-authored-by: Emil Tullstedt <emil.tullstedt@grafana.com>
2020-11-19 14:47:17 +01:00
Sofia Papagiannaki
48e753d888
Alerting: Log alert warnings for obsolete notifiers when extracting alerts and remove spammy error ( #28162 )
...
* Lower level of notification translation messages
* API: Log alert warnings when saving dashboard
* Remove spammy error
* Rename function parameter
* Apply suggestions from code review
Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com>
* Apply suggestions from code review
* Fix test
* Change alertValidator return type
* Small fix
* Rename symbol
* Revert "Rename symbol"
This reverts commit 40b619b21a2df8319d1dad933863e3f728ece2dbf35c5f52af7f95800c5f95d3e75b001ac5c3f281
2020-10-22 14:43:12 +03:00
Arve Knudsen
16c185c3b9
Chore: Drop xerrors dependency ( #26718 )
...
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
2020-07-31 09:45:20 +02:00
Arve Knudsen
41d432b5ae
Chore: Enable whitespace linter ( #25903 )
...
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
2020-07-06 20:17:28 +02:00
Sofia Papagiannaki
1e543d5ac1
Alerting: Ignore obsolete notification channels referenced by alerts ( #25302 )
...
* Ignore obsolete notification channel
* Fix tests
* Update pkg/services/alerting/rule.go
Co-authored-by: Marcus Efraimsson <marcus.efraimsson@gmail.com>
2020-06-02 19:33:13 +03:00
Dima Ryskin
44b7f3ea1c
AlertNotifications: Translate notifications IDs to UIDs in Rule builder ( #19882 )
...
* AlertNotifications: Translate notifications IDs to UIDs in alert Rule builder
* Avoid shadowing errors, raise validation error on non-existing notification id
* create a cache for notification Uids to minimize db overhead
* add cache usage test
* avoid caching empty notification Uids
* isolate db in alert notificationUid caching tests
2020-03-18 15:00:56 +02:00
Gali Alykoff
f942fecc52
Chore: Improve err message for notifications ( #18757 )
...
Improve message of notification json error
Fix test after change error message
2019-08-28 16:49:36 +02:00
Carl Bergquist
13f137a17d
tech: avoid alias for importing models in alerting ( #17041 )
...
ref #14679
2019-05-14 08:15:05 +02:00
Torkel Ödegaard
7c81f4dfd8
fix(Alerting): Fixed alert rules with eval in day units, fixes #16174 ( #16182 )
2019-03-25 16:27:58 +01:00
bergquist
21fff415ed
removes unnessecary db request
2019-01-28 15:37:52 +01:00
bergquist
935da14f7d
tab/spaces formatting
2019-01-28 15:27:02 +01:00
Pavel Bakulev
f461d52004
Converted notification id to uid via fmt for old alert notification settings
2019-01-16 16:52:00 +02:00
Pavel Bakulev
2de32756c2
Returned id for alert notifications which were created without uid
2019-01-16 16:52:00 +02:00
Pavel Bakulev
f132e929ce
Added uid for alert notifications
2019-01-16 16:50:00 +02:00
Pavel Bakulev
6e3e9a337d
Added alert_notification configuration
2019-01-16 16:45:42 +02:00
bergquist
fbb3ad5fc4
make sure frequency cannot be zero
...
frequency set to zero causes division by zero
panics in the alert schedular.
closes #14810
2019-01-10 14:17:10 +01:00
bergquist
71f406558e
tech(alerting): remove comments
2016-12-19 15:40:09 +01:00
bergquist
4af420f759
tech(alerting): refactor how evalhandler uses conditions
2016-11-03 17:31:36 +01:00
bergquist
ccee1b3f96
fix(alerting): fix bug with unhandled error
...
closes #6239
2016-10-11 17:37:07 +02:00
bergquist
592ae5a39a
tests(alerting): fixes broken tests. pointers and stuff 🤷
2016-09-07 17:05:41 +02:00
Torkel Ödegaard
fbae6abb3c
feat(alerting): progress on handling no data in alert query, #5860
2016-09-06 20:40:12 +02:00
bergquist
cb6fd4ca78
test(alerting): fixes broken unit test
2016-08-11 16:55:08 +02:00
Torkel Ödegaard
717cce014b
feat(alerting): refactoring
2016-07-27 17:07:44 +02:00
