IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-25 18:55:37 -06:00
Code Issues Packages Projects Releases Wiki Activity
27,166 Commits 5,416 Branches 554 Tags
c21cf065b2bd99e08507fb4c7bb5f01bd0bb8c22
Commit Graph

5637 Commits

Author SHA1 Message Date
Torkel Ödegaard
763e958d9d Login: Fixes redirect url encoding issues of # %23 being unencoded after login (#29299) 2020-11-24 07:27:08 +01:00
Ryan McKinley
cfaca42e97 InfluxDB: update flux library and support boolean label values (#29310) 2020-11-23 13:19:52 -08:00
Arve Knudsen
063f863abc WebhookNotifier: Convert tests away from goconvey (#29291) 
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
 2020-11-23 10:37:53 +01:00
Torkel Ödegaard
1076f47509 Dashboard: Fixes kiosk state after being redirected to login page and back (#29273) 
* Login: Fixes issue where url parameters where modified by golang url code

* Add tests

* Fix test cases

* Update pkg/middleware/auth_test.go

Co-authored-by: Sofia Papagiannaki <papagian@users.noreply.github.com>

* fixed formatting

Co-authored-by: Marcus Efraimsson <marcus.efraimsson@gmail.com>
Co-authored-by: Sofia Papagiannaki <papagian@users.noreply.github.com>
 2020-11-20 19:30:37 +01:00
Carl Bergquist
702cb90846 make it possible to hide change password link in profile menu (#29246) 
Co-authored-by: Will Browne <wbrowne@users.noreply.github.com>
 2020-11-20 17:01:10 +01:00
Arve Knudsen
9593d57914 Chore: Enable errorlint linter (#29227) 
* Enable errorlint linter
* Handle wrapped errors

Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
Co-authored-by: Emil Tullstedt <emil.tullstedt@grafana.com>
 2020-11-19 14:47:17 +01:00
Arve Knudsen
294770f411 Chore: Handle wrapped errors (#29223) 
* Chore: Handle wrapped errors

Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>

Co-authored-by: Emil Tullstedt <emil.tullstedt@grafana.com>
 2020-11-19 13:34:28 +01:00
Kyle Brandt
0cb29d337a Expressions: Move GEL into core as expressions (#29072) 
* comes from grafana/gel-app
* remove transform plugin code
* move __expr__ and -100 constants to expr pkg
* set OrgID on request plugin context
* use gtime for resample duration
* in resample, rename "rule" to "window", use gtime for duration, parse duration before exec
* remove gel entry from plugins-bundled/external.json
which creates an empty array for plugins
 2020-11-19 07:17:00 -05:00
Arve Knudsen
006868339d Backend: Fix build (#29206) 
* Backend: Fix build

Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
 2020-11-18 16:16:58 +01:00
Will Browne
2939caf9a2 Permissions: Validate against Team/User permission role update (#29101) 
* validate against role field update

* lowercase error string

* make all msgs consistent style

* fix wording

Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com>

* sayonara simple json

Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com>
 2020-11-18 15:36:41 +01:00
Carl Bergquist
15a6508d4a trace user login and datasource name instead of id (#29183) 
id's are not very helpful when debugging a system.

Signed-off-by: bergquist <carl.bergquist@gmail.com>
 2020-11-18 09:21:45 +01:00
Arve Knudsen
8c9bb7a215 playlist: Improve test (#29120) 
* playlist: Improve test

Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
 2020-11-18 09:16:49 +01:00
Karl Atkinson
65ed8a76a6 CloudWatch: added HTTP API Gateway specific metrics and dimensions (#28780) 2020-11-17 19:27:20 +01:00
Alexey Zhiltsov
2212c6dbbb SQL: Define primary key for tables without it (#22255) 
The annotation_tag and alert_rule_tag tables did not have
PRIMARY KEY defined what cause problems with migration to
MariaDB with Galera setup with
 innodb_force_primary_key=1
Or MySQL > 8.0.13 with
 sql_require_primary_key=ON

Which can manifest as follows:

MariaDB
Error 1173: This table type requires a primary key

MySQL
ERROR 3750 (HY000): Unable to create or change a table
without a primary key, when the system variable 'sql_require_primary_key' is set.

Extra reading for curious:
https://jfg-mysql.blogspot.com/2017/08/danger-no-pk-with-RBR-and-mariadb-protection.html

Fixes #12971

Co-authored-by: Marcus Efraimsson <marcus.efraimsson@gmail.com>
 2020-11-17 17:58:56 +01:00
Arve Knudsen
52c154a221 Backend: Rename variables for style conformance (#29097) 
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
 2020-11-17 17:09:14 +01:00
Arve Knudsen
4dd7b7a82d Chore: Remove unused Go code (#28852) 
* Chore: Remove more unused Go code

Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
 2020-11-17 11:51:31 +01:00
Arve Knudsen
8c765e8068 API: Rewrite tests from goconvey (#29091) 
* API: Rewrite tests from goconvey

Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>

* Fix test

Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>

* Fix tests

Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
 2020-11-17 11:31:35 +01:00
Arve Knudsen
2bf964c61e Chore: Fix linting issues caught by ruleguard (#28799) 
* Chore: Fix linting issues caught by ruleguard

Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>

* Improve error check

Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
 2020-11-17 11:27:45 +01:00
Victor Cinaglia
967e9b39e8 Fix panic when using complex dynamic URLs in app plugin routes (#27977) 
* remove unused function to interpolate URLs

* share function to add headers between ds/plugin proxies

* stop performing unnecessary plugin setting lookup

* fix bug causing runtime errors when using complex templated URLs

* lower case util functions not used outside of pluginproxy package

* change test URL to a (valid) dummy URL to make intent clearer

Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com>
 2020-11-17 10:56:42 +01:00
Andrew Mattheisen
4430ca2317 build paths in an os independent way (#29143) 
Use filepath instead of path to manipulate filename paths in a way compatible with the target operating system-defined file paths.
 2020-11-17 08:03:16 +01:00
Alexander Zobnin
4f9123ebe2 Provisioning: always pin app to the sidebar when enabled (#29084) 2020-11-17 09:45:40 +03:00
Emil Hessman
8c7e7e6d22 Chore: Rewrite preferences test from GoConvey to stdlib and testify (#29129) 2020-11-16 12:54:12 +01:00
Emil Hessman
bdc6e2fe0a Chore: Require OrgId to be specified in delete playlist command (#29117) 2020-11-14 09:49:07 +01:00
Arve Knudsen
fbf0d2c086 Plugin proxy: Handle URL parsing errors (#29093) 
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
 2020-11-13 19:38:09 +01:00
Arve Knudsen
e503188b6f Data source proxy: Convert 401 from data source to 400 (#28962) 
* Data source proxy: Convert 401 from data source to 400

Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
 2020-11-13 13:21:43 +01:00
Will Browne
eba046d3cb Auth: Enable more complete credential chain for SigV4 default SDK auth option (#29065) 
* Force more complete credential chain for default auth option

* simplify

* allow assume role for default
 2020-11-13 10:27:35 +01:00
Arve Knudsen
cb62e69997 Chore: Convert API tests to standard Go lib (#29009) 
* Chore: Convert tests to standard Go lib

Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>

Co-authored-by: Will Browne <wbrowne@users.noreply.github.com>
 2020-11-13 09:52:38 +01:00
kay delaney
9659c98d61 Test Datasource/Bug: Fixes division by zero in csv metric values scenario (#29029) 
Closes #8705
 2020-11-12 16:20:08 +00:00
Arve Knudsen
8f9e5a839f Plugins: Bring back coreplugin package (#29064) 
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
 2020-11-12 17:16:04 +01:00
Tom Daly
18f3969fdb Add 'EventBusName' dimension to CloudWatch 'AWS/Events' namespace (#28402) 2020-11-12 16:48:35 +02:00
Marcus Efraimsson
ded4be0435 CloudWatch: Add support for AWS/ClientVPN metrics and dimensions (#29055) 
Fixes #28778
 2020-11-12 15:47:02 +01:00
Sofia Papagiannaki
43f580c299 AlertingNG: manage and evaluate alert definitions via the API (#28377) 
* Alerting NG: prototype v2 (WIP)

* Separate eval package

* Modify eval alert definition endpoint

* Disable migration if ngalert is not enabled

* Remove premature test

* Fix lint issues

* Delete obsolete struct

* Apply suggestions from code review

* Update pkg/services/ngalert/ngalert.go

Co-authored-by: Kyle Brandt <kyle@grafana.com>

* Add API endpoint for listing alert definitions

* Introduce index for alert_definition table

* make ds object for expression to avoid panic

* wrap error

* Update pkg/services/ngalert/eval/eval.go

* Swith to backend.DataQuery

* Export TransformWrapper callback

* Fix lint issues

* Update pkg/services/ngalert/ngalert.go

Co-authored-by: Kyle Brandt <kyle@grafana.com>

* Validate alert definitions before storing them

* Introduce AlertQuery

* Add test

* Add QueryType in AlertQuery

* Accept only float64 (seconds) durations

* Apply suggestions from code review

* Get rid of bus

* Do not export symbols

* Fix failing test

* Fix failure due to service initialization order

Introduce MediumHigh service priority and assign it to backendplugin
service

* Fix test

* Apply suggestions from code review

* Fix renamed reference

Co-authored-by: Kyle Brandt <kyle@grafana.com>
 2020-11-12 15:11:30 +02:00
Arve Knudsen
a1e80af800 Fix linting issues (#28811) 
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
 2020-11-12 13:25:14 +01:00
Domas
76df096791 Logging: Log frontend errors (#28073) 
* basic frontend  Sentry integration

* backend endpoint to capture sentry events

* WIP!

* log user email for frontend logs

* remove debug logging

* lint fixes

* Fix type exports & property names

Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com>

* additional struct naming fix

* rename log endpoint, config section & interface

* add sentry sample rate to config

* refac to use EchoSrv

* log user id

* backend tests

* tests for SentryEchoBackend

* sentry echo backend tests

* CustomEndpointTransport tests

* Update pkg/api/frontend_logging_test.go

Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com>

* Update conf/defaults.ini

Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com>

* Update pkg/api/frontend_logging_test.go

Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com>

* don't export unnecesasrily

* update go.sum

* get rid of Convey in tests, use stdlib

* add sentry config to sample.ini

* cleanup to set orig logging handler in test

* Apply suggestions from code review

Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com>

* PR feedback changes

* lock sentry version

Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com>
 2020-11-12 12:29:43 +01:00
Emil Hessman
3519330166 Chore: Rewrite test helpers from GoConvey to stdlib (#28919) 2020-11-11 21:33:32 +01:00
Chris Cowan
4ed7612e57 Elasticsearch: Add Moving Function Pipeline Aggregation (#28131) 
* Elasticsearch: Add Moving Function Pipeline Aggregation

* Removing support for moving average in 7.x

* Fixing getMetricAggTypes to handle undefined esVersion

* Adding moving_fn to go code

* Update public/app/plugins/datasource/elasticsearch/metric_agg.ts

Co-authored-by: Giordano Ricci <grdnricci@gmail.com>

* Adding test for esversion 70

* Removing default value for script, adding placeholder instead

* Fixing formatting

* Adding code for handling missing or obsolete aggregations

Co-authored-by: Giordano Ricci <grdnricci@gmail.com>
 2020-11-11 17:42:28 +00:00
Arve Knudsen
ab078133bf Backend: Remove unused code (#28933) 
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
 2020-11-11 11:38:04 +01:00
Carl Bergquist
e3c7d66324 Tracing: Add setting for sampling server (#29011) 
Signed-off-by: bergquist <carl.bergquist@gmail.com>
Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com>
Co-authored-by: Emil Tullstedt <emil.tullstedt@grafana.com>
 2020-11-11 10:21:52 +01:00
Arve Knudsen
b5379c5335 Chore: Fix SQL related Go variable naming (#28887) 
* Chore: Fix variable naming

Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
 2020-11-11 06:21:08 +01:00
kay delaney
b2dcf06b60 Backend: Adds route for well-known change password URL (#28788) 
* Backend: Adds route for well-known change password URL

* Include 'dashboard/new' in backend routes

* Move index route handler registration out of "not logged in views" section

Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com>
 2020-11-10 22:36:35 +00:00
Carl Bergquist
db637a3630 Tracing: log traceID in request logger (#28952) 
Signed-off-by: bergquist <carl.bergquist@gmail.com>
 2020-11-10 05:45:39 +01:00
Carl Bergquist
afb06ec21a start tracking usage stats for tempo (#28948) 
Signed-off-by: bergquist <carl.bergquist@gmail.com>
 2020-11-09 22:12:23 +01:00
Will Browne
a7ea8de47e Short URL: Cleanup unvisited/stale short URLs (#28867) 
* cleanup stale short urls

* refactor test case names

* service injection

* fix query

* add docs

* remove comma
 2020-11-09 18:08:16 +01:00
Arve Knudsen
ef2de2d357 setting: Fix tests on Mac (#28886) 
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
 2020-11-09 14:39:56 +01:00
Leonard Gram
8fb06da34e Plugins: allow override when allowing unsigned plugins (#28901) 
* Plugins: allow override when allowing unsigned plugins

* Update pkg/plugins/plugins.go

Co-authored-by: Emil Tullstedt <emil.tullstedt@grafana.com>

* Plugins: removed java-style setter

* Plugins: cleanup

* Update pkg/plugins/plugins.go

Co-authored-by: Agnès Toulet <35176601+AgnesToulet@users.noreply.github.com>

Co-authored-by: Emil Tullstedt <emil.tullstedt@grafana.com>
Co-authored-by: Agnès Toulet <35176601+AgnesToulet@users.noreply.github.com>
 2020-11-09 09:50:23 +01:00
Emil Hessman
a717e856c5 Chore: Rewrite test in GoConvey to stdlib and testify (#28918) 2020-11-09 08:13:06 +01:00
Agnès Toulet
2c246276fd API: replace SendLoginLogCommand with LoginHook (#28777) 
* API: replace SendLoginLogCommand with LoginHook

* LoginInfo: Query -> LoginUsername
 2020-11-06 10:01:13 +01:00
Agnès Toulet
f0421ed08e Dashboards / Folders: delete related data (permissions, stars, tags, versions, annotations) when deleting a dashboard or a folder (#28826) 
* Dashboard: delete related data when deleting a dashboard or a folder

* fix migrations order

* apply PR feedback
 2020-11-06 09:02:31 +01:00
Ryan McKinley
b91e9faccf Live: update centrifuge and the ChannelHandler api (#28843) 2020-11-05 10:37:04 -08:00
Arve Knudsen
676d393ec9 Chore: Fix issues reported by staticcheck; enable stylecheck linter (#28866) 
* Chore: Fix issues reported by staticcheck

Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>

* Apply suggestions from code review

Co-authored-by: Emil Tullstedt <emil.tullstedt@grafana.com>
 2020-11-05 15:37:11 +01:00