Commit Graph
8814 Commits
Author SHA1 Message Date
Konrad Lalik c41c638b52 Alerting: Fix silences preview (#66000)
* Use alertmanager /alerts endpoint to show preview of instances affected by silence

* Fix debounce dependency, add no instances warning

* Rename silences preview component

* Fix the preview file name, use IsNulLDate to check the date

* Fix valid matchers condition

* Cleanup

* Remove unused code
2023-04-26 10:27:37 +02:00
Oscar KilhedandIvan Ortega 044d7f61c7 DataSourcePicker: fix flickering datasource dropdown (#67206)
* fix flickering

* refactor onClose/onOpen

* do not set value of input, make the placeholder look like the value instead

* Show search icon when the dropdown is open

---------

Co-authored-by: Ivan Ortega <ivanortegaalba@gmail.com>
2023-04-26 10:08:32 +03:00
Torkel Ödegaard 926abcf6aa Scenes: Update scenes to v6 (#67110)
* Scenes: Update scenes to v6

* Fix test
2023-04-26 07:03:44 +02:00
Ivan Ortega Alba 581cc85ba5 Add analytics to new DS picker and onboarding experience (#67060)
* Add analytics to ds picker advanced mode

* Add analytics to ds picker dropdown
2023-04-25 21:07:16 +02:00
Adela Almasanandnmarrs 12e5101b91 Canvas: Connection properties based on data (#64360)
Co-authored-by: nmarrs <nathanielmarrs@gmail.com>
2023-04-25 10:31:45 -07:00
Alexa VandDominik Prokop 2a67b8ad32 Panel Header Fix: Implement new Panel Header on Angular Panels (#66826)
Co-authored-by: Dominik Prokop <dominik.prokop@grafana.com>
2023-04-25 18:16:46 +02:00
Ashley Harrison e6e741546f Nested folders: Create basic Move/Delete modals (#67140)
* add modal scaffolding

* add some unit tests

* remove dummy api, add some TODO comments

* small test refactor

* another small test refactor

* fix unit tests due to aria-label/data-testid change
2023-04-25 17:08:40 +01:00
Polina Boneva fe23c76250 Dashboard: New panel in a dashboard is not deleted after "Discard"-ing changes in Panel Edit (#66476)
* add isNew notPersistedProperty to PanelModel

* if panel is newly created and user "Discard"s it, the panel is removed entirely

* add Todo's for when we remove the emptyDashboardPage FF

* add isNew to new panel after file dropping on dashboard page

* handle the "Apply" case

* CSV file dropping is not relevant to a new panel bc it doesnt open edit page
2023-04-25 17:18:58 +03:00
Polina Boneva 2f1a08511a [Chore] Dashboard: Update analytic events for new panel/row/import/pasted panel (#67205)
update analytic events for new panel/row/import/pasted panel
2023-04-25 17:06:54 +03:00
Torkel Ödegaard de18ed6659 PanelContext: Add functionality to update data from panel (#66993) 2023-04-25 14:55:50 +02:00
64ee42d01e Alerting: Add limits and move state and label matching filters to the BE (#66267)
* WIP

* Add instance totals to combined rule. Use totals to display instances stats in the UI

* WIP

* add global summaries, fix TS errors

* fix useCombined test

* fix test

* use activeAt from rule when available

* Fix NaN in global stats

* Add no data total to global summary

* Add totals recalculation for filtered rules

* Fix instances totals, remove instances filtering from alert list view

* Update tests

* Fetch alerts considering filtering label matchers

* WIP - Fetch alerts appending state filter to endpoint

* Fix multiple values for state in request being applyied

* fix test

* Calculate hidden by for grafana managed alerts

* Use INSTANCES_DISPLAY_LIMIT constant for limiting alert instances instead of 1

* Rename matchers parameter according to API changes

* Fix calculating total number of grafana instances

* Rename matcher prop after previous change

* Display button to remove max instances limit

* Change matcher query param to be an array of strings

* Add test for paramsWithMatcherAndState method

* Refactor matcher to be an string array to be consistent with state

* Use matcher query string as matcher object type (encoded JSON)

* Avoind encoding matcher parameters twice

* fix tests

* Enable toggle for the limit/show all button and restore limit and filters when we come back from custom view

* Move getMatcherListFromString method to utils/alertmanager.ts

* Fix limit toggle button being shown when it's not necessary

* Use filteredTotals from be response to calculate hidden by count

* Fix variables not being replaced correctly

* Fix total shown to be all the instances filtered without limits

* Adress some PR review comments

* Move paramsWithMatcherAndState inside prometheusUrlBuilder method

---------

Co-authored-by: Gilles De Mey <gilles.de.mey@gmail.com>
Co-authored-by: Konrad Lalik <konrad.lalik@grafana.com>
Co-authored-by: Virginia Cepeda <virginia.cepeda@grafana.com>
2023-04-25 11:19:20 +02:00
Ivan Ortega Alba 44035ecbb2 Advanced DS Picker open Connections page when toggle is enabled (#67139) 2023-04-25 10:42:04 +02:00
Ivan Ortega Alba 4d474e8e4f Fix icon size for data source picker list item (#67144) 2023-04-25 10:41:31 +02:00
Joey 5c2a344ce1 Traces: Order keys in span filter select (#66689)
* Order logs keys last

* Add tests
2023-04-25 08:56:06 +01:00
Ashley Harrison 4e492ae725 Navigation: Unify Page component (#66951)
* remove old page component

* add test to check initDashboard is only called once (prevent variables loading twice)

* add help node

* update unit tests

* remove last mentions of topnav

* fix unit tests

* remove unused props from ButtonRow interface

* remove prop from test
2023-04-24 16:41:32 +01:00
Josh Hunt 69e5a2bdf9 NestedFolders: Basic search view (#67093)
* First stab and reusing SearchView for new Browse Dashboards

* NestedFolders: Basic SearchView

* last bits of cleanup
2023-04-24 18:32:04 +03:00
Victor MarinandTorkel Ödegaard efd0e9cbea Datagrid Panel: Edit data within your dashboards (#66353)
* wip

* Datagrid WIP: snapshotting when data edited, better UI for adding column/rows, refactors

* wip

* WIP

* wip

* Add series selector

* Delete selection on key press

* wip

* Multiple row select and delete

* wip

* draggable rows/columns, better column width calculator

* bug fixes

* scrollbars

* add feature flag

* bugfixes

* bugfixes

* bugfixes

* bugfixes

* Add possibility to rename column

* Input fixes

* bugfixes

* bugfixes

* performance optimisations

* WIP component refactoring and optimisations

* comment bit of code to remove error for testing

* fix column move and payload types

* WIP refactors and tests

* e2e tests

* queryGroup subscription refactor

* queryGroup - add component on update, fix failing tests

* refactor querygroup

* querygroup refactor

* tests

* fix codeowners validation

* lint fixes

* revert convertFieldType modification in favor of already merged mod + re-add mistakenly deleted line

* remove //ts-ignores

* Minor style tweaks

* fix

* align colors with theme

* fixes

* refactor

* add test for convertFieldType transformer and write todo

---------

Co-authored-by: Torkel Ödegaard <torkel@grafana.com>
2023-04-24 17:46:31 +03:00
Alexander Zobnin 28a641aa50 Authentication UI: Fix permissions for saving settings (#67086)
Fix permissions for saving settings
2023-04-24 09:57:05 +02:00
Konrad LalikandGilles De Mey 91704cf7de Alerting: Loki-based alert state history modal (#66595)
* adds alertstatehistory backend config to grafanaBootData

* add alertStateHistory api

* show different ASH modal when using loki implementation

* group log lines by instance (unique set of labels)
Co-Authored-By: Konrad Lalik <konrad.lalik@grafana.com>

* render log lines for each instance
Co-Authored-By: Konrad Lalik <konrad.lalik@grafana.com>

* Add visual improvements to the log record of state changes

* Add values to log records

* compute common labels and show unique labels

* Add state changes visualization

* fix common labels extraction

* Code cleanup

* Add timespan-based log record view

* WIP

* scroll to timestamp - poc

* Use SortedVector for timestamp field

* add conditional accessor for frames

* update some of the log formats and styles

* Timestamp-based visualization with scrolling

* minor improvements

* Split Loki's state history viewer into multiple files

* Add memoization to prevent graph rerender on filter updates

* make chart size shrink when fewer instances

* style updates

* show warning when instances are hidden

* Add basic label-based filtering

* Improve label-based filtering

* Add regex validation

* Improve no instances message when everything was filtered out

* Update warning message

* Move timeline viewer to a separate file, refactor handling timeline pointer changes

* Remove unused component, add comments

* Fix test snapshot, fix type error

* adds tests for common.ts

* Add tests for converting log records into data frames

* Add basic component test, fix type guards

* Use a constant for timeseries limit

* Improve a11y, update component test

* Memoize AlertStateTag, migrate from deprecated ArrayVector

* Update public/app/features/alerting/unified/components/rules/state-history/common.ts

* Move helper hook into a separate file. Add Search input component

* Change the limit of visible time series on the timeline

* Add LogRecordViewer perf improvements, refactor timeline cursor events tracking

* Use callback to pass timeline refs

* Add grouping tests for the log record viewer

---------

Co-authored-by: Gilles De Mey <gilles.de.mey@gmail.com>
2023-04-24 09:28:11 +02:00
Agnès Toulet fe5a07f336 Rendering: Fix panel rendered count on error (#67027)
Rendering: fix panel rendered count on error
2023-04-24 09:27:49 +02:00
Adela Almasan b992bdb62d Annotations: Avoid crash when listing panels (that are rows) (#66869) 2023-04-21 23:50:45 +03:00
Ezequiel Victorero 0b246942ae PublicDashboards: Remove flaky test (#67061) 2023-04-21 14:46:27 -03:00
Virginia Cepeda 329d940448 Alerting: fix condition to distinguish multiple datasources type in dropdown (#67065)
* Add function to check if a datasource is managing alerts

* Use helper function to get datasources that manage alerts
2023-04-21 14:27:39 -03:00
Sven Grossmann 6abd75b69c Log Context: Add wrap lines button to easier wrap lines (#67047)
* add wrap lines button

* change default to 50 lines

* fix test

* change css classes
2023-04-21 17:21:02 +02:00
Oscar Kilhed d419402a43 DataSourcePicker: Add recently used from local storage to ds picker (#66985)
* Add recently used from local storage to ds picker
2023-04-21 18:07:11 +03:00
Ashley Harrison 1cad819670 Nested folders: Add dummy Move/Delete actions (#67051)
* slight refactor, show actions on selection

* add unit tests

* refactor logic into custom selector + hook
2023-04-21 15:18:40 +01:00
IevaandGabriel MABILLE 5d7433d820 RBAC: Make access control metadata for folders work with nested folders (#66464)
* remove metadata for single folder listing

* extendTests

* remove ac metadata from dash and folder search results

* remove test

* remove one more test

* put ac metadata back for single folder API responses

* extend tests

* remove ac metadata from folder frontend object

* undo unneeded change

* PR feedback

Co-authored-by: Gabriel MABILLE <gamab@users.noreply.github.com>

---------

Co-authored-by: Gabriel MABILLE <gamab@users.noreply.github.com>
2023-04-21 15:05:11 +01:00
Torkel Ödegaard 0f9c6be3f0 QueryGroup: Cleanup leftovers from hackathons (#67048) 2023-04-21 15:32:47 +02:00
Torkel Ödegaard 34110f68b7 EmptyDashboard: Fix wrong font weight (#66555) 2023-04-21 14:15:09 +02:00
Josh Hunt 1d0387dcc2 NestedFolders: Make TagsCell return null when showing nothing (#67041) 2023-04-21 12:17:04 +01:00
Gabriel MABILLEandEric Leijonmarck b7f047c8dd Fix: Hide invite when disabled login form is set (#67031)
* FIX: Hide Invite Button with external user management

* Hide also when login form is disabled

* add tests and readability

---------

Co-authored-by: Eric Leijonmarck <eric.leijonmarck@gmail.com>
2023-04-21 12:03:13 +01:00
Josh Hunt 0eca9950a0 NestedFolders: Show Tags in Browse Dashboards (#67029)
* NestedFolders: Show tags in Browse Dashboards view

* tests
2023-04-21 11:49:58 +01:00
Joey 6522bb377e Tracing: Rename feature toggle (#66833)
Rename feature toggle so something more specific so new work can use older feature toggle name
2023-04-21 11:31:24 +01:00
Ivan Ortega Alba 49624ca2ef Adjust styles for DS picker dropdown and modal (#67004)
Adjust styles for dropdown and modal
2023-04-21 11:25:03 +02:00
Andres Martinez Gotor 29aaf429ad Plugins: Fix width for README pages with tables (#66872) 2023-04-21 10:02:10 +02:00
Ashley Harrison 1f193f1bad Navigation IA: Update Monitoring to Observability (#66963)
* update monitoring -> observability

* update backend test
2023-04-21 08:39:49 +01:00
Sonia Aguilar 400fae3bd6 Alerting: Change tooltip error text in collapsed contact point table (#67022)
Change tooltip error message in collapsed contact point table
2023-04-21 09:37:31 +02:00
Ryan McKinley 607b94aaa2 FieldValues: Use standard array functions (#67012) 2023-04-20 22:03:38 -07:00
Josh Hunt 3518f8ec53 NestedFolders: Refactor BrowseView state into redux (#66898)
* refactor all state into redux

* add tests for reducers

* added comments
2023-04-20 16:37:00 +01:00
Matias Chomicki c11baa3ead Stats Inspector: Prevent long stats from being hidden (#66866)
* Stats Inspector: Prevent stats from being hidden

* Inspect stats: inline container styles
2023-04-20 17:06:47 +02:00
Leon SorokinandRyan McKinley b24ba7b7ae FieldValues: Use plain arrays instead of Vector (part 3 of 2) (#66612)
Co-authored-by: Ryan McKinley <ryantxu@gmail.com>
2023-04-20 17:59:18 +03:00
Polina Boneva 2f0f5ca09e [Chore] Dashboard: Add i18n for creating a panel, row, library panel, and pasted panel (#66234)
* add translation keys for empty dashboard redesign

* run yarn i18n:extract; rephrase one trans key because of [warning] Found translation key already mapped to a map or parent of new key already mapped to a string: dashboard.toolbar.add.visualization

* reduce to 3-step locale phrase IDs

* extract phrase IDs
2023-04-20 10:35:29 -04:00
Sven Grossmann c903d1546f Log Context: Add feature tracking (#66912)
add feature tracking
2023-04-20 15:42:44 +02:00
Josh Hunt 78d7b6c0c9 NestedFolders: Backend nested-dashboards route (#66955)
* NestedFolders: Add backend route for temp browse dashboards page

* tweak 'preview new ui' badge

* tweak 'preview new ui' badge
2023-04-20 14:34:35 +01:00
Sven Grossmann bec18e390e Log Context: Add feedback button (#66910)
* add feedback link

* add feedback button to `Modal.ButtonRow`
2023-04-20 14:36:04 +02:00
Sven Grossmann 1e53a87d76 Log Context: Add button to open the context query in a split view (#66777)
* add show context button

* improve type definition

* change to default `maxLines`

* remove context query

* add provider to tests

* add test for split view button

* improve documentation

* add tests for `getLogRowContextQuery`

* refactor LogsContainer functions

* fix spelling

* add `contextQuery` as state

* fix tests

* fix lint

* do not use callIfDefined

* make button secondary
2023-04-20 14:21:14 +02:00
Ivan Ortega Alba 40c7b3126e Prompt DS modal when the user adds the first panel to a dashboard (#66911)
* Prompt DS modal when the user adds the first panel to a dashboard

* Rename state prop and use toggle

* Change modal size

* Avoid flickering for dashboard modal when changing number of results

* When editing panel 1, only display when new dashboard
2023-04-20 13:44:19 +02:00
Oscar KilhedandIvan Ortega a7e74f6d6d DataSourcePicker: Refactor and collapse the DataSourceDropdown components (#66820)
* clean up the components and convert to functional components

* Create hooks for getting DS

* remove focus style override from input

---------

Co-authored-by: Ivan Ortega <ivanortegaalba@gmail.com>
2023-04-20 12:11:13 +02:00
Ivan Ortega Alba 3edc246ca3 Variables are available in the new DS picker and modal (#66923) 2023-04-20 11:34:24 +02:00
AbdulandIvana Huckova 3a013cbe48 Explore: Clear live logs (#64237)
* feat: add clear logs to explorer's live logs

* refactor live logs pause/resume updating logic

* add tests for clearing live logs

* rm unused imports

* move `onClear` live logs logic to redux

* move clear logs tests to `query.test`

* use utils `sortLogsRows` and Button's icon props

* rename `filterLogRows` and add `clearedAt` as an arg

* mv clearedAt type closer to live tailing items and add jsdoc

* mv `filterLogRowsByTime` to `/utils` and use it at `LiveLogs` component

* make `Exit live` button consistent with other actions

* use `sortLogRows` and fix timestamp by id on `makeLogs`

* change clear live logs from based on timestamp to index on logRows

* assign `null` to `clearedAtIndex` on first batch of logs live

* move `isFirstStreaming` implementation to `clearLogs` reducer

* fix `clearLogs` tests

* Update public/app/features/explore/state/query.ts

Co-authored-by: Ivana Huckova <30407135+ivanahuckova@users.noreply.github.com>

---------

Co-authored-by: Ivana Huckova <30407135+ivanahuckova@users.noreply.github.com>
2023-04-20 10:21:28 +02:00