Dave Waters
c4dcf5a4ee
fix gofmt, add test, correct noted concerns with default value
2018-10-16 17:33:38 -04:00
Dave Waters
6376154b16
add channel option to disable the resolved alert (OK Message) that is sent when condition returns to normal.
2018-10-15 17:16:14 -04:00
Marcus Efraimsson
418f77e70e
get or create alert notification should use transaction
2018-10-02 15:07:44 +02:00
bergquist
7b781e4c3c
use notification state id instead of notifier id
2018-10-02 14:53:39 +02:00
bergquist
67e5f62514
move version conflict logging for mark as complete to sqlstore package
2018-10-02 14:23:18 +02:00
bergquist
9022e871e3
avoid sending full notification state to pending/complete
2018-10-02 13:57:41 +02:00
bergquist
341d8af637
rename GetNotificationStateQuery to GetOrCreateNotificationStateQuery
2018-10-02 11:23:40 +02:00
bergquist
7f1d7cefc0
reminder: uses UpdatedAt to track state changes.
2018-10-02 11:19:09 +02:00
bergquist
75f832cda8
use alert state changes counter as secondary version
2018-10-01 15:58:30 +02:00
Marcus Efraimsson
1be8fb76b8
cleanup alert_notification_state when deleting alert rules and channels
2018-09-30 21:57:15 +02:00
Marcus Efraimsson
5ec086dc56
don't notify if notification state pending
...
If notification state is pending and last update of state was made
less than a minute ago. In the case of a grafana instance is shut down/crashes
between setting pending state and before sending the notification/marks as complete
this logic should allow the notification to be sent after some time instead of
being left in an inconsistent state where no notifications are being sent.
2018-09-30 21:52:50 +02:00
Marcus Efraimsson
d412aafb7e
remove unused code
2018-09-30 20:16:01 +02:00
Marcus Efraimsson
67c58fa5e4
fix set sent_at on complete
2018-09-28 15:11:03 +02:00
Marcus Efraimsson
c1763508e0
handle pending and completed state for alert notifications
2018-09-28 14:22:03 +02:00
Marcus Efraimsson
69cc24ea3f
wip: test get alert notification state
2018-09-28 11:17:03 +02:00
Leonard Gram
1a75aa54de
wip: impl so that get alertstate also creates it if it does not exist
2018-09-28 10:48:08 +02:00
bergquist
15ce474639
wip
2018-09-27 16:21:53 +02:00
Marcus Efraimsson
d093244282
sqlstore: add support for checking if error is constraint validation error
2018-09-27 13:38:22 +02:00
bergquist
c5278af6c4
add support for mysql and postgres unique index error codes
2018-09-27 11:33:13 +02:00
bergquist
3fab616239
implement sql queries for transactional alert reminders
2018-09-27 11:14:44 +02:00
bergquist
ff79f80685
initial rename refactoring
2018-09-27 09:43:00 +02:00
bergquist
b04052f515
alerting: move all notification conditions to defaultShouldNotify
2018-09-26 14:34:10 +02:00
Mario Trangoni
bb5aaa2dce
pkg/services/sqlstore/alert_notification.go: Simplify err check
...
$ gometalinter --vendor --disable=all --enable=megacheck --deadline=10m ./...
pkg/services/sqlstore/alert_notification.go:242:3⚠️ 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (megacheck)
2018-09-18 23:42:20 +02:00
Mario Trangoni
f73236f8f4
pkg/services/sqlstore: Fix x.Sql is deprecated: use SQL instead. (megacheck)
...
See,
$ gometalinter --vendor --disable-all --enable=megacheck --disable=gotype --deadline 6m ./... | grep SQL
alert.go:43:9⚠️ x.Sql is deprecated: use SQL instead. (SA1019) (megacheck)
alert_notification.go:122:12⚠️ sess.Sql is deprecated: use SQL instead. (SA1019) (megacheck)
annotation.go:226:12⚠️ x.Sql is deprecated: use SQL instead. (SA1019) (megacheck)
dashboard.go:228:9⚠️ x.Sql is deprecated: use SQL instead. (SA1019) (megacheck)
dashboard.go:302:10⚠️ x.Sql is deprecated: use SQL instead. (SA1019) (megacheck)
dashboard.go:416:9⚠️ x.Sql is deprecated: use SQL instead. (SA1019) (megacheck)
dashboard.go:635:12⚠️ x.Sql is deprecated: use SQL instead. (SA1019) (megacheck)
migrations/user_mig.go:137:9⚠️ sess.Sql is deprecated: use SQL instead. (SA1019) (megacheck)
plugin_setting.go:29:10⚠️ x.Sql is deprecated: use SQL instead. (SA1019) (megacheck)
quota.go:41:12⚠️ x.Sql is deprecated: use SQL instead. (SA1019) (megacheck)
quota.go:84:13⚠️ x.Sql is deprecated: use SQL instead. (SA1019) (megacheck)
quota.go:143:12⚠️ x.Sql is deprecated: use SQL instead. (SA1019) (megacheck)
quota.go:186:13⚠️ x.Sql is deprecated: use SQL instead. (SA1019) (megacheck)
quota.go:234:12⚠️ x.Sql is deprecated: use SQL instead. (SA1019) (megacheck)
team.go:172:12⚠️ x.Sql is deprecated: use SQL instead. (SA1019) (megacheck)
team.go:199:17⚠️ x.Sql is deprecated: use SQL instead. (SA1019) (megacheck)
team.go:223:9⚠️ x.Sql is deprecated: use SQL instead. (SA1019) (megacheck)
temp_user.go:99:10⚠️ x.Sql is deprecated: use SQL instead. (SA1019) (megacheck)
temp_user.go:124:10⚠️ x.Sql is deprecated: use SQL instead. (SA1019) (megacheck)
user.go:375:3⚠️ sess.Sql is deprecated: use SQL instead. (SA1019) (megacheck)
user.go:377:3⚠️ sess.Sql is deprecated: use SQL instead. (SA1019) (megacheck)
user.go:379:3⚠️ sess.Sql is deprecated: use SQL instead. (SA1019) (megacheck)
2018-09-16 12:26:05 +02:00
bergquist
396f8e6464
notifications: read without tran, write with tran
2018-06-29 15:15:31 +02:00
bergquist
83a12afc07
adds tests for journaling sql operations
2018-06-16 11:27:04 +02:00
bergquist
12bf5c225a
tests for defaultShouldNotify
2018-06-15 16:27:20 +02:00
bergquist
f4b089d551
notifications: make journaling ctx aware
2018-06-15 15:30:17 +02:00
bergquist
4a8e9cf93f
removes more unused code
2018-06-07 07:15:50 +02:00
bergquist
850aa21d45
removes unused code
2018-06-07 07:06:13 +02:00
bergquist
171a38df99
alerting: fixes broken table rename
2018-06-05 14:29:48 +02:00
bergquist
7333d7b8d4
alerting: invert sendOnce to sendReminder
2018-06-05 10:44:17 +02:00
bergquist
93124f38fa
alerting: only check frequency when not send once
2018-06-04 22:19:27 +02:00
bergquist
86e65f84f9
alerting: fixes invalid error handling
2018-06-04 17:30:57 +02:00
John Baublitz
bdf433594a
Implement code review changes
2018-06-04 13:19:14 +02:00
John Baublitz
c0a9e5cf1d
Fix tests
2018-06-04 13:19:14 +02:00
John Baublitz
fca97535d1
Fix multiple bugs
2018-06-04 13:19:14 +02:00
John Baublitz
3cb0e27e1c
Revert changes post code review and move them to notification page
2018-06-04 13:19:14 +02:00
Karsten Weiss
be2d635078
Simplify error returns (gosimple)
...
This fixes:
pkg/api/avatar/avatar.go:261:2: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013)
pkg/log/file.go:102:2: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013)
pkg/metrics/graphitebridge/graphite.go:298:2: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013)
pkg/services/provisioning/provisioning.go:23:2: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013)
pkg/services/sqlstore/alert_notification.go:27:3: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013)
pkg/services/sqlstore/alert_notification.go:27:3: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013)
pkg/services/sqlstore/annotation.go:105:3: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013)
pkg/services/sqlstore/annotation.go:105:3: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013)
pkg/services/sqlstore/dashboard.go:351:2: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013)
pkg/services/sqlstore/dashboard.go:435:2: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013)
pkg/services/sqlstore/dashboard_acl.go:38:3: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013)
pkg/services/sqlstore/dashboard_acl.go:38:3: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013)
pkg/services/sqlstore/stats.go:22:2: 'if err != nil { return err }; return err' can be simplified to 'return err' (S1013)
pkg/services/sqlstore/team.go:213:2: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013)
pkg/services/sqlstore/user.go:256:3: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013)
pkg/services/sqlstore/user.go:256:3: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013)
pkg/services/sqlstore/user.go:274:3: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013)
pkg/services/sqlstore/user.go:274:3: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013)
pkg/services/sqlstore/user.go:482:3: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013)
pkg/services/sqlstore/user.go:482:3: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013)
2018-04-16 21:04:57 +02:00
bergquist
ea988a37dd
tech: avoid using deprecated functions
2018-01-23 22:30:45 +01:00
Torkel Ödegaard
359421b5e8
refactor: sqlstore inTransaction consolidated to one version, fixes #8376
2017-05-23 10:56:23 +02:00
bergquist
e5c64732f1
fix(sql): Add boolstr to all dialects
...
closes #6116
2016-09-23 09:36:15 +02:00
bergquist
2ca7284a56
tech(notifications): splitt into 3 queries
...
closes #5883
2016-09-06 08:43:15 +02:00
bergquist
c893e5d241
feat(notifications): add support for default notifications
...
ref #5883
2016-09-05 21:35:37 +02:00
Torkel Ödegaard
1edd224168
feat(alerting): fixing failing unit tests
2016-08-01 14:34:58 +02:00
Torkel Ödegaard
0d9b98da6d
feat(alerting): progress on email notifications
2016-07-26 12:29:52 +02:00
Torkel Ödegaard
a6c6094775
feat(alerting): started reworking notifications
2016-07-22 16:45:17 +02:00
bergquist
5d62c84a19
feat(alerting): adds default checkbox to ui
2016-06-20 16:19:15 +02:00
bergquist
fa309ec925
feat(alerting): add default notification group
2016-06-20 15:24:48 +02:00
bergquist
b907ce341c
feat(alerting): enables deletes for alert notifications
2016-06-16 15:21:44 +02:00
