Commit Graph

51601 Commits

Author SHA1 Message Date
Ieva
1c2ae2c72d
Dashboards: Correctly display Admin access to dashboards in the UI (#88439)
* include folder wildcard scope in dash permission inheritance

* Update pkg/services/accesscontrol/ossaccesscontrol/permissions_services.go

Co-authored-by: Karl Persson <kalle.persson@grafana.com>

---------

Co-authored-by: Karl Persson <kalle.persson@grafana.com>
2024-05-30 10:06:01 +03:00
Diego Augusto Molina
990ad860df
Chore: Allow using the Go race detector locally (#88380)
* use the Go race detector for local testing only

* add recipe to check if Go race detector is enabled
2024-05-29 20:34:16 -03:00
Nathan Marrs
98152b2f84
Stat: Add docs for stat percent change color options (#88454)
update docs
2024-05-29 14:13:01 -07:00
Bogdan Matei
011becb39e
Scopes: Use Grafana namespace instead of default (#88451) 2024-05-29 23:48:17 +03:00
Kyle Cunningham
f5346e3e2a
Table Panel: Move inspector into drawer component (#88196)
* Move inspector into drawer component

* Fix up naming

* fix betterer lint issue

---------

Co-authored-by: nmarrs <nathanielmarrs@gmail.com>
2024-05-30 03:33:05 +07:00
Nick Richmond
7334f71e09
CodeEditor: Improved styles when the code editor is loading (#88102)
* fix: monaco loading state

* chore: betterer

* test: leverage e2e selectors

* refactor: prefer HOC to wrap with testid

* refactor: add clarity

* docs: add clarity

* refactor: loading messaging

* test: rename vars to improve clarity

* test: rename vars to improve clarity
2024-05-29 15:55:18 -04:00
William Wernert
5de7d4d06d
Alerting: Create writer interface for recording rules (#88459)
* Create writer interface for recording rules

Also create fake impl + use it for stub in scheduler
2024-05-29 22:38:33 +03:00
Joseph Perez
4e99cd2860
Docs: Edit of "Developer Guide" and other topics (part 2 of doc quality project) (#86072)
* Edit deprecation-policy

* Edit drone-pipeline

* Docs: Edit of 4 files, part 2 of quality improvement

* Update contribute/developer-guide.md

* Update contribute/developer-guide.md

Co-authored-by: J Stickler <julie.stickler@grafana.com>

* Changes from feedback

* Properly style UNIX

* Update contribute/drone-pipeline.md

* Update contribute/feature-toggles.md

Co-authored-by: J Stickler <julie.stickler@grafana.com>

* Format with prettier

---------

Co-authored-by: J Stickler <julie.stickler@grafana.com>
2024-05-29 11:08:41 -07:00
Ezequiel Victorero
e81f48ef95
Dashboards: Do not expose datasource name and uid on dashboard external export (#88382)
Co-authored-by: Juan Cabanas <juan.cabanas@grafana.com>
2024-05-29 14:36:48 -03:00
Bogdan Matei
55ea077c3e
Scopes: Select scope even without data retrieval (#87988)
* Scopes: Select scope even without data retrieval

* Pass entire scope and not only the spec to Prometheus

* Enrich ScopeSpec that is sent to Prometheus

* add name to BE

---------

Co-authored-by: Kyle Brandt <kyle@grafana.com>
2024-05-29 20:09:27 +03:00
Señor Performo - Leandro Melendez
8b5c9e3e2a
Docs: Add Installation YouTube Videos to documentation pages. (#88443)
* Added Installation video index.md

* Update index.md adding video for Debian and Ubuntu installs

* Update index.md adding install video in macOS

* Update index.md adding video to install RHEL or Fedora

* Update index.md adding install video for SUSE

* Update index.md adding video for Windows installer
2024-05-29 10:56:15 -06:00
Tom Ratcliffe
3adb07cf4d
Alerting: Make regex notification routing preview consistent with notification policies implementation (#88413)
Co-authored-by: Gilles De Mey <gilles.de.mey@gmail.com>
2024-05-29 17:04:35 +01:00
renovate[bot]
2a65a8a1d1 Update dependency @reduxjs/toolkit to v2.2.5 2024-05-29 15:42:32 +00:00
renovate[bot]
dfae694cff Update dependency @react-types/shared to v3.23.1 2024-05-29 15:22:25 +00:00
Carl Bergquist
0e6464fc96
Don't use transaction for updating last seen for an user. (#88426)
dont use transaction for updating last seen

Signed-off-by: bergquist <carl.bergquist@gmail.com>
2024-05-29 18:13:04 +03:00
Sonia Aguilar
289ce61855
Alerting: Add the feature toggle for the new central alert state history feature (#88346)
* Add the feature toggle for the new central alert state history feature

* WIP

* Revert "WIP"

This reverts commit 80b8879d4e.
2024-05-29 18:01:38 +03:00
renovate[bot]
e1d7ef30ec Update dependency @react-types/overlays to v3.8.7 2024-05-29 14:47:24 +00:00
Sven Grossmann
f81e8e04aa
LogsTable: Fix default sort by time (#88398) 2024-05-29 16:46:26 +02:00
renovate[bot]
144e476840 Update dependency @react-types/menu to v3.9.9 2024-05-29 14:30:54 +00:00
Darren Janeczek
763108ce10
datatrails: in Components, model.useState(), instead of model.state (#88432)
fix: in Components, `model.useState()`, instead of `model.state`

Generally, it is better practice. More succinct.
It could also eliminate subtle state bugs.
2024-05-29 10:29:57 -04:00
renovate[bot]
633486e4f1 Update dependency @react-types/button to v3.9.4 2024-05-29 14:10:56 +00:00
brendamuir
c8bbc9d6e5
Alerting docs: adds template selector docs (#88412)
* Alerting docs: adds template selector docs

* adds line about single save
2024-05-29 15:39:22 +02:00
renovate[bot]
e63037fe51 Update dependency @playwright/test to v1.44.1 2024-05-29 13:34:47 +00:00
renovate[bot]
8fa48ceb76 Update dependency @kusto/monaco-kusto to v10.0.22 2024-05-29 12:53:14 +00:00
renovate[bot]
c5b27c809a Update dependency @grafana/faro-web-sdk to v1.7.3 2024-05-29 11:55:28 +00:00
Gilles De Mey
781f67dfb6
Alerting: Support alertingDisableSendAlertsExternal feature toggle (#88384) 2024-05-29 13:54:07 +02:00
renovate[bot]
e93169b66c Update dependency @grafana/faro-web-sdk to v1.7.3 2024-05-29 11:30:50 +00:00
Ana Ivanov
c977653811
Add navigation config for grafana-csp-app (#88360)
Add navigation config for grafana-csp-app
2024-05-29 14:28:33 +03:00
Laura Fernández
a47e71fd34
Chore: create the no-untranslated-literals rule (#88271) 2024-05-29 13:03:59 +02:00
Fayzal Ghantiwala
543f0ae37e
Alerting: Update ListAlertRulesQuery to take a slice of RuleGroups (#88385)
* Change ListAlertRulesQuery to take RuleGroup slice instead

* Change func name

* Change func name

* Fix fakes

* Fix function arg
2024-05-29 11:50:33 +01:00
renovate[bot]
4c8ce76929 Update dependency @grafana/faro-core to v1.7.3 2024-05-29 09:55:43 +00:00
Andres Martinez Gotor
0f32c2bff9
Revamp tests for Add/Update Datasource (#88386) 2024-05-29 04:54:11 -05:00
renovate[bot]
2d18de7e84
Update dependency @floating-ui/react to v0.26.16 (#88409)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-05-29 12:28:26 +03:00
renovate[bot]
48d49b4502
Update dependency cypress to v13.10.0 (#84140)
* Update dependency cypress to v13.10.0

* updated cypress-version in config

* updated configs

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Gábor Farkas <gabor.farkas@gmail.com>
2024-05-29 11:10:42 +02:00
Ben Sully
2455c0cc37
Add Kubernetes icon (#86677) 2024-05-29 09:49:59 +01:00
github-actions[bot]
d8b662e8d5
Update make docs procedure (#88404)
Co-authored-by: grafanabot <bot@grafana.com>
2024-05-29 08:12:13 +00:00
Gabriel MABILLE
5eecc01123
VSCode: Launch Grafana with Storage server (#88351)
* VSCode: Launch Grafana with Storage server

* Fix module_server_test
2024-05-29 10:02:35 +02:00
antonio
1f90123f35
alerting>tutorials>get-started v2 (#88373)
* alerting>tutorials>get-started v2

* admon fix

* link fix

* pretty face

* Update docs/sources/tutorials/alerting-get-started/index.md

Co-authored-by: brendamuir <100768211+brendamuir@users.noreply.github.com>

* Update docs/sources/tutorials/alerting-get-started/index.md

Co-authored-by: brendamuir <100768211+brendamuir@users.noreply.github.com>

* Update docs/sources/tutorials/alerting-get-started/index.md

Co-authored-by: brendamuir <100768211+brendamuir@users.noreply.github.com>

* Update docs/sources/tutorials/alerting-get-started/index.md

Co-authored-by: brendamuir <100768211+brendamuir@users.noreply.github.com>

* Update docs/sources/tutorials/alerting-get-started/index.md

Co-authored-by: brendamuir <100768211+brendamuir@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: brendamuir <100768211+brendamuir@users.noreply.github.com>

* suggestions

* All pretty, no pity.

---------

Co-authored-by: brendamuir <100768211+brendamuir@users.noreply.github.com>
2024-05-29 10:00:37 +02:00
Leonor Oliveira
ade96dbdbd
Introduce Comparator interface (#88016)
* Introduce Comparator interface

* Add compare implementation everywhere

* Add comment explaining what Compare should do

* Lint
2024-05-29 09:42:24 +02:00
Tobias Skarhed
06304894a1
Dashboard: Keyboard and mouse panel shortcuts improvement (#87317)
* Add custom attention state to dashboard

* Add attention state to DashboardGrid

* Remove old functionality

* Add attention state to keybindingSrv

* Create PanelAttentionService

* Add PanelAttentionService with scenes support

* Remove unused code

* Use viz panel key instead of VizPanel

* Add type assertion

* Add e2e test

* Update comments

* Use panel id for non-scenes use case

* Support undefined service use case

* Memoize singleton call

* Debounce mouseover

* Set panelAttention with appEvents

* Use AppEvents for Scenes

* Remove panelAttentionSrv

* Wait in e2e to handle debounce

* Move subscription to KeybindingSrv

* Remove imports and reset keyboardShortcuts from main

* Fix on* event handlers
2024-05-29 09:11:23 +02:00
Larissa Wandzura
66d6b3d83b
Docs: Update Grafana Teams documentation (#86942)
* added config doc

* added content

* added new topic docs and made updates

* minor updates

* updates based on feedback

* ran prettier , made updates

* removed original doc, updates to topic docs

* removed old index doc

* fixed format issue

* Update docs/sources/administration/team-management/administering-grafana-teams.md

Co-authored-by: Jack Baldry <jack.baldry@grafana.com>

* Update docs/sources/administration/team-management/configure-grafana-teams.md

Co-authored-by: Jack Baldry <jack.baldry@grafana.com>

* Update docs/sources/administration/team-management/configure-grafana-teams.md

Co-authored-by: Jack Baldry <jack.baldry@grafana.com>

* Update docs/sources/administration/team-management/configure-grafana-teams.md

Co-authored-by: Jack Baldry <jack.baldry@grafana.com>

* Update docs/sources/administration/team-management/configure-grafana-teams.md

Co-authored-by: Jack Baldry <jack.baldry@grafana.com>

* Update docs/sources/administration/team-management/administering-grafana-teams.md

Co-authored-by: Jack Baldry <jack.baldry@grafana.com>

* Update docs/sources/administration/team-management/_index.md

Co-authored-by: Jack Baldry <jack.baldry@grafana.com>

* Update docs/sources/administration/team-management/configure-grafana-teams.md

Co-authored-by: Jack Baldry <jack.baldry@grafana.com>

* Update docs/sources/administration/team-management/configure-grafana-teams.md

Co-authored-by: Jack Baldry <jack.baldry@grafana.com>

* Update docs/sources/administration/team-management/configure-grafana-teams.md

Co-authored-by: Jack Baldry <jack.baldry@grafana.com>

* Update docs/sources/administration/team-management/configure-grafana-teams.md

Co-authored-by: Jack Baldry <jack.baldry@grafana.com>

* edits based on feedback

* updates based on feedback

* improved some wording

* ran prettier

* minor correction

* added aliases

* Update docs/sources/administration/team-management/configure-grafana-teams.md

Co-authored-by: Jack Baldry <jack.baldry@grafana.com>

* added contractions

* Removed .nx

---------

Co-authored-by: Jack Baldry <jack.baldry@grafana.com>
2024-05-29 08:22:45 +03:00
Andreas Christou
3eea71cc6b
Azure: Basic Logs support (#88025)
* Azure monitor: Basic Logs frontend (#85905)

* adds datasource level config for enabling basic logs

* add basiclogsquery type to query json

* add toggle between basic and analytics

* adds basic logs toggle from UI, blocks time picker to only dashboard if basic logs is selected

* add check to remove UI if alerting

* tests for logsmanagement component

* tests for logs query editor

* tests for time mangement control

* remove unused imports

* clears query whenever toggle changes from basic <-> analytics

* add test to account for clearning query

* Update public/app/plugins/datasource/azuremonitor/components/ConfigEditor/BasicLogsToggle.tsx

wording

Co-authored-by: Andreas Christou <andreas.christou@grafana.com>

* Update public/app/plugins/datasource/azuremonitor/components/LogsQueryEditor/LogsQueryEditor.tsx

spelling

Co-authored-by: Andreas Christou <andreas.christou@grafana.com>

* Update public/app/plugins/datasource/azuremonitor/components/LogsQueryEditor/LogsQueryEditor.tsx

spelling

Co-authored-by: Andreas Christou <andreas.christou@grafana.com>

* update dependency list

* clear basic logs if resources change

* fix tests

---------

Co-authored-by: Andreas Christou <andreas.christou@grafana.com>

* Azure Monitor: Basic Logs modal acknowledgement (#86244)

* adds datasource level config for enabling basic logs

* add basiclogsquery type to query json

* add toggle between basic and analytics

* adds basic logs toggle from UI, blocks time picker to only dashboard if basic logs is selected

* add check to remove UI if alerting

* tests for logsmanagement component

* tests for logs query editor

* tests for time mangement control

* remove unused imports

* add confirm modal

* clears query whenever toggle changes from basic <-> analytics

* add test to account for clearning query

* adds modal acknowledgement for basic logs query

* tests for handling modal logic

* basic logs ack type

* Update public/app/plugins/datasource/azuremonitor/components/ConfigEditor/BasicLogsToggle.tsx

wording

Co-authored-by: Andreas Christou <andreas.christou@grafana.com>

* Update public/app/plugins/datasource/azuremonitor/components/LogsQueryEditor/LogsQueryEditor.tsx

spelling

Co-authored-by: Andreas Christou <andreas.christou@grafana.com>

* Update public/app/plugins/datasource/azuremonitor/components/LogsQueryEditor/LogsQueryEditor.tsx

spelling

Co-authored-by: Andreas Christou <andreas.christou@grafana.com>

* update dependency list

* clear basic logs if resources change

* remove modal from config page

* remove basic logs query ack type

* add modal acknowledgement to toggle between basic and analytics

* clear query if resources change

* fix tests

* fix tests

* Update public/app/plugins/datasource/azuremonitor/components/LogsQueryEditor/LogsManagement.tsx

Co-authored-by: Andreas Christou <andreas.christou@grafana.com>

* fix tests

---------

Co-authored-by: Andreas Christou <andreas.christou@grafana.com>

* Azure Monitor: Basic Logs Backend (#87653)

* fix logic for showingBasicLogsToggle

* move to utils function and add basiclogsquery in apply template variable

* add backend safeguards for basiclogsqueries

* adds support for calling search or query apis based on whether it is basic logs or not

* add tests for utils

* initial test for basic logs query in the backend

* tests for basic logs

* remve comment

* simplify checks for basic logs

* adds fromAlert prop for azure monitor backend services

* adds fromAlert check fo basic logs

* fix working and empty tags

* add telemetry for basic logs

* remove import from grafana core package

* change fromAlert true in tests

* change the way tests catch errors

* Update pkg/tsdb/azuremonitor/loganalytics/utils.go

Co-authored-by: Andreas Christou <andreas.christou@grafana.com>

* Update pkg/tsdb/azuremonitor/loganalytics/utils.go

Co-authored-by: Andreas Christou <andreas.christou@grafana.com>

* Update pkg/tsdb/azuremonitor/loganalytics/utils.go

Co-authored-by: Andreas Christou <andreas.christou@grafana.com>

* Update pkg/tsdb/azuremonitor/loganalytics/azure-log-analytics-datasource.go

Co-authored-by: Andreas Christou <andreas.christou@grafana.com>

* restructure code to only run basic logs checks if basiclogsflag is true

* data retention warning

* tests for calculate time range

* Simplify determining if request is from alerting

* Fix lint and bool check

* Fix tests

* clarify data retention

---------

Co-authored-by: Jocelyn <jcolladokuri@microsoft.com>
Co-authored-by: jcolladokuri <jocelyncollado52@gmail.com>

* Azure Monitor: Basic Logs data volume notification (#88009)

* frontend changes for data ingested warning

* initial logic for getResource

* payload processing

* create basicLogs usage function

* add utils for converting time and getting the data volume query for basic logs

* frontend updates for showing the data ingested for the given query

* frontend tests

* add check for when no dataIngested is returned

* remove backend.logger prints

* comment on what function does

* fix merge

* make resource URI regex case insensitive

* add support for workspace variables in basic logs flow

* add undefined check

* structure and add tests for variable support

* Update pkg/tsdb/azuremonitor/loganalytics/azure-log-analytics-datasource.go

Co-authored-by: Andreas Christou <andreas.christou@grafana.com>

* add tracing for basic logs usage request

* clean up data volume query struct

* use async/await instead of callback

* fix parameters for getApiURL

* restrict time on usage query to 8 days max

* add time to dependency array to refetch basic logs usage

* move time check implementation to backend

* fix utils tests

---------

Co-authored-by: Jocelyn <jcolladokuri@microsoft.com>
Co-authored-by: jcolladokuri <jocelyncollado52@gmail.com>

---------

Co-authored-by: jcolladokuri <jcolladokuri@microsoft.com>
Co-authored-by: jcolladokuri <jocelyncollado52@gmail.com>
2024-05-28 18:06:27 +01:00
Stephen J. Smith
0b2fab9967
Azure Monitor: Fix typo that may cause an API request to fail (#88320)
Fix typo
2024-05-28 17:58:06 +01:00
Alexander Weaver
b926b6336d
Alerting: Scheduled recording rules execute their queries (#88309)
* Basic eval flow

* Wiring-up

* fix

* Extend todo

* Start with tests

* Include some relevant tests, skip ones that seem to have timing-based race conditions

* Some tests, touch up linter and todo

* Solve TODO

* Add tracing

* Tests to make sure an eval went through

* Wire up feature toggles

* Update pkg/services/ngalert/schedule/recording_rule.go

Co-authored-by: Steve Simpson <steve.simpson@grafana.com>

* Update pkg/services/ngalert/schedule/recording_rule_test.go

Co-authored-by: Steve Simpson <steve.simpson@grafana.com>

* Update pkg/services/ngalert/schedule/recording_rule_test.go

Co-authored-by: Steve Simpson <steve.simpson@grafana.com>

* Update pkg/services/ngalert/schedule/recording_rule_test.go

Co-authored-by: Steve Simpson <steve.simpson@grafana.com>

---------

Co-authored-by: Steve Simpson <steve.simpson@grafana.com>
2024-05-28 10:59:21 -05:00
Eric Leijonmarck
910553df20
Actionsets: Add cfg option for only writing actionsets (#88367)
* test

* test

* missed test

* fix review comments
2024-05-28 16:32:23 +01:00
Andrej Ocenas
5f326e98c1
NodeGraph: Add msagl and the layered layout code (#88375) 2024-05-28 17:04:03 +02:00
Bruno
07debd66c2
Ephemeral instances: fetch the grafana version from the package.json file (#88300) 2024-05-28 11:52:00 -03:00
Matthew Jacobson
8418aca823
Alerting: Add single rule checks to alert rule access control (#88307)
* Alerting: Add single rule checks to alert rule access control

Modifies ruler api single rule read to no longer fetch entire groups and instead
 use the new single rule ac check.
Simplifies provisioning api getAlertRuleAuthorized logic to always load a single
 rule instead of conditionally loading the entire group when provisioning
 permissions are not present.

* Swap out Has/AuthorizeAccessToRule for Has/AuthorizeAccessInFolder
2024-05-28 10:49:24 -04:00
Eric Leijonmarck
ebbb64059f
LBAC datasource: Add swagger updates (#88383)
add swagger updates
2024-05-28 15:28:12 +01:00
Jack Baldry
26c2391c7e
[docs/sources/datasources] Replace docs/reference shortcode with ref URIs (#88078) 2024-05-28 15:17:49 +01:00