Commit Graph

904 Commits

Author SHA1 Message Date
Sonia Aguilar
753c84f825
Alerting: Pass yaml as a query param in export request (#62751)
* Set YAML as default value for exporting alert rules

* use YAML format for rule list export

Co-authored-by: Sonia Aguilar <33540275+soniaAguilarPeiron@users.noreply.github.com>

* lint

* Add new format query param to swagger+docs

* Fix broken test

---------

Co-authored-by: Gilles De Mey <gilles.de.mey@gmail.com>
Co-authored-by: Matt Jacobson <matthew.jacobson@grafana.com>
2023-02-02 16:10:02 +00:00
Sonia Aguilar
517e614661
Alerting: Set YAML as default value for exporting alert rules (#62760)
Set YAML as default value for exporting alert rules
2023-02-02 11:38:27 +00:00
Torkel Ödegaard
b8e7ef48d0
AppChrome: Unify logic for chromeless pages that should not have NavBar, CommandPalette, Search etc (#62281)
* Keybindings: No global keybindings on chromeless pages

* simplify condition

* Refactoring

* Align name and file

* Move logic into AppChrome

* minor fix

* Update Page.tsx

* Fixing test

* Fixed tests

* More fixes

* Fixed more tests

* Fixing final test

* Fixed search in old nav
2023-02-02 09:53:06 +01:00
Gilles De Mey
26866953c1
Alerting: hide "silence" button for external AM setups (#62133) 2023-02-01 15:51:05 +01:00
Sonia Aguilar
151e57df70
Alerting: Add Copy action to templates table (#62135)
* Add duplicate action to templates table

Co-authored-by: Virginia Cepeda <virginia.cepeda@grafana.com>

* Move duplicate icon, and remove provenance when rendering TemplateForm

* Create generic generateCopiedName method to avoid duplication and use it also in the CloneRuleEditor

* Use 'Copy' for duplicating templates and cloning alert rules

* Improve updating the template content with new unique define values when copying

Co-authored-by: Konrad Lalik <konradlalik@gmail.com>

* Fix typo

---------

Co-authored-by: Virginia Cepeda <virginia.cepeda@grafana.com>
Co-authored-by: Konrad Lalik <konradlalik@gmail.com>
2023-02-01 14:14:10 +01:00
Gilles De Mey
faa920437c
Alerting: Add support for "normal" as state filter in rule search (#62630) 2023-02-01 13:32:06 +01:00
Alex Moreno
53945afedf
Alerting: Allow alert rule pausing from API (#62326)
* Add is_paused attr to the POST alert rule group endpoint

* Add is_paused to alerting API POST alert rule group

* Fixed tests

* Add is_paused to alerting gettable endpoints

* Fix integration tests

* Alerting: allow to pause existing rules (#62401)

* Display Pause Rule switch in Editing Rule form

* add isPaused property to form interface and dto

* map isPaused prop with is_paused value from DTO

Also update test snapshots

* Append '(Paused)' text on alert list state column when appropriate

* Change Switch styles according to discussion with UX

Also adding a tooltip with info what this means

* Adjust styles

* Fix alignment and isPaused type definition

Co-authored-by: gillesdemey <gilles.de.mey@gmail.com>

* Fix test

* Fix test

* Fix RuleList test

---------

Co-authored-by: gillesdemey <gilles.de.mey@gmail.com>

* wip

* Fix tests and add comments to clarify AlertRuleWithOptionals

* Fix one more test

* Fix tests

* Fix typo in comment

* Fix alert rule(s) cannot be paused via API

* Add integration tests for alerting api pausing flow

* Remove duplicated integration test

---------

Co-authored-by: Virginia Cepeda <virginia.cepeda@grafana.com>
Co-authored-by: gillesdemey <gilles.de.mey@gmail.com>
Co-authored-by: George Robinson <george.robinson@grafana.com>
2023-02-01 13:15:03 +01:00
Sonia Aguilar
c0865c863d
Alerting: Show 'start typing' message in evaluation group folder in case of empty options. (#62611)
Show start typing message in evaluation group folder in case of empty options
2023-02-01 12:20:57 +01:00
ismail simsek
91221bc436
Expressions: Fixes the issue showing expressions editor (#62510)
* Use suggested value for uid

* update the snapshot

* use __expr__

* replace all -100 with __expr__

* update snapshot

* more changes

* revert redundant change

* Use expr.DatasourceUID where it's possible

* generate files
2023-01-31 18:50:10 +01:00
Gilles De Mey
702fd0f9e8
Docs: Update wording / text and copy (#61868)
Co-authored-by: brendamuir <100768211+brendamuir@users.noreply.github.com>
2023-01-30 15:26:21 +00:00
Konrad Lalik
7b47beef2f
Alerting: Add Rule UID and Clone button to the rule details page (#62321) 2023-01-30 16:02:01 +01:00
Sonia Aguilar
d44f250aea
Alerting: Add export button for exporting all alert rules in alert list view (#62416)
* Add export button for exporting all alert rules in alert list view

* Add RBAC for export button

* Use provisioningPermissions.read in getRulesAccess method instead of directly using AccessControlAction.AlertingProvisioningRead
2023-01-30 11:13:08 +01:00
Gilles De Mey
13159d03ba
Alerting: Use optional chaining for accessing frames (#61814) 2023-01-28 18:39:23 +01:00
Gilles De Mey
54ff88463c
Alerting: remove link to Grafana University (#62318) 2023-01-27 08:21:47 -05:00
Sonia Aguilar
8bbef70363
Alerting: Fix recording rules being shown in the rules table on edit group modal (#62171)
* Fix recording rules being shown in the rules table on edit group modal

* Show no alerts message when there is not some non-recording rules and add tests

* Move specific mock constants to the test file
2023-01-26 16:11:29 +01:00
Konrad Lalik
e8dd01df35
Alerting: Alert rules search improvements (#61398)
Co-authored-by: Gilles De Mey <gilles.de.mey@gmail.com>
2023-01-26 13:44:14 +01:00
Virginia Cepeda
a20d1eec32
Alerting: validate alert condition on saving rule (#61958)
* Validate alert condition on saving rule

* Remove unused const
2023-01-26 09:27:08 -03:00
Sonia Aguilar
dbdd135298
Alerting: Fix recording rules showing alert notification information. (#61988)
* Fix recording rules form steps not showing alert information

* Fix docs about creating cloud and recording rules

* Update docs with suggested changes
2023-01-25 08:26:51 +00:00
Sonia Aguilar
3b73b16245
Alerting: Add maxdatapoints in alert rule form (#61904)
Add maxdatapoints in alert rule form
2023-01-24 09:16:21 +01:00
Jack Westbrook
3a7623753b
Build: Replace babel-loader with esbuild-loader (#57837)
* build(webpack): replace babel-loader with esbuild-loader

* build(webpack): add esbuild minifier to production builds

* Wip

* Removed ngInject and replaced with manual inject params

* chore: bump esbuild to 0.15.13

* Fixed angular issues

* build(frontend): update esbuild to 0.16.16

* chore(webpack): support browserslist for esbuild

* build(esbuild): unify versions of esbuild to 0.16.17 and esbuild-loader to 2.21.0

Co-authored-by: Torkel Ödegaard <torkel@grafana.com>
2023-01-23 12:15:05 +01:00
Ivan Ortega Alba
5bfe098b0a
test: use deterministic timestamp to compare snapshots (#61670) 2023-01-23 09:44:10 +01:00
Gilles De Mey
845128dde9
Alerting: Swap templates and contact points places (#61808)
Alerting: swap templates and contact points places
2023-01-19 21:51:45 +01:00
Sonia Aguilar
a6102105af
Alerting: Fix QueryAndExpressionStep not using the right query (#61738)
Fix QueryAndExpressionStep not using the right query
2023-01-19 17:33:32 +01:00
George Robinson
d4256b352d
Docs: Rename Message templates to Notification templates (#59477)
This commit renames "Message templates" to "Notification templates"
in the user interface as it suggests that these templates cannot
be used to template anything other than the message. However, message
templates are much more general and can be used to template other fields
too such as the subject of an email, or the title of a Slack message.
2023-01-18 17:26:34 +00:00
Konrad Lalik
9256ca371d
Alerting: Landing page v2 (#61600) 2023-01-18 12:40:09 +01:00
Santiago
b5fa9e3501
Chore: Fix "manger" typo (#61649)
fix mangers -> managers
2023-01-17 23:13:27 +00:00
Sonia Aguilar
04b5e6ed9e
Alerting: Fix group select not being filled by selected folder when creating alert from panel (#61577)
Add fetchRulerRulesIfNotFetchedYet fetching when results are an empty object
2023-01-17 11:16:54 +01:00
Sonia Aguilar
fb5a033282
Alerting: use SupportedPlugin.OnCall detecting OnCall types as a single source of truth (#61473)
Use SupportedPlugin.OnCall detecting OnCall types as a single source of truth
2023-01-13 13:34:39 +01:00
Sonia Aguilar
24c3c3a0ef
Alerting: Use pluginBridge to check if plugin is installed (#61356)
* Use getPluginSettings (/api/plugins//settings) to check if plugin is installed

* Use usePluginBridge hook instead of getPluginSettings to check if plugin is installed
2023-01-12 19:52:36 +01:00
Gilles De Mey
6b620c79e0
Alerting: Fix flakey silence test (#61395) 2023-01-12 14:32:25 -03:00
Gilles De Mey
11a8628381
Alerting: Improve incident button (#61372) 2023-01-12 15:30:31 +01:00
Sonia Aguilar
f2d4e24710
Alerting: improve FolderPicker and Evaluation Group Select for Huge lists (#61221)
* Add AsyncVirtualizedSelect component in grafana-ui

* Slice FolderPicker results to 1k and virtualize list using AsyncVirtualizedSelect

* Group list in alert form: Use AsyncSelect and slice results to 1000

* Virtualize and slice always in FolderPicker: set default sliceResults value and let consumers change this value

* Always slice results in FolderPicker

* Limit folder results setting the limit in the api call instead slicing in the FE

* Remove warning about the limit in the Select label
2023-01-12 11:45:03 +01:00
Sonia Aguilar
f7ae909324
Alerting: Fix General folder being added in alerting FolderPicker (#61277)
Fix General folder being added in alerting FolderPicker
2023-01-11 15:35:47 +01:00
Marcus Andersson
b633d5395d
Bugfix: Prevent previous query editor to set default values when changing data source (#60218)
* Fixed issue where the query editor of the previous ds sets default values on query passed to the query editor of the next ds.

* Fixed issue with changing data source for query in Alerting.

* Will apply default values from DS if available.

* Fix failing tests.

* fixed spell error.

* reverted getDefaultQuery call so it can be added in a separate PR.
2023-01-11 14:06:33 +01:00
Gilles De Mey
909ec67c56
Alerting: Declare incident from a firing alert (#61178) 2023-01-11 11:52:20 +00:00
Gilles De Mey
db6d0464e9
Alerting: revert #60728 (#61222) 2023-01-11 12:37:11 +01:00
Virginia Cepeda
3b2ec752fb
Alerting: change context parameter type (#61197)
Change boolean value to string as the Faro API doesn't accept boolean types for the entries of the context object
2023-01-10 12:17:11 -03:00
Virginia Cepeda
7604360622
Alerting: Add info to alert rule creation metric (#61105)
Add extra info to alert rule creation metrics
2023-01-09 15:27:02 -03:00
Virginia Cepeda
115218b1ff
Alerting: only track events for survey if user is not new (#61005)
* Only track events data if user is not new

To know this we evaluate the creation date to be older than two weeks

* Address PR comments
2023-01-09 14:41:03 -03:00
Sonia Aguilar
4ae0382415
Alerting: Add pagination in group modal alert table (#60868)
Add pagination in group modal alert table
2023-01-04 14:48:34 +01:00
Sonia Aguilar
f22286df3f
Alerting: Fix missing edit/delete/copy link in alert view (#60874)
Fix missing edit/delete/copy link in alert view
2023-01-03 13:08:14 +01:00
Gilles De Mey
f72cbc16ad
Alerting: Warn about missing contact-point in notification policy (#60728)
* initial simplistic version
still need to figure out what to do with child policies

* adds test
2022-12-23 14:54:57 +01:00
Gilles De Mey
e9fe9baf66
Alerting: Improve threshold displays (#60046) 2022-12-22 16:28:17 +01:00
Kristina
58716de073
Fix Explore URL generator (#60653) 2022-12-22 16:23:30 +01:00
Sonia Aguilar
22ad487c4b
Use queryFn instead of query to be able to catch errors in onCall req… (#60685)
Use queryFn instead of query to be able to catch errors in onCall request
2022-12-22 14:30:27 +01:00
Gilles De Mey
cb1ca92419
Alerting: re-enable recording rule editor test (#60639) 2022-12-21 13:12:44 -03:00
Gilles De Mey
16c6f223ba
TimeSeriesPanel: Allow threshold indicators without change handler (#60575) 2022-12-21 16:18:35 +01:00
Sonia Aguilar
e219e2a834
Alerting: Recognise & change UI for OnCall notification policy + contact point (#60259)
* Identify and show onCall contact points with a badge in case the plugin is installed

* Add onCall logo for onCall contact points Badge

* Refactor and make Grafana App Receiver type more generic, not only for onCall type

* Show onCall notification policy in the specific routing table with special onCall badge

* Fix tests

* Move onCall badge to the type column in contact points view table

* Fix typos and remove onCallIntegrations from tagTypes in alertingApi

* Fetch only local plugins instead of all (external are not needed) and don't fetch plugin details

* Use directly useGetOnCallIntegrationsQuery and more PR review suggestions

* Move onCall contact point to the top in the drop-down,  in the notification policy view

* Add PR review requested changes
2022-12-21 14:46:55 +01:00
Armand Grillet
aaab477594
Use new link for templating docs (#60615) 2022-12-21 13:10:08 +01:00
Santiago
d070032065
Alerting: Fix incorrect links/aliases to template docs (#60597) 2022-12-20 22:38:01 +01:00