Commit Graph

874 Commits

Author SHA1 Message Date
Giordano Ricci
9770768efc
Chore: refactor some styles in explore to use the object syntax (#80080)
* Chore: refactor some styles in explore to use the object syntax

* refactor LiveLogs styles to use object syntax

* Revert "refactor LiveLogs styles to use object syntax"

This reverts commit 293aa2589f.
2024-01-16 19:49:12 +00:00
Andre Pereira
d27e2fec88
Data Trails: Actions redesign and overview tab (#80216)
* Use last used datasource or default datasource when starting a trail

* Use tabs and move actions bar to same line when possible

* Added overview tab with description, type and labels

* Clickable labels in overview tab

* Show label value counts next to the label name

* Fix action bar zIndex

* Address PR comments

* Refactor

* Refactor getLabelOptions to utils

* Reuse language provider from state

* betterer

* testing some refactors

* Remove unreachable code

* Refactor GROUP_BY var to MetricScene

* Fix url by excluding var-groupby

* Fix conflicts

* Use <Text/> instead of custom styles

* Simplify setting overview as default tab

---------

Co-authored-by: Torkel Ödegaard <torkel@grafana.com>
2024-01-16 20:22:53 +02:00
Joey
6796e66fb8
Pyroscope: Add standalone build (#80222)
* Pyroscope standalone build

* Fix for tests

* Add missing packages

* Remove import

* Update trace to profiles

* Update test
2024-01-16 12:46:15 +00:00
Ivan Ortega Alba
07778cb221
DashboardLinksSettings: Move them to Scenes (#79998) 2024-01-16 13:24:54 +02:00
Ivana Huckova
67d77e76be
Loki: Refactor debug section to remove dependency on deprecated getFieldLinksForExplore (#80594)
* Refactor debug section

* Show href only if matched regex
2024-01-16 12:00:31 +01:00
Fabrizio
522519f671
Tempo: Decouple Tempo from Grafana core (#79888) 2024-01-16 11:36:40 +01:00
Ashley Harrison
406ace27c0
Chore: remove merge conflict from .betterer.results (#80563)
remove merge conflict
2024-01-15 16:19:16 +00:00
Torkel Ödegaard
8157711893
DashboardDataSource: Implement sharing logic inside the data source (#80526)
* Make dashboard data source query actually use DashboardDataSource

* remove commented out bit

* Always wrap SceneQueryRunner with SceneDataTransformer

* Update Dashboard model compat wrapper tests

* DashboardQueryEditor test

* VizPanelManager tests update

* transform save model to scene tests update

* Betterer

* PanelMenuBehavior test update

* Few more bits

* Prettier

---------

Co-authored-by: Dominik Prokop <dominik.prokop@grafana.com>
2024-01-15 16:43:30 +01:00
Victor Marin
1cf53a34d1
Scenes: Render versions in dashboard settings (#80229)
* Add versions tab in dashboard settings

* Fetch and render dashboard versions

* PR discussion changes

* remove unnecessary async in test

* PR discussion mods

* linter fix
2024-01-15 16:57:45 +02:00
Ashley Harrison
d5db67a073
Chore: type improvements (#80464)
* type improvements

* some more fixes

* add TODOs to remove type assertions
2024-01-15 14:29:39 +00:00
Sonia Aguilar
10f0d094ad
Alerting: Visualize autogenerated policy tree for simplified routing. (#79509)
* WIP

* WIP: disable some actions when is autogenerated policy

* WIP

* Wip: add checks for group by in auto-generated policy

* Make autogenerated policy readOnly and enable Readonly modal for it

* Use real check for autogenerated root

* Fix test

* Refactor: rename consts

* Add test for policy form being read only

* Add tests

* Update some code comments

* Fix Switch component not being styled as disabled

* Rename isAutogeneratedChunkOpen property to isBranchOpen and fix test

* Revert fix for Switch as it has moved to another separate PR

* Split Policy component in smaller sub components

* use useAlertmanagerAbility form for checking autogenerated tree visibility and fix container for autogenerated policy being rendered when it's not supported

* Update useAbilities test and dont use toAbility for ViewAutogeneratedPolicyTree

* Fix Policy being unmounted every 10 secs and move the collapsed/expanded state to each Policy component

* remove permissions from createDropdownMenuActions method parameters and convert the method to a hook

* Revert using PolicyItem

* Add test for createDropdownMenuActions

* Revert having a read only view form for the policy

* Remove readonly from default policy form

* Only show collapsible when node has children

* Split DefaultPolicyIndicator

* use hidehideCurrentPolicy instead of showCurrentPolicy

* Address some review suggestions
2024-01-15 13:36:26 +01:00
Jamin
66c85d9826
Frontend: Migrate LoadingIndicator.tsx from aria-label e2e selectors to data-testid (#79664)
* refactor: update component to use data-testid

* refactor: update loading indicator e2e selector

* oops - forgot to update betterer results

* update loading indicator in variable picker

---------

Co-authored-by: joshhunt <josh@trtr.co>
Co-authored-by: Josh Hunt <joshhunt@users.noreply.github.com>
2024-01-12 18:30:11 +02:00
Giordano Ricci
e471064cda
Explore: use numeric ids for panel ids when building query transactions (#80135) 2024-01-12 14:05:46 +00:00
Matias Chomicki
aa670280fc
Logs: add infinite scrolling to Explore (#76348)
* Explore: propose action, thunk, and decorators for load more

* LogsContainer: add loadMore method

* Query: remove unused var

* Loading more: use navigation to simulate scrolling

* Explore: figure out data combination

* Fix imports

* Explore: deduplicate results when using query splitting

* LogsNavigation: add scroll behavior

* Remove old code

* Scroll: adjust delta value

* Load more: remove refIds from signature

We can resolve them inside Explore state

* Load more: rename to loadMoreLogs

* Infinite scrolling: use scrollElement to listen to scrolling events

* Explore logs: add fixed height to scrollable logs container

* Logs: make logs container the scrolling element

* Logs: remove dynamic logs container size

It works very well with 1 query, but breaks with more than 1 query or when Logs is not the last rendered panel

* Logs navigation: revert changes

* Infinite scroll: create component

* Infinite scroll: refactor and clean up effect

* Infinite scroll: support oldest first scrolling direction

* Infinite scroll: support loading oldest logs in ascending and descending order

* Infinite scroll: use scroll to top from logs navigation

* Logs: make logs container smaller

* Logs: make container smaller

* State: integrate explore's loading states

* Infinite scroll: add loading to effect dependency array

* Infinite scroll: display message when scroll limit is reached

* Infinite scroll: add support to scroll in both directions

* Infinite scroll: capture wheel events for top scroll

* scrollableLogsContainer: deprecate in favor of logsInfiniteScrolling

* Infinite scroll: implement timerange limits

* Infinite scroll: pass timezone

* Fix unused variables and imports

* Infinite scroll: implement timerange limits for absolute time

* Infinite scroll: fix timerange limits for absolute and relative times

* Infinite scroll: reset out-of-bounds message

* Logs: make container taller

* Line limit: use "displayed" instead of "returned" for infinite scrolling

* Infinite scrolling: disable behavior when there is no scroll

* Remove console log

* Infinite scroll: hide limit reached message when using relative time

* Logs: migrate styles to object notation

* Prettier formatting

* LogsModel: fix import order

* Update betterer.results

* Logs: remove exploreScrollableLogsContainer test

* Infinite scroll: display loader

* Infinite scroll: improve wheel handling

* Explore: unify correlations code

* Explore: move new function to helpers

* Remove comment

* Fix imports

* Formatting

* Query: add missing awaits in unit test

* Logs model: add unit test

* Combine frames: move code to feature/logs

* Explore: move getCorrelations call back to query

It was causing a weird test failure

* Fix imports

* Infinite scroll: parametrize scrolling threshold

* Logs: fix overflow css

* Infinite scroll: add basic unit test

* Infinite scroll: add unit test for absolute time ranges

* Formatting

* Explore query: add custom interaction for scrolling

* Query: move correlations before update time

* Fix import in test

* Update comment

* Remove comment

* Remove comment

* Infinite scroll: report interactions from component

* Fix import order

* Rename action

* Infinite scroll: update limit reached message

* Explore logs: remove type assertion

* Update betterer
2024-01-12 13:22:03 +02:00
Ivan Ortega Alba
e9f1b41d23
EditVariable: Add base form to edit variables (#80172) 2024-01-12 12:01:11 +02:00
Dominik Prokop
cd66149c65
DashboardScene: Handle Dashboard data source when editing panel (#79991)
* Dashboard model compat wrapper update

* Handle changing data source type to and from Dashboard data source

* VizPanelManager tests

* Betterer

* DashboardModelCompatibilityWrapper tests

* Review: test updates

* Test updates

* Test fix

* Move the complexity of the dashboard data source edit directly to the ShareQueryDataProvider

* Make sure deactivation handler ain't called multiple times

* Make sure compat panel compat wrapper return queries for shared runner with transformations

* Betterer

* VizPanelManager: Remove data object subscription

* Remove unnecesary code
2024-01-12 01:21:32 -08:00
Leon Sorokin
b53e0521d2
Panels: AnnotationsPlugin2 (#79531)
Co-authored-by: Adela Almasan <adela.almasan@grafana.com>
2024-01-12 09:02:40 +02:00
Sonia Aguilar
e1af9bcecc
Alerting: Fix group filter (#80358)
* Fix group filter

* Fix Warning: Receivedfor a non-boolean attribute

* remove defaultQueryString.length > 3 from the logic to check if input is invalid
2024-01-11 17:28:12 +02:00
Jamin
71b98163e5
Frontend: Migrate DataSourceHttpSettings.tsx from aria-label e2e selectors to data-testid (#79615) 2024-01-10 11:51:16 +00:00
Ashley Harrison
1162c28a55
Connections: hook up search to url params to match cloud behaviour (#80166)
hook up connections search to url params to match cloud behaviour
2024-01-10 09:57:17 +00:00
Ashley Harrison
68ba6cc67b
Chore: some type fixes (#80094)
* some type fixes

* few more fixes

* more

* fix unit test
2024-01-09 10:00:00 +00:00
Tobias Skarhed
fbd0ceec7c
Chore: Remove gf-form in Permissions (#79908)
* Remove empty table in favor of Alert

* Change to using Box and Text
2024-01-05 14:32:01 +01:00
Adela Almasan
935ecdd809
XYChart: Improved new tooltip (#75818)
Co-authored-by: Ihor Yeromin <yeryomin.igor@gmail.com>
Co-authored-by: Leon Sorokin <leeoniya@gmail.com>
2024-01-05 00:55:23 +02:00
Yuri Tseretyan
f6a46744a6
Alerting: Support hysteresis command expression (#75189)
Backend: 

* Update the Grafana Alerting engine to provide feedback to HysteresisCommand. The feedback information is stored in state.Manager as a fingerprint of each state. The fingerprint is persisted to the database. Only fingerprints that belong to Pending and Alerting states are considered as "loaded" and provided back to the command.
   - add ResultFingerprint to state.State. It's different from other fingerprints we store in the state because it is calculated from the result labels.
  -  add rule_fingerprint column to alert_instance
   - update alerting evaluator to accept AlertingResultsReader via context, and update scheduler to provide it.
   - add AlertingResultsFromRuleState that implements the new interface in eval package
   - update getExprRequest to patch the hysteresis command.

* Only one "Recovery Threshold" query is allowed to be used in the alert rule and it must be the Condition.


Frontend:

* Add hysteresis option to Threshold in UI. It's called "Recovery Threshold"
* Add test for getUnloadEvaluatorTypeFromCondition
* Hide hysteresis in panel expressions

* Refactor isInvalid and add test for it
* Remove unnecesary React.memo
* Add tests for updateEvaluatorConditions

---------

Co-authored-by: Sonia Aguilar <soniaaguilarpeiron@gmail.com>
2024-01-04 11:47:13 -05:00
Alex Khomenko
0844b87b2f
PluginDetails: Fix usage list height (#79695) 2024-01-04 15:42:28 +02:00
Jamin
576b8ccff6
Frontend: Migrate PageToolbar.tsx from aria-label e2e selectors to data-testid (#79663)
* refactor: update PageToolbar to use data-testid

* refactor: update selector text

---------

Co-authored-by: joshhunt <josh@trtr.co>
2024-01-04 13:52:38 +02:00
Ashley Harrison
54369158ce
Betterer: update results file (#79979)
update results file
2024-01-03 13:21:36 +00:00
Tobias Skarhed
65a655cfc9
Chore: Remove gf-form in DashboardLinks (#79762) 2024-01-03 13:30:17 +01:00
Adela Almasan
070e41d136
Exemplars: Update UX to match new tooltips (#79916) 2024-01-03 06:27:34 -06:00
Leon Sorokin
fb79be4a43
Transformations: Add frame source picker to allow transforming annotations (#77842)
Co-authored-by: Ryan McKinley <ryantxu@gmail.com>
2024-01-02 23:33:31 -06:00
Ihor Yeromin
a05f266e27
Units: Add scalable unit option (#79411)
* fix(units): add scalable unit option

---------

Co-authored-by: nmarrs <nathanielmarrs@gmail.com>
2024-01-02 18:40:57 +01:00
Khushi Jain
fe757f69c5
Forms: Remove gf-form from opentsdb/components (#79830)
* Forms: Remove gf-form from opentsdb/components

* filter and tag

* rate

* Update public/app/plugins/datasource/opentsdb/components/DownSample.tsx

Co-authored-by: Alex Khomenko <Clarity-89@users.noreply.github.com>

* Update public/app/plugins/datasource/opentsdb/components/FilterSection.tsx

Co-authored-by: Alex Khomenko <Clarity-89@users.noreply.github.com>

* Update public/app/plugins/datasource/opentsdb/components/MetricSection.tsx

Co-authored-by: Alex Khomenko <Clarity-89@users.noreply.github.com>

* Update public/app/plugins/datasource/opentsdb/components/RateSection.tsx

Co-authored-by: Alex Khomenko <Clarity-89@users.noreply.github.com>

* Update public/app/plugins/datasource/opentsdb/components/TagSection.tsx

Co-authored-by: Alex Khomenko <Clarity-89@users.noreply.github.com>

* prettier

* more changes

---------

Co-authored-by: Alex Khomenko <Clarity-89@users.noreply.github.com>
2024-01-02 16:06:23 +02:00
Gilles De Mey
e5227550c4
Alerting: Detail view v2 (#77795) 2024-01-02 10:05:58 +01:00
Ryan McKinley
ae3156d727
XYChart: Config cleanup and refactoring (#79915)
* xy config cleanup

* more cleanup

* clean up betterer some

---------

Co-authored-by: nmarrs <nathanielmarrs@gmail.com>
2023-12-31 16:50:53 -08:00
Tobias Skarhed
99582b48d7
Chore: Remove gf-form usage in grafana datasource (#79640) 2023-12-29 13:37:44 +01:00
Brendan O'Handley
a9f4ffab5d
Prometheus: Migrate from aria-label to data-testid for selectors (#78554)
* migrate from aria-label to data-testid for selectors

* fix e2e tests with shared components

* fix e2e tests with more shared components

* pass data-testid to SelectBase component

* pass data-testid to value container and traverse the dom to access the input in e2e
2023-12-26 13:43:06 -06:00
Jamin
f41a0559fa
Frontend: Migrate NewsContainer.tsx from aria-label e2e selectors to data-testid (#79666) 2023-12-26 15:06:33 +00:00
Alex Khomenko
fde8a00721
SSO: Add GitHub auth configuration page (#78933)
* Setup route

* Set up the page

* Add orgs

* Load settings

* Make API call

* Remove log

* Add FormPrompt

* Update types

* Add tests

* Fix tests

* Cleanup

* Load settings

* Fix naming

* Switch to PUT endpoint

* Switch to CSS object

* Setup fields

* Render fields

* Extend types

* Dynamic provider page

* Rename page

* Filter out non-implemented providers

* Fix types

* Add teamIDs validation

* Update tests

* Fix URL

* Update name

* Send full data

* Add password input

* Update test

* Expand default values

* Fix test

* Use SecretInput

* Remove dev mode for the feature toggle

* Convert fields

* Remove fieldFormat utils

* Update fields logic

* Update tests

* Update betterer

* SSO: Make client secret not required

* Update field name

* Revert feature toggle to dev mode

* Use provider endpoint

* Fix form state check

* Update tests

* Fix URL redirect after form submit

* Mock locationService

* Separate Form component

* Fix trailing slash
2023-12-21 15:26:42 +02:00
Jamin
38f176edfb
Frontend: Migrate SubMenu.tsx: from aria-label e2e selectors to data-testid (#79662) 2023-12-21 11:52:57 +00:00
Dominik Prokop
73eab8fcd6
DashboardScene: Data source and query options edit for a panel (#79267)
* Scenes bump

* Refactor query group components so that they are reusable

* Basic queries rendering and datasource change

* Store last used ds in local storage

* maxDataPoints and minInterval queries options

* Progress on query options

* Query options tests

* Allow panel inspection / queries inspection from panel edit

* Add counters to data pane tabs

* Betterer update

* Handle data source changes

* Minor fixes

* Data source change tests

* Handle scenario of data source change when transformations are in place

* Review comment

* Fix test
2023-12-19 05:51:19 -08:00
Khushi Jain
54dc5846c2
Chore: Refactor dataviz aria-label e2e selectors to data-testid (#78938)
Co-authored-by: nmarrs <nathanielmarrs@gmail.com>
2023-12-17 02:10:04 +02:00
Khushi Jain
dba690d653
Chore: Removes gf-form from profile/user (#79552)
* Chore: Removes gf-form from profile/user

* message

* better
2023-12-16 09:46:54 +02:00
ismail simsek
2edcf0edbd
InfluxDB: Use database input for SQL configuration instead of metadata (#79579)
* introduce constants file

* update frontend to use database field

* use dbName field instead of metadata

* use secureGrpc

* betterer
2023-12-15 18:41:32 +01:00
Ivana Huckova
f8a1e7d500
Loki: Decouple from Prometheus parsingUtils (#79460)
Loki: Remove dependency on parsingUtils
2023-12-15 17:15:20 +01:00
Joey
8a6ea4bfad
Tempo: Fix graph dragging (#79508)
* Fix graph dragging

* Add comment
2023-12-15 10:43:35 +00:00
Tobias Skarhed
8d529bc4cb
Betterer: Add our own regexp matcher (#79448)
* Add betterer rule for gf-form

* Betterer: Write generic regexp matcher

* Add space

* Update lockfile

* Update comments

* Add comment with notice
2023-12-15 12:12:56 +02:00
Tobias Skarhed
79fca7dce4
Chore: Remove gf-form and change to CSS object in Graphite function editor (#79446)
Chore: remove gf-form and add CSS fumction object
2023-12-15 11:29:34 +02:00
Khushi Jain
d1db163bb5
Chore: Removes gf-form from admin/user_ (#79502)
* userProfile

* userpermis

* usersession

* useradmin
2023-12-15 08:06:51 +02:00
Ashley Harrison
a221ebf7cc
Revert "Betterer: Add rule for gf-form (#79303)" (#79445)
This reverts commit 7a38a5ab1d.
2023-12-13 12:26:17 +01:00
Tobias Skarhed
7a38a5ab1d
Betterer: Add rule for gf-form (#79303)
Add betterer rule for gf-form
2023-12-13 11:35:57 +01:00