Commit Graph

11 Commits

Author SHA1 Message Date
lpugoy
c792af3ad0
grafana-mixin: Fix expression for GrafanaRequestsFailing alert (#63382)
Fix expression for GrafanaRequestsFailing alert

The intent of the alert is to get the ratio of 5xx to all status codes
[^1]. With the original expression, the left hand side can have more than
one row with the same labels except for the status code. This results in
a promql error because it is doing a many-to-one matching. Doing a sum
on the left hand side first should preserve the intent of the alert and
resolve the issue.

[^1]: https://github.com/grafana/grafana/pull/43116
2023-05-04 14:35:36 +02:00
Carlos Juan Gómez Peñalver
984e293d60
many-to-one requires explicit grouping (#58174)
The current query results in a many-to-one relationship which requires explicit grouping see more details here
https://github.com/portefaix/portefaix-hub/pull/306

https://prometheus.io/docs/prometheus/latest/querying/operators/#many-to-one-and-one-to-many-vector-matches
2023-02-21 11:00:48 +01:00
Pedro Araújo
18fdb89554
grafana-mixin: Fix GrafanaRequestsFailing alert (#43116)
Due to PromQL's label matching, both sides of the division will have same series; that means that, whenever there's a 5xx error, both sides will have the same value and the division will be `1`. I believe the idea was to get the ratio of 5xx compared will all status code, and to do that, we need to aggregate the `status_code` dimension away.
2021-12-20 15:12:37 +01:00
idafurjes
e20766146a
Upgrade build-container to version 1.4.8 (#42373)
* Upgrade build-container to version 1.4.8

* disable lint of mixin

Co-authored-by: Ying WANG <ying.wang@grafana.com>
2021-11-29 12:03:16 +01:00
Carl Bergquist
075256923b
Update the grafana-mixin to use HTTP histograms (#39155)
Signed-off-by: bergquist <carl.bergquist@gmail.com>
2021-10-06 14:15:12 +02:00
Richard Hartmann
483f79ff16
Chore: Add newline at EOF (#36595)
Signed-off-by: Richard Hartmann <richih@richih.org>
2021-07-09 08:21:59 -07:00
Carl Bergquist
cf6512abd9
reduce severity level to warning (#28939)
Signed-off-by: bergquist <carl.bergquist@gmail.com>
2020-11-20 10:30:51 +01:00
Torkel Ödegaard
9f5bdce25c
IssueTriage: Needs more info automation and messages (#28137)
* IssueTriage: Needs more info automation and messages

* Updated

* Updated

* Updated wording
2020-10-16 16:49:55 +02:00
Carl Bergquist
9c256982e5
should only ignore the file in the grafana mixin root folder (#28306)
Signed-off-by: bergquist <carl.bergquist@gmail.com>
2020-10-16 10:26:56 +02:00
Arve Knudsen
847dc0bec7
Drone: Fix grafana-mixin linting (#28308)
* Drone: Fix Starlark script

Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>

* grafana-mixin: Move build logic to scripts

Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>

* Drone: Use mixin scripts

Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>

* CI build image: Install jsonnetfmt and mixtool

Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>

* Makefile: Print commands

Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
2020-10-16 09:46:26 +02:00
Carl Bergquist
6002df580f
Add monitoring mixing for Grafana (#28285)
Co-authored-by: Tom Wilkie <tom.wilkie@gmail.com>
2020-10-15 17:05:56 +02:00