Commit Graph

11 Commits

Author SHA1 Message Date
Marcus Efraimsson
80a170e62f add some mock/stub guidelines to testing guideline (#16466) 2019-04-09 14:34:34 +02:00
Oleg Gaidarenko
04b3afcd15
Chore: Implement revive (#16200)
Since we do not like some of the default golint rules,
this commit proposes to use https://github.com/mgechev/revive.

And potential revive speed-up should't hurt :).

Right now, presented config (./conf/revive.toml) is permissive,
we might improve it over time however. Fixes for found revive
issues in the code are very limited so it wouldn't be large to review.

Also in this commit:

* Add annotations for makefile commands and declare phony targets

* Rename "gometalinter" script and CI command to "lint"
  since we are doing there a bit more then using gometalinter package

* Add Makefile rules to .editorconfig

* Documentation which mentioned "golint" replaced with revive

Fixes #16109
Ref #16160
2019-03-27 17:53:49 +01:00
Carl Bergquist
d9db457b87
Merge pull request #16033 from bergquist/backend_codestyle
Adds backend code style guide
2019-03-19 08:16:36 +01:00
Leonard Gram
6673915f2e
Update style_guides/backend.md
Co-Authored-By: bergquist <carl@grafana.com>
2019-03-19 08:16:19 +01:00
Hugo Häggmark
ed1b001904 docs: renamed file and added redux framework file 2019-03-18 06:39:34 -07:00
Hugo Häggmark
f251345b68 docs: moved examples to frontend.md 2019-03-18 06:39:34 -07:00
Hugo Häggmark
f3b9ce317e docs: intial draft for frontend review doc 2019-03-18 06:39:34 -07:00
bergquist
98911e0708 adds backend code style guide 2019-03-15 20:19:24 +01:00
Torkel Ödegaard
590450291a
Update frontend.md 2019-03-05 09:23:04 +01:00
Torkel Ödegaard
707d0e13bd
Update frontend.md 2019-03-05 09:22:26 +01:00
Torkel Ödegaard
0c16d3cd6a Moved history component, added start draft of frontend code style guide 2019-01-23 11:37:46 +01:00