Commit Graph

8851 Commits

Author SHA1 Message Date
Juan Cabanas
e88e50efe4 ShareModal: Responsive tabs and Public Dashboards modal fixed (#66805) 2023-04-28 13:37:11 -03:00
Oscar Kilhed
836fef6785 DataSourcePicker: keyboard navigatable list hook and implementation in the new data source picker dropdown (#67370)
Co-authored-by: Ivan Ortega <ivanortegaalba@gmail.com>
2023-04-28 18:19:31 +02:00
Tobias Skarhed
166641d66d NestedFolders: Permission for creating and editing (#67406)
* Initial permissions

* Show/hide checkboxes

* Fix kinds from main

* CreateNewButton tests

* Update DashboardsTree test

* Mock folder permissions

* Rename showCheckBoxes to canSelect

* Make column ordering look better
2023-04-28 18:00:56 +02:00
Virginia Cepeda
7338164612 Alerting: Add alert instance picker (#67138)
* Add Preview template and payload editor to templates form

* Add TemplatePreview test and update css

* Preview errors for each template that is wrong

* Enable preview templating only for Grafana Alert Manager

* Use harcoded default payload instead of requesting it to the backend

* Update error response in the api definition

* Add spinner when loading result for preview

* Update api request followind DD changes

* Use pre instead of TextArea to render the preview

* Fix tests

* Add alert list editor

* Add start and end time for alert generator

* Add preview for data list added in the modal

* Update copies and move submit button in alert generator to the bottom

* Copy updates

* Refactor

* Use tab instead of button to preview

* Move payload editor next to the content

* Copy update

* Refactor

* Adress PR review comments

* Fix wrong json format throwing an exception when adding more data

* Use monaco editor for payload

* Only show text 'Preview for...'  when we have more than one define

* Fix some errors

* Update CollapseSection style

* Add tooltip for the Payload info icon explaining the available list of alert data fields in preview

* Set payload as invalid if it's not an array

* Fix test

* Update text in AlertTemplateDataTable

* Add separators to distinguish lines that belong to the preview

* Use harcoded default payload instead of requesting it to the backend

* Add alert instance picker

* Add rule search capability and cleanup

* Display alert instance extra information on hover

* Rebase and integrate with existing view

* Display folder under rule name

* Display unique labels for alert instances

* Remove unneeded interface

* Reset state after closing the modal

* Refactor useEffect and useMemo

* Move common code to variable

* Refactor to avoid setting filtered rules as state

* Disable instance selector button when there are errors in the payload

* Validate payload on button click

* Change warning text

* Add support for state filters in alertmanager alerts request

* Use RTK Query to fetch alert instances

* Address review comments

* Fix lint

---------

Co-authored-by: Sonia Aguilar <soniaaguilarpeiron@gmail.com>
2023-04-28 12:58:15 -03:00
Joey
7448427739 Tracing: Feedback button (#67398)
* Feedback button

* Hide button

* Make gen-cue
2023-04-28 16:27:07 +01:00
Sonia Aguilar
3854be1fcb Alerting: Implement template preview for Grafana AlertManager (#65530)
* Add Preview template and payload editor to templates form

* Add TemplatePreview test and update css

* Preview errors for each template that is wrong

* Enable preview templating only for Grafana Alert Manager

* Use harcoded default payload instead of requesting it to the backend

* Update error response in the api definition

* Add spinner when loading result for preview

* Update api request followind DD changes

* Use pre instead of TextArea to render the preview

* Fix tests

* Add alert list editor

* Add start and end time for alert generator

* Add preview for data list added in the modal

* Update copies and move submit button in alert generator to the bottom

* Copy updates

* Refactor

* Use tab instead of button to preview

* Move payload editor next to the content

* Copy update

* Refactor

* Adress PR review comments

* Fix wrong json format throwing an exception when adding more data

* Use monaco editor for payload

* Only show text 'Preview for...'  when we have more than one define

* Fix some errors

* Update CollapseSection style

* Add tooltip for the Payload info icon explaining the available list of alert data fields in preview

* Set payload as invalid if it's not an array

* Fix test

* Update text in AlertTemplateDataTable

* Add separators to distinguish lines that belong to the preview

* Fix text

* Use subDays instead of addDays for substracting days
2023-04-28 17:05:45 +02:00
Giordano Ricci
b5a2c3c7f5 Query History: Remove migration (#67470) 2023-04-28 16:03:51 +01:00
Andre Pereira
ffd83a027d Trace View: Export trace button (#67368)
* Add export button to trace view

* Support zipkin, jaeger and otlp formats
2023-04-28 15:34:14 +01:00
Kuba Siemiatkowski
f8faacd54a Datasource: Overhaul plugin error handling and action buttons (#67014)
* - initial work on data source config page

* - add links to test status box
- add tracking function

* - add test for the DataSourceConfigAlert component

* - fix flicker of the alert box

* - fix the build

* - small improvements

* - fix failing build

* - fix failing unit tests

* - prettier and betterer fixes

* - fix failing e2e tests

* - fix build again

* - rewrite solution according to the PR comments

* - cleanup

* - fix failing e2e

* - use absolute path in link

* Minor fixes

---------

Co-authored-by: Torkel Ödegaard <torkel@grafana.com>
2023-04-28 15:57:17 +02:00
Ivan Ortega Alba
8b6160bc66 Fix: Advanced DS picker search is case sensitive (#67420) 2023-04-28 10:38:14 +00:00
Alexa V
b4a7427f31 [Chore] Refactor Panel Menu Rudderstack events and add missing instrumentation (#66850) 2023-04-28 12:19:39 +02:00
Alexander Zobnin
a1b9eb1eea Authentication UI: Hide empty settings section (#67407) 2023-04-28 08:58:01 +02:00
Kyle Cunningham
1fbac96bd4 SQL Datasources: Update behavior of default connection limits (#66687)
* Update behavior of defaults in connection limits

* Refactor to use config object instead

* Refactor remove unneeded function

---------

Co-authored-by: Zoltán Bedi <zoltan.bedi@gmail.com>
2023-04-28 13:23:08 +07:00
Torkel Ödegaard
43def489f4 PageNotFound: G10 Redesign (#66909)
* PageNotFound: G10 Redesign

* Make into a reusable component so we can have a more specific version for dashboards

* Make graphic abit smaller
2023-04-28 08:18:14 +02:00
Ryan McKinley
f5d97c677b TimeSeries: Explicitly add transformer when timeseries-long exists (#64092) 2023-04-28 06:10:02 +03:00
Ryan McKinley
ca1f79b9ba Kindsys: Target k8s style resource definitions (#67008)
Co-authored-by: sam boyer <sdboyer@grafana.com>
2023-04-27 23:32:38 +03:00
Ryan McKinley
8352e716dd ArrayDataFrame: Convert to a simple utility function rather than dynamically loaded values (#67427) 2023-04-27 12:38:19 -07:00
Juan Cabanas
fc3737bf4f PublicDashboards: Email sharing users page (#67124) 2023-04-27 14:20:03 -03:00
Ivan Ortega Alba
4d96afa979 Check add DS permissions in advanced DS picker (#67237) 2023-04-27 16:51:31 +02:00
Gilles De Mey
b94fceddad Alerting: Make Loki & Prometheus instant vector by default (#66797)
Co-authored-by: Konrad Lalik <konrad.lalik@grafana.com>
2023-04-27 17:38:22 +03:00
Ashley Harrison
4b241311b3 Nested folders: very naive implementations of move/delete (#67309)
* implement naive delete

* implement naive move

* use params object instead of appending to url
2023-04-27 15:10:34 +01:00
Joey
886b91eca5 Tracing: Next/prev text for span filters (#67208)
* Next/prev text

* Tests

* Update test

* Updated state vars and also made other improvements
2023-04-27 13:28:19 +01:00
Ivana Huckova
3a8bb226bd Logs: Use millisecond precision for open context in split view (#67385)
Log: Use millisecond precision for open context in split view
2023-04-27 14:09:20 +02:00
Khushi Jain
2306fb38dc Search: Preserves search filters when navigating to another page (#67021) 2023-04-27 13:12:51 +02:00
Tobias Skarhed
4b047b62a7 NestedFolders: Button for creating new dashboards and and folders (#67260)
* Add CreateNewButton and tests

* Add translation support

* Move reused phrases to temp common file

* Use just a simple button

---------

Co-authored-by: joshhunt <josh@trtr.co>
2023-04-27 11:43:20 +01:00
kay delaney
2dc5872bd6 New Dashboard: Fix "build a dashboard" when empty dash page feature is enabled (#66816)
* New Dashboard: Fix "build a dashboard" when used with empty dash page feature

Closes #66659
2023-04-27 11:11:19 +01:00
Josh Hunt
334ecd1be7 NestedFolders: Select all for Browse and Search (#67227)
* NestedFolders: Select all for BrowseView and SearchView

* show fake indeterminate state for SearchView

* fix types

* Select search results as additional pages are loaded

* fix (de)select all between browse and search

* tests

* fix test

* fix test
2023-04-27 12:29:26 +03:00
Joey
d949aa778b Traces: Only show filtered spans (#66986)
* Only show filtered spans

* Add & update tests
2023-04-27 08:19:58 +01:00
Levente Balogh
61e3bbb858 React Router: start migrating to v6 (#66921)
Chore: add the react-router-compat package
2023-04-27 07:18:38 +02:00
Andre Pereira
fb45cb6237 Explore: Update table min height (#67321)
* Set table min content height to 300px

* Cleanup code that changes height of table component
2023-04-26 22:21:29 +01:00
Josh Hunt
9796b6b000 NestedFolders: Connect Search input fields to state manager (#67193)
* NestedFolders: Connect Search input fields to state manager

* Fix tag list not loading

* Clear includePanels checkbox when leaving search

* fix test

* Fix extra right margin

* fix missing style

* cleanup

* fix placeholder

* fix test
2023-04-26 15:42:25 +01:00
Juan Cabanas
4b3aead2d0 DataLinks: encoded URL fixed (#66418) 2023-04-26 10:46:21 -03:00
Ivan Ortega Alba
a576bd4f26 DataSourcePicker: Tweak styles (#67280) 2023-04-26 15:07:51 +02:00
Juan Cabanas
47aa8c7654 PublicDashboards: HoverWidget in panel fix (#66685)
Hover widget modified for public dashboards.
2023-04-26 09:06:38 -03:00
Dominik Prokop
a62cb96089 QueryGroup: Fix infinite loop in edit mode (#67273) 2023-04-26 04:41:31 -07:00
Oscar Kilhed
a4f1206811 DataSourcePicker: Fix datasource picker input not clearing on close (#67248)
Fix datasource picker input not clearing on close
2023-04-26 12:27:32 +02:00
Ashley Harrison
258f11f08d Nested folders: deduplicate selection of children (#67229)
* scaffold out dedupe logic, use mock api to get descendant info

* rename methods

* use for..of

* some renaming for clarity
2023-04-26 11:20:10 +01:00
Konrad Lalik
c41c638b52 Alerting: Fix silences preview (#66000)
* Use alertmanager /alerts endpoint to show preview of instances affected by silence

* Fix debounce dependency, add no instances warning

* Rename silences preview component

* Fix the preview file name, use IsNulLDate to check the date

* Fix valid matchers condition

* Cleanup

* Remove unused code
2023-04-26 10:27:37 +02:00
Oscar Kilhed
044d7f61c7 DataSourcePicker: fix flickering datasource dropdown (#67206)
* fix flickering

* refactor onClose/onOpen

* do not set value of input, make the placeholder look like the value instead

* Show search icon when the dropdown is open

---------

Co-authored-by: Ivan Ortega <ivanortegaalba@gmail.com>
2023-04-26 10:08:32 +03:00
Torkel Ödegaard
926abcf6aa Scenes: Update scenes to v6 (#67110)
* Scenes: Update scenes to v6

* Fix test
2023-04-26 07:03:44 +02:00
Ivan Ortega Alba
581cc85ba5 Add analytics to new DS picker and onboarding experience (#67060)
* Add analytics to ds picker advanced mode

* Add analytics to ds picker dropdown
2023-04-25 21:07:16 +02:00
Adela Almasan
12e5101b91 Canvas: Connection properties based on data (#64360)
Co-authored-by: nmarrs <nathanielmarrs@gmail.com>
2023-04-25 10:31:45 -07:00
Alexa V
2a67b8ad32 Panel Header Fix: Implement new Panel Header on Angular Panels (#66826)
Co-authored-by: Dominik Prokop <dominik.prokop@grafana.com>
2023-04-25 18:16:46 +02:00
Ashley Harrison
e6e741546f Nested folders: Create basic Move/Delete modals (#67140)
* add modal scaffolding

* add some unit tests

* remove dummy api, add some TODO comments

* small test refactor

* another small test refactor

* fix unit tests due to aria-label/data-testid change
2023-04-25 17:08:40 +01:00
Polina Boneva
fe23c76250 Dashboard: New panel in a dashboard is not deleted after "Discard"-ing changes in Panel Edit (#66476)
* add isNew notPersistedProperty to PanelModel

* if panel is newly created and user "Discard"s it, the panel is removed entirely

* add Todo's for when we remove the emptyDashboardPage FF

* add isNew to new panel after file dropping on dashboard page

* handle the "Apply" case

* CSV file dropping is not relevant to a new panel bc it doesnt open edit page
2023-04-25 17:18:58 +03:00
Polina Boneva
2f1a08511a [Chore] Dashboard: Update analytic events for new panel/row/import/pasted panel (#67205)
update analytic events for new panel/row/import/pasted panel
2023-04-25 17:06:54 +03:00
Torkel Ödegaard
de18ed6659 PanelContext: Add functionality to update data from panel (#66993) 2023-04-25 14:55:50 +02:00
Sonia Aguilar
64ee42d01e Alerting: Add limits and move state and label matching filters to the BE (#66267)
* WIP

* Add instance totals to combined rule. Use totals to display instances stats in the UI

* WIP

* add global summaries, fix TS errors

* fix useCombined test

* fix test

* use activeAt from rule when available

* Fix NaN in global stats

* Add no data total to global summary

* Add totals recalculation for filtered rules

* Fix instances totals, remove instances filtering from alert list view

* Update tests

* Fetch alerts considering filtering label matchers

* WIP - Fetch alerts appending state filter to endpoint

* Fix multiple values for state in request being applyied

* fix test

* Calculate hidden by for grafana managed alerts

* Use INSTANCES_DISPLAY_LIMIT constant for limiting alert instances instead of 1

* Rename matchers parameter according to API changes

* Fix calculating total number of grafana instances

* Rename matcher prop after previous change

* Display button to remove max instances limit

* Change matcher query param to be an array of strings

* Add test for paramsWithMatcherAndState method

* Refactor matcher to be an string array to be consistent with state

* Use matcher query string as matcher object type (encoded JSON)

* Avoind encoding matcher parameters twice

* fix tests

* Enable toggle for the limit/show all button and restore limit and filters when we come back from custom view

* Move getMatcherListFromString method to utils/alertmanager.ts

* Fix limit toggle button being shown when it's not necessary

* Use filteredTotals from be response to calculate hidden by count

* Fix variables not being replaced correctly

* Fix total shown to be all the instances filtered without limits

* Adress some PR review comments

* Move paramsWithMatcherAndState inside prometheusUrlBuilder method

---------

Co-authored-by: Gilles De Mey <gilles.de.mey@gmail.com>
Co-authored-by: Konrad Lalik <konrad.lalik@grafana.com>
Co-authored-by: Virginia Cepeda <virginia.cepeda@grafana.com>
2023-04-25 11:19:20 +02:00
Ivan Ortega Alba
44035ecbb2 Advanced DS Picker open Connections page when toggle is enabled (#67139) 2023-04-25 10:42:04 +02:00
Ivan Ortega Alba
4d474e8e4f Fix icon size for data source picker list item (#67144) 2023-04-25 10:41:31 +02:00