Commit Graph

120 Commits

Author SHA1 Message Date
Ashley Harrison
be65aaf5dc Chore: Clean up some more old SCSS (#89404)
* remove/migrate normalize.scss

* fix typo

* migrate _add_data_source styles

* migrate panel-header styles

* migrate slate styles to emotion globals

* put back a couple of classes used by external plugins
2024-06-21 10:03:57 +01:00
Ashley Harrison
13d00e09ab Chore: Migrate some more SCSS to emotion (#89038)
* migrate section-heading

* move fonts to global styles

* migrate code styles to emotion globals

* migrate spacings styles and leave some in angular

* padding should be 2 here not 1
2024-06-12 14:46:20 +01:00
Yulia Shanyrova
80bdfbe2eb Plugins: Fix Explore button visibility for datasource plugins (#88614)
Use hasAccessToExplore method at datasource list
2024-06-10 14:27:17 +02:00
Marcus Andersson
804c726413 PluginExtensions: Make the extensions registry reactive (#83085)
* feat: add a reactive extension registry

Co-authored-by: Marcus Andersson <marcus.andersson@grafana.com>

* feat: add hooks to work with the reactive registry

Co-authored-by: Marcus Andersson <marcus.andersson@grafana.com>

* feat: start using the reactive registry

Co-authored-by: Marcus Andersson <marcus.andersson@grafana.com>

* feat: update the "command palette" extension point to use the hook

* feat: update the "alerting" extension point to use the hooks

Co-authored-by: Marcus Andersson <marcus.andersson@grafana.com>

* feat: update the "explore" extension point to use the hooks

Co-authored-by: Marcus Andersson <marcus.andersson@grafana.com>

* feat: update the "datasources config" extension point to use the hooks

Co-authored-by: Marcus Andersson <marcus.andersson@grafana.com>

* feat: update the "panel menu" extension point to use the hooks

Co-authored-by: Marcus Andersson <marcus.andersson@grafana.com>

* feat: update the "pyroscope datasource" extension point to use the hooks

Co-authored-by: Marcus Andersson <marcus.andersson@grafana.com>

* feat: update the "user profile page" extension point to use the hooks

* chore: update betterer

* fix: update the hooks to not re-render unnecessarily

* chore: remove the old `createPluginExtensionRegistry` impementation

* chore: add "TODO" for `PanelMenuBehaviour` extension point

* feat: update the return value of the hooks to contain a `{ isLoading }` param

* tests: add more tests for the usePluginExtensions() hook

* fix: exclude the cloud-home-app from being non-awaited

* refactor: use uuidv4() for random ID generation (for the registry object)

* fix: linting issue

* feat: use the hooks for the new alerting extension point

* feat: use `useMemo()` for `AlertInstanceAction` extension point context

---------

Co-authored-by: Levente Balogh <balogh.levente.hu@gmail.com>
2024-04-24 09:33:16 +02:00
Ashley Harrison
fc45b56d9d EmptyState: Apply call-to-action variant in core (#86448)
* apply empty state in a bunch of places

* fix unit tests

* put alert back on top

* add data-testids so e2e tests keep working

* remove info boxes

* fix annotations empty state alignment with new maxWidth
2024-04-22 17:01:24 +01:00
TechVest
1ffe858e06 chore: remove repetitive words (#86412)
Signed-off-by: TechVest <techdashen@qq.com>
2024-04-17 13:08:00 +01:00
Josh Hunt
b5337ba419 I18N: Fix untranslated descriptions in data source picker (#86216)
I18n: Remove t() call from root module scope
2024-04-16 10:28:24 +01:00
Ashley Harrison
40c148ba48 EmptyState: Provide custom messages for existing empty states (#86021)
provide custom messages for existing empty states
2024-04-12 11:08:14 +02:00
Ashley Harrison
3c69de6be5 Chore: removing some type assertions (#85839)
* fix some type assertions in loops

* some more cleanup

* some alerting fixes

* put comments in correct place to ignore rule

* couple more

* undo SilencesFilter changes
2024-04-10 14:54:31 +01:00
Ashley Harrison
7ad2ec9665 EmptyState: use not-found empty state variant everywhere in core (#85007)
* use EmptyState component everywhere in core

* remove GrotNotFound core component

* update unit tests

* search -> not-found

* fix 3 more
2024-03-27 12:15:12 +00:00
Erik Sundell
28ecd83987 Datasources: Add fixed width to name field in config editor (#84970)
add fixed width to name field
2024-03-26 10:13:09 +01:00
Levente Balogh
155e38edfe Plugin Extensions: Add prop types to component extensions (#84295)
* feat: make it possible to specify prop types for component extensions

* Update packages/grafana-runtime/src/services/pluginExtensions/getPluginExtensions.ts

* chore: adapted test case

* chore: update betterer

* feat: update types for configureComponentExtension()

* fix: remove type specifics for `configureExtensionComponent`

* Update betterer config

---------

Co-authored-by: Darren Janeczek <38694490+darrenjaneczek@users.noreply.github.com>
Co-authored-by: Darren Janeczek <darren.janeczek@grafana.com>
2024-03-18 15:14:51 +02:00
Timur Olzhabayev
6bc662e53b Chore: Removing error object from tracking (#84500)
Removing error object from tracking
2024-03-14 19:15:36 +02:00
Ashley Harrison
691115da7a Chore: replace react-popper with @floating-ui/react in DataSourcePicker (#82528)
* replace react-popper with floating-ui in DataSourcePicker

* don't need {force:true}
2024-02-16 09:40:16 +00:00
Sergej-Vlasov
3605d85c4c Dashboards: Remove advancedDataSourcePicker feature toggle (#81790)
* remove advancedDataSourcePicker feature toggle from DataSourcePickerWithPrompt

* remove advancedDataSourcePicker toggle from DataSourcePicker and adjust tests that relied on old picker

* adjust failing tests in QueryVariableEditorForm

* move DataSourceDropdown to DataSourcePicker file

* covert style declaration syntax to object style in DataSourcePicker

* remove advancedDataSourcePicker  feature flag from registry

* remove .only from test

* adjust QueryVariableEditor test to avoid console.error
2024-02-06 09:20:07 +00:00
Timur Olzhabayev
c02d57c6a9 Chore: removing folderId from plugindashboard service (#80570)
* removing folderId from plugindashboard service

* fixing linting
2024-01-16 11:08:39 +01:00
Dominik Prokop
73eab8fcd6 DashboardScene: Data source and query options edit for a panel (#79267)
* Scenes bump

* Refactor query group components so that they are reusable

* Basic queries rendering and datasource change

* Store last used ds in local storage

* maxDataPoints and minInterval queries options

* Progress on query options

* Query options tests

* Allow panel inspection / queries inspection from panel edit

* Add counters to data pane tabs

* Betterer update

* Handle data source changes

* Minor fixes

* Data source change tests

* Handle scenario of data source change when transformations are in place

* Review comment

* Fix test
2023-12-19 05:51:19 -08:00
Ashley Harrison
1efd21c08a Data sources: Add skeleton loader (#79016)
* refactor out DataSourcesListCard

* add skeleton

* increase gap between buttons on skeleton to match real component

* lineHeight: 1 instead of 0

* refactor out ternary
2023-12-13 09:50:27 +00:00
Esteban Beltran
46142da4db Chore: Migrate from aria-label to data-testid in plugin-related tests (#79272)
* Update basicsettings for datasource

* Change aria-label for data-testid

* Update more tests

* Update betterer

* Remove unnecessary data-testid

* Put back aria label for some datasource selectors

* Try to use data-testid with alerts

* Update betterer
2023-12-11 15:05:54 +01:00
Taewoo K
4fbd9a55b2 Remove feature toggle data source page header (#77751)
* remove feature toggle:dataSourcePageHeader

* remove feature flag: dataSourcePageHeader

* remove unused prop:alertingSupported
2023-11-06 15:21:15 -05:00
Josh Hunt
07266aa983 Rewrite old useStyles2 pattern to use new pattern (#76136)
* Rewrite old useStyles2 pattern to use new pattern

* fix lint from used imports
2023-10-09 10:49:08 +01:00
Aditi Patel
a2b71fd149 Markup DataSourcePicker for translations (components used in Explore only) (#75400)
* feat: added markup for data source picker title

* feat: added markup for builtin data source list

* feat: added markup for datasource list

* chore: generated markup files

* feat: added markup for new data source button

* chore: generated markup files

* fix: fixed prefix names

* chore: updated markup files

* fix: removed extra spaces
2023-10-06 15:11:53 +02:00
Ivan Ortega Alba
6aa27607ae DataSourcePicker: Disable autocomplete for the search input (#75898) 2023-10-03 18:06:27 +03:00
Jack Westbrook
5108430aec Datasources: Filter plugin errors to only show datasource plugins (#74339)
* feat(plugins): allow filtering of plugin errors by plugin type

* refactor(plugins): migrate PluginsErrorsInfo component to use Alert component

* chore(plugins): remove redundant d3 import

* feat(datasources): filter plugin errors by plugin type

* refactor(plugins): pass plugin.type from selector rather than guess from pluginId

* refactor(plugins): move filtering to selector
2023-10-03 15:54:49 +02:00
Aditi Patel
56c75cc542 I18n: Markup ExploreToolbar component (#74292)
* chore: markup explore-split-toolbar and data-source-dropdown

* chore: markup explore-refesh-picker

* fix:  apostrophe in empty-recent-list paragraph

* chore: added markup for add to dashboard

* fix: corrected prefix

* fix: typos

* chore: updated markup prefixes in all other languages

* chore: added i18n markup for aria-labels

* i18n files generated

* i18n aria-label added for Add to Dashboard

* fix: fixed prefixes according to the grafana guidelines

* chore: generated i18n json files

* fix: fixed prefixes

* fix: apos; entity rendering

* chore: updated markup files

* chore: updated markup Locale file

* fix: updated prefix names

* chore: updated markup files

* fix: updated markup prefix for data-source-picker

* fix: trimmed extra spaces

* chore: updated markup files

* fix: added back translation phrases

* fix: Updated prefix name in DataSourceDropdown.tsx

* fix: created addToDashboard variable with translation markup
2023-09-25 10:38:17 +02:00
Ivan Ortega Alba
087e1658c2 Revert "Rename "Add new data source" to "Connect data"" (#74321)
Revert "Rename "Add new data source" to "Connect data" (#73688)"

This reverts commit 7543a28ae2.
2023-09-05 12:43:35 +02:00
Kristina
cd2dcba484 Datasource Picker: Invert the builtin svg logos on light mode (#71684)
* Invert the builtin svg logos on light mode

* Empty-Commit
2023-08-30 17:11:42 +01:00
Ivan Ortega Alba
7543a28ae2 Rename "Add new data source" to "Connect data" (#73688)
* DS Picker: Rename "Add new data source" to "Connect data"

* DS Picker: Center empty list CTA
2023-08-28 11:54:51 +02:00
mikkancso
1646b901af EditDatasource: Fix navtree when dataSourcePageHeader is on (#72827)
use useDataSourceSettingsNav from connections in DataSourceTabPage
2023-08-08 07:53:32 +02:00
Ivan Ortega Alba
148b6186b7 DS Picker: Ignore capitalization when sorting by name (#72665) 2023-08-01 13:20:59 +02:00
Ashley Harrison
7406c4ff51 Data sources: Dashboards page now loads correctly from direct url (#72264)
* ensure DataSourceDashboardsPage initialises data source settings

* fix unit test

* apply suggestions from review
2023-07-28 09:37:56 +01:00
Ivan Ortega Alba
8415dd40d7 DSPicker: Use new DS picker everywhere in Grafana (#70609) 2023-07-26 18:40:51 +02:00
Polina Boneva
cae68b955b Dashboard: New Datasource picker link is keyboard accessible (#72134)
* WIP

* fixes for readability

* fix

* WIP

* Keep tab index working with portal

* Use callback and clean up

* Fix linting errors

* Ignore clickable element

---------

Co-authored-by: Ivan Ortega <ivanortegaalba@gmail.com>
2023-07-26 16:02:04 +03:00
mikkancso
b08271da32 Connections: Stop using dataConnectionsConsole feature toggle (#72111)
* remove dataConnectionsConsole feature toggle

* fix imports

* reintroduce dataConnectionsConsole

To prevent breaking change
2023-07-24 10:54:52 +02:00
Piotr Jamróz
173c87beb5 DatasourcePicker: Call onChange only if data source changes (#71630)
Call onChange only when data source changes
2023-07-19 08:39:52 +02:00
Ivan Ortega Alba
18b4f72c7a DS Picker: Use trigger width as min width (#71501) 2023-07-13 17:10:38 +02:00
Levente Balogh
324b33146a Datasources: Pass down the edit-form errors (#69830)
feat: pass the error to the event handler
2023-07-13 11:31:02 +02:00
Ivan Ortega Alba
6ad9e386ad DS Picker: Filter available DS based on component props (#70613)
* Apply filters consistently to every list in the picker

* Display all built-in DS when editing a panel

* Add `uploadFile` prop to toggle the CSV file DS
2023-07-06 11:50:55 +02:00
Ashley Harrison
7a2a5dde8b Chore: Enable remaining jsx-a11y rules (#70990)
enabling remaining a11y rules + ignore existing violations
2023-06-30 16:58:16 +01:00
RoxanaAnamariaTurc
af9b071a78 I18n: Mark up strings on Navigation - Connections section (#70914) 2023-06-30 11:27:19 +01:00
Oscar Kilhed
50c0ff8400 DatasourcePicker: Skip flaky upload test (#70756)
Skip flaky upload test
2023-06-27 18:05:06 +02:00
Ivan Ortega Alba
3bf8dc1397 DS Picker: Add missing props and improve autoheight logic (#70393)
* DS Picker: Add `inputId` and `noDefault` options

* DS Picker: Add `disabled` state

* Add tests for `disabled`

* Select default DS if `current` is not provided

* Remove `width` from style

* Move types next to components

* Only calculate height when opening
2023-06-23 10:26:18 +02:00
Oscar Kilhed
cf4d86d95f DataSourcePicker: refactor file drop out of query group (#68236)
* refactor file drop out of query group

* make sure we display errors when file upload fails

* refactor to make onChange take default queries

* let grafana datasource handle file -> query

* add dropdown tests

* add modal tests

* add filtering props to dropdown

---------

Co-authored-by: Ivan Ortega Alba <ivanortegaalba@gmail.com>
2023-06-21 10:55:55 +02:00
Giordano Ricci
d5d3db9a6e DSPicker: Respect datasource & mixed props (#70377) 2023-06-20 14:21:49 +02:00
Ivan Ortega Alba
6be0ca396f DS Picker: first item is always active when filtering (#70071)
* Select always the first item by default when filtering

* Avoid re-render when updating the selected item state
2023-06-16 18:30:49 +03:00
Ivan Ortega Alba
5b97670f11 DS Picker: Support width and hideTextValue (#70074) 2023-06-15 16:34:20 +02:00
Jaroslav Benc
12cd99ae8d Pass testing status to the data source plugin extension (#69988) 2023-06-14 13:18:24 +02:00
Ivan Ortega Alba
908b248e10 DS Picker: Built-in datasources are not marked as selected (#70020) 2023-06-14 10:52:49 +02:00
Ivan Ortega Alba
bc48622919 DS Picker: Fix React key issue for built-in data source list (#70018) 2023-06-13 16:06:49 +00:00
Levente Balogh
d25cea90b0 Datasources: Make the datasources config extendable by plugins (#68064)
* feat: add a new UI extension type: component

* fix: remove reference to not existing type

* chore: update betterer results

* review: use a single type notation in import

* review: stop exporting `PluginExtensionBase`

* refactor: make extension config types more explicit

By using some repetition now these types are much easier to oversee.

* feat: add a new extension point to the datasources config

* fix: export tcontext type from grafana-data

* chore: update betterer results

* chore: fix tests

* feat: extend the context shared with extensions

* feat: stop omitting jsonData props & update context type

* tests: update tests
2023-06-02 11:01:36 +02:00