Artur Wierzbicki
2e599643f6
Previews: refactor ( #47728 )
...
* #44449 : return standard thumb service even if auth setup fails
* #44449 : remove dashboardPreviewsScheduler feature flag
* #44449 : externalize dashboardPreviews config
* #44449 : disable previews by default
* #44449 : rename logger
* #44449 : dashboardPreviewsAdmin feature requires dev mode
* #44449 : retrigger CII
2022-04-25 01:55:10 +04:00
Josh Hunt
3c6e0e8ef8
Chore: ESlint import order ( #44959 )
...
* Add and configure eslint-plugin-import
* Fix the lint:ts npm command
* Autofix + prettier all the files
* Manually fix remaining files
* Move jquery code in jest-setup to external file to safely reorder imports
* Resolve issue caused by circular dependencies within Prometheus
* Update .betterer.results
* Fix missing // @ts-ignore
* ignore iconBundle.ts
* Fix missing // @ts-ignore
2022-04-22 14:33:13 +01:00
Torkel Ödegaard
7181efd1cf
Explore: Allow users to save Explore queries to dashboards ( #47083 )
...
* Select: Expose AsyncSelectProps interface
* DashboardPicker: Add a generic DashboardPicker component
* Dashboard Service: improve types
* Explore: allow saving explore state in a new panel in an existing dashboard
* Handle saving provisioned dashboards error
* Improve test coverage
* simplify test setup
* Strip base path from url when redirecting to a dashboard
* Keep existing variables when saving to an existing dashboard
* group assertions in test
* SearchCard: handle undefined in meta.updated
* Change required error message
* Add to dashboard alternative
* Add to existing is working
* Add to dashboard form
* remove default add-panel when creating a dashboard from explore
* types cleanup
* remove unneeded BE change
* simplify selector
* Add explore2Dashboard feature toggle
* add tests
* Small refactor & add tests
* small DashboardPicker improvements
* use partial from lodash
* Better error handling
* improve tests & disable button when there are no queries
* rename addPanelToDashboard function
* remove localStorage item if opening tab fails
* UI touchups & tracking
* Fix tests & remove close reporting
* remove echologger debug
* fix adding a panel to an existing dashboard
* Enable explore2Dashboard by default and add docs
* Ensure each panel in dashboards has a valid ID
* force CI restart
Co-authored-by: Elfo404 <me@giordanoricci.com>
2022-04-12 13:26:07 +02:00
Nathan Marrs
99bb6ebd2b
Search: Update tag filter options dynamically ( #47165 )
2022-04-08 12:18:52 -07:00
Nathan Marrs
015a31644c
Search: clean up styling ( #47221 )
2022-04-06 16:59:24 -07:00
Ryan McKinley
38dc34359b
Search: show dashboards form query ( #47085 )
2022-03-31 14:38:46 -07:00
Nathan Marrs
85286a5182
Search v2: encode query in url ( #47078 )
2022-03-30 13:00:40 -07:00
Nathan Marrs
4449439a41
Search: Implement basic improved UI ( #46758 )
2022-03-30 09:50:32 -07:00
Josh Hunt
89757cf58f
ManageDashboards: Fix error when deleting all dashboards from folder view ( #46877 )
...
* user essentials mob! 🔱
* draft tests
* tests!
* better default ids for test data
2022-03-24 09:43:25 +00:00
Ryan McKinley
93390b5a1e
Search: use search service ( #46714 )
...
Co-authored-by: nmarrs <nathanielmarrs@gmail.com>
2022-03-18 01:36:32 +01:00
Ryan McKinley
736820f975
Search: use minisearch for better frontend searching ( #46710 )
...
Co-authored-by: nmarrs <nathanielmarrs@gmail.com>
2022-03-17 14:26:48 -07:00
Ryan McKinley
0aad61d0ac
Search: add a simple search page (behind feature flag) ( #45487 )
...
Co-authored-by: nmarrs <nathanielmarrs@gmail.com>
2022-03-03 14:56:14 -08:00
kay delaney
59317a22e4
AppNotifications: Migrate usage of deprecated appEvents.emit method to redux actions ( #45607 )
2022-02-23 11:31:15 +00:00
Artur Wierzbicki
6c76aa71e8
Previews: capability check ( #44601 )
...
* add SQL migrations
* dashboard previews from sql: poc
* added todos
* refactor: use the same enums where possible
* use useEffect, always return json
* added todo
* refactor + delete files after use
* refactor + fix manual thumbnail upload
* refactor: move all interactions with sqlStore to thumbnail repo
* refactor: remove file operations in thumb crawler/service
* refactor: fix dashboard_thumbs sql store
* refactor: extracted thumbnail fetching/updating to a hook
* refactor: store thumbnails in redux store
* refactor: store thumbnails in redux store
* refactor: private'd repo methods
* removed redux storage, saving images as blobs
* allow for configurable rendering timeouts
* added 1) query for dashboards with stale thumbnails, 2) command for marking thumbnails as stale
* use sql-based queue in crawler
* ui for marking thumbnails as stale
* replaced `stale` boolean prop with `state` enum
* introduce rendering session
* compilation errors
* fix crawler stop button
* rename thumbnail state frozen to locked
* #44449 : fix merge conflicts
* #44449 : remove thumb methods from `Store` interface
* #44449 : clean filepath, defer file closing
* #44449 : fix rendering.Theme cyclic import
* #44449 : linting
* #44449 : linting
* #44449 : mutex'd crawlerStatus access
* #44449 : added integration tests for `sqlstore.dashboard_thumbs`
* #44449 : added comments to explain the `ThumbnailState` enum
* #44449 : use os.ReadFile rather then os.Open
* #44449 : always enable dashboardPreviews feature during integration tests
* #44449 : add /previews/system-requirements API
* #44449 : remove sleep time, adjust number of threads
* #44449 : review fix: add `orgId` to `DashboardThumbnailMeta`
* #44449 : review fix: automatic parsing of thumbnailState
* #44449 : update returned json
* #44449 : UI changes - dashboard previews sytem req check
* #44449 : lint fixes
* #44449 : fix tests
* #44449 : typo
* #44449 : fix getSystemRequirements API: return 200 even if we plugin version is invalid
* #44449 : fix getSystemRequirements API: don't return SemverConstraint on error
* #44449 : fix getSystemRequirements API
* #44449 : fix previews sytem requirements text
* #44449 : add `doThumbnailsExist` to repo
* #44449 : remove redux api
* #44449 : add missing model
* #44449 : implement frontedsettings-driven capability check
* #44449 : simplify
* #44449 : revert test changes
* #44449 : add dummy setup settings
* #44449 : implicit typing over `FC<Props>`
* #44449 : refactor conditionals
* #44449 : replace `getText` with a react component
* #44449 : fix component interface
* #44449 : add onRemove to `PreviewsSystemRequirements` alert
* #44449 : add bottom/top margin to previewSystemRequirements modal
* #44449 : merge conflict fix
* #44449 : remove console.log
Co-authored-by: Ryan McKinley <ryantxu@gmail.com>
Co-authored-by: Alexander Emelin <frvzmb@gmail.com>
2022-02-16 21:49:50 +04:00
Marcus Andersson
eb9d85a2bf
Deprecation: use locationService in favor of getLocationSrv ( #44813 )
...
* deprecated
* updating documentation.
* added deprecation notice.
* Replacing deprecated getLocationSrv.
* Update docs/sources/developers/plugins/migration-guide.md
Co-authored-by: achatterjee-grafana <70489351+achatterjee-grafana@users.noreply.github.com>
* Update docs/sources/developers/plugins/migration-guide.md
Co-authored-by: achatterjee-grafana <70489351+achatterjee-grafana@users.noreply.github.com>
* Update docs/sources/developers/plugins/migration-guide.md
Co-authored-by: achatterjee-grafana <70489351+achatterjee-grafana@users.noreply.github.com>
* Update docs/sources/developers/plugins/migration-guide.md
Co-authored-by: achatterjee-grafana <70489351+achatterjee-grafana@users.noreply.github.com>
* updating according to feedback.
* Update docs/sources/developers/plugins/migration-guide.md
Co-authored-by: achatterjee-grafana <70489351+achatterjee-grafana@users.noreply.github.com>
* Update docs/sources/developers/plugins/migration-guide.md
Co-authored-by: achatterjee-grafana <70489351+achatterjee-grafana@users.noreply.github.com>
Co-authored-by: achatterjee-grafana <70489351+achatterjee-grafana@users.noreply.github.com>
2022-02-07 09:37:56 +01:00
renovate[bot]
d87cd6f26c
Update dependency prettier to v2.5.1 ( #43473 )
...
* Update dependency prettier to v2.5.1
* prettier fixes
* chore(toolkit): bump prettier to 2.5.1
* style(eslint): bump grafana config to 2.5.2 in core and toolkit
* style(mssql-datasource): fix no-inferrable-types eslint errors
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Ashley Harrison <ashley.harrison@grafana.com>
Co-authored-by: Jack Westbrook <jack.westbrook@gmail.com>
2022-02-02 12:02:32 +00:00
Artur Wierzbicki
46a34451d5
Analytics: add more properties to dashboard list viewed event ( #44739 )
2022-02-02 13:41:10 +04:00
Artur Wierzbicki
6e1615b42a
Analytics: send dashboard_list_viewed events to rudderstack ( #44589 )
...
* #44449 : report interactions with showPreviews toggle
* #44449 : hookify showPreviews
* #44449 : report dashboard_list_viewed event rather than enabled/disabled_dashboard_previews
2022-01-31 22:17:05 +04:00
kay delaney
3c1122cf29
CollapsableSection: Improves keyboard navigation and screen-reader support ( #44005 )
2022-01-25 15:36:17 +00:00
kay delaney
cc9e70be5c
Tags: Make Tags component more a11y-friendly ( #43808 )
2022-01-10 15:41:19 +00:00
kay delaney
890c43adf1
UI/Card: Refactor Card component for improved accessibility ( #41890 )
...
* UI/Card: Improve accessibility of Card component
Co-authored-by: Torkel Ödegaard <torkel@grafana.com>
2022-01-06 15:48:12 +00:00
Ashley Harrison
b826804ef7
Hide previews behind toggle properly ( #43704 )
2022-01-05 15:28:03 +00:00
Ashley Harrison
c509c32091
Remove height/width to fix safari issue ( #43668 )
2022-01-04 15:55:34 +00:00
Ryan McKinley
a3d2c79d06
Previews: check feature flag on dashboard manage page ( #43632 )
2022-01-03 23:15:50 +01:00
Ryan McKinley
4233a62aeb
DashboardPreviews: add dashboard previews behind feature flag ( #43226 )
...
Co-authored-by: Ashley Harrison <ashley.harrison@grafana.com>
Co-authored-by: Artur Wierzbicki <artur@arturwierzbicki.com>
2021-12-23 09:43:53 -08:00
renovate[bot]
159fb4cebb
Update dependency eslint-plugin-react to v7.27.1 ( #43207 )
...
* Update dependency eslint-plugin-react to v7.27.1
* Fix up code to work with new version of eslint-plugin-react
* kick drone
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Ashley Harrison <ashley.harrison@grafana.com>
2021-12-21 11:11:27 +00:00
Ashley Harrison
0388082768
Update SearchItem.tsx ( #42783 )
2021-12-06 14:14:56 +00:00
Ashley Harrison
a365dcca5b
Manage dashboards: Can now delete empty folders ( #42527 )
...
* Manage dashboards: Can now delete empty folders
* Split hasChecked out into a separate function
* Update modal text
2021-12-01 14:53:41 +00:00
Hugo Häggmark
5498203507
Chore: Reduce pa11y-ci errors ( #41787 )
...
* Chore: moves alert to test-id
* Chore: moves Dashboard navigation to test-id
* Chore: moves Bar gauge value to data-testid
* Chore move Folder picker select container to data-testid
* Chore: moves Time zone picker select container to data-testid
* Chore: moves Choose starting day of the week to data-testid
* Chore: change tabIndex on search input
* Chore: moves various search related aria-lables to data-testid
* Chore: connects label to select input on alerting page
* Chore: connects TimeZonePicker and WeekStartPicker with labels
* Chore: moves CallToActionButton to data-testid
* Chore: move user home preferences select to data-testid
* Chore: lower all thresholds
2021-11-17 14:45:45 +01:00
renovate[bot]
99b50ffa00
Update dependency @testing-library/dom to v8 ( #40990 )
...
* Update dependency @testing-library/dom to v8
* Update our use of useFakeTimers
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Ashley Harrison <ashley.harrison@grafana.com>
2021-10-27 16:57:20 +01:00
Hugo Häggmark
70e759e0c0
Folders: Prevents deletion of General folder ( #40192 )
2021-10-08 11:15:15 +02:00
Alex Khomenko
5c7e874008
Search: Fix local storage key ( #40127 )
...
* Default to 'General' if no folder title is present
* Add bottom padding
2021-10-07 11:35:31 +03:00
kay delaney
1ce750471f
A11y: Fix fastpass issues for dashboard management pages ( #39940 )
...
* A11y: Fix fastpass issues for dashboard pages
See #39429
2021-10-06 11:58:18 +01:00
Ashley Harrison
c2c04f218a
Chore(DashboardSearch): Convert to use useTheme2 ( #39918 )
2021-10-04 10:32:29 +01:00
Hugo Häggmark
7c7b21b39e
DashboardList/AlertList: Fix for missing All folder value ( #39772 )
...
* DashboardList/AlertList: Fix for missing All folder value
* Refactor: Fixes case where folder does not exist in results
2021-10-01 06:20:25 +02:00
Dominik Prokop
f887576a27
Table panel: Make filter case insensitive ( #39746 )
...
* Expose FilterInput from grafana/ui
* Make table filter case insensitive
* Update packages/grafana-ui/src/components/Table/FilterList.tsx
Co-authored-by: Hugo Häggmark <hugo.haggmark@grafana.com>
Co-authored-by: Oscar Kilhed <oscar.kilhed@grafana.com>
Co-authored-by: Hugo Häggmark <hugo.haggmark@grafana.com>
2021-09-29 09:35:41 +02:00
Ashley Harrison
06571e0af6
Dashboard: Don't show SectionHeader unless section has a title ( #39336 )
...
* Dashboard: Don't show SectionHeader unless section has a title
* Dashboard: Add unit test to prevent regression
2021-09-17 11:59:15 +01:00
Gábor Farkas
9417e86316
Updated "react-use" package to newest version ( #37579 )
...
* package.json: updated react-use to newest version
* fixes (typescript and other)
2021-08-05 14:32:51 +02:00
Sofia Papagiannaki
b96dd1877c
Folder API: optionally force deleting Grafana 8 alerts when deleting a folder (or error) ( #36427 )
...
* Folder API: Add an optional query parameter for allowing deleting a folder containing rules
* Update frontend
- Set forceDeleteRules=true when frontend deletes a folder
- Improve modal text
* Update docs
* Apply suggestions from code review
Co-authored-by: gotjosh <josue@grafana.com>
Co-authored-by: Nathan Rodman <nathanrodman@gmail.com>
Co-authored-by: achatterjee-grafana <70489351+achatterjee-grafana@users.noreply.github.com>
2021-07-22 12:27:13 +03:00
Ashley Harrison
54f8996acf
Select: Portal select menu to document.body ( #36398 )
...
* ValueMappings: Force overflowing modal content to scroll
* ValueMappings: Update unit tests
* Select: Portal Select to document.body, close menu on scroll
* Select: Fix tests + apply updates from https://github.com/grafana/grafana/pull/32833
* ValueMappingsEditorModal: Revert to using selectEvent in the tests
* Select: Fix remaining unit tests
* Portal: Rewrite Portal as a functional component so we can use useTheme2
* Modal: Remove modal styles from this PR
* Update E2E tests
* More unit test fixes
* Select: Fix remaining E2E tests
* Select: Create util method to select an option in tests
2021-07-14 14:04:23 +01:00
Josh Hunt
4c0acf335b
Grafana-UI: Refactor Checkbox to fix alignment issues ( #36164 )
...
* Grafana-UI: Fix Checkbox vertical layout issues
* reorganise css
* WIP for fixing checkboxes in manage dashboards
* Cleanup checkbox and fix issue in Dashboard manage page
* update tests
2021-07-08 14:09:58 +02:00
Alex Khomenko
91e9ef232d
Memoize SearchResults ( #35851 )
2021-06-17 11:19:33 +03:00
Alex Khomenko
8e827337ea
Search: runAllTimers => runOnlyPendingTimers ( #35509 )
2021-06-11 12:45:18 +03:00
Alex Khomenko
2cc172db1a
Search: minor UI fixes ( #35335 )
...
* Increase margin between search item so it's visible
* Fix manage dashboards height overflow
* Align folder icon
* Increase margin
* Update container height
* Fix className not being passed to CardContainer
2021-06-08 14:41:06 +02:00
Uchechukwu Obasi
9d21dccc30
ManageDashboard: fixes dashboard list overflowing its parent container ( #35317 )
2021-06-07 14:04:23 +01:00
Alex Khomenko
bfcc6a2248
Remove extra margin for checkboxes ( #35169 )
2021-06-04 13:10:57 +02:00
Alex Khomenko
486ab7c639
Debounce location update ( #35033 )
2021-06-01 17:20:00 +03:00
Torkel Ödegaard
f6ecded86b
Theme: Page styles move to emotion global styles and design tweaks ( #33529 )
...
* Theme: Page styles move to emotion global styles and design tweaks
* More style tweaks
* tweaks
* Updating snapshots
* Another fix
* Another fix
* minor fix
* More style tweaks to page toolbar and alert rule page
* minor polish
2021-04-30 10:04:01 +02:00
Alex Khomenko
6d95f2f1db
Chore: Update typescript to v4.2.4 ( #33297 )
...
* Update typescript to v4.2.4
* Update @types/slate
* Fix QueryVariableEditor.test.tsx
* Fix search-related type errors
* Fix Plugin pages type errors
* Fix missing initializer errors
* Update snapshot
* Revert tsconfig changes
2021-04-28 15:40:01 +03:00
Torkel Ödegaard
7e2bf4f6c3
Theming: Make new theme exposed by ThemeContext and make new theme include v1 for compatability (to pass to useTheme) ( #33207 )
...
* WIP: Making new theme the default
* Progress
* Updates, lots of updates
* Things are working
* Fixed issues with storybook
* Fixed tests
2021-04-21 14:25:43 +02:00
