Commit Graph

18 Commits

Author SHA1 Message Date
Oscar Kilhed
0b2640e9ff Dashboard scenes: Editing library panels. (#83223)
* wip

* Refactor find panel by key

* clean up lint, make isLoading optional

* change library panel so that the dashboard key is attached to the panel instead of the library panel

* do not reload everything when the library panel is already loaded

* Progress on library panel options in options pane

* We can skip building the edit scene until we have the library panel loaded

* undo changes to findLibraryPanelbyKey, changes not necessary when the panel has the findable id instead of the library panel

* fix undo

* make sure the save model gets the id from the panel and not the library panel

* remove non necessary links and data providers from dummy loading panel

* change library panel so that the dashboard key is attached to the panel instead of the library panel

* make sure the save model gets the id from the panel and not the library panel

* do not reload everything when the library panel is already loaded

* Fix merge issue

* Clean up

* lint cleanup

* wip saving

* working save

* use title from panel model

* move library panel api functions

* fix issue from merge

* Add confirm save modal. Update library panel to response from save request. Add library panel information box to panel options

* Better naming

* Remove library panel from viz panel state, use sourcePanel.parent instead. Fix edited by time formatting

* Add tests for editing library panels

* implement changed from review feedback

* minor refactor from feedback
2024-03-11 20:48:27 +01:00
Oscar Kilhed
bc7eacfcbd Dashboard Scenes: Add model to library panel inspect json (#83536)
* Add model to library panel inspect json

* Add missing information from library panel when inspecting its JSON

* minor refactor

* refactor inspect library panel model to show the model that was fetched from the api

* nit: improve comment

* fix library panel import path

---------

Co-authored-by: Alexandra Vargas <alexa1866@gmail.com>
2024-03-05 10:51:22 +01:00
Oscar Kilhed
19743a7fef Dashboard scenes: Change library panel to set dashboard key to panel instead of library panel. (#83420)
* change library panel so that the dashboard key is attached to the panel instead of the library panel

* make sure the save model gets the id from the panel and not the library panel

* do not reload everything when the library panel is already loaded

* Fix merge issue

* Clean up
2024-02-27 17:56:29 +01:00
Torkel Ödegaard
526916e10f DashboardScene: Panel edit use new splitter and new conditional data and options pane logic (#82377)
Rebase
2024-02-14 13:37:52 +01:00
Dominik Prokop
361c49233d DashboardScenePageStateManager: Do not initialise dashboard meta after fetch (#80875) 2024-01-19 16:46:10 +00:00
Dominik Prokop
1de876c354 DashboardScene: Get rid of panel edit route (#80605)
* Wip: get rod of panel edit route

* Cleanup unused code

* Test update

* Simplify url sync for inspect and vie/edit panel

* Update navigating back to dashboard from edit panel

* DashboardScene:  Panel inspect improvements (#80655)

Improve inspect, andle view pane end edit mode inspection

* Url sync fixes

* Test update
2024-01-17 05:53:53 -08:00
Alexa V
4c6bbabc1c Dashboard: Migration - Dashboard Settings Variables (List, Duplicate, Delete) (#78917)
Co-authored-by: Torkel Ödegaard <torkel@grafana.com>
2023-12-14 12:54:15 +01:00
Dominik Prokop
303c3ddc24 DashboardScene: Pass hashed panelId to query runner if a panel is a clone (#78820)
* DashboardScene: Pass hashed panelId  to query runner if a panel is a clone

* Test

* Nit
2023-12-01 01:07:55 -08:00
Torkel Ödegaard
d33a624ba6 DashboardScene: View panel scene (#78718)
* DashboardScene: View panel fixes

* Update

* Update

* Update

* works and added tests

* Update

* Update
2023-11-30 11:20:15 +01:00
Dominik Prokop
2b953660a4 DashboardSettings: Provide skeleton for list editing (#78789)
* DashboardSettings: Provide basics for list editing

* Update public/app/features/dashboard-scene/scene/DashboardSceneUrlSync.ts

Co-authored-by: Torkel Ödegaard <torkel@grafana.com>

* Lint

* Review

* Fix page nav for items

* Move links to dashbaord scene state

---------

Co-authored-by: Torkel Ödegaard <torkel@grafana.com>
2023-11-29 06:01:40 -08:00
Torkel Ödegaard
d70d939294 DashboardScene: Basics stubs for starting with editviews (dashboard settings) (#78209) 2023-11-20 18:19:30 +01:00
Torkel Ödegaard
0d55dad075 DashboardScene: Fixes full page reload of fullscreen view of a repeated panel (#76326)
* Progress on view panel for repeats

* Good enough

* Update
2023-10-13 16:03:38 +02:00
Torkel Ödegaard
3529b7413d DashboardScene: Include url params when switching from old dashboard arch to new (#74969)
* DashboardScene: Include url params when switching from old dashboard arch to new

* remove imports

* fix
2023-09-22 13:04:17 +02:00
Torkel Ödegaard
1d1bdaab37 DashboardScene: ShareModal + link sharing (#74955)
* DashboardScene: Panel menu updates, adding explore action

* DashboardScene: Panel menu updates, adding explore action

* Initial test

* Update

* share modal

* Update

* rename

* Update tests

* Fix test

* update

* Fix tooltip wording

* Update translation file

* fix e2e

* Extract ShareLinkTab component

* rename to overlay

---------

Co-authored-by: Dominik Prokop <dominik.prokop@grafana.com>
2023-09-19 16:02:21 +02:00
Torkel Ödegaard
499b02b3c6 DashboardScene: Panel edit route basics (#74081)
* DashboardScene: Panel edit route basics

* remove unused file

* Removed some comments

* Minor fix

* Update

* example of apply changes implementation

* SceneObjectRef: Testing scene object ref

* Rename to ref suffix

* Update

* Fix url sync in panel edit

* Update

* Update

* simplify logic when committing change

* remove import

* Another fix for committing change
2023-09-11 13:51:05 +02:00
Torkel Ödegaard
d82a3c9fc6 DashboardScene: Repeat panel by variable (#74294)
* Progress

* think this a bad approach

* Scene panel repeats looking good

* Update

* update

* Update

* Use key instead for inspect/view

* refactorings to improve tests

* Update

* More tests

* Update

* added support for key / value variables

* Update

* Fixes

* remove log

* Update

* Removed old gdev templating dashboard and added new and improved one

* Update

* Added repeating panels coded demo

* Update to latest scenes lib

* review feedback fixes

* update

* Sync schema
2023-09-05 13:51:46 +02:00
Torkel Ödegaard
0563b51098 DashboardScene: Use numeric panel ids in url (#74005)
* DashboardScene: Use numeric panel ids in url

* Rename fix

* Fixed tests
2023-08-30 10:09:47 +02:00
Torkel Ödegaard
412e545503 DashboardScene: Support for discard, start at transform back to save model and save drawer (#73873)
* SceneDashboard: Discard changes now works

* To save model works and start at save drawer

* Update

* Added missing file

* Refactorings to keep responsibility more logical

* Refactorings

* Removed file

* Fixed state issue

* Update

* Update
2023-08-29 14:17:55 +02:00