Commit Graph

2086 Commits

Author SHA1 Message Date
Ashley Harrison
f9a89e5cd2
Navigation: correctly mark a MegaMenuItem as active if it has active children (#76944)
correctly mark a MegaMenuItem as active if it has active children
2023-10-23 10:55:25 +01:00
Ashley Harrison
a2921d9dfb
DockedMegaMenu: More consistent spacing on active state (#76873)
* more consistent spacing on active state

* use correct secondary variant buttons
2023-10-23 09:15:39 +01:00
Ashley Harrison
f5758e9f4b
Navigation: Correctly highlight a SectionNavItem if it has children that are active (#76860)
correctly highlight a sectionnavitem if it has children that are active
2023-10-20 10:27:25 +01:00
Laura Benz
d16a274e3a
Nav: Design changes in MegaMenu (#76735)
* refactor: move expand button to front

* refactor: add grid + adjust level 2

* refactor: remove grid + fix alignment for all three levels

* refactor: first iteration alignment

* refactor: styling of MegaMenuItemIcon

* refactor: remove styling of div in MegaMenuItemIcon

* refactor: styling object

* refactor: alignment of first level

* refactor: alignment of second level

* refactor: alignment of third level and active state

* feat: add connecting line for level 3

* feat: add comment

* refactor: remove unused code

* refactor: clean up styling

* refactor: clean up styling

* refactor: clean up styling

* some small tweaks

* remove unused props from getStyles

* fix dock button position and text ellipsing

* add padding to container to prevent icon button overlapping on left side

* add active overlay

* adjust font-weight, add padding to RHS

* add border-box for overlay

* adjust menu width to 300, don't use non-integer levels

* use height: 100%

* don't think we need minWidth

* make chevrons right/down

* make url required, cut down css

* move active state to container

* remove unused class

* add padding at top and bottom of menu as well

* adjust chevron size

---------

Co-authored-by: Ashley Harrison <ashley.harrison@grafana.com>
2023-10-19 17:41:58 +02:00
Joey
a851750b1c
Tracing: Update configuration editor links (#76678)
Update doc links
2023-10-18 12:30:38 +01:00
Laura Benz
a546db4b3a
Nav: Remove and refactor MegaMenu and its sub-components (#76614)
* refactor: remove hasActiveChild

* refactor: remove unused properties from MegeMenuItemText

* refactor: remove MegaMenuItemIcon

* refactor after code review
2023-10-17 10:34:44 +02:00
Alexander Zobnin
87d697e4fe
TeamPicker: Add optional initial value support (#76353)
* TeamPicker: Add optional initial value support

* Rename value to teamId
2023-10-16 17:02:12 +02:00
Laura Benz
5423e75bf3
Nav: Replace cloneDeep() in MegaMenu (#76607)
* refactor: remove deep clone of nav tree

* refactor: fix mutation issue
2023-10-16 12:03:35 +02:00
Ashley Harrison
b6fb1e52f2
Navigation: Limit SectionNav to rendering items up to 3 levels (#76478)
* only render section nav items up to 3 levels

* extract level depth into constant, apply in DockedMegaMenu as well
2023-10-13 10:38:35 +01:00
Eric Leijonmarck
38cdce526a
Auth: Enable None role for 10.2 (#76343)
* remove the feature toggle for noBasicRole

* linting

* remove unused
2023-10-12 13:00:26 +02:00
Aaron Godin
c2cbb0a924
noBasicRole feature: Change RolePickerInput to not show the "None" role (#76300)
Change RolePickerInput to only show the basic role when it's not the None role (no basic role feature)
2023-10-11 09:42:09 -05:00
Joao Silva
5f6fea33f2
Chore: Improve typings in OptionsUI and Explore (#76245) 2023-10-11 11:43:25 +01:00
Ashley Harrison
abd2c9c287
Navigation: Hide docked menu and dock button on mobile (#76334)
* hide docked menu and dock button on mobile

* add logic to handle hamburger menu button on mobile
2023-10-11 11:33:15 +01:00
Oscar Kilhed
608f066ca5
PanelConfig: Add option to calculate min/max per field instead of using the global min/max in the data frame. (#75952)
* Add option to calculate min max per field

* Fix eslint warnings

* Add back hideFromDefaults that went missing

* whitespace

* Add tests

* Refactor range calculation

* Rename localMinMax -> fieldMinMax

* Remove the lint exceptions

Removing these as to not hide these once we get around to fixing the
underlying typing issue.

* Update docs
2023-10-11 10:50:11 +02:00
Ashley Harrison
930c753340
Navigation: Implement logic for docking nav menu (#76188)
* Create a state for dockedMegaMenu and the function to manage it

* Add the dockedMenu icon and handle the status when clicking it

* Add Megamenu to section nav area when it is docked

* get logic working

* fix mobile

* refactor state + persist in localStorage

* adjust icon and don't use position absolute

* restore old rudderstack tracking

* use Flex instead

* adjust feature toggle to be experimental

* extract out localStorage handling into utils

* don't need separate file

* use store.set/get instead

---------

Co-authored-by: eledobleefe <laura.fernandez@grafana.com>
2023-10-10 14:55:52 +01:00
Josh Hunt
07266aa983
Rewrite old useStyles2 pattern to use new pattern (#76136)
* Rewrite old useStyles2 pattern to use new pattern

* fix lint from used imports
2023-10-09 10:49:08 +01:00
Jo
4474f19836
Service Accounts: Enable adding folder, dashboard and data source permissions to service accounts (#76133)
* Add SAs to Datasource permissions

Co-authored-by: ievaVasiljeva <ieva.vasiljeva@grafana.com>

* add SAs to dashboards/folders managed permissions

* Update public/app/core/components/AccessControl/Permissions.tsx

Co-authored-by: Ieva <ieva.vasiljeva@grafana.com>

* regenerate i18n

* add doc

---------

Co-authored-by: ievaVasiljeva <ieva.vasiljeva@grafana.com>
2023-10-06 17:48:13 +02:00
Kyle Cunningham
0e0f1183e6
Transformations: Update row title (#75988)
* Update row title in transformations

* Prettier fixes
2023-10-06 09:32:52 -05:00
Leon Sorokin
e2dcd5184a
Dashboard: Overflow and z-index adjustments (#75597) 2023-10-05 22:46:15 -05:00
Krishna Dhakal
76e102d1a3
Explore: A tooltip for reorder icon in query operation (#75978)
* tooltip in draggabledots icon

* making it a IconButton
2023-10-05 16:31:16 +02:00
Kristina
4b3d63dcdc
Correlations: Add an editor in Explore (#73315)
* Start adding correlations editor mode

* Add selector for merge conflict resolution

* Enable saving

* Build out new corelation helper component

* flesh out save with label/description, change color

* Have breadcrumb exit correlation editor mode

* Add extension property to show/hide, use it for correlations

* Bring in feature toggle

* Remove unnecessary param

* Cleanup

* Parse logs json

* Work on correlation edit mode bar

* Tinker with a top element for the editor mode

* Handle various explore state changes with correlations editor mode

* WIP - add unsaved changes modal

* Have correlation bar always rendered, sometimes hidden

* Add various prompt modals

* Clear correlations data on mode bar unmount, only use not left pane changes to count as dirty

* Move special logic to explore

* Remove all shouldShow logic from plugin extensions

* remove grafana data changes

* WIP - clean up correlations state

* Interpolate data before sending to onclick

* Override outline button coloring to account for dark background

* More cleanup, more color tweaking

* Prettier formatting, change state to refer to editor

* Fix tests

* More state change tweaks

* ensure correlation save ability, change correlation editor state vars

* fix import

* Remove independent selector for editorMode, work close pane into editor exit flow

* Add change datasource post action

* Clean up based on PR feedback, handle closing left panel with helper better

* Remove breadcrumb additions, add section and better ID to cmd palette action

* Interpolate query results if it is ran with a helper with vars

* Pass the datasource query along with the correlate link to ensure the datasource unique ID requirement passes

* Use different onmount function to capture state of panes at time of close instead of time of mount

* Fix node graph’s datalink not working

* Actually commit the fix to saving

* Fix saving correlations with mixed datasource to use the first query correlation UID

* Add tracking

* Use query datasources in mixed scenario, move exit tracking to click handler

* Add correlations to a place where both can be used in the correlations editor

* Be more selective on when we await the datasource get

* Fix CSS to use objects

* Update betterer

* Add test around new decorator functionality

* Add tests for decorate with correlations

* Some reorganization and a few tweaks based on feedback

* Move dirty state change to state function and out of component

* Change the verbiage around a little

* Various suggestions from Gio

Co-authored-by: Giordano Ricci <me@giordanoricci.com>

* More small Gio-related tweaks

* Tie helper data to datasource - clear it out when the datasource changes

* Missed another Gio tweak

* Fix linter error

* Only clear helper data on left pane changes

* Add height offset for correlation editor bar so it doesn’t scroll off page

---------

Co-authored-by: Piotr Jamróz <pm.jamroz@gmail.com>
Co-authored-by: Giordano Ricci <me@giordanoricci.com>
2023-10-03 09:28:29 -05:00
Ashley Harrison
18b237879d
DockedMegaMenu: Refactor and rename to simplify (#75872)
* tidy up some styles

* remove NavBarMenuItemWrapper + consolidate components

* lots of renaming

* use object syntax in FeatureHighlight

* fix a couple of missing find+replace

* adjust li positioning

* fix text truncation

* bit more tidy up

* refactor indent into it's own component

* memoize styles in Indent
2023-10-03 13:03:27 +01:00
Ashley Harrison
e9555d727a
Drawer: remove wrapping div preventing Drawer from scrolling properly (#75823)
remove wrapping div prevent drawer from scrolling properly
2023-10-02 16:01:28 +01:00
Ashley Harrison
158e7b9977
DockedMegaMenu: Show correct breadcrumbs on dashboard settings (#75808)
need this logic when using dockedMegaMenu
2023-10-02 13:58:27 +01:00
Torkel Ödegaard
6e246a5fd2
Breadcrumbs: Remove logic that is no longer needed (#75263) 2023-09-28 13:47:04 +02:00
Ashley Harrison
efaa779c2e
Navigation: Refactor MegaMenu to separate out overlay/animation logic (#75365)
* user essentials mob! 🔱

lastFile:public/app/core/components/AppChrome/DockedMegaMenu/DockedMegaMenu.tsx

* mob start [ci-skip] [ci skip] [skip ci]

* user essentials mob! 🔱

lastFile:public/app/core/components/AppChrome/DockedMegaMenu/DockedMegaMenu.tsx

* user essentials mob! 🔱

lastFile:public/app/core/components/AppChrome/AppChrome.tsx

* fix border css + scroll

* import width from DockedMegaMenu

* extract logic out into AppChromeMenu

* fix bug with hamburger icon

* rename some styles

* one more rename

* remove janky state logic

* prevent react-aria closing the overlay when interacting with the toggle button

* don't need boolean

---------

Co-authored-by: eledobleefe <laura.fernandez@grafana.com>
2023-09-27 17:05:40 +01:00
Ashley Harrison
b374912937
Drawer: Make content scroll by default (#75287)
* deprecate scrollableContent prop and make it the default behaviour

* restore prop behaviour, just make it default to true

* Update packages/grafana-ui/src/components/Drawer/Drawer.tsx

Co-authored-by: Alexa V <239999+axelavargas@users.noreply.github.com>

---------

Co-authored-by: Alexa V <239999+axelavargas@users.noreply.github.com>
2023-09-27 13:31:57 +01:00
Domas
bd452fe904
Trace View: Remove "deployment.environment" default traces 2 logs tag (#74986)
* Remove deployment.environment default tag

* format

* remove mentions from docs
2023-09-26 16:52:32 +03:00
Leon Sorokin
0668820259
StateTimeline: Refactor hover markers (#75326) 2023-09-23 05:35:17 +03:00
Leon Sorokin
aadd5bacfa
Chore: uPlot v1.6.26 (#75199) 2023-09-22 11:33:39 -05:00
Joey
4155f0a92e
Tracing: Fix cannot assign to read only property in TagMappingInput (#75070)
* Fix cannot assign to read only property in TagMappingInput

* cloneDeep and updates

* Update assignment

* Updates state change
2023-09-22 15:03:42 +01:00
Torkel Ödegaard
115038a35b
Breadcrumbs: Enable plugins to override breadcrumbs that are generated by pages defined in plugin.json (#75218)
* Breadcrumbs: Make it more flexible for plugins to override items defined in plugin.json

* only check when we have a url

* better fix
2023-09-22 07:38:34 +02:00
Laura Fernández
14f4ed0180
Navigation: enable third level on the DockedMegaMenu (#75180) 2023-09-21 15:15:11 +02:00
Khushi Jain
5e4a900abe
Forms: Remove gf-form appearances in admin, profile and team settings (#74360)
* Accessibility: Added label prop to RadioButtonGroup

* Update packages/grafana-ui/src/components/Forms/RadioButtonGroup/RadioButtonGroup.tsx

Co-authored-by: Tobias Skarhed <1438972+tskarhed@users.noreply.github.com>

* Update RadioButtonGroup.tsx

* Update RadioButtonGroup.tsx

* corrected ariaLabel

* fix accessibility

* Forms: Remove gf-form appearances in Grafana

* remove wrong commit

* Remove gf-form from User Profile Edit Form

* AlertRuleList

* to not change anything under AlertRuleList

* removed gf-form-button-row

---------

Co-authored-by: Tobias Skarhed <1438972+tskarhed@users.noreply.github.com>
2023-09-20 12:04:56 +02:00
Laura Fernández
efeff6bbb1
Navigation: create the DockedMegaMenu component and use the toggle to switch between it and MegaMenu (#75084) 2023-09-19 17:47:03 +02:00
Laura Fernández
0c08163357
Navigation: hide sectionNav when the dockedMegaMenu feature toggle is enabled (#75026) 2023-09-19 12:34:53 +02:00
Adela Almasan
7171b35095
Canvas: Avoid conflicting stylesheets when loading SVG icons (#74461) 2023-09-18 17:38:45 +00:00
Alex Khomenko
42371600f1
Chore: Remove DashboardPickerByID (#73466) 2023-09-18 11:21:38 +03:00
Ashley Harrison
0c44a6f9bb
Chore: Improve typings 🧹 (#74599)
* various type fixes

* candlestick panel type fixes

* few more fixes

* some fixes

* more :)

* moar!

* undo change to SilencesFilter

* undo change to configureStore
2023-09-13 09:17:07 +01:00
Polina Boneva
b14263af45
Dashboard: Remove old panel code and leave only new panel design (#74196)
* delete PanelHeader

* PanelHeaderMenuItem is only used in PageHeader

* PanelHeaderCorner only used by PanelEditorTableView

* PanelHeaderMenuTrigger not used anywhere

* PanelHeaderMenuWrapperNew is PanelHeaderMenuWrapper, old one is deleted

* remove newPanelChromeUI from test

* delete feature flag newPanelChromeUI

* PanelHeaderMenuWrapperNew is PanelHeaderMenuWrapper, old one is deleted
2023-09-12 11:54:41 +03:00
Torkel Ödegaard
73a675af02
DashboardScene: Inspect panel data tab (#74646)
* Refactor data tab to be usable from scenes

* DashboardScene: Inspect data tab

* Everything seem to work now

* don't change drawer size in this PR

* Remove uncommented code

* Fix layout issues for data actions

* Added comment explaining retry
2023-09-11 16:11:22 +02:00
Eric Leijonmarck
394976bb6e
Service accounts: Fix mouse leave event by hide scrollbar in firefox and chrome (#74266)
fix: hide scrollbar in firefox and chrome for menu, due to mouse leave event
2023-09-08 07:40:18 +01:00
Ashley Harrison
ebe13a53f7
Browse Dashboards: Split new browse UI from nested folders backend (#74435)
* create new feature toggle + start to put stuff behind it

* block move, tidy up interfaces

* fix new/folder actions buttons

* show warning when deleting library panels/alert rules + run i18n:extract

* pseudo

* update unit tests

* pass alert in description
2023-09-07 11:41:00 +01:00
Ieva
d46208b28a
Chore: remove legacy AC fallback from frontend access control checks (#74385)
* don't use legacy AC fallback for frontend access control checks

* extend tests

* more test fixes

* more test fixes

* more test fixes

* final test fix

* team test fix

* finally fix tests
2023-09-06 16:07:49 +01:00
Eric Leijonmarck
87e8b654a2
Auth: Fix set basicrole to the previous role in UI on error from backend (#74395)
fix: onchange effect to set basicrole when error from backend
2023-09-05 18:44:57 +01:00
Ashley Harrison
e2724f39d9
Time Range: Using relative time takes timezone into account (#74013)
* account for timezone when using relative times
Co-authored-by: eledobleefe <laura.fernandez@grafana.com>
Co-authored-by: Joao Silva <joao.silva@grafana.com>
Co-authored-by: L-M-K-B <48948963+L-M-K-B@users.noreply.github.com>
Co-authored-by: joshhunt <josh@trtr.co>
Co-authored-by: tskarhed <1438972+tskarhed@users.noreply.github.com>

* keep as it was originally for now

* add e2e test for relative time zone overrides

* empty commit to add coauthors

Co-authored-by: eledobleefe <laura.fernandez@grafana.com>
Co-authored-by: Joao Silva <joao.silva@grafana.com>
Co-authored-by: L-M-K-B <48948963+L-M-K-B@users.noreply.github.com>
Co-authored-by: joshhunt <josh@trtr.co>
Co-authored-by: tskarhed <1438972+tskarhed@users.noreply.github.com>

* fix types

* switch to using table panel in e2e test

* use regex for partial text match

* actually go to the dashboard...

* use include.text

* check for visibility first

* try waiting on backend request to complete

* CI driven development is fun

* make sure we're waiting for both data query calls

* open dashboard instead

* kick drone

* Revert "open dashboard instead"

This reverts commit bab9c77c4d.

* check timezone second

* refactor to avoid detached elements

---------

Co-authored-by: eledobleefe <laura.fernandez@grafana.com>
Co-authored-by: Joao Silva <joao.silva@grafana.com>
Co-authored-by: L-M-K-B <48948963+L-M-K-B@users.noreply.github.com>
Co-authored-by: joshhunt <josh@trtr.co>
Co-authored-by: tskarhed <1438972+tskarhed@users.noreply.github.com>
2023-09-04 10:38:35 +01:00
Denny Chang
a90f3b58b5
i18n: Mark up HelpModal for translations (#73806)
* fix: i18n Help Modal

* fix: change translation modal to grafana-ui.modal

* fix: lint

* fix: by run yarn:i18n pseudo
2023-08-30 14:08:18 +01:00
Jev Forsberg
6f368d51fd
Transformations: Force QueryOperationRow to expand on showHelp click (#73958)
* baldm0mma/help_button/ force QueryOperationRow to expand on showHelp click

* baldm0mma/help_button/ remove comment

* baldm0mma/help_button/ add comment to onClose()

* baldm0mma/help_button/ remove useToggle for showing help

* baldm0mma/help_button/ remove comment

* baldm0mma/help_button/ update comment

* baldm0mma/help_button/ add full toggle control for parent of QueryOperationRow

* baldm0mma/help_button/ update inline comments

* baldm0mma/help_button/ update annos
2023-08-29 09:41:44 -06:00
Torkel Ödegaard
5bd58cac57
Eslint: Update grafana/eslint-config that allows public accessability modifier (#73906) 2023-08-28 14:57:49 +02:00
Ashley Harrison
1f49d480a8
Drawer: Clicking a Select arrow within a Drawer no longer causes it to close (#73557)
ensure drawer doesn't close when clicking dropdown arrow
2023-08-22 16:11:18 +01:00