Laura Benz
439dd062da
Explore: Add unit tests for addQueryRow() and generateEmptyQuery() ( #60977 )
...
* feat: add condition
* refactor: clea up
* refactor: remove changes and add my solution as comment
* feat: add test
* refactor: test preparation
* refactor: finish test prep and remove planned changed from addQueryRow()
* refactor: finish first test
* refactor: add required props after removing any (not complete)
* refactor: replace props and clean up
* refactor: add another test
* refactor: extend tests with datasourceInstance
* refactor: add test for mixed ds enabled
* refactor: remove typescript errors
* feat: add first attempt of a test for generateEmptyQuery()
* feat: setup first test for generateEmptyQuery()
* refactor: remove typescript errors
* feat: add another test for generateEmptyQuery()
* refactor: add some assertions
* refactor: restructure tests
* refactor: remove doubled code
* refactor: remove typescript errors
* refactor: remove mocking mistake and add test
* refactor: remove mocking mistakes
* refactor: repair mock for feature toggle
* refactor: clean up
* refactor: changes from code review
2023-01-31 10:13:08 +01:00
Adela Almasan
58c9618160
Canvas: Update connection info on element rename ( #62532 )
2023-01-30 22:36:57 -06:00
Adela Almasan
a92c081a33
Canvas: Connections positioning ux improvements ( #62516 )
2023-01-30 15:50:10 -06:00
Drew Slobodnjak
bf2cf76cad
Geomap: Maintain consistent control styling ( #62518 )
...
Co-authored-by: nmarrs <nathanielmarrs@gmail.com>
2023-01-30 13:11:58 -08:00
Jev Forsberg
c6f4eb4282
chore: remove unused css prop ( #62350 )
...
balm0mma/remUnusedCss/ remove unused css prop
2023-01-30 11:33:20 -07:00
Andreas Christou
3ac97dd396
TemplateVariables: Fix custom variable function support ( #62509 )
...
Validate query values
2023-01-30 17:49:16 +00:00
Andres Martinez Gotor
6d230d95eb
Azure Monitor: Enable multiple resource queries ( #62467 )
2023-01-30 17:19:03 +01:00
Ida Štambuk
f1a2a76897
Datasources: Use getDefaultQuery in annotations editors ( #61870 )
...
+ Add Cloudwatch default annotation
2023-01-30 16:45:03 +01:00
Gilles De Mey
702fd0f9e8
Docs: Update wording / text and copy ( #61868 )
...
Co-authored-by: brendamuir <100768211+brendamuir@users.noreply.github.com>
2023-01-30 15:26:21 +00:00
Konrad Lalik
7b47beef2f
Alerting: Add Rule UID and Clone button to the rule details page ( #62321 )
2023-01-30 16:02:01 +01:00
Joey Tawadrous
780f43a33d
Flame graph: Add metadata above flame graph ( #61921 )
...
* Remove percentTitle
* Flame graph metadata
* Remove comment
* Update test
* Update metadata
2023-01-30 14:02:26 +00:00
Ashley Harrison
f19b07c0bc
Accessibility: Remove unnecessary onClick from title element ( #59696 )
...
* remove unnecessary onClick from title element
* associate icon label with title + fix unit tests
* remove cursor: pointer;
* remove link color from title as it's no longer clickable
* remove useless aria-label
* stop incorrectly marking title as a ReactNode - it's just a string
2023-01-30 13:32:16 +00:00
Oscar Kilhed
0bfdc42ffe
Grafana DS: Limit dropzone to spreadsheet filetypes ( #62329 )
...
* Grafana DS: Limit dropzone to spreadsheet filetypes
2023-01-30 12:17:01 +01:00
Eric Leijonmarck
a232e7ceca
Auth: Add skip_org_role_sync for Okta ( #62106 )
...
* WIP
* Update pkg/services/login/authinfo.go
* fix: merge
* change order to internal last
* adds: docs
* add: configuration for defaults and sample
* Update docs/sources/setup-grafana/configure-grafana/_index.md
Co-authored-by: Jo <joao.guerreiro@grafana.com>
* Update docs/sources/setup-grafana/configure-grafana/_index.md
Co-authored-by: Christopher Moyer <35463610+chri2547@users.noreply.github.com>
---------
Co-authored-by: Jo <joao.guerreiro@grafana.com>
Co-authored-by: Christopher Moyer <35463610+chri2547@users.noreply.github.com>
2023-01-30 10:54:14 +00:00
Sven Grossmann
d7026900bd
LokiContext: Add feature tracking ( #62344 )
...
* add feature tracking to LokiContextUi
* only depend on `row.uid`
Co-authored-by: Gábor Farkas <gabor.farkas@gmail.com>
---------
Co-authored-by: Gábor Farkas <gabor.farkas@gmail.com>
2023-01-30 11:30:39 +01:00
Sonia Aguilar
d44f250aea
Alerting: Add export button for exporting all alert rules in alert list view ( #62416 )
...
* Add export button for exporting all alert rules in alert list view
* Add RBAC for export button
* Use provisioningPermissions.read in getRulesAccess method instead of directly using AccessControlAction.AlertingProvisioningRead
2023-01-30 11:13:08 +01:00
Ida Štambuk
a9d44aa795
Datasources: Add support for getDetDefaultQuery in variable editor ( #62026 )
...
+Cloudwatch implementation
2023-01-30 10:58:43 +01:00
Sven Grossmann
ae8c61c0b2
Logs: Fix stats not being updated when log results change ( #62317 )
...
update stats in logdetails
2023-01-30 10:54:20 +01:00
Josh Hunt
d51e7ec7ef
Preferences: Add theme preference to match system theme ( #61986 )
...
* user essentials mob! 🔱
lastFile:pkg/api/preferences.go
* user essentials mob! 🔱
* user essentials mob! 🔱
lastFile:packages/grafana-data/src/types/config.ts
* user essentials mob! 🔱
lastFile:public/app/core/services/echo/utils.test.ts
* user essentials mob! 🔱
* user essentials mob! 🔱
lastFile:public/views/index-template.html
* user essentials mob! 🔱
* Restore currentUser.lightTheme for backwards compat
* fix types
* Apply suggestions from code review
Co-authored-by: Christopher Moyer <35463610+chri2547@users.noreply.github.com>
* cleanup
* cleanup
---------
Co-authored-by: Ashley Harrison <ashley.harrison@grafana.com>
Co-authored-by: Joao Silva <joao.silva@grafana.com>
Co-authored-by: Christopher Moyer <35463610+chri2547@users.noreply.github.com>
2023-01-30 10:51:51 +01:00
Andres Martinez Gotor
be7b90bbd1
Azure Monitor: Add info about multiple resource selection ( #62327 )
2023-01-30 10:49:57 +01:00
Andres Martinez Gotor
bed1bb1a73
Azure Monitor: Allow to specify a region when listing resources ( #62306 )
...
* Azure Monitor: Allow to specify a region when listing resources
* Add region template variable to e2e tests
2023-01-30 10:49:20 +01:00
Sven Grossmann
da7065d3dc
LokiContext: Fix wrong queries being run when reopened ( #62353 )
...
* fix wrong query being run when reopened
* fix typo
Co-authored-by: Ivana Huckova <30407135+ivanahuckova@users.noreply.github.com>
* and test for `onClose`
* rename functions
---------
Co-authored-by: Ivana Huckova <30407135+ivanahuckova@users.noreply.github.com>
2023-01-30 09:26:27 +01:00
Levente Balogh
9b2abe7613
Datasources: Extend properties for the datasource-test tracking event ( #62292 )
...
chore: extend properties for the test datasource tracking event
2023-01-30 08:29:13 +01:00
Ryan McKinley
0d2a786816
Schema: Add schema for library panels ( #62169 )
2023-01-30 04:14:12 +00:00
Gilles De Mey
13159d03ba
Alerting: Use optional chaining for accessing frames ( #61814 )
2023-01-28 18:39:23 +01:00
Josh Hunt
6c990b461e
SupportBundles: Feature flag + access control navtree item ( #62337 )
...
* SupportBundles: Feature flag + access control navtree item
* remove translation
2023-01-27 20:04:04 +00:00
Drew Slobodnjak
07dc994765
Canvas: Anchor highlight persistance ( #62364 )
...
* Canvas: Anchor highlight persistance
* Update public/app/plugins/panel/canvas/ConnectionAnchors.tsx
Co-authored-by: Nathan Marrs <nathanielmarrs@gmail.com>
* Fix CONNECTION_ANCHOR_ALT dependencies
* Simplify anchor type assertion logic
* Ensure that anchor highlight is reset when anchors are hidden
* Add helpful comment on return bool of function
---------
Co-authored-by: Nathan Marrs <nathanielmarrs@gmail.com>
2023-01-27 11:35:57 -08:00
Gareth Dawson
b2c8126e6e
Loki: Show query size approximation ( #62109 )
...
* feat: make api request to /loki/api/v1/index/stats
* fix: add /index/stats to callResource valid urls
* feat: make call to getQueryStats when the query changes
* feat: render user tooltip displaying the estimated value for processed data
* fix: add new props to component tests
* test: add tests for query size estimation
* fix: disable error message on request failure
* refactor: add suggestions from code review
* refactor: only pass required query string
2023-01-27 17:32:53 +00:00
Galen Kistler
5ad7cca9d4
Prometheus: Fix "-Instant" string showing up in prometheus instant query UI ( #62265 )
...
Add string constant and make sure to remove from name before outputting to frontend
2023-01-27 10:40:12 -06:00
Ivana Huckova
d5294eb8fa
Explore: Implement feature toggle for logs sample ( #62291 )
...
* Explore: Implement feature toggle for logs sample
* Run pkg/services/featuremgmt/toggles_gen_test.go
* Remove boolean
* Update copy
2023-01-27 17:30:25 +01:00
Ashley Harrison
1ef7cfda3f
Navigation: more command palette tweaks ( #62286 )
...
* update placeholder text, only create search keybindings if topNavCommandPalette is disabled
* make search input wider
2023-01-27 16:21:48 +00:00
Josh Hunt
305209f4be
CommandPalette: Render dashboard + nav actions as links ( #62315 )
...
* CommandPalette: Render links as links!
* Update public/app/features/commandPalette/KBarResults.tsx
Co-authored-by: Ashley Harrison <ashley.harrison@grafana.com>
* Apply suggestions from code review
Co-authored-by: Ashley Harrison <ashley.harrison@grafana.com>
* fix ellipsis showing
---------
Co-authored-by: Ashley Harrison <ashley.harrison@grafana.com>
2023-01-27 16:10:05 +00:00
Ivana Huckova
d0e95f8c95
Loki: Add X-Query-Tags header for logs sample and data sample ( #62333 )
2023-01-27 16:41:40 +01:00
Levente Balogh
9453bec819
FileDropzone: Revert introducing a new prop ( #62324 )
2023-01-27 16:40:54 +01:00
Andres Martinez Gotor
317ef1de86
Azure Monitor: Add variable function to list regions ( #62297 )
2023-01-27 16:29:05 +01:00
Gábor Farkas
88119ad6c3
Elasticsearch: Support nested aggregation ( #62301 )
...
* Add nested query support
* Add nested support for alerts
* update nested aggregation
* cleanup types
* Add nested integration test
* Move aggdef to nested
* fixed merge conflict
* fixed lint warning
* mark nested-mode experimental
---------
Co-authored-by: Ethan Gallant <ethan@ziax.com>
Co-authored-by: Ethan J. Gallant <ethan.gallant@acquia.com>
2023-01-27 16:18:36 +01:00
Dominik Prokop
83199c4bf5
Dashboard schema: Review and mature timezone property ( #62090 )
...
* Review and mature timezone property of Dashboard kind
* Update timezone type
2023-01-27 07:13:33 -08:00
Sven Grossmann
df2db3bb23
LogContext: Fix setting wrong height for ElasticSearch ( #62330 )
...
fix wrong height for elastic
2023-01-27 15:41:16 +01:00
Andre Pereira
afd39c18ba
Explore: Refactor trace view and move to core ( #61938 )
...
* Move TraceView to core grafana
* Remove unused code
* yarn install
* Remove jaeger-ui-components from CODEOWNERS and other tools
* Type fixes
* yarn install
* Remove mock that we no longer need
* Fix merge conflicts
* Re-add Apache license for trace view components
* Use an exclamation-circle instead of triangle to denote errors
* Remove eslint disables and update betterer results instead
2023-01-27 14:13:17 +00:00
Sven Grossmann
7c02d9bb8a
Logs: Add experimental support to display a datasource custom UI in LogContext ( #62189 )
...
* add loki contextfilter component
* add `getLogRowContextUi` support to DataSourceAPI
* add `runContextQuery` to LogRowContextProvider
* pass `getRowContextUi` to `LogRowContext`
* adapt LogRowContext to show datasource ui
* implement LogRowContextUi in Loki
* add `logsContextDatasourceUi` feature flag
* change state to `Alpha`
* disable the feature if `logsContextDatasourceUi` is not set
* don't fetch labels in the constructor
* adjust to right height
* remove unnecessary eslint disable
* add test for LokiContextUi
* move code down in datasource.ts
* rename `refresh` to `runContextQuery`
* update datasource tests
* don't update if `updateFilter` fn changes
* organized imports in datasource.test.ts
* don't trigger on intialization changes
* change tag to `experimental`
* move `getLogRowContextUi` to props
2023-01-27 15:12:01 +01:00
Giuseppe Guerra
af1e2d68da
Plugins: Allow loading panel plugins from a CDN ( #59096 )
...
* POC: Plugins CDN reverse proxy
* CDN proxy POC: changed env var names
* Add authorization: false for /public path in frontend plugin loader
* Moved CDN settings to Cfg, add some comments
* Fix error 500 in asset fetch if plugin is not using CDN
* Fix EnterpriseLicensePath declared twice
* Fix linter complaining about whitespaces
* Plugins CDN: Skip signature verification for CDN plugins
* Plugins CDN: Skip manifest and signature check for cdn plugins
* Plugins: use IsValid() and IsInternal() rather than equality checks
* Plugins CDN: remove comment
* Plugins CDN: Fix seeker can't seek when serving plugins from local fs
* Plugins CDN: add back error codes in getLocalPluginAssets
* Plugins CDN: call asset.Close() rather than asset.readSeekCloser.Close()
* Plugins CDN: Fix panic in JsonApiErr when errorMessageCoder wraps a nil error
* Plugins CDN: Add error handling to proxyCDNPluginAsset
* Plugins CDN: replace errorMessageCoder with errutil
* Plugins CDN POC: expose cdn plugin paths to frontend for system.js
* Plugins CDN: Fix cdn plugins showing as unsigned in frontend
* WIP: Add support for formatted URL
* Fix missing cdnPluginsBaseURLs in GrafanaConfig
* Plugins CDN: Remove reverse proxy mode and reverse proxy references
* Plugins CDN: Simplify asset serving logic
* Plugins CDN: sanitize redirect path
* Plugins CDN: Removed unused pluginAsset type
* Plugins CDN: Removed system.js changes
* Plugins CDN: Return different system.js baseURL and module for cdn plugins
* Plugins CDN: Ensure CDN is disabled for non-external plugins
* lint
* Plugins CDN: serve images and screenshots from CDN, refactoring
* Lint
* Plugins CDN: Fix URLs for system.js (baseUrl and module)
* Plugins CDN: Add more tests for RelativeURLForSystemJS
* Plugins CDN: Iterate only on apps when preloading
* Plugins CDN: Refactoring
* Plugins CDN: Add comments to url_constructor.go
* Plugins CDN: Update defaultHGPluginsCDNBaseURL
* Plugins CDN: undo extract meta from system js config
* refactor(plugins): migrate systemjs css plugin to typescript
* feat(plugins): introduce systemjs cdn loader plugin
* feat(plugins): add systemjs load type
* Plugins CDN: Removed RelativeURLForSystemJS
* Plugins CDN: Log backend redirect hits along with plugin info
* Plugins CDN: Add pluginsCDNBasePath to getFrontendSettingsMap
* feat(plugins): introduce cdn loading for angular plugins
* refactor(plugins): move systemjs cache buster into systemjsplugins directory
* Plugins CDN: Rename pluginsCDNBasePath to pluginsCDNBaseURL
* refactor(plugins): introduce pluginsCDNBaseURL to the frontend
* Plugins CDN: Renamed "cdn base path" to "cdn url template" in backend
* Plugins CDN: lint
* merge with main
* Instrumentation: Add prometheus counter for backend hits, log from Info to Warn
* Config: Changed key from plugins_cdn.url to plugins.plugins_cdn_base_url
* CDN: Add backend tests
* Lint: goimports
* Default CDN URL to empty string,
* Do not use CDN in setImages and module if the url template is empty
* CDN: Backend: Add test for frontend settings
* CDN: Do not log missing module.js warn if plugin is being loaded from CDN
* CDN: Add backend test for CDN plugin loader
* Removed 'cdn' signature level, switch to 'valid'
* Fix pfs.TestParseTreeTestdata for cdn plugin testdata dir
* Fix TestLoader_Load
* Fix gocyclo complexity of loadPlugins
* Plugins CDN: Moved prometheus metric to api package, removed asset_path label
* Fix missing in config
* Changes after review
* Add pluginscdn.Service
* Fix tests
* Refactoring
* Moved all remaining CDN checks inside pluginscdn.Service
* CDN url constructor: Renamed stringURLFor to stringPath
* CDN: Moved asset URL functionality to assetpath service
* CDN: Renamed HasCDN() to IsEnabled()
* CDN: Replace assert with require
* CDN: Changes after review
* Assetpath: Handle url.Parse error
* Fix plugin_resource_test
* CDN: Change fallback redirect from 302 to 307
* goimports
* Fix tests
* Switch to contextmodel.ReqContext in plugins.go
Co-authored-by: Will Browne <will.browne@grafana.com>
Co-authored-by: Jack Westbrook <jack.westbrook@gmail.com>
2023-01-27 15:08:17 +01:00
Joey Tawadrous
591501ef3f
Traces: Upgraded feature tracking ( #62181 )
...
Upgraded feature tracking
2023-01-27 13:33:27 +00:00
Gilles De Mey
54ff88463c
Alerting: remove link to Grafana University ( #62318 )
2023-01-27 08:21:47 -05:00
Yaelle Chaudy
3281eb9223
[Navigation] Add user events for quick actions/dashboard actions ( #62220 )
...
Add fe events for quick actions/dashboard actions
2023-01-27 14:11:17 +01:00
Victor Marin
846acd28ff
StateTimeline: Show correct legend label when value mappings set ( #62282 )
...
* StateTimeline: Show correct legend label when value mappings set
* Add test dashboard for thresholds and value mappings
* run stripnulls.sh
2023-01-27 14:30:42 +02:00
Torkel Ödegaard
bfcf936c38
QueryEditorRows: Remove double callback from onDataSourceChange ( #62172 )
...
* QueryEditorRows: Remove double callbacked from onDataSourceChange
* A few more updates
* Updated
2023-01-27 13:30:12 +01:00
Oscar Kilhed
dab3fac01b
Grafana DS: Fix dropzone showing upload file even if there is a file ( #62200 )
...
* Grafana DS: Fix dropzone showing upload file even if there is a file
2023-01-27 11:51:10 +00:00
Josh Hunt
960307e938
Search: Remember sorting preference between visits ( #62248 )
...
Search: Remember sort option between uses
2023-01-27 11:00:28 +00:00
Torkel Ödegaard
4deb10888e
Revert "Transforms: Add join by fields" ( #62278 )
2023-01-27 11:58:18 +01:00
Victor Marin
1464dd4095
Re-add RowHeight option to StatusHistory ( #62293 )
2023-01-27 12:52:32 +02:00