mirror of
https://github.com/grafana/grafana.git
synced 2025-01-09 15:43:23 -06:00
04b3afcd15
Since we do not like some of the default golint rules, this commit proposes to use https://github.com/mgechev/revive. And potential revive speed-up should't hurt :). Right now, presented config (./conf/revive.toml) is permissive, we might improve it over time however. Fixes for found revive issues in the code are very limited so it wouldn't be large to review. Also in this commit: * Add annotations for makefile commands and declare phony targets * Rename "gometalinter" script and CI command to "lint" since we are doing there a bit more then using gometalinter package * Add Makefile rules to .editorconfig * Documentation which mentioned "golint" replaced with revive Fixes #16109 Ref #16160
36 lines
964 B
Bash
Executable File
36 lines
964 B
Bash
Executable File
#!/bin/bash
|
|
|
|
function exit_if_fail {
|
|
command=$@
|
|
echo "Executing '$command'"
|
|
eval $command
|
|
rc=$?
|
|
if [ $rc -ne 0 ]; then
|
|
echo "'$command' returned $rc."
|
|
exit $rc
|
|
fi
|
|
}
|
|
|
|
go get -u github.com/alecthomas/gometalinter
|
|
go get -u github.com/tsenart/deadcode
|
|
go get -u github.com/jgautheron/goconst/cmd/goconst
|
|
go get -u github.com/gordonklaus/ineffassign
|
|
go get -u github.com/opennota/check/cmd/structcheck
|
|
go get -u github.com/mdempsky/unconvert
|
|
go get -u github.com/opennota/check/cmd/varcheck
|
|
go get -u honnef.co/go/tools/cmd/staticcheck
|
|
go get -u github.com/mgechev/revive
|
|
|
|
exit_if_fail gometalinter --enable-gc --vendor --deadline 10m --disable-all \
|
|
--enable=deadcode \
|
|
--enable=goconst \
|
|
--enable=gofmt \
|
|
--enable=ineffassign \
|
|
--enable=structcheck \
|
|
--enable=unconvert \
|
|
--enable=varcheck \
|
|
--enable=staticcheck
|
|
|
|
exit_if_fail go vet ./pkg/...
|
|
exit_if_fail revive -formatter stylish -config ./conf/revive.toml
|