mirror of
https://github.com/grafana/grafana.git
synced 2024-11-28 11:44:26 -06:00
d9cdcb550e
* Chore: Refactor api handlers to use web.Bind * fix comments * fix comment * trying to fix most of the tests and force routing.Wrap type check * fix library panels tests * fix frontend logging tests * allow passing nil as a response to skip writing * return nil instead of the response * rewrite login handler function types * remove handlerFuncCtx * make linter happy * remove old bindings from the libraryelements * restore comments
79 lines
2.2 KiB
Go
79 lines
2.2 KiB
Go
package api
|
|
|
|
import (
|
|
"errors"
|
|
"fmt"
|
|
"net/http"
|
|
"path"
|
|
"strings"
|
|
|
|
"github.com/grafana/grafana/pkg/api/dtos"
|
|
"github.com/grafana/grafana/pkg/api/response"
|
|
"github.com/grafana/grafana/pkg/models"
|
|
"github.com/grafana/grafana/pkg/setting"
|
|
"github.com/grafana/grafana/pkg/util"
|
|
"github.com/grafana/grafana/pkg/web"
|
|
)
|
|
|
|
// createShortURL handles requests to create short URLs.
|
|
func (hs *HTTPServer) createShortURL(c *models.ReqContext) response.Response {
|
|
cmd := dtos.CreateShortURLCmd{}
|
|
if err := web.Bind(c.Req, &cmd); err != nil {
|
|
return response.Error(http.StatusBadRequest, "bad request data", err)
|
|
}
|
|
hs.log.Debug("Received request to create short URL", "path", cmd.Path)
|
|
|
|
cmd.Path = strings.TrimSpace(cmd.Path)
|
|
|
|
if path.IsAbs(cmd.Path) {
|
|
hs.log.Error("Invalid short URL path", "path", cmd.Path)
|
|
return response.Error(400, "Path should be relative", nil)
|
|
}
|
|
if strings.Contains(cmd.Path, "../") {
|
|
hs.log.Error("Invalid short URL path", "path", cmd.Path)
|
|
return response.Error(400, "Invalid path", nil)
|
|
}
|
|
|
|
shortURL, err := hs.ShortURLService.CreateShortURL(c.Req.Context(), c.SignedInUser, cmd.Path)
|
|
if err != nil {
|
|
return response.Error(500, "Failed to create short URL", err)
|
|
}
|
|
|
|
url := fmt.Sprintf("%s/goto/%s?orgId=%d", strings.TrimSuffix(setting.AppUrl, "/"), shortURL.Uid, c.OrgId)
|
|
c.Logger.Debug("Created short URL", "url", url)
|
|
|
|
dto := dtos.ShortURL{
|
|
UID: shortURL.Uid,
|
|
URL: url,
|
|
}
|
|
|
|
return response.JSON(200, dto)
|
|
}
|
|
|
|
func (hs *HTTPServer) redirectFromShortURL(c *models.ReqContext) {
|
|
shortURLUID := web.Params(c.Req)[":uid"]
|
|
|
|
if !util.IsValidShortUID(shortURLUID) {
|
|
return
|
|
}
|
|
|
|
shortURL, err := hs.ShortURLService.GetShortURLByUID(c.Req.Context(), c.SignedInUser, shortURLUID)
|
|
if err != nil {
|
|
if errors.Is(err, models.ErrShortURLNotFound) {
|
|
hs.log.Debug("Not redirecting short URL since not found")
|
|
return
|
|
}
|
|
|
|
hs.log.Error("Short URL redirection error", "err", err)
|
|
return
|
|
}
|
|
|
|
// Failure to update LastSeenAt should still allow to redirect
|
|
if err := hs.ShortURLService.UpdateLastSeenAt(c.Req.Context(), shortURL); err != nil {
|
|
hs.log.Error("Failed to update short URL last seen at", "error", err)
|
|
}
|
|
|
|
hs.log.Debug("Redirecting short URL", "path", shortURL.Path)
|
|
c.Redirect(setting.ToAbsUrl(shortURL.Path), 302)
|
|
}
|