mirror of
https://github.com/grafana/grafana.git
synced 2025-02-25 18:55:37 -06:00
105313f5c2
* add action set resolver * rename variables * some fixes and some tests * more tests * more tests, and put action set storing behind a feature toggle * undo change from cfg to feature mgmt - will cover it in a separate PR due to the amount of test changes * fix dependency cycle, update some tests * add one more test * fix for feature toggle check not being set on test configs * linting fixes * check that action set name can be split nicely * clean up tests by turning GetActionSetNames into a function * undo accidental change * test fix * more test fixes
87 lines
2.9 KiB
Go
87 lines
2.9 KiB
Go
package acimpl
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
|
|
"github.com/prometheus/client_golang/prometheus"
|
|
|
|
"github.com/grafana/grafana/pkg/infra/log"
|
|
"github.com/grafana/grafana/pkg/infra/metrics"
|
|
"github.com/grafana/grafana/pkg/services/accesscontrol"
|
|
"github.com/grafana/grafana/pkg/services/auth/identity"
|
|
"github.com/grafana/grafana/pkg/services/featuremgmt"
|
|
"github.com/grafana/grafana/pkg/setting"
|
|
)
|
|
|
|
var _ accesscontrol.AccessControl = new(AccessControl)
|
|
|
|
func ProvideAccessControl(cfg *setting.Cfg) *AccessControl {
|
|
logger := log.New("accesscontrol")
|
|
return &AccessControl{
|
|
cfg, logger, accesscontrol.NewResolvers(logger),
|
|
}
|
|
}
|
|
|
|
type AccessControl struct {
|
|
cfg *setting.Cfg
|
|
log log.Logger
|
|
resolvers accesscontrol.Resolvers
|
|
}
|
|
|
|
func (a *AccessControl) Evaluate(ctx context.Context, user identity.Requester, evaluator accesscontrol.Evaluator) (bool, error) {
|
|
timer := prometheus.NewTimer(metrics.MAccessEvaluationsSummary)
|
|
defer timer.ObserveDuration()
|
|
metrics.MAccessEvaluationCount.Inc()
|
|
|
|
if user == nil || user.IsNil() {
|
|
a.log.Warn("No entity set for access control evaluation")
|
|
return false, nil
|
|
}
|
|
|
|
// If the user is in no organization, then the evaluation must happen based on the user's global permissions
|
|
permissions := user.GetPermissions()
|
|
if user.GetOrgID() == accesscontrol.NoOrgID {
|
|
permissions = user.GetGlobalPermissions()
|
|
}
|
|
if len(permissions) == 0 {
|
|
a.debug(ctx, user, "No permissions set", evaluator)
|
|
return false, nil
|
|
}
|
|
|
|
// TODO update this to use featuremgmt.FeatureToggles instead of checking the config
|
|
if a.cfg != nil && a.cfg.IsFeatureToggleEnabled != nil && a.cfg.IsFeatureToggleEnabled(featuremgmt.FlagAccessActionSets) {
|
|
evaluator = evaluator.AppendActionSets(ctx, a.resolvers.GetActionSetResolver())
|
|
}
|
|
|
|
a.debug(ctx, user, "Evaluating permissions", evaluator)
|
|
// Test evaluation without scope resolver first, this will prevent 403 for wildcard scopes when resource does not exist
|
|
if evaluator.Evaluate(permissions) {
|
|
return true, nil
|
|
}
|
|
|
|
resolvedEvaluator, err := evaluator.MutateScopes(ctx, a.resolvers.GetScopeAttributeMutator(user.GetOrgID()))
|
|
if err != nil {
|
|
if errors.Is(err, accesscontrol.ErrResolverNotFound) {
|
|
return false, nil
|
|
}
|
|
return false, err
|
|
}
|
|
|
|
a.debug(ctx, user, "Evaluating resolved permissions", resolvedEvaluator)
|
|
return resolvedEvaluator.Evaluate(permissions), nil
|
|
}
|
|
|
|
func (a *AccessControl) RegisterScopeAttributeResolver(prefix string, resolver accesscontrol.ScopeAttributeResolver) {
|
|
a.resolvers.AddScopeAttributeResolver(prefix, resolver)
|
|
}
|
|
|
|
func (a *AccessControl) RegisterActionResolver(resolver accesscontrol.ActionResolver) {
|
|
a.resolvers.SetActionResolver(resolver)
|
|
}
|
|
|
|
func (a *AccessControl) debug(ctx context.Context, ident identity.Requester, msg string, eval accesscontrol.Evaluator) {
|
|
namespace, id := ident.GetNamespacedID()
|
|
a.log.FromContext(ctx).Debug(msg, "namespace", namespace, "id", id, "orgID", ident.GetOrgID(), "permissions", eval.GoString())
|
|
}
|