mirror of
https://github.com/grafana/grafana.git
synced 2024-11-23 09:26:43 -06:00
986b766ca0
* rewrite eslint test to not care about position of errors * changing file contents shouldn't require a betterer.results update * fix up eslint test * fix the undocumented stories test * ignore .test.ts files as well
70 lines
2.3 KiB
TypeScript
70 lines
2.3 KiB
TypeScript
import { regexp } from '@betterer/regexp';
|
|
import { BettererFileTest } from '@betterer/betterer';
|
|
import { ESLint, Linter } from 'eslint';
|
|
import { existsSync } from 'fs';
|
|
|
|
export default {
|
|
'no enzyme tests': () => regexp(/from 'enzyme'/g).include('**/*.test.*'),
|
|
'better eslint': () => countEslintErrors().include('**/*.{ts,tsx}'),
|
|
'no undocumented stories': () => countUndocumentedStories().include('**/*.story.tsx'),
|
|
};
|
|
|
|
function countUndocumentedStories() {
|
|
return new BettererFileTest(async (filePaths, fileTestResult) => {
|
|
filePaths.forEach((filePath) => {
|
|
if (!existsSync(filePath.replace(/\.story.tsx$/, '.mdx'))) {
|
|
// In this case the file contents don't matter:
|
|
const file = fileTestResult.addFile(filePath, '');
|
|
// Add the issue to the first character of the file:
|
|
file.addIssue(0, 0, 'No undocumented stories are allowed, please add an .mdx file with some documentation');
|
|
}
|
|
});
|
|
});
|
|
}
|
|
|
|
function countEslintErrors() {
|
|
return new BettererFileTest(async (filePaths, fileTestResult, resolver) => {
|
|
const { baseDirectory } = resolver;
|
|
const cli = new ESLint({ cwd: baseDirectory });
|
|
|
|
await Promise.all(
|
|
filePaths.map(async (filePath) => {
|
|
const linterOptions = (await cli.calculateConfigForFile(filePath)) as Linter.Config;
|
|
|
|
const rules: Partial<Linter.RulesRecord> = {
|
|
'@typescript-eslint/no-explicit-any': 'error',
|
|
};
|
|
|
|
if (!filePath.endsWith('.test.tsx') && !filePath.endsWith('.test.ts')) {
|
|
rules['@typescript-eslint/consistent-type-assertions'] = [
|
|
'error',
|
|
{
|
|
assertionStyle: 'never',
|
|
},
|
|
];
|
|
}
|
|
|
|
const runner = new ESLint({
|
|
baseConfig: {
|
|
...linterOptions,
|
|
rules,
|
|
},
|
|
useEslintrc: false,
|
|
cwd: baseDirectory,
|
|
});
|
|
|
|
const lintResults = await runner.lintFiles([filePath]);
|
|
lintResults
|
|
.filter((lintResult) => lintResult.source)
|
|
.forEach((lintResult) => {
|
|
const { messages } = lintResult;
|
|
const file = fileTestResult.addFile(filePath, '');
|
|
messages.forEach((message, index) => {
|
|
file.addIssue(0, 0, message.message, `${index}`);
|
|
});
|
|
});
|
|
})
|
|
);
|
|
});
|
|
}
|