grafana/public/app/features/panel/state/reducers.ts
Torkel Ödegaard d62ca1283c
PanelState: Introduce a new separate redux panel state not keyed by panel.id (#40302)
* Initial pass to move panel state to it's own, and make it by key not panel.id

* Progress

* Not making much progress, having panel.key be mutable is causing a lot of issues

* Think this is starting to work

* Began fixing tests

* Add selector

* Bug fixes and changes to cleanup, and fixing all flicking when switching library panels

* Removed console.log

* fixes after merge

* fixing tests

* fixing tests

* Added new test for changePlugin thunk
2021-10-13 08:53:36 +02:00

79 lines
2.2 KiB
TypeScript

import { createSlice, Draft, PayloadAction } from '@reduxjs/toolkit';
import { AngularComponent } from '@grafana/runtime';
import { PanelPlugin } from '@grafana/data';
export type RootPanelsState = Record<string, PanelState>;
export interface PanelState {
plugin?: PanelPlugin;
angularComponent?: AngularComponent;
instanceState?: any | null;
}
export const initialState: RootPanelsState = {};
const panelsSlice = createSlice({
name: 'panels',
initialState,
reducers: {
panelModelAndPluginReady: (state, action: PayloadAction<PanelModelAndPluginReadyPayload>) => {
if (action.payload.cleanUpKey) {
cleanUpAngularComponent(state[action.payload.cleanUpKey]);
delete state[action.payload.cleanUpKey];
}
state[action.payload.key] = {
plugin: action.payload.plugin,
};
},
cleanUpPanelState: (state, action: PayloadAction<{ key: string }>) => {
cleanUpAngularComponent(state[action.payload.key]);
delete state[action.payload.key];
},
setPanelInstanceState: (state, action: PayloadAction<SetPanelInstanceStatePayload>) => {
state[action.payload.key].instanceState = action.payload.value;
},
setPanelAngularComponent: (state, action: PayloadAction<SetPanelAngularComponentPayload>) => {
const panelState = state[action.payload.key];
cleanUpAngularComponent(panelState);
panelState.angularComponent = action.payload.angularComponent;
},
},
});
function cleanUpAngularComponent(panelState?: Draft<PanelState>) {
if (panelState?.angularComponent) {
panelState.angularComponent.destroy();
}
}
export interface PanelModelAndPluginReadyPayload {
key: string;
plugin: PanelPlugin;
/** Used to cleanup previous state when we change key (used when switching panel plugin) */
cleanUpKey?: string;
}
export interface SetPanelAngularComponentPayload {
key: string;
angularComponent: AngularComponent;
}
export interface SetPanelInstanceStatePayload {
key: string;
value: any;
}
export const {
panelModelAndPluginReady,
setPanelAngularComponent,
setPanelInstanceState,
cleanUpPanelState,
} = panelsSlice.actions;
export const panelsReducer = panelsSlice.reducer;
export default {
panels: panelsReducer,
};