mirror of
https://github.com/grafana/grafana.git
synced 2025-02-25 18:55:37 -06:00
04b3afcd15
Since we do not like some of the default golint rules, this commit proposes to use https://github.com/mgechev/revive. And potential revive speed-up should't hurt :). Right now, presented config (./conf/revive.toml) is permissive, we might improve it over time however. Fixes for found revive issues in the code are very limited so it wouldn't be large to review. Also in this commit: * Add annotations for makefile commands and declare phony targets * Rename "gometalinter" script and CI command to "lint" since we are doing there a bit more then using gometalinter package * Add Makefile rules to .editorconfig * Documentation which mentioned "golint" replaced with revive Fixes #16109 Ref #16160
28 lines
579 B
TOML
28 lines
579 B
TOML
ignoreGeneratedHeader = false
|
|
severity = "error"
|
|
confidence = 0.8
|
|
errorCode = 0
|
|
|
|
[rule.context-as-argument]
|
|
[rule.error-return]
|
|
[rule.package-comments]
|
|
[rule.range]
|
|
[rule.superfluous-else]
|
|
[rule.modifies-parameter]
|
|
|
|
# This can be checked by other tools like megacheck
|
|
[rule.unreachable-code]
|
|
|
|
# Those are probably should be enabled at some point
|
|
# [rule.unexported-return]
|
|
# [rule.exported]
|
|
# [rule.var-naming]
|
|
# [error-naming]
|
|
# [rule.dot-imports]
|
|
# [blank-imports]
|
|
# [rule.receiver-naming]
|
|
# [error-strings]
|
|
# [rule.if-return]
|
|
# [rule.indent-error-flow]
|
|
# [rule.blank-imports]
|