grafana/.github
Michael Mandrus 5626461b3c
Caching: Refactor enterprise query caching middleware to a wire service (#65616)
* define initial service and add to wire

* update caching service interface

* add skipQueryCache header handler and update metrics query function to use it

* add caching service as a dependency to query service

* working caching impl

* propagate cache status to frontend in response

* beginning of improvements suggested by Lean - separate caching logic from query logic.

* more changes to simplify query function

* Decided to revert renaming of function

* Remove error status from cache request

* add extra documentation

* Move query caching duration metric to query package

* add a little bit of documentation

* wip: convert resource caching

* Change return type of query service QueryData to a QueryDataResponse with Headers

* update codeowners

* change X-Cache value to const

* use resource caching in endpoint handlers

* write resource headers to response even if it's not a cache hit

* fix panic caused by lack of nil check

* update unit test

* remove NONE header - shouldn't show up in OSS

* Convert everything to use the plugin middleware

* revert a few more things

* clean up unused vars

* start reverting resource caching, start to implement in plugin middleware

* revert more, fix typo

* Update caching interfaces - resource caching now has a separate cache method

* continue wiring up new resource caching conventions - still in progress

* add more safety to implementation

* remove some unused objects

* remove some code that I left in by accident

* add some comments, fix codeowners, fix duplicate registration

* fix source of panic in resource middleware

* Update client decorator test to provide an empty response object

* create tests for caching middleware

* fix unit test

* Update pkg/services/caching/service.go

Co-authored-by: Arati R. <33031346+suntala@users.noreply.github.com>

* improve error message in error log

* quick docs update

* Remove use of mockery. Update return signature to return an explicit hit/miss bool

* create unit test for empty request context

* rename caching metrics to make it clear they pertain to caching

* Update pkg/services/pluginsintegration/clientmiddleware/caching_middleware.go

Co-authored-by: Marcus Efraimsson <marcus.efraimsson@gmail.com>

* Add clarifying comments to cache skip middleware func

* Add comment pointing to the resource cache update call

* fix unit tests (missing dependency)

* try to fix mystery syntax error

* fix a panic

* Caching: Introduce feature toggle to caching service refactor (#66323)

* introduce new feature toggle

* hide calls to new service behind a feature flag

* remove licensing flag from toggle (misunderstood what it was for)

* fix unit tests

* rerun toggle gen

---------

Co-authored-by: Arati R. <33031346+suntala@users.noreply.github.com>
Co-authored-by: Marcus Efraimsson <marcus.efraimsson@gmail.com>
2023-04-12 12:30:33 -04:00
..
ISSUE_TEMPLATE chore: minor update to feature request description (#65112) 2023-03-21 14:46:59 +00:00
workflows Bump grafana/code-coverage from 0.1.18 to 0.1.19 (#65308) 2023-04-12 08:42:17 +00:00
bot.md Chore: Move from master to main branch (#33693) 2021-05-06 16:29:29 +02:00
CODEOWNERS Caching: Refactor enterprise query caching middleware to a wire service (#65616) 2023-04-12 12:30:33 -04:00
commands.json chore: automatically add relevant items to dataviz / bi projects (#65882) 2023-04-04 08:54:09 -07:00
dependabot.yml Configure Renovate (#40336) 2021-10-13 12:25:12 +01:00
issue-opened.json GHActions: move new 'opened' action to separate workflow (#63228) 2023-02-10 07:27:28 -10:00
metrics-collector.json GHActions: add issue type to each query (#63972) 2023-03-02 09:00:30 -10:00
pr-checks.json Chore: Add PR Check action enforcing changelog decision (#48728) 2022-05-05 11:38:46 +02:00
pr-commands.json Add to Docs squad project when PRs are labelled with type/docs (#64285) 2023-03-07 10:53:03 +00:00
PULL_REQUEST_TEMPLATE.md Remove two PR reviewer checklist items (#65290) 2023-04-03 09:13:56 -06:00
renovate.json5 Chore: Upgrade to react 18 (#64428) 2023-04-11 10:51:54 +01:00
teams.yml Add GH action to automatically add issue labeled to GH board (#54151) 2022-08-24 16:20:10 +02:00