mirror of
https://github.com/grafana/grafana.git
synced 2025-02-15 01:53:33 -06:00
* Add actions and scopes * add resource service for dashboard and folder * Add dashboard guardian with fgac permission evaluation * Add CanDelete function to guardian interface * Add CanDelete property to folder and dashboard dto and set values * change to correct function name * Add accesscontrol to folder endpoints * add access control to dashboard endpoints * check access for nav links * Add fixed roles for dashboard and folders * use correct package * add hack to override guardian Constructor if accesscontrol is enabled * Add services * Add function to handle api backward compatability * Add permissionServices to HttpServer * Set permission when new dashboard is created * Add default permission when creating new dashboard * Set default permission when creating folder and dashboard * Add access control filter for dashboard search * Add to accept list * Add accesscontrol to dashboardimport * Disable access control in tests * Add check to see if user is allow to create a dashboard * Use SetPermissions * Use function to set several permissions at once * remove permissions for folder and dashboard on delete * update required permission * set permission for provisioning * Add CanCreate to dashboard guardian and set correct permisisons for provisioning * Dont set admin on folder / dashboard creation * Add dashboard and folder permission migrations * Add tests for CanCreate * Add roles and update descriptions * Solve uid to id for dashboard and folder permissions * Add folder and dashboard actions to permission filter * Handle viewer_can_edit flag * set folder and dashboard permissions services * Add dashboard permissions when importing a new dashboard * Set access control permissions on provisioning * Pass feature flags and only set permissions if access control is enabled * only add default permissions for folders and dashboards without folders * Batch create permissions in migrations * Remove `dashboards:edit` action * Remove unused function from interface * Update pkg/services/guardian/accesscontrol_guardian_test.go Co-authored-by: Gabriel MABILLE <gamab@users.noreply.github.com> Co-authored-by: Ieva <ieva.vasiljeva@grafana.com>
210 lines
6.0 KiB
Go
210 lines
6.0 KiB
Go
package api
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
"net/http"
|
|
"strconv"
|
|
"time"
|
|
|
|
"github.com/grafana/grafana/pkg/api/dtos"
|
|
"github.com/grafana/grafana/pkg/api/response"
|
|
"github.com/grafana/grafana/pkg/models"
|
|
"github.com/grafana/grafana/pkg/services/accesscontrol"
|
|
"github.com/grafana/grafana/pkg/services/featuremgmt"
|
|
"github.com/grafana/grafana/pkg/services/guardian"
|
|
"github.com/grafana/grafana/pkg/web"
|
|
)
|
|
|
|
func (hs *HTTPServer) GetDashboardPermissionList(c *models.ReqContext) response.Response {
|
|
dashID, err := strconv.ParseInt(web.Params(c.Req)[":dashboardId"], 10, 64)
|
|
if err != nil {
|
|
return response.Error(http.StatusBadRequest, "dashboardId is invalid", err)
|
|
}
|
|
|
|
_, rsp := hs.getDashboardHelper(c.Req.Context(), c.OrgId, dashID, "")
|
|
if rsp != nil {
|
|
return rsp
|
|
}
|
|
|
|
g := guardian.New(c.Req.Context(), dashID, c.OrgId, c.SignedInUser)
|
|
|
|
if canAdmin, err := g.CanAdmin(); err != nil || !canAdmin {
|
|
return dashboardGuardianResponse(err)
|
|
}
|
|
|
|
acl, err := g.GetACLWithoutDuplicates()
|
|
if err != nil {
|
|
return response.Error(500, "Failed to get dashboard permissions", err)
|
|
}
|
|
|
|
filteredAcls := make([]*models.DashboardAclInfoDTO, 0, len(acl))
|
|
for _, perm := range acl {
|
|
if perm.UserId > 0 && dtos.IsHiddenUser(perm.UserLogin, c.SignedInUser, hs.Cfg) {
|
|
continue
|
|
}
|
|
|
|
perm.UserAvatarUrl = dtos.GetGravatarUrl(perm.UserEmail)
|
|
|
|
if perm.TeamId > 0 {
|
|
perm.TeamAvatarUrl = dtos.GetGravatarUrlWithDefault(perm.TeamEmail, perm.Team)
|
|
}
|
|
if perm.Slug != "" {
|
|
perm.Url = models.GetDashboardFolderUrl(perm.IsFolder, perm.Uid, perm.Slug)
|
|
}
|
|
|
|
filteredAcls = append(filteredAcls, perm)
|
|
}
|
|
|
|
return response.JSON(200, filteredAcls)
|
|
}
|
|
|
|
func (hs *HTTPServer) UpdateDashboardPermissions(c *models.ReqContext) response.Response {
|
|
apiCmd := dtos.UpdateDashboardAclCommand{}
|
|
if err := web.Bind(c.Req, &apiCmd); err != nil {
|
|
return response.Error(http.StatusBadRequest, "bad request data", err)
|
|
}
|
|
if err := validatePermissionsUpdate(apiCmd); err != nil {
|
|
return response.Error(400, err.Error(), err)
|
|
}
|
|
|
|
dashID, err := strconv.ParseInt(web.Params(c.Req)[":dashboardId"], 10, 64)
|
|
if err != nil {
|
|
return response.Error(http.StatusBadRequest, "dashboardId is invalid", err)
|
|
}
|
|
|
|
dash, rsp := hs.getDashboardHelper(c.Req.Context(), c.OrgId, dashID, "")
|
|
if rsp != nil {
|
|
return rsp
|
|
}
|
|
|
|
g := guardian.New(c.Req.Context(), dashID, c.OrgId, c.SignedInUser)
|
|
if canAdmin, err := g.CanAdmin(); err != nil || !canAdmin {
|
|
return dashboardGuardianResponse(err)
|
|
}
|
|
|
|
var items []*models.DashboardAcl
|
|
for _, item := range apiCmd.Items {
|
|
items = append(items, &models.DashboardAcl{
|
|
OrgID: c.OrgId,
|
|
DashboardID: dashID,
|
|
UserID: item.UserID,
|
|
TeamID: item.TeamID,
|
|
Role: item.Role,
|
|
Permission: item.Permission,
|
|
Created: time.Now(),
|
|
Updated: time.Now(),
|
|
})
|
|
}
|
|
|
|
hiddenACL, err := g.GetHiddenACL(hs.Cfg)
|
|
if err != nil {
|
|
return response.Error(500, "Error while retrieving hidden permissions", err)
|
|
}
|
|
items = append(items, hiddenACL...)
|
|
|
|
if okToUpdate, err := g.CheckPermissionBeforeUpdate(models.PERMISSION_ADMIN, items); err != nil || !okToUpdate {
|
|
if err != nil {
|
|
if errors.Is(err, guardian.ErrGuardianPermissionExists) || errors.Is(err, guardian.ErrGuardianOverride) {
|
|
return response.Error(400, err.Error(), err)
|
|
}
|
|
|
|
return response.Error(500, "Error while checking dashboard permissions", err)
|
|
}
|
|
|
|
return response.Error(403, "Cannot remove own admin permission for a folder", nil)
|
|
}
|
|
|
|
if hs.Features.IsEnabled(featuremgmt.FlagAccesscontrol) {
|
|
old, err := g.GetAcl()
|
|
if err != nil {
|
|
return response.Error(500, "Error while checking dashboard permissions", err)
|
|
}
|
|
if err := hs.updateDashboardAccessControl(c.Req.Context(), dash.OrgId, dash.Id, false, items, old); err != nil {
|
|
return response.Error(500, "Failed to update permissions", err)
|
|
}
|
|
return response.Success("Dashboard permissions updated")
|
|
}
|
|
|
|
if err := hs.dashboardService.UpdateDashboardACL(c.Req.Context(), dashID, items); err != nil {
|
|
if errors.Is(err, models.ErrDashboardAclInfoMissing) ||
|
|
errors.Is(err, models.ErrDashboardPermissionDashboardEmpty) {
|
|
return response.Error(409, err.Error(), err)
|
|
}
|
|
return response.Error(500, "Failed to create permission", err)
|
|
}
|
|
|
|
return response.Success("Dashboard permissions updated")
|
|
}
|
|
|
|
// updateDashboardAccessControl is used for api backward compatibility
|
|
func (hs *HTTPServer) updateDashboardAccessControl(ctx context.Context, orgID, dashID int64, isFolder bool, items []*models.DashboardAcl, old []*models.DashboardAclInfoDTO) error {
|
|
commands := []accesscontrol.SetResourcePermissionCommand{}
|
|
for _, item := range items {
|
|
permissions := item.Permission.String()
|
|
role := ""
|
|
if item.Role != nil {
|
|
role = string(*item.Role)
|
|
}
|
|
|
|
commands = append(commands, accesscontrol.SetResourcePermissionCommand{
|
|
UserID: item.UserID,
|
|
TeamID: item.TeamID,
|
|
BuiltinRole: role,
|
|
Permission: permissions,
|
|
})
|
|
}
|
|
|
|
for _, o := range old {
|
|
shouldRemove := true
|
|
for _, item := range items {
|
|
if item.UserID != 0 && item.UserID == o.UserId {
|
|
shouldRemove = false
|
|
break
|
|
}
|
|
if item.TeamID != 0 && item.TeamID == o.TeamId {
|
|
shouldRemove = false
|
|
break
|
|
}
|
|
if item.Role != nil && o.Role != nil && *item.Role == *o.Role {
|
|
shouldRemove = false
|
|
break
|
|
}
|
|
}
|
|
if shouldRemove {
|
|
role := ""
|
|
if o.Role != nil {
|
|
role = string(*o.Role)
|
|
}
|
|
|
|
commands = append(commands, accesscontrol.SetResourcePermissionCommand{
|
|
UserID: o.UserId,
|
|
TeamID: o.TeamId,
|
|
BuiltinRole: role,
|
|
Permission: "",
|
|
})
|
|
}
|
|
}
|
|
|
|
svc := hs.permissionServices.GetDashboardService()
|
|
if isFolder {
|
|
svc = hs.permissionServices.GetFolderService()
|
|
}
|
|
|
|
_, err := svc.SetPermissions(ctx, orgID, strconv.FormatInt(dashID, 10), commands...)
|
|
return err
|
|
}
|
|
|
|
func validatePermissionsUpdate(apiCmd dtos.UpdateDashboardAclCommand) error {
|
|
for _, item := range apiCmd.Items {
|
|
if item.UserID > 0 && item.TeamID > 0 {
|
|
return models.ErrPermissionsWithUserAndTeamNotAllowed
|
|
}
|
|
|
|
if (item.UserID > 0 || item.TeamID > 0) && item.Role != nil {
|
|
return models.ErrPermissionsWithRoleNotAllowed
|
|
}
|
|
}
|
|
return nil
|
|
}
|