mirror of
https://github.com/grafana/grafana.git
synced 2024-12-01 13:09:22 -06:00
b0881daf23
* use tokens or urls in image annotations * improve tests, fix some comments * fix empty tokens * code review changes, check for url before checking for token (support old token formats)
218 lines
7.9 KiB
Go
218 lines
7.9 KiB
Go
package store_test
|
|
|
|
import (
|
|
"context"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
|
|
"github.com/grafana/grafana/pkg/infra/db"
|
|
"github.com/grafana/grafana/pkg/services/ngalert/models"
|
|
"github.com/grafana/grafana/pkg/services/ngalert/store"
|
|
"github.com/grafana/grafana/pkg/services/ngalert/tests"
|
|
)
|
|
|
|
func TestIntegrationSaveAndGetImage(t *testing.T) {
|
|
if testing.Short() {
|
|
t.Skip("skipping integration test")
|
|
}
|
|
|
|
// our database schema uses second precision for timestamps
|
|
store.TimeNow = func() time.Time {
|
|
return time.Now().Truncate(time.Second)
|
|
}
|
|
|
|
ctx := context.Background()
|
|
_, dbstore := tests.SetupTestEnv(t, baseIntervalSeconds)
|
|
|
|
// create an image with a path on disk
|
|
image1 := models.Image{Path: "example.png"}
|
|
require.NoError(t, dbstore.SaveImage(ctx, &image1))
|
|
require.NotEqual(t, image1.Token, "")
|
|
|
|
// image should not have expired
|
|
assert.False(t, image1.HasExpired())
|
|
assert.Equal(t, image1.ExpiresAt, image1.CreatedAt.Add(24*time.Hour))
|
|
|
|
// should return the image with a path on disk
|
|
result1, err := dbstore.GetImage(ctx, image1.Token)
|
|
require.NoError(t, err)
|
|
assert.Equal(t, image1, *result1)
|
|
|
|
// save the image a second time should not change the expiration time
|
|
ts := image1.ExpiresAt
|
|
require.NoError(t, dbstore.SaveImage(ctx, &image1))
|
|
assert.Equal(t, image1.ExpiresAt, ts)
|
|
|
|
// create an image with a URL
|
|
image2 := models.Image{URL: "https://example.com/example.png"}
|
|
require.NoError(t, dbstore.SaveImage(ctx, &image2))
|
|
require.NotEqual(t, image2.Token, "")
|
|
|
|
// create another image with the same URL
|
|
image3 := models.Image{URL: "https://example.com/example.png"}
|
|
require.NoError(t, dbstore.SaveImage(ctx, &image3))
|
|
require.NotEqual(t, image3.Token, "")
|
|
|
|
// image should not have expired
|
|
assert.False(t, image2.HasExpired())
|
|
assert.Equal(t, image2.ExpiresAt, image2.CreatedAt.Add(24*time.Hour))
|
|
|
|
// should return the image with a URL
|
|
result2, err := dbstore.GetImage(ctx, image2.Token)
|
|
require.NoError(t, err)
|
|
assert.Equal(t, image2, *result2)
|
|
|
|
// querying by URL should yield the same result even though we have two images with the same URL
|
|
result2, err = dbstore.GetImageByURL(ctx, image2.URL)
|
|
require.NoError(t, err)
|
|
assert.Equal(t, image2, *result2)
|
|
|
|
// expired image should not be returned
|
|
image1.ExpiresAt = time.Now().Add(-time.Second)
|
|
require.NoError(t, dbstore.SaveImage(ctx, &image1))
|
|
result1, err = dbstore.GetImage(ctx, image1.Token)
|
|
assert.EqualError(t, err, "image not found")
|
|
assert.Nil(t, result1)
|
|
|
|
// Querying by URL should yield the same result.
|
|
image2.ExpiresAt = time.Now().Add(-time.Second)
|
|
require.NoError(t, dbstore.SaveImage(ctx, &image1))
|
|
result2, err = dbstore.GetImage(ctx, image2.URL)
|
|
assert.EqualError(t, err, "image not found")
|
|
assert.Nil(t, result2)
|
|
}
|
|
|
|
func TestIntegrationGetImages(t *testing.T) {
|
|
if testing.Short() {
|
|
t.Skip("skipping integration test")
|
|
}
|
|
|
|
// our database schema uses second precision for timestamps
|
|
store.TimeNow = func() time.Time {
|
|
return time.Now().Truncate(time.Second)
|
|
}
|
|
|
|
ctx := context.Background()
|
|
_, dbstore := tests.SetupTestEnv(t, baseIntervalSeconds)
|
|
|
|
// create an image with a path on disk
|
|
image1 := models.Image{Path: "example.png"}
|
|
require.NoError(t, dbstore.SaveImage(ctx, &image1))
|
|
|
|
// should return the first image
|
|
images, mismatched, err := dbstore.GetImages(ctx, []string{image1.Token})
|
|
require.NoError(t, err)
|
|
assert.Len(t, mismatched, 0)
|
|
assert.Equal(t, []models.Image{image1}, images)
|
|
|
|
// create an image with a long URL (e.g signed URL)
|
|
image2 := models.Image{URL: "https://example.com/example.png?Signature=fPow8xzlrNpQqZp2K4KE9Xs7KfrUEzBmINHwICX9" +
|
|
"yXkTcVrIb3CmyfpdAl9glG6RHFnkg8Lkg7L88CwltPV3QhUTReLXKwWH364dwU0HgHmYtfZTVFJd33Y1r4a1SvuXWWyciGeI7YtQC8NYoNswZJ" +
|
|
"R7lpbdF968Y95BX99vqJLgjPV3zppuRKWEMObGd05GCEKN9wMr1y3wIpUMLkZxwCx0i59afBNnCewEEL1k6HywtvGukP0mI2XDQOdGTVpZYc8L" +
|
|
"j7JcLur5pwgF6XzmCWxDTUEnYI2TGFdSlhhXbMp7ZINs32QXqOMX0TzaNP7TpmTO09p6UBRntMIRacb6p6nZNbIe2L0uInOZFVTwdzMDsCExBw" +
|
|
"sPa6uIftFjJG6rU8YHpDYBAIkdn9RBBMpgxJ7PW5cm8zmAmWNhXILkJoudqLnL7pGVS6JwEnTRvCeoUEK9bBcvcUIyfj0wuHZphQz0bG01v9c6" +
|
|
"3RghISMfeJl8nulfvph9A4CqMRfqdTQkNBuyw6UXJlMWLONMmuIB8XPDRquABFSeRhRx8LGRzlmJfgGI80IIS9If7Kyb5VmINJvnnHqNd8GTyW" +
|
|
"910WMK4bUUMtyMQgdPHTsAt4BseQ6ShhfZt1fxQS88NgpJf4tNkyxOEqNoIme4KneIiue6T2g8GEYBOcsw9U9oc1h8Nv1mPshaQ0cx8acPX9Mt" +
|
|
"kcgyRF49HV92HBXYghZx0LudPSvVv73XgIBn6eZvP12BPS9Lgzz5gfGULWkPhlOuot1Lsnu1NzVsYY94EbgiPk6AEjpsl2OZmHHqnsVXamIXhX" +
|
|
"dvY8KxwYd5VDvw3q1mlUZfG4FipZU0NRRSVm9bLlyazabTnPBkCDUG6o4YZHqIuYCk0zsEWErEYvTf5DZmQCXC6Igu8lkKmWdW7ei70fUVYixA" +
|
|
"4js7S0DuECKE5tzAcPvgCKFBJ6imQjPnCaAv62SL8Qd9VHKohtcinRAn1uJ1AGhjjtwfTSTvwJxdeFlsUXl95sVivlLqZZAsN4Q12y8M2JTwDJ" +
|
|
"ztYxvr9m2FixQZ2IqhLmc8dVgtQedrIf0ZEHflMiWlPavvJsAf8OXXdspYj3Nrn"}
|
|
require.NoError(t, dbstore.SaveImage(ctx, &image2))
|
|
|
|
// should return both images
|
|
images, mismatched, err = dbstore.GetImages(ctx, []string{image1.Token, image2.Token})
|
|
require.NoError(t, err)
|
|
assert.Len(t, mismatched, 0)
|
|
assert.ElementsMatch(t, []models.Image{image1, image2}, images)
|
|
|
|
// should return the first image
|
|
images, mismatched, err = dbstore.GetImages(ctx, []string{image1.Token})
|
|
require.NoError(t, err)
|
|
assert.Len(t, mismatched, 0)
|
|
assert.Equal(t, []models.Image{image1}, images)
|
|
|
|
// should return the second image
|
|
images, mismatched, err = dbstore.GetImages(ctx, []string{image2.Token})
|
|
require.NoError(t, err)
|
|
assert.Len(t, mismatched, 0)
|
|
assert.Equal(t, []models.Image{image2}, images)
|
|
|
|
// should return the first image and an error
|
|
images, mismatched, err = dbstore.GetImages(ctx, []string{image1.Token, "unknown"})
|
|
assert.EqualError(t, err, "image not found")
|
|
assert.Equal(t, []string{"unknown"}, mismatched)
|
|
assert.Equal(t, []models.Image{image1}, images)
|
|
|
|
// should return no images for no tokens
|
|
images, mismatched, err = dbstore.GetImages(ctx, []string{})
|
|
require.NoError(t, err)
|
|
assert.Len(t, mismatched, 0)
|
|
assert.Len(t, images, 0)
|
|
|
|
// should return no images for nil tokens
|
|
images, mismatched, err = dbstore.GetImages(ctx, nil)
|
|
require.NoError(t, err)
|
|
assert.Len(t, mismatched, 0)
|
|
assert.Len(t, images, 0)
|
|
|
|
// expired image should not be returned
|
|
image1.ExpiresAt = time.Now().Add(-time.Second)
|
|
require.NoError(t, dbstore.SaveImage(ctx, &image1))
|
|
images, mismatched, err = dbstore.GetImages(ctx, []string{image1.Token, image2.Token})
|
|
assert.EqualError(t, err, "image not found")
|
|
assert.Equal(t, []string{image1.Token}, mismatched)
|
|
assert.Equal(t, []models.Image{image2}, images)
|
|
}
|
|
|
|
func TestIntegrationDeleteExpiredImages(t *testing.T) {
|
|
if testing.Short() {
|
|
t.Skip("skipping integration test")
|
|
}
|
|
|
|
// our database schema uses second precision for timestamps
|
|
store.TimeNow = func() time.Time {
|
|
return time.Now().Truncate(time.Second)
|
|
}
|
|
|
|
ctx := context.Background()
|
|
_, dbstore := tests.SetupTestEnv(t, baseIntervalSeconds)
|
|
|
|
// create two images
|
|
image1 := models.Image{Path: "example.png"}
|
|
require.NoError(t, dbstore.SaveImage(ctx, &image1))
|
|
image2 := models.Image{URL: "https://example.com/example.png"}
|
|
require.NoError(t, dbstore.SaveImage(ctx, &image2))
|
|
|
|
err := dbstore.SQLStore.WithDbSession(ctx, func(sess *db.Session) error {
|
|
// should return both images
|
|
var result1, result2 models.Image
|
|
ok, err := sess.Where("token = ?", image1.Token).Get(&result1)
|
|
require.NoError(t, err)
|
|
assert.True(t, ok)
|
|
ok, err = sess.Where("token = ?", image2.Token).Get(&result2)
|
|
require.NoError(t, err)
|
|
assert.True(t, ok)
|
|
|
|
// should delete expired image
|
|
image1.ExpiresAt = time.Now().Add(-time.Second)
|
|
require.NoError(t, dbstore.SaveImage(ctx, &image1))
|
|
n, err := dbstore.DeleteExpiredImages(ctx)
|
|
require.NoError(t, err)
|
|
assert.Equal(t, int64(1), n)
|
|
|
|
// should return just the second image
|
|
ok, err = sess.Where("token = ?", image1.Token).Get(&result1)
|
|
require.NoError(t, err)
|
|
assert.False(t, ok)
|
|
ok, err = sess.Where("token = ?", image2.Token).Get(&result2)
|
|
require.NoError(t, err)
|
|
assert.True(t, ok)
|
|
|
|
return nil
|
|
})
|
|
require.NoError(t, err)
|
|
}
|