mirror of
https://github.com/grafana/grafana.git
synced 2025-02-25 18:55:37 -06:00
* * Teams: Appropriately apply user id filter in /api/teams/:id and /api/teams/search * Teams: Ensure that users searching for teams are only able see teams they have access to * Teams: Require teamGuardian admin privileges to list team members * Teams: Prevent org viewers from administering teams * Teams: Add org_id condition to team count query * Teams: clarify permission requirements in teams api docs * Teams: expand scenarios for team search tests * Teams: mock teamGuardian in tests Co-authored-by: Dan Cech <dcech@grafana.com> * remove duplicate WHERE statement * Fix for CVE-2022-21702 (cherry picked from commit 202d7c190082c094bc1dc13f7fe9464746c37f9e) * Lint and test fixes (cherry picked from commit 3e6b67d5504abf4a1d7b8d621f04d062c048e981) * check content type properly (cherry picked from commit 70b4458892bf2f776302720c10d24c9ff34edd98) * basic csrf origin check (cherry picked from commit 3adaa5ff39832364f6390881fb5b42ad47df92e1) * compare origin to host (cherry picked from commit 5443892699e8ed42836bb2b9a44744ff3e970f42) * simplify url parsing (cherry picked from commit b2ffbc9513fed75468628370a48b929d30af2b1d) * check csrf for GET requests, only compare origin (cherry picked from commit 8b81dc12d8f8a1f07852809c5b4d44f0f0b1d709) * parse content type properly (cherry picked from commit 16f76f4902e6f2188bea9606c68b551af186bdc0) * mentioned get in the comment (cherry picked from commit a7e61811ef8ae558ce721e2e3fed04ce7a5a5345) * add content-type: application/json to test HTTP requests * fix pluginproxy test * Fix linter when comparing errors Co-authored-by: Kevin Minehart <kmineh0151@gmail.com> Co-authored-by: Dan Cech <dcech@grafana.com> Co-authored-by: Marcus Efraimsson <marcus.efraimsson@gmail.com> Co-authored-by: Serge Zaitsev <serge.zaitsev@grafana.com> Co-authored-by: Vardan Torosyan <vardants@gmail.com>
216 lines
7.5 KiB
Go
216 lines
7.5 KiB
Go
package api
|
|
|
|
import (
|
|
"bytes"
|
|
"context"
|
|
"encoding/json"
|
|
"net/http"
|
|
"testing"
|
|
|
|
"github.com/grafana/grafana/pkg/api/routing"
|
|
"github.com/grafana/grafana/pkg/components/simplejson"
|
|
"github.com/grafana/grafana/pkg/models"
|
|
"github.com/grafana/grafana/pkg/services/dashboardimport"
|
|
"github.com/grafana/grafana/pkg/web/webtest"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestImportDashboardAPI(t *testing.T) {
|
|
t.Run("Quota not reached, schema loader service disabled", func(t *testing.T) {
|
|
importDashboardServiceCalled := false
|
|
service := &serviceMock{
|
|
importDashboardFunc: func(ctx context.Context, req *dashboardimport.ImportDashboardRequest) (*dashboardimport.ImportDashboardResponse, error) {
|
|
importDashboardServiceCalled = true
|
|
return nil, nil
|
|
},
|
|
}
|
|
|
|
schemaLoaderServiceCalled := false
|
|
schemaLoaderService := &schemaLoaderServiceMock{
|
|
dashboardApplyDefaultsFunc: func(input *simplejson.Json) (*simplejson.Json, error) {
|
|
schemaLoaderServiceCalled = true
|
|
return input, nil
|
|
},
|
|
}
|
|
|
|
importDashboardAPI := New(service, quotaServiceFunc(quotaNotReached), schemaLoaderService, nil)
|
|
routeRegister := routing.NewRouteRegister()
|
|
importDashboardAPI.RegisterAPIEndpoints(routeRegister)
|
|
s := webtest.NewServer(t, routeRegister)
|
|
|
|
t.Run("Not signed in should return 404", func(t *testing.T) {
|
|
cmd := &dashboardimport.ImportDashboardRequest{}
|
|
jsonBytes, err := json.Marshal(cmd)
|
|
require.NoError(t, err)
|
|
req := s.NewRequest(http.MethodPost, "/api/dashboards/import", bytes.NewReader(jsonBytes))
|
|
req.Header.Add("Content-Type", "application/json")
|
|
resp, err := s.Send(req)
|
|
require.NoError(t, err)
|
|
require.NoError(t, resp.Body.Close())
|
|
require.Equal(t, http.StatusUnauthorized, resp.StatusCode)
|
|
})
|
|
|
|
t.Run("Signed in, empty plugin id and dashboard model empty should return error", func(t *testing.T) {
|
|
cmd := &dashboardimport.ImportDashboardRequest{
|
|
PluginId: "",
|
|
Dashboard: nil,
|
|
}
|
|
jsonBytes, err := json.Marshal(cmd)
|
|
require.NoError(t, err)
|
|
req := s.NewRequest(http.MethodPost, "/api/dashboards/import", bytes.NewReader(jsonBytes))
|
|
req.Header.Add("Content-Type", "application/json")
|
|
webtest.RequestWithSignedInUser(req, &models.SignedInUser{
|
|
UserId: 1,
|
|
})
|
|
resp, err := s.Send(req)
|
|
require.NoError(t, err)
|
|
require.NoError(t, resp.Body.Close())
|
|
require.Equal(t, http.StatusUnprocessableEntity, resp.StatusCode)
|
|
})
|
|
|
|
t.Run("Signed in, dashboard model set should call import dashboard service", func(t *testing.T) {
|
|
cmd := &dashboardimport.ImportDashboardRequest{
|
|
Dashboard: simplejson.New(),
|
|
}
|
|
jsonBytes, err := json.Marshal(cmd)
|
|
require.NoError(t, err)
|
|
req := s.NewRequest(http.MethodPost, "/api/dashboards/import", bytes.NewReader(jsonBytes))
|
|
req.Header.Add("Content-Type", "application/json")
|
|
webtest.RequestWithSignedInUser(req, &models.SignedInUser{
|
|
UserId: 1,
|
|
})
|
|
resp, err := s.Send(req)
|
|
require.NoError(t, err)
|
|
require.NoError(t, resp.Body.Close())
|
|
require.Equal(t, http.StatusOK, resp.StatusCode)
|
|
require.True(t, importDashboardServiceCalled)
|
|
})
|
|
|
|
t.Run("Signed in, dashboard model set, trimdefaults enabled should not call schema loader service", func(t *testing.T) {
|
|
cmd := &dashboardimport.ImportDashboardRequest{
|
|
Dashboard: simplejson.New(),
|
|
}
|
|
jsonBytes, err := json.Marshal(cmd)
|
|
require.NoError(t, err)
|
|
req := s.NewRequest(http.MethodPost, "/api/dashboards/import?trimdefaults=true", bytes.NewReader(jsonBytes))
|
|
req.Header.Add("Content-Type", "application/json")
|
|
webtest.RequestWithSignedInUser(req, &models.SignedInUser{
|
|
UserId: 1,
|
|
})
|
|
resp, err := s.Send(req)
|
|
require.NoError(t, err)
|
|
require.NoError(t, resp.Body.Close())
|
|
require.Equal(t, http.StatusOK, resp.StatusCode)
|
|
require.False(t, schemaLoaderServiceCalled)
|
|
require.True(t, importDashboardServiceCalled)
|
|
})
|
|
})
|
|
|
|
t.Run("Quota not reached, schema loader service enabled", func(t *testing.T) {
|
|
importDashboardServiceCalled := false
|
|
service := &serviceMock{
|
|
importDashboardFunc: func(ctx context.Context, req *dashboardimport.ImportDashboardRequest) (*dashboardimport.ImportDashboardResponse, error) {
|
|
importDashboardServiceCalled = true
|
|
return nil, nil
|
|
},
|
|
}
|
|
|
|
schemaLoaderServiceCalled := false
|
|
schemaLoaderService := &schemaLoaderServiceMock{
|
|
enabled: true,
|
|
dashboardApplyDefaultsFunc: func(input *simplejson.Json) (*simplejson.Json, error) {
|
|
schemaLoaderServiceCalled = true
|
|
return input, nil
|
|
},
|
|
}
|
|
|
|
importDashboardAPI := New(service, quotaServiceFunc(quotaNotReached), schemaLoaderService, nil)
|
|
routeRegister := routing.NewRouteRegister()
|
|
importDashboardAPI.RegisterAPIEndpoints(routeRegister)
|
|
s := webtest.NewServer(t, routeRegister)
|
|
|
|
t.Run("Signed in, dashboard model set, trimdefaults enabled should call schema loader service", func(t *testing.T) {
|
|
cmd := &dashboardimport.ImportDashboardRequest{
|
|
Dashboard: simplejson.New(),
|
|
}
|
|
jsonBytes, err := json.Marshal(cmd)
|
|
require.NoError(t, err)
|
|
req := s.NewRequest(http.MethodPost, "/api/dashboards/import?trimdefaults=true", bytes.NewReader(jsonBytes))
|
|
req.Header.Add("Content-Type", "application/json")
|
|
webtest.RequestWithSignedInUser(req, &models.SignedInUser{
|
|
UserId: 1,
|
|
})
|
|
resp, err := s.Send(req)
|
|
require.NoError(t, err)
|
|
require.NoError(t, resp.Body.Close())
|
|
require.Equal(t, http.StatusOK, resp.StatusCode)
|
|
require.True(t, schemaLoaderServiceCalled)
|
|
require.True(t, importDashboardServiceCalled)
|
|
})
|
|
})
|
|
|
|
t.Run("Quota reached", func(t *testing.T) {
|
|
service := &serviceMock{}
|
|
schemaLoaderService := &schemaLoaderServiceMock{}
|
|
importDashboardAPI := New(service, quotaServiceFunc(quotaReached), schemaLoaderService, nil)
|
|
|
|
routeRegister := routing.NewRouteRegister()
|
|
importDashboardAPI.RegisterAPIEndpoints(routeRegister)
|
|
s := webtest.NewServer(t, routeRegister)
|
|
|
|
t.Run("Signed in, dashboard model set, should return 403 forbidden/quota reached", func(t *testing.T) {
|
|
cmd := &dashboardimport.ImportDashboardRequest{
|
|
Dashboard: simplejson.New(),
|
|
}
|
|
jsonBytes, err := json.Marshal(cmd)
|
|
require.NoError(t, err)
|
|
req := s.NewRequest(http.MethodPost, "/api/dashboards/import", bytes.NewReader(jsonBytes))
|
|
req.Header.Add("Content-Type", "application/json")
|
|
webtest.RequestWithSignedInUser(req, &models.SignedInUser{
|
|
UserId: 1,
|
|
})
|
|
resp, err := s.Send(req)
|
|
require.NoError(t, err)
|
|
require.NoError(t, resp.Body.Close())
|
|
require.Equal(t, http.StatusForbidden, resp.StatusCode)
|
|
})
|
|
})
|
|
}
|
|
|
|
type serviceMock struct {
|
|
importDashboardFunc func(ctx context.Context, req *dashboardimport.ImportDashboardRequest) (*dashboardimport.ImportDashboardResponse, error)
|
|
}
|
|
|
|
func (s *serviceMock) ImportDashboard(ctx context.Context, req *dashboardimport.ImportDashboardRequest) (*dashboardimport.ImportDashboardResponse, error) {
|
|
if s.importDashboardFunc != nil {
|
|
return s.importDashboardFunc(ctx, req)
|
|
}
|
|
|
|
return nil, nil
|
|
}
|
|
|
|
type schemaLoaderServiceMock struct {
|
|
enabled bool
|
|
dashboardApplyDefaultsFunc func(input *simplejson.Json) (*simplejson.Json, error)
|
|
}
|
|
|
|
func (s *schemaLoaderServiceMock) IsDisabled() bool {
|
|
return !s.enabled
|
|
}
|
|
|
|
func (s *schemaLoaderServiceMock) DashboardApplyDefaults(input *simplejson.Json) (*simplejson.Json, error) {
|
|
if s.dashboardApplyDefaultsFunc != nil {
|
|
return s.dashboardApplyDefaultsFunc(input)
|
|
}
|
|
|
|
return input, nil
|
|
}
|
|
|
|
func quotaReached(c *models.ReqContext, target string) (bool, error) {
|
|
return true, nil
|
|
}
|
|
|
|
func quotaNotReached(c *models.ReqContext, target string) (bool, error) {
|
|
return false, nil
|
|
}
|