mirror of
https://github.com/grafana/grafana.git
synced 2024-11-26 02:40:26 -06:00
7520166f17
* Fix CreateTeam api endpoint No team member should be created for requests authenticated by API tokens. * Update middleware test Assert that `isAnonymous` is set for `SignedInUser` authenticated via API key. * Add test for team creation Assert that no team member is created if the signed in user is anomymous. * Revert "Fix CreateTeam api endpoint" This reverts commit9fcc4e67f5
. * Revert "Update middleware test" This reverts commit75f767e58d
. * Fix CreateTeam api endpoint No team member should be created for requests authenticated by API tokens. * Update team test * Change error to warning and update tests
168 lines
4.5 KiB
Go
168 lines
4.5 KiB
Go
package api
|
|
|
|
import (
|
|
"github.com/grafana/grafana/pkg/api/dtos"
|
|
"github.com/grafana/grafana/pkg/bus"
|
|
m "github.com/grafana/grafana/pkg/models"
|
|
"github.com/grafana/grafana/pkg/services/teamguardian"
|
|
"github.com/grafana/grafana/pkg/util"
|
|
)
|
|
|
|
// POST /api/teams
|
|
func (hs *HTTPServer) CreateTeam(c *m.ReqContext, cmd m.CreateTeamCommand) Response {
|
|
cmd.OrgId = c.OrgId
|
|
|
|
if c.OrgRole == m.ROLE_VIEWER {
|
|
return Error(403, "Not allowed to create team.", nil)
|
|
}
|
|
|
|
if err := hs.Bus.Dispatch(&cmd); err != nil {
|
|
if err == m.ErrTeamNameTaken {
|
|
return Error(409, "Team name taken", err)
|
|
}
|
|
return Error(500, "Failed to create Team", err)
|
|
}
|
|
|
|
if c.OrgRole == m.ROLE_EDITOR && hs.Cfg.EditorsCanAdmin {
|
|
// if the request is authenticated using API tokens
|
|
// the SignedInUser is an empty struct therefore
|
|
// an additional check whether it is an actual user is required
|
|
if c.SignedInUser.IsRealUser() {
|
|
addMemberCmd := m.AddTeamMemberCommand{
|
|
UserId: c.SignedInUser.UserId,
|
|
OrgId: cmd.OrgId,
|
|
TeamId: cmd.Result.Id,
|
|
Permission: m.PERMISSION_ADMIN,
|
|
}
|
|
|
|
if err := hs.Bus.Dispatch(&addMemberCmd); err != nil {
|
|
c.Logger.Error("Could not add creator to team.", "error", err)
|
|
}
|
|
} else {
|
|
c.Logger.Warn("Could not add creator to team because is not a real user.")
|
|
}
|
|
}
|
|
|
|
return JSON(200, &util.DynMap{
|
|
"teamId": cmd.Result.Id,
|
|
"message": "Team created",
|
|
})
|
|
}
|
|
|
|
// PUT /api/teams/:teamId
|
|
func (hs *HTTPServer) UpdateTeam(c *m.ReqContext, cmd m.UpdateTeamCommand) Response {
|
|
cmd.OrgId = c.OrgId
|
|
cmd.Id = c.ParamsInt64(":teamId")
|
|
|
|
if err := teamguardian.CanAdmin(hs.Bus, cmd.OrgId, cmd.Id, c.SignedInUser); err != nil {
|
|
return Error(403, "Not allowed to update team", err)
|
|
}
|
|
|
|
if err := hs.Bus.Dispatch(&cmd); err != nil {
|
|
if err == m.ErrTeamNameTaken {
|
|
return Error(400, "Team name taken", err)
|
|
}
|
|
return Error(500, "Failed to update Team", err)
|
|
}
|
|
|
|
return Success("Team updated")
|
|
}
|
|
|
|
// DELETE /api/teams/:teamId
|
|
func (hs *HTTPServer) DeleteTeamByID(c *m.ReqContext) Response {
|
|
orgId := c.OrgId
|
|
teamId := c.ParamsInt64(":teamId")
|
|
user := c.SignedInUser
|
|
|
|
if err := teamguardian.CanAdmin(hs.Bus, orgId, teamId, user); err != nil {
|
|
return Error(403, "Not allowed to delete team", err)
|
|
}
|
|
|
|
if err := hs.Bus.Dispatch(&m.DeleteTeamCommand{OrgId: orgId, Id: teamId}); err != nil {
|
|
if err == m.ErrTeamNotFound {
|
|
return Error(404, "Failed to delete Team. ID not found", nil)
|
|
}
|
|
return Error(500, "Failed to delete Team", err)
|
|
}
|
|
return Success("Team deleted")
|
|
}
|
|
|
|
// GET /api/teams/search
|
|
func (hs *HTTPServer) SearchTeams(c *m.ReqContext) Response {
|
|
perPage := c.QueryInt("perpage")
|
|
if perPage <= 0 {
|
|
perPage = 1000
|
|
}
|
|
page := c.QueryInt("page")
|
|
if page < 1 {
|
|
page = 1
|
|
}
|
|
|
|
var userIdFilter int64
|
|
if hs.Cfg.EditorsCanAdmin && c.OrgRole != m.ROLE_ADMIN {
|
|
userIdFilter = c.SignedInUser.UserId
|
|
}
|
|
|
|
query := m.SearchTeamsQuery{
|
|
OrgId: c.OrgId,
|
|
Query: c.Query("query"),
|
|
Name: c.Query("name"),
|
|
UserIdFilter: userIdFilter,
|
|
Page: page,
|
|
Limit: perPage,
|
|
}
|
|
|
|
if err := bus.Dispatch(&query); err != nil {
|
|
return Error(500, "Failed to search Teams", err)
|
|
}
|
|
|
|
for _, team := range query.Result.Teams {
|
|
team.AvatarUrl = dtos.GetGravatarUrlWithDefault(team.Email, team.Name)
|
|
}
|
|
|
|
query.Result.Page = page
|
|
query.Result.PerPage = perPage
|
|
|
|
return JSON(200, query.Result)
|
|
}
|
|
|
|
// GET /api/teams/:teamId
|
|
func GetTeamByID(c *m.ReqContext) Response {
|
|
query := m.GetTeamByIdQuery{OrgId: c.OrgId, Id: c.ParamsInt64(":teamId")}
|
|
|
|
if err := bus.Dispatch(&query); err != nil {
|
|
if err == m.ErrTeamNotFound {
|
|
return Error(404, "Team not found", err)
|
|
}
|
|
|
|
return Error(500, "Failed to get Team", err)
|
|
}
|
|
|
|
query.Result.AvatarUrl = dtos.GetGravatarUrlWithDefault(query.Result.Email, query.Result.Name)
|
|
return JSON(200, &query.Result)
|
|
}
|
|
|
|
// GET /api/teams/:teamId/preferences
|
|
func (hs *HTTPServer) GetTeamPreferences(c *m.ReqContext) Response {
|
|
teamId := c.ParamsInt64(":teamId")
|
|
orgId := c.OrgId
|
|
|
|
if err := teamguardian.CanAdmin(hs.Bus, orgId, teamId, c.SignedInUser); err != nil {
|
|
return Error(403, "Not allowed to view team preferences.", err)
|
|
}
|
|
|
|
return getPreferencesFor(orgId, 0, teamId)
|
|
}
|
|
|
|
// PUT /api/teams/:teamId/preferences
|
|
func (hs *HTTPServer) UpdateTeamPreferences(c *m.ReqContext, dtoCmd dtos.UpdatePrefsCmd) Response {
|
|
teamId := c.ParamsInt64(":teamId")
|
|
orgId := c.OrgId
|
|
|
|
if err := teamguardian.CanAdmin(hs.Bus, orgId, teamId, c.SignedInUser); err != nil {
|
|
return Error(403, "Not allowed to update team preferences.", err)
|
|
}
|
|
|
|
return updatePreferencesFor(orgId, 0, teamId, &dtoCmd)
|
|
}
|