mirror of
https://github.com/grafana/grafana.git
synced 2025-01-01 11:47:05 -06:00
7715672fb3
* Chore: use org service methods
* fix tests
* fix errors
* adjust func signatures for getbyname
* 💩
* Use the same fake service to get the user in AC and in HS
* Fix middleware test
* Fix more middleware test
* Fix api tests
Co-authored-by: gamab <gabi.mabs@gmail.com>
Co-authored-by: Ida Furjesova <ida.furjesova@grafana.com>
120 lines
4.0 KiB
Go
120 lines
4.0 KiB
Go
package plugins
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
"testing"
|
|
|
|
"github.com/grafana/grafana/pkg/services/org"
|
|
"github.com/grafana/grafana/pkg/services/org/orgtest"
|
|
"github.com/grafana/grafana/pkg/services/pluginsettings"
|
|
|
|
"github.com/grafana/grafana/pkg/infra/log"
|
|
"github.com/grafana/grafana/pkg/models"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestPluginProvisioner(t *testing.T) {
|
|
t.Run("Should return error when config reader returns error", func(t *testing.T) {
|
|
expectedErr := errors.New("test")
|
|
reader := &testConfigReader{err: expectedErr}
|
|
ap := PluginProvisioner{log: log.New("test"), cfgProvider: reader}
|
|
err := ap.applyChanges(context.Background(), "")
|
|
require.Equal(t, expectedErr, err)
|
|
})
|
|
|
|
t.Run("Should apply configurations", func(t *testing.T) {
|
|
cfg := []*pluginsAsConfig{
|
|
{
|
|
Apps: []*appFromConfig{
|
|
{PluginID: "test-plugin", OrgID: 2, Enabled: true},
|
|
{PluginID: "test-plugin-2", OrgID: 3, Enabled: false},
|
|
{PluginID: "test-plugin", OrgName: "Org 4", Enabled: true, SecureJSONData: map[string]string{"token": "secret"}},
|
|
{PluginID: "test-plugin-2", OrgID: 1, Enabled: true, JSONData: map[string]interface{}{"test": true}},
|
|
},
|
|
},
|
|
}
|
|
reader := &testConfigReader{result: cfg}
|
|
store := &mockStore{}
|
|
orgMock := orgtest.NewOrgServiceFake()
|
|
orgMock.ExpectedOrg = &org.Org{ID: 4}
|
|
ap := PluginProvisioner{log: log.New("test"), cfgProvider: reader, pluginSettings: store, orgService: orgMock}
|
|
|
|
err := ap.applyChanges(context.Background(), "")
|
|
require.NoError(t, err)
|
|
require.Len(t, store.updateRequests, 4)
|
|
|
|
testCases := []struct {
|
|
ExpectedPluginID string
|
|
ExpectedOrgID int64
|
|
ExpectedEnabled bool
|
|
ExpectedPluginVersion string
|
|
ExpectedJSONData map[string]interface{}
|
|
ExpectedSecureJSONData map[string]string
|
|
}{
|
|
{ExpectedPluginID: "test-plugin", ExpectedOrgID: 2, ExpectedEnabled: true, ExpectedPluginVersion: "2.0.1"},
|
|
{ExpectedPluginID: "test-plugin-2", ExpectedOrgID: 3, ExpectedEnabled: false},
|
|
{ExpectedPluginID: "test-plugin", ExpectedOrgID: 4, ExpectedEnabled: true, ExpectedSecureJSONData: map[string]string{"token": "secret"}},
|
|
{ExpectedPluginID: "test-plugin-2", ExpectedOrgID: 1, ExpectedEnabled: true, ExpectedJSONData: map[string]interface{}{"test": true}},
|
|
}
|
|
|
|
for index, tc := range testCases {
|
|
cmd := store.updateRequests[index]
|
|
require.NotNil(t, cmd)
|
|
require.Equal(t, tc.ExpectedPluginID, cmd.PluginID)
|
|
require.Equal(t, tc.ExpectedOrgID, cmd.OrgID)
|
|
require.Equal(t, tc.ExpectedEnabled, cmd.Enabled)
|
|
require.Equal(t, tc.ExpectedPluginVersion, cmd.PluginVersion)
|
|
require.Equal(t, tc.ExpectedJSONData, cmd.JSONData)
|
|
require.Equal(t, tc.ExpectedSecureJSONData, cmd.SecureJSONData)
|
|
}
|
|
})
|
|
}
|
|
|
|
type testConfigReader struct {
|
|
result []*pluginsAsConfig
|
|
err error
|
|
}
|
|
|
|
func (tcr *testConfigReader) readConfig(_ context.Context, _ string) ([]*pluginsAsConfig, error) {
|
|
return tcr.result, tcr.err
|
|
}
|
|
|
|
type mockStore struct {
|
|
updateRequests []*pluginsettings.UpdateArgs
|
|
}
|
|
|
|
func (m *mockStore) GetOrgByNameHandler(_ context.Context, query *models.GetOrgByNameQuery) error {
|
|
if query.Name == "Org 4" {
|
|
query.Result = &models.Org{Id: 4}
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func (m *mockStore) GetPluginSettingByPluginID(_ context.Context, args *pluginsettings.GetByPluginIDArgs) (*pluginsettings.DTO, error) {
|
|
if args.PluginID == "test-plugin" && args.OrgID == 2 {
|
|
return &pluginsettings.DTO{
|
|
PluginVersion: "2.0.1",
|
|
}, nil
|
|
}
|
|
|
|
return nil, models.ErrPluginSettingNotFound
|
|
}
|
|
|
|
func (m *mockStore) UpdatePluginSetting(_ context.Context, args *pluginsettings.UpdateArgs) error {
|
|
m.updateRequests = append(m.updateRequests, args)
|
|
return nil
|
|
}
|
|
|
|
func (m *mockStore) UpdatePluginSettingPluginVersion(_ context.Context, _ *pluginsettings.UpdatePluginVersionArgs) error {
|
|
return nil
|
|
}
|
|
|
|
func (m *mockStore) GetPluginSettings(_ context.Context, _ *pluginsettings.GetArgs) ([]*pluginsettings.InfoDTO, error) {
|
|
return nil, nil
|
|
}
|
|
|
|
func (m *mockStore) DecryptedValues(_ *pluginsettings.DTO) map[string]string {
|
|
return nil
|
|
}
|