mirror of
https://github.com/grafana/grafana.git
synced 2025-02-25 18:55:37 -06:00
* chore(plugins): bump systemjs to latest version * refactor(plugins): switch runtime over to use latest systemjs, add typings * refactor(plugins): use latest systemjs APIs for runtime dependency resolution * refactor(plugins): return valid urls from backend for latest systemjs import to work * revert(plugins): remove cfg from assetpath in favour of relative paths * fix(plugins): useDefault for systemjs deps to solve undefined errors * feat(plugins): add basic support for loading plugins via CDN * fix(plugins): load nested plugins with latest systemjs * feat(plugins): add back ability to transform plugin src for cdns * feat(plugins): get caching for module.js working, clean up * refactor(plugin_loader): create buildImportMap fn and more clean up * refactor(angularapp): use buildImportMap for dependencies and clean up * test(plugin_loader): fix failing test due to systemjs update * test(jest): mock systemjs amd extra in tests to prevent it breaking tests * chore(plugins): remove systemjs module-types extra, already included with system * fix(plugins): update key for invalidating cached plugins * fix: move systemjs amd define to another global so monaco can load * refactor(plugins): clean up cache buster and tests * chore(plugins): remove debug * refactor(plugins): move systemjs define to keep global cleaner * fix(plugins): set useDefault so system modules lodash references dont fail * feat(plugins): hook systemjs onload so stylesheets are applied to the dom * refactor(plugins): wrap amd formatted plugins in iife to prevent define collision * feat(plugins): support system module format for legacy plugins * test(plugincachebuster): update tests to match latest implementation * test(plugins-loader): fix up tests post module property change * fix test * Update pkg/plugins/manager/loader/assetpath/assetpath.go Co-authored-by: Will Browne <wbrowne@users.noreply.github.com> * chore(plugin_loader): remove stray import from merge conflict * Revert "Update pkg/plugins/manager/loader/assetpath/assetpath.go" This reverts commit 0df57d1cf20f49c22c93369001c70aae46a97c42. * fix(plugin_loader): set use default for shared plugin dependencies * refactor(plugins): use leading slash for Module and BaseUrl * fix(plugins): fix resolve appending extension to cache query param * refactor(plugins): align baseurl and module paths * refactor(plugins): update builtInPlugins keys to match naming convention * refactor(plugins): minor loader clean up, fix up types * test(plugins): fix failing tests * refactor(plugins): rename cache buster systemjs plugin to cache * refactor(plugins): separate plugin_loader into smaller files * chore(plugins): clean up plugin_loader types * chore(plugin_sandbox): fix typescript error * chore(npm): remove unplug debug and pin systemjs to 6.14.1 * refactor(plugins-cdn): update loaders to use absolute module url from backend * fix(plugins): escape period in systemjs module regex * chore(plugins): delete redundant systemjs plugins * refactor(plugin_loader): move hooks into own file, add types * test(plugins): add tests for systemjs loader hooks * chore(plugins): rename systemjshooks file * chore(plugins): remove redundant systemjs cdn backend code * fix(plugins): handle loading with config.appSubUrl * chore(plugins): delete redundant plugin-cdn angular code * test(plugins): fix failing systemjs test missing pluginsCDNBaseUrl * refactor(plugins): backend provides base and module properties with AppSubUrl * fix(plugins): consider AppSubUrl for plugin logos * fix(plugins): use isHostedOnCDN util when checking for cdn hosted plugins * add new appSubURL field to config * refactor relative URL func * fix path for core app * refactor asset path input * fix(plugins): catch errors in loadPluginCss * feat(plugins-cdn): selectively transform sourceMapURL * re-add deleted test case * chore(plugins): bump to latest systemjs@6.14.2 * feat(plugins): add systemjs-cjs-extra for loading commonjs plugins --------- Co-authored-by: Will Browne <will.browne@grafana.com> Co-authored-by: Will Browne <wbrowne@users.noreply.github.com>
371 lines
10 KiB
TypeScript
371 lines
10 KiB
TypeScript
import {
|
|
DataFrame,
|
|
FieldType,
|
|
getDefaultTimeRange,
|
|
LoadingState,
|
|
PanelData,
|
|
PanelPluginMeta,
|
|
toDataFrame,
|
|
VisualizationSuggestion,
|
|
} from '@grafana/data';
|
|
import { config } from 'app/core/config';
|
|
import { SuggestionName } from 'app/types/suggestions';
|
|
|
|
import { getAllSuggestions, panelsToCheckFirst } from './getAllSuggestions';
|
|
|
|
jest.unmock('app/core/core');
|
|
jest.unmock('app/features/plugins/plugin_loader');
|
|
|
|
for (const pluginId of panelsToCheckFirst) {
|
|
config.panels[pluginId] = {
|
|
module: `core:plugin/${pluginId}`,
|
|
} as PanelPluginMeta;
|
|
}
|
|
|
|
config.panels['text'] = {
|
|
id: 'text',
|
|
name: 'Text',
|
|
skipDataQuery: true,
|
|
info: {
|
|
description: 'pretty decent plugin',
|
|
logos: { small: 'small/logo', large: 'large/logo' },
|
|
},
|
|
} as PanelPluginMeta;
|
|
|
|
class ScenarioContext {
|
|
data: DataFrame[] = [];
|
|
suggestions: VisualizationSuggestion[] = [];
|
|
|
|
setData(scenarioData: DataFrame[]) {
|
|
this.data = scenarioData;
|
|
|
|
beforeAll(async () => {
|
|
await this.run();
|
|
});
|
|
}
|
|
|
|
async run() {
|
|
const panelData: PanelData = {
|
|
series: this.data,
|
|
state: LoadingState.Done,
|
|
timeRange: getDefaultTimeRange(),
|
|
};
|
|
|
|
this.suggestions = await getAllSuggestions(panelData);
|
|
}
|
|
|
|
names() {
|
|
return this.suggestions.map((x) => x.name);
|
|
}
|
|
}
|
|
|
|
function scenario(name: string, setup: (ctx: ScenarioContext) => void) {
|
|
describe(name, () => {
|
|
const ctx = new ScenarioContext();
|
|
setup(ctx);
|
|
});
|
|
}
|
|
|
|
scenario('No series', (ctx) => {
|
|
ctx.setData([]);
|
|
|
|
it('should return correct suggestions', () => {
|
|
expect(ctx.names()).toEqual([SuggestionName.Table, SuggestionName.TextPanel]);
|
|
});
|
|
});
|
|
|
|
scenario('No rows', (ctx) => {
|
|
ctx.setData([
|
|
toDataFrame({
|
|
fields: [
|
|
{ name: 'Time', type: FieldType.time, values: [] },
|
|
{ name: 'Max', type: FieldType.number, values: [] },
|
|
],
|
|
}),
|
|
]);
|
|
|
|
it('should return correct suggestions', () => {
|
|
expect(ctx.names()).toEqual([SuggestionName.Table]);
|
|
});
|
|
});
|
|
|
|
scenario('Single frame with time and number field', (ctx) => {
|
|
ctx.setData([
|
|
toDataFrame({
|
|
fields: [
|
|
{ name: 'Time', type: FieldType.time, values: [1, 2, 3, 4, 5] },
|
|
{ name: 'Max', type: FieldType.number, values: [1, 10, 50, 2, 5] },
|
|
],
|
|
}),
|
|
]);
|
|
|
|
it('should return correct suggestions', () => {
|
|
expect(ctx.names()).toEqual([
|
|
SuggestionName.LineChart,
|
|
SuggestionName.LineChartSmooth,
|
|
SuggestionName.AreaChart,
|
|
SuggestionName.LineChartGradientColorScheme,
|
|
SuggestionName.BarChart,
|
|
SuggestionName.BarChartGradientColorScheme,
|
|
SuggestionName.Gauge,
|
|
SuggestionName.GaugeNoThresholds,
|
|
SuggestionName.Stat,
|
|
SuggestionName.StatColoredBackground,
|
|
SuggestionName.BarGaugeBasic,
|
|
SuggestionName.BarGaugeLCD,
|
|
SuggestionName.Table,
|
|
SuggestionName.StateTimeline,
|
|
SuggestionName.StatusHistory,
|
|
]);
|
|
});
|
|
|
|
it('Bar chart suggestion should be using timeseries panel', () => {
|
|
expect(ctx.suggestions.find((x) => x.name === SuggestionName.BarChart)?.pluginId).toBe('timeseries');
|
|
});
|
|
|
|
it('Stat panels have reduce values disabled', () => {
|
|
for (const suggestion of ctx.suggestions) {
|
|
if (suggestion.options?.reduceOptions?.values) {
|
|
throw new Error(`Suggestion ${suggestion.name} reduce.values set to true when it should be false`);
|
|
}
|
|
}
|
|
});
|
|
});
|
|
|
|
scenario('Single frame with time 2 number fields', (ctx) => {
|
|
ctx.setData([
|
|
toDataFrame({
|
|
fields: [
|
|
{ name: 'Time', type: FieldType.time, values: [1, 2, 3, 4, 5] },
|
|
{ name: 'ServerA', type: FieldType.number, values: [1, 10, 50, 2, 5] },
|
|
{ name: 'ServerB', type: FieldType.number, values: [1, 10, 50, 2, 5] },
|
|
],
|
|
}),
|
|
]);
|
|
|
|
it('should return correct suggestions', () => {
|
|
expect(ctx.names()).toEqual([
|
|
SuggestionName.LineChart,
|
|
SuggestionName.LineChartSmooth,
|
|
SuggestionName.AreaChartStacked,
|
|
SuggestionName.AreaChartStackedPercent,
|
|
SuggestionName.BarChartStacked,
|
|
SuggestionName.BarChartStackedPercent,
|
|
SuggestionName.Gauge,
|
|
SuggestionName.GaugeNoThresholds,
|
|
SuggestionName.Stat,
|
|
SuggestionName.StatColoredBackground,
|
|
SuggestionName.PieChart,
|
|
SuggestionName.PieChartDonut,
|
|
SuggestionName.BarGaugeBasic,
|
|
SuggestionName.BarGaugeLCD,
|
|
SuggestionName.Table,
|
|
SuggestionName.StateTimeline,
|
|
SuggestionName.StatusHistory,
|
|
]);
|
|
});
|
|
|
|
it('Stat panels have reduceOptions.values disabled', () => {
|
|
for (const suggestion of ctx.suggestions) {
|
|
if (suggestion.options?.reduceOptions?.values) {
|
|
throw new Error(`Suggestion ${suggestion.name} reduce.values set to true when it should be false`);
|
|
}
|
|
}
|
|
});
|
|
});
|
|
|
|
scenario('Single time series with 100 data points', (ctx) => {
|
|
ctx.setData([
|
|
toDataFrame({
|
|
fields: [
|
|
{ name: 'Time', type: FieldType.time, values: [...Array(100).keys()] },
|
|
{ name: 'ServerA', type: FieldType.number, values: [...Array(100).keys()] },
|
|
],
|
|
}),
|
|
]);
|
|
|
|
it('should not suggest bar chart', () => {
|
|
expect(ctx.suggestions.find((x) => x.name === SuggestionName.BarChart)).toBe(undefined);
|
|
});
|
|
});
|
|
|
|
scenario('30 time series with 100 data points', (ctx) => {
|
|
ctx.setData(
|
|
repeatFrame(
|
|
30,
|
|
toDataFrame({
|
|
fields: [
|
|
{ name: 'Time', type: FieldType.time, values: [...Array(100).keys()] },
|
|
{ name: 'ServerA', type: FieldType.number, values: [...Array(100).keys()] },
|
|
],
|
|
})
|
|
)
|
|
);
|
|
|
|
it('should not suggest timeline', () => {
|
|
expect(ctx.suggestions.find((x) => x.pluginId === 'state-timeline')).toBe(undefined);
|
|
});
|
|
});
|
|
|
|
scenario('50 time series with 100 data points', (ctx) => {
|
|
ctx.setData(
|
|
repeatFrame(
|
|
50,
|
|
toDataFrame({
|
|
fields: [
|
|
{ name: 'Time', type: FieldType.time, values: [...Array(100).keys()] },
|
|
{ name: 'ServerA', type: FieldType.number, values: [...Array(100).keys()] },
|
|
],
|
|
})
|
|
)
|
|
);
|
|
|
|
it('should not suggest gauge', () => {
|
|
expect(ctx.suggestions.find((x) => x.pluginId === 'gauge')).toBe(undefined);
|
|
});
|
|
});
|
|
|
|
scenario('Single frame with string and number field', (ctx) => {
|
|
ctx.setData([
|
|
toDataFrame({
|
|
fields: [
|
|
{ name: 'Name', type: FieldType.string, values: ['Hugo', 'Dominik', 'Marcus'] },
|
|
{ name: 'ServerA', type: FieldType.number, values: [1, 2, 3] },
|
|
],
|
|
}),
|
|
]);
|
|
|
|
it('should return correct suggestions', () => {
|
|
expect(ctx.names()).toEqual([
|
|
SuggestionName.BarChart,
|
|
SuggestionName.BarChartHorizontal,
|
|
SuggestionName.Gauge,
|
|
SuggestionName.GaugeNoThresholds,
|
|
SuggestionName.Stat,
|
|
SuggestionName.StatColoredBackground,
|
|
SuggestionName.PieChart,
|
|
SuggestionName.PieChartDonut,
|
|
SuggestionName.BarGaugeBasic,
|
|
SuggestionName.BarGaugeLCD,
|
|
SuggestionName.Table,
|
|
]);
|
|
});
|
|
|
|
it('Stat/Gauge/BarGauge/PieChart panels to have reduceOptions.values enabled', () => {
|
|
for (const suggestion of ctx.suggestions) {
|
|
if (suggestion.options?.reduceOptions && !suggestion.options?.reduceOptions?.values) {
|
|
throw new Error(`Suggestion ${suggestion.name} reduce.values set to false when it should be true`);
|
|
}
|
|
}
|
|
});
|
|
});
|
|
|
|
scenario('Single frame with string and 2 number field', (ctx) => {
|
|
ctx.setData([
|
|
toDataFrame({
|
|
fields: [
|
|
{ name: 'Name', type: FieldType.string, values: ['Hugo', 'Dominik', 'Marcus'] },
|
|
{ name: 'ServerA', type: FieldType.number, values: [1, 2, 3] },
|
|
{ name: 'ServerB', type: FieldType.number, values: [1, 2, 3] },
|
|
],
|
|
}),
|
|
]);
|
|
|
|
it('should return correct suggestions', () => {
|
|
expect(ctx.names()).toEqual([
|
|
SuggestionName.BarChart,
|
|
SuggestionName.BarChartStacked,
|
|
SuggestionName.BarChartStackedPercent,
|
|
SuggestionName.BarChartHorizontal,
|
|
SuggestionName.BarChartHorizontalStacked,
|
|
SuggestionName.BarChartHorizontalStackedPercent,
|
|
SuggestionName.Gauge,
|
|
SuggestionName.GaugeNoThresholds,
|
|
SuggestionName.Stat,
|
|
SuggestionName.StatColoredBackground,
|
|
SuggestionName.PieChart,
|
|
SuggestionName.PieChartDonut,
|
|
SuggestionName.BarGaugeBasic,
|
|
SuggestionName.BarGaugeLCD,
|
|
SuggestionName.Table,
|
|
]);
|
|
});
|
|
});
|
|
|
|
scenario('Single frame with only string field', (ctx) => {
|
|
ctx.setData([
|
|
toDataFrame({
|
|
fields: [{ name: 'Name', type: FieldType.string, values: ['Hugo', 'Dominik', 'Marcus'] }],
|
|
}),
|
|
]);
|
|
|
|
it('should return correct suggestions', () => {
|
|
expect(ctx.names()).toEqual([SuggestionName.Stat, SuggestionName.Table]);
|
|
});
|
|
|
|
it('Stat panels have reduceOptions.fields set to show all fields', () => {
|
|
for (const suggestion of ctx.suggestions) {
|
|
if (suggestion.options?.reduceOptions) {
|
|
expect(suggestion.options.reduceOptions.fields).toBe('/.*/');
|
|
}
|
|
}
|
|
});
|
|
});
|
|
|
|
scenario('Given default loki logs data', (ctx) => {
|
|
ctx.setData([
|
|
toDataFrame({
|
|
fields: [
|
|
{ name: 'ts', type: FieldType.time, values: ['2021-11-11T13:38:45.440Z', '2021-11-11T13:38:45.190Z'] },
|
|
{
|
|
name: 'line',
|
|
type: FieldType.string,
|
|
values: [
|
|
't=2021-11-11T14:38:45+0100 lvl=dbug msg="Client connected" logger=live user=1 client=ee79155b-a8d1-4730-bcb3-94d8690df35c',
|
|
't=2021-11-11T14:38:45+0100 lvl=dbug msg="Adding CSP header to response" logger=http.server cfg=0xc0005fed00',
|
|
],
|
|
labels: { filename: '/var/log/grafana/grafana.log', job: 'grafana' },
|
|
},
|
|
],
|
|
meta: {
|
|
preferredVisualisationType: 'logs',
|
|
},
|
|
}),
|
|
]);
|
|
|
|
it('should return correct suggestions', () => {
|
|
expect(ctx.names()).toEqual([SuggestionName.Logs, SuggestionName.Table]);
|
|
});
|
|
});
|
|
|
|
scenario('Given a preferredVisualisationType', (ctx) => {
|
|
ctx.setData([
|
|
toDataFrame({
|
|
meta: {
|
|
preferredVisualisationType: 'table',
|
|
},
|
|
fields: [
|
|
{
|
|
name: 'Trace Id',
|
|
type: FieldType.number,
|
|
values: [1, 2, 3],
|
|
config: {},
|
|
},
|
|
{ name: 'Trace Group', type: FieldType.string, values: ['traceGroup1', 'traceGroup2', 'traceGroup3'] },
|
|
],
|
|
}),
|
|
]);
|
|
|
|
it('should return the preferred visualization first', () => {
|
|
expect(ctx.names()[0]).toEqual(SuggestionName.Table);
|
|
});
|
|
});
|
|
|
|
function repeatFrame(count: number, frame: DataFrame): DataFrame[] {
|
|
const frames: DataFrame[] = [];
|
|
for (let i = 0; i < count; i++) {
|
|
frames.push(frame);
|
|
}
|
|
return frames;
|
|
}
|