mirror of
https://github.com/grafana/grafana.git
synced 2024-11-29 20:24:18 -06:00
cc65b4d46a
* [Chore] Remove setting provider from secret service Co-authored-by: Tania B <yalyna.ts@gmail.com> Co-authored-by: Joan López de la Franca Beltran <joanjan14@gmail.com> * Add a ShouldBeRedacted func Co-authored-by: Tania B <yalyna.ts@gmail.com> Co-authored-by: Joan López de la Franca Beltran <joanjan14@gmail.com> * Secrets: Make Migrator extensible Co-authored-by: Gabriel MABILLE <gamab@users.noreply.github.com> Co-authored-by: Tania B <yalyna.ts@gmail.com> * Alerting: Fix tests after refactor Co-authored-by: Gabriel MABILLE <gamab@users.noreply.github.com> Co-authored-by: Tania B <yalyna.ts@gmail.com> * Remove commented code no longer used * Fix Wire bindings Co-authored-by: Tania B <yalyna.ts@gmail.com> * Add constructors to secrets * Linting * Undo undesired change --------- Co-authored-by: gamab <gabi.mabs@gmail.com> Co-authored-by: Tania B <yalyna.ts@gmail.com> Co-authored-by: Gabriel MABILLE <gamab@users.noreply.github.com>
232 lines
8.3 KiB
Go
232 lines
8.3 KiB
Go
package alerting
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
"math"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/stretchr/testify/require"
|
|
|
|
"github.com/grafana/grafana/pkg/components/simplejson"
|
|
"github.com/grafana/grafana/pkg/infra/localcache"
|
|
"github.com/grafana/grafana/pkg/infra/tracing"
|
|
"github.com/grafana/grafana/pkg/infra/usagestats"
|
|
"github.com/grafana/grafana/pkg/infra/usagestats/validator"
|
|
"github.com/grafana/grafana/pkg/services/alerting/models"
|
|
"github.com/grafana/grafana/pkg/services/annotations/annotationstest"
|
|
"github.com/grafana/grafana/pkg/services/dashboards"
|
|
"github.com/grafana/grafana/pkg/services/datasources"
|
|
fd "github.com/grafana/grafana/pkg/services/datasources/fakes"
|
|
encryptionprovider "github.com/grafana/grafana/pkg/services/encryption/provider"
|
|
encryptionservice "github.com/grafana/grafana/pkg/services/encryption/service"
|
|
"github.com/grafana/grafana/pkg/setting"
|
|
)
|
|
|
|
type FakeEvalHandler struct {
|
|
SuccessCallID int // 0 means never success
|
|
CallNb int
|
|
}
|
|
|
|
func NewFakeEvalHandler(successCallID int) *FakeEvalHandler {
|
|
return &FakeEvalHandler{
|
|
SuccessCallID: successCallID,
|
|
CallNb: 0,
|
|
}
|
|
}
|
|
|
|
func (handler *FakeEvalHandler) Eval(evalContext *EvalContext) {
|
|
handler.CallNb++
|
|
if handler.CallNb != handler.SuccessCallID {
|
|
evalContext.Error = errors.New("Fake evaluation failure")
|
|
}
|
|
}
|
|
|
|
type FakeResultHandler struct{}
|
|
|
|
func (handler *FakeResultHandler) handle(evalContext *EvalContext) error {
|
|
return nil
|
|
}
|
|
|
|
// A mock implementation of the AlertStore interface, allowing to override certain methods individually
|
|
type AlertStoreMock struct {
|
|
getAllAlerts func(context.Context, *models.GetAllAlertsQuery) ([]*models.Alert, error)
|
|
getAlertNotificationsWithUidToSend func(ctx context.Context, query *models.GetAlertNotificationsWithUidToSendQuery) ([]*models.AlertNotification, error)
|
|
getOrCreateNotificationState func(ctx context.Context, query *models.GetOrCreateNotificationStateQuery) (*models.AlertNotificationState, error)
|
|
}
|
|
|
|
func (a *AlertStoreMock) GetAlertById(c context.Context, cmd *models.GetAlertByIdQuery) (res *models.Alert, err error) {
|
|
return nil, nil
|
|
}
|
|
|
|
func (a *AlertStoreMock) GetAllAlertQueryHandler(c context.Context, cmd *models.GetAllAlertsQuery) (res []*models.Alert, err error) {
|
|
if a.getAllAlerts != nil {
|
|
return a.getAllAlerts(c, cmd)
|
|
}
|
|
return nil, nil
|
|
}
|
|
|
|
func (a *AlertStoreMock) GetAlertNotificationUidWithId(c context.Context, query *models.GetAlertNotificationUidQuery) (res string, err error) {
|
|
return "", nil
|
|
}
|
|
|
|
func (a *AlertStoreMock) GetAlertNotificationsWithUidToSend(c context.Context, cmd *models.GetAlertNotificationsWithUidToSendQuery) (res []*models.AlertNotification, err error) {
|
|
if a.getAlertNotificationsWithUidToSend != nil {
|
|
return a.getAlertNotificationsWithUidToSend(c, cmd)
|
|
}
|
|
return nil, nil
|
|
}
|
|
|
|
func (a *AlertStoreMock) GetOrCreateAlertNotificationState(c context.Context, cmd *models.GetOrCreateNotificationStateQuery) (res *models.AlertNotificationState, err error) {
|
|
if a.getOrCreateNotificationState != nil {
|
|
return a.getOrCreateNotificationState(c, cmd)
|
|
}
|
|
return nil, nil
|
|
}
|
|
|
|
func (a *AlertStoreMock) GetDashboardUIDById(_ context.Context, _ *dashboards.GetDashboardRefByIDQuery) error {
|
|
return nil
|
|
}
|
|
|
|
func (a *AlertStoreMock) SetAlertNotificationStateToCompleteCommand(_ context.Context, _ *models.SetAlertNotificationStateToCompleteCommand) error {
|
|
return nil
|
|
}
|
|
|
|
func (a *AlertStoreMock) SetAlertNotificationStateToPendingCommand(_ context.Context, _ *models.SetAlertNotificationStateToPendingCommand) error {
|
|
return nil
|
|
}
|
|
|
|
func (a *AlertStoreMock) SetAlertState(_ context.Context, _ *models.SetAlertStateCommand) (res models.Alert, err error) {
|
|
return models.Alert{}, nil
|
|
}
|
|
|
|
func (a *AlertStoreMock) GetAlertStatesForDashboard(_ context.Context, _ *models.GetAlertStatesForDashboardQuery) (res []*models.AlertStateInfoDTO, err error) {
|
|
return nil, nil
|
|
}
|
|
|
|
func (a *AlertStoreMock) HandleAlertsQuery(context.Context, *models.GetAlertsQuery) (res []*models.AlertListItemDTO, err error) {
|
|
return nil, nil
|
|
}
|
|
|
|
func (a *AlertStoreMock) PauseAlert(context.Context, *models.PauseAlertCommand) error {
|
|
return nil
|
|
}
|
|
|
|
func (a *AlertStoreMock) PauseAllAlerts(context.Context, *models.PauseAllAlertCommand) error {
|
|
return nil
|
|
}
|
|
|
|
func TestEngineProcessJob(t *testing.T) {
|
|
usMock := &usagestats.UsageStatsMock{T: t}
|
|
usValidatorMock := &validator.FakeUsageStatsValidator{}
|
|
|
|
encProvider := encryptionprovider.ProvideEncryptionProvider()
|
|
encService, err := encryptionservice.ProvideEncryptionService(encProvider, usMock, setting.NewCfg())
|
|
require.NoError(t, err)
|
|
tracer := tracing.InitializeTracerForTest()
|
|
|
|
store := &AlertStoreMock{}
|
|
dsMock := &fd.FakeDataSourceService{
|
|
DataSources: []*datasources.DataSource{{ID: 1, Type: datasources.DS_PROMETHEUS}},
|
|
}
|
|
engine := ProvideAlertEngine(nil, nil, nil, usMock, usValidatorMock, encService, nil, tracer, store, setting.NewCfg(), nil, nil, localcache.New(time.Minute, time.Minute), dsMock, annotationstest.NewFakeAnnotationsRepo())
|
|
setting.AlertingEvaluationTimeout = 30 * time.Second
|
|
setting.AlertingNotificationTimeout = 30 * time.Second
|
|
setting.AlertingMaxAttempts = 3
|
|
engine.resultHandler = &FakeResultHandler{}
|
|
job := &Job{running: true, Rule: &Rule{}}
|
|
|
|
t.Run("Should register usage metrics func", func(t *testing.T) {
|
|
store.getAllAlerts = func(ctx context.Context, q *models.GetAllAlertsQuery) (res []*models.Alert, err error) {
|
|
settings, err := simplejson.NewJson([]byte(`{"conditions": [{"query": { "datasourceId": 1}}]}`))
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
return []*models.Alert{{Settings: settings}}, nil
|
|
}
|
|
|
|
report, err := usMock.GetUsageReport(context.Background())
|
|
require.Nil(t, err)
|
|
|
|
require.Equal(t, 1, report.Metrics["stats.alerting.ds.prometheus.count"])
|
|
require.Equal(t, 0, report.Metrics["stats.alerting.ds.other.count"])
|
|
})
|
|
|
|
t.Run("Should trigger retry if needed", func(t *testing.T) {
|
|
t.Run("error + not last attempt -> retry", func(t *testing.T) {
|
|
engine.evalHandler = NewFakeEvalHandler(0)
|
|
|
|
for i := 1; i < setting.AlertingMaxAttempts; i++ {
|
|
attemptChan := make(chan int, 1)
|
|
cancelChan := make(chan context.CancelFunc, setting.AlertingMaxAttempts)
|
|
|
|
engine.processJob(i, attemptChan, cancelChan, job)
|
|
nextAttemptID, more := <-attemptChan
|
|
|
|
require.Equal(t, i+1, nextAttemptID)
|
|
require.Equal(t, true, more)
|
|
require.NotNil(t, <-cancelChan)
|
|
}
|
|
})
|
|
|
|
t.Run("error + last attempt -> no retry", func(t *testing.T) {
|
|
engine.evalHandler = NewFakeEvalHandler(0)
|
|
attemptChan := make(chan int, 1)
|
|
cancelChan := make(chan context.CancelFunc, setting.AlertingMaxAttempts)
|
|
|
|
engine.processJob(setting.AlertingMaxAttempts, attemptChan, cancelChan, job)
|
|
nextAttemptID, more := <-attemptChan
|
|
|
|
require.Equal(t, 0, nextAttemptID)
|
|
require.Equal(t, false, more)
|
|
require.NotNil(t, <-cancelChan)
|
|
})
|
|
|
|
t.Run("no error -> no retry", func(t *testing.T) {
|
|
engine.evalHandler = NewFakeEvalHandler(1)
|
|
attemptChan := make(chan int, 1)
|
|
cancelChan := make(chan context.CancelFunc, setting.AlertingMaxAttempts)
|
|
|
|
engine.processJob(1, attemptChan, cancelChan, job)
|
|
nextAttemptID, more := <-attemptChan
|
|
|
|
require.Equal(t, 0, nextAttemptID)
|
|
require.Equal(t, false, more)
|
|
require.NotNil(t, <-cancelChan)
|
|
})
|
|
})
|
|
|
|
t.Run("Should trigger as many retries as needed", func(t *testing.T) {
|
|
t.Run("never success -> max retries number", func(t *testing.T) {
|
|
expectedAttempts := setting.AlertingMaxAttempts
|
|
evalHandler := NewFakeEvalHandler(0)
|
|
engine.evalHandler = evalHandler
|
|
|
|
err := engine.processJobWithRetry(context.Background(), job)
|
|
require.Nil(t, err)
|
|
require.Equal(t, expectedAttempts, evalHandler.CallNb)
|
|
})
|
|
|
|
t.Run("always success -> never retry", func(t *testing.T) {
|
|
expectedAttempts := 1
|
|
evalHandler := NewFakeEvalHandler(1)
|
|
engine.evalHandler = evalHandler
|
|
|
|
err := engine.processJobWithRetry(context.Background(), job)
|
|
require.Nil(t, err)
|
|
require.Equal(t, expectedAttempts, evalHandler.CallNb)
|
|
})
|
|
|
|
t.Run("some errors before success -> some retries", func(t *testing.T) {
|
|
expectedAttempts := int(math.Ceil(float64(setting.AlertingMaxAttempts) / 2))
|
|
evalHandler := NewFakeEvalHandler(expectedAttempts)
|
|
engine.evalHandler = evalHandler
|
|
|
|
err := engine.processJobWithRetry(context.Background(), job)
|
|
require.Nil(t, err)
|
|
require.Equal(t, expectedAttempts, evalHandler.CallNb)
|
|
})
|
|
})
|
|
}
|