mirror of
https://github.com/grafana/grafana.git
synced 2025-02-25 18:55:37 -06:00
9e8efaa459
Adds three functions: `withStoredImages` iterates over a list of models.Alerts, extracting a stored image's data from storage, if available, and executing a user-provided function. `withStoredImage` does this for an image attached to a specific alert. `openImage` finds and opens an image file on disk. Moves `store.Image` to `models.Image` Simplifies `channels.ImageStore` interface and updates notifiers that use it to use the simpler methods. Updates all pkg/alert/notifier/channels to use withStoredImage routines.
107 lines
2.4 KiB
Go
107 lines
2.4 KiB
Go
package state
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"math/rand"
|
|
"testing"
|
|
|
|
"github.com/grafana/grafana/pkg/infra/log"
|
|
"github.com/grafana/grafana/pkg/services/dashboards"
|
|
"github.com/grafana/grafana/pkg/services/ngalert/eval"
|
|
"github.com/grafana/grafana/pkg/services/ngalert/metrics"
|
|
ngmodels "github.com/grafana/grafana/pkg/services/ngalert/models"
|
|
"github.com/grafana/grafana/pkg/services/ngalert/store"
|
|
"github.com/grafana/grafana/pkg/services/sqlstore/mockstore"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
// Not for parallel tests.
|
|
type CountingImageService struct {
|
|
Called int
|
|
}
|
|
|
|
func (c *CountingImageService) NewImage(_ context.Context, _ *ngmodels.AlertRule) (*ngmodels.Image, error) {
|
|
c.Called += 1
|
|
return &ngmodels.Image{
|
|
Token: fmt.Sprint(rand.Int()),
|
|
}, nil
|
|
}
|
|
|
|
func Test_maybeNewImage(t *testing.T) {
|
|
tests := []struct {
|
|
description string
|
|
shouldScreenshot bool
|
|
state *State
|
|
oldState eval.State
|
|
}{
|
|
{
|
|
"Take a screenshot when we change to an alerting state",
|
|
true,
|
|
&State{
|
|
State: eval.Alerting,
|
|
Image: &ngmodels.Image{
|
|
Token: "erase me",
|
|
},
|
|
},
|
|
eval.Normal,
|
|
},
|
|
{
|
|
"Take a screenshot if we're already alerting with no image",
|
|
true,
|
|
&State{
|
|
State: eval.Alerting,
|
|
},
|
|
eval.Alerting,
|
|
},
|
|
{
|
|
"Take a screenshot if we're resolved.",
|
|
true,
|
|
&State{
|
|
Resolved: true,
|
|
State: eval.Normal,
|
|
Image: &ngmodels.Image{
|
|
Token: "abcd",
|
|
},
|
|
},
|
|
eval.Alerting,
|
|
},
|
|
{
|
|
"Don't take a screenshot if we already have one.",
|
|
false,
|
|
&State{
|
|
State: eval.Alerting,
|
|
Image: &ngmodels.Image{
|
|
Token: "already set",
|
|
},
|
|
},
|
|
eval.Alerting,
|
|
},
|
|
{
|
|
"Don't take a screenshot if we're pending.",
|
|
false,
|
|
&State{
|
|
State: eval.Pending,
|
|
},
|
|
eval.Normal,
|
|
},
|
|
}
|
|
|
|
for _, test := range tests {
|
|
t.Run(test.description, func(t *testing.T) {
|
|
imageService := &CountingImageService{}
|
|
mgr := NewManager(log.NewNopLogger(), &metrics.State{}, nil,
|
|
&store.FakeRuleStore{}, &store.FakeInstanceStore{}, mockstore.NewSQLStoreMock(),
|
|
&dashboards.FakeDashboardService{}, imageService)
|
|
err := mgr.maybeTakeScreenshot(context.Background(), &ngmodels.AlertRule{}, test.state, test.oldState)
|
|
require.NoError(t, err)
|
|
if !test.shouldScreenshot {
|
|
require.Equal(t, 0, imageService.Called)
|
|
} else {
|
|
require.Equal(t, 1, imageService.Called)
|
|
require.NotNil(t, test.state.Image)
|
|
}
|
|
})
|
|
}
|
|
}
|