grafana/public/app/features/dashboard/state/PanelModel.test.ts
Ashley Harrison dcf58555e8
Chore: Some test type fixes (#81812)
some test type fixes
2024-02-05 09:47:30 +00:00

608 lines
19 KiB
TypeScript

import { ComponentClass } from 'react';
import {
FieldConfigProperty,
PanelData,
PanelProps,
standardEditorsRegistry,
standardFieldConfigEditorRegistry,
dateTime,
TimeRange,
PanelMigrationHandler,
PanelTypeChangedHandler,
} from '@grafana/data';
import { getPanelPlugin } from '@grafana/data/test/__mocks__/pluginMocks';
import { mockStandardFieldConfigOptions } from '@grafana/data/test/helpers/fieldConfig';
import { setTemplateSrv } from '@grafana/runtime';
import { queryBuilder } from 'app/features/variables/shared/testing/builders';
import { PanelQueryRunner } from '../../query/state/PanelQueryRunner';
import { TemplateSrv } from '../../templating/template_srv';
import { variableAdapters } from '../../variables/adapters';
import { createQueryVariableAdapter } from '../../variables/query/adapter';
import { TimeOverrideResult } from '../utils/panel';
import { PanelModel } from './PanelModel';
standardFieldConfigEditorRegistry.setInit(() => mockStandardFieldConfigOptions());
standardEditorsRegistry.setInit(() => mockStandardFieldConfigOptions());
const getVariables = () => variablesMock;
const getVariableWithName = (name: string) => variablesMock.filter((v) => v.name === name)[0];
const getFilteredVariables = jest.fn();
setTemplateSrv(
new TemplateSrv({
getVariables,
getVariableWithName,
getFilteredVariables,
})
);
variableAdapters.setInit(() => [createQueryVariableAdapter()]);
describe('PanelModel', () => {
describe('when creating new panel model', () => {
let model: any;
let modelJson: Record<string, unknown>;
let persistedOptionsMock;
const tablePlugin = getPanelPlugin(
{
id: 'table',
},
null as unknown as ComponentClass<PanelProps>, // react
{} // angular
);
tablePlugin.setPanelOptions((builder) => {
builder.addBooleanSwitch({
name: 'Show thresholds',
path: 'showThresholds',
defaultValue: true,
description: '',
});
});
tablePlugin.useFieldConfig({
standardOptions: {
[FieldConfigProperty.Unit]: {
defaultValue: 'flop',
},
[FieldConfigProperty.Decimals]: {
defaultValue: 2,
},
},
useCustomConfig: (builder) => {
builder.addBooleanSwitch({
name: 'CustomProp',
path: 'customProp',
defaultValue: false,
});
},
});
beforeEach(async () => {
persistedOptionsMock = {
fieldOptions: {
thresholds: [
{
color: '#F2495C',
index: 1,
value: 50,
},
{
color: '#73BF69',
index: 0,
value: null,
},
],
},
arrayWith2Values: [{ name: 'changed to only one value' }],
};
modelJson = {
type: 'table',
maxDataPoints: 100,
interval: '5m',
showColumns: true,
targets: [{ refId: 'A' }, { noRefId: true }],
options: persistedOptionsMock,
fieldConfig: {
defaults: {
unit: 'mpg',
thresholds: {
mode: 'absolute',
steps: [
{ color: 'green', value: null },
{ color: 'red', value: 80 },
],
},
},
overrides: [
{
matcher: {
id: '1',
options: {},
},
properties: [
{
id: 'thresholds',
value: {
mode: 'absolute',
steps: [
{ color: 'green', value: null },
{ color: 'red', value: 80 },
],
},
},
],
},
],
},
};
model = new PanelModel(modelJson);
await model.pluginLoaded(tablePlugin);
});
describe('migrations', () => {
let initialMigrator: PanelMigrationHandler<(typeof model)['options']> | undefined = undefined;
beforeEach(() => {
initialMigrator = tablePlugin.onPanelMigration;
});
afterEach(() => {
tablePlugin.onPanelMigration = initialMigrator;
});
it('should run sync migrations', async () => {
model.options.valueToMigrate = 'old-legacy';
tablePlugin.onPanelMigration = (p) => ({ ...p.options, valueToMigrate: 'new-version' });
tablePlugin.onPanelMigration = (p) => {
p.options.valueToMigrate = 'new-version';
return p.options;
};
await model.pluginLoaded(tablePlugin);
expect(model.options).toMatchObject({ valueToMigrate: 'new-version' });
});
it('should run async migrations', async () => {
model.options.valueToMigrate = 'old-legacy';
tablePlugin.onPanelMigration = async (p) =>
new Promise((resolve) => {
setTimeout(() => resolve({ ...p.options, valueToMigrate: 'new-version' }), 10);
});
await model.pluginLoaded(tablePlugin);
expect(model.options).toMatchObject({ valueToMigrate: 'new-version' });
});
});
it('should apply defaults', () => {
expect(model.gridPos.h).toBe(3);
});
it('should apply option defaults', () => {
expect(model.getOptions().showThresholds).toBeTruthy();
});
it('should change null thresholds to negative infinity', () => {
expect(model.fieldConfig.defaults.thresholds.steps[0].value).toBe(-Infinity);
expect(model.fieldConfig.overrides[0].properties[0].value.steps[0].value).toBe(-Infinity);
});
it('should apply option defaults but not override if array is changed', () => {
expect(model.getOptions().arrayWith2Values.length).toBe(1);
});
it('should apply field config defaults', () => {
// default unit is overriden by model
expect(model.getFieldOverrideOptions().fieldConfig.defaults.unit).toBe('mpg');
// default decimals are aplied
expect(model.getFieldOverrideOptions().fieldConfig.defaults.decimals).toBe(2);
});
it('should set model props on instance', () => {
expect(model.showColumns).toBe(true);
});
it('should add missing refIds', () => {
expect(model.targets[1].refId).toBe('B');
});
it("shouldn't break panel with non-array targets", () => {
modelJson.targets = {
0: { refId: 'A' },
foo: { bar: 'baz' },
};
model = new PanelModel(modelJson);
expect(model.targets[0].refId).toBe('A');
});
it('getSaveModel should remove defaults', () => {
const saveModel = model.getSaveModel();
expect(saveModel.gridPos).toBe(undefined);
});
it('getSaveModel should remove nonPersistedProperties', () => {
const saveModel = model.getSaveModel();
expect(saveModel.events).toBe(undefined);
});
it('getSaveModel should clean libraryPanels from a collapsed row', () => {
const newmodelJson = {
type: 'row',
panels: [
{
...modelJson,
libraryPanel: {
uid: 'BVIBScisnl',
model: modelJson,
name: 'Library panel title',
},
},
modelJson,
],
};
const newmodel = new PanelModel(newmodelJson);
const saveModel = newmodel.getSaveModel();
expect(saveModel.panels[0].tagrets).toBe(undefined);
expect(saveModel.panels[1].targets).toBeTruthy();
});
describe('variables interpolation', () => {
beforeEach(() => {
model.scopedVars = {
aaa: { value: 'AAA', text: 'upperA' },
bbb: { value: 'BBB', text: 'upperB' },
};
});
it('should interpolate variables', () => {
const out = model.replaceVariables('hello $aaa');
expect(out).toBe('hello AAA');
});
it('should prefer the local variable value', () => {
const extra = { aaa: { text: '???', value: 'XXX' } };
const out = model.replaceVariables('hello $aaa and $bbb', extra);
expect(out).toBe('hello XXX and BBB');
});
it('Can use request scoped vars', () => {
model.getQueryRunner().getLastRequest = () => {
return {
scopedVars: {
__interval: { text: '10m', value: '10m' },
},
};
};
const out = model.replaceVariables('hello $__interval');
expect(out).toBe('hello 10m');
});
});
describe('when changing panel type', () => {
beforeEach(() => {
const newPlugin = getPanelPlugin({ id: 'graph' });
newPlugin.useFieldConfig({
standardOptions: {
[FieldConfigProperty.Color]: {
settings: {
byThresholdsSupport: true,
},
},
},
useCustomConfig: (builder) => {
builder.addNumberInput({
path: 'customProp',
name: 'customProp',
defaultValue: 100,
});
},
});
newPlugin.setPanelOptions((builder) => {
builder.addBooleanSwitch({
name: 'Show thresholds labels',
path: 'showThresholdLabels',
defaultValue: false,
description: '',
});
});
model.fieldConfig.defaults.decimals = 3;
model.fieldConfig.defaults.custom = {
customProp: true,
};
model.fieldConfig.overrides = [
{
matcher: { id: 'byName', options: 'D-series' },
properties: [
{
id: 'custom.customProp',
value: false,
},
{
id: 'decimals',
value: 0,
},
],
},
];
model.changePlugin(newPlugin);
model.alert = { id: 2 };
});
it('should keep maxDataPoints', () => {
expect(model.maxDataPoints).toBe(100);
});
it('should keep interval', () => {
expect(model.interval).toBe('5m');
});
it('should preseve standard field config', () => {
expect(model.fieldConfig.defaults.decimals).toEqual(3);
});
it('should clear custom field config and apply new defaults', () => {
expect(model.fieldConfig.defaults.custom).toEqual({
customProp: 100,
});
});
it('should remove overrides with custom props', () => {
expect(model.fieldConfig.overrides.length).toEqual(1);
expect(model.fieldConfig.overrides[0].properties[0].id).toEqual('decimals');
});
it('should apply next panel option defaults', () => {
expect(model.getOptions().showThresholdLabels).toBeFalsy();
expect(model.getOptions().showThresholds).toBeUndefined();
});
it('should remove table properties but keep core props', () => {
expect(model.showColumns).toBe(undefined);
});
it('should restore table properties when changing back', () => {
model.changePlugin(tablePlugin);
expect(model.showColumns).toBe(true);
});
it('should restore custom field config to what it was and preserve standard options', () => {
model.changePlugin(tablePlugin);
expect(model.fieldConfig.defaults.custom.customProp).toBe(true);
});
it('should remove alert rule when changing type that does not support it', () => {
model.changePlugin(getPanelPlugin({ id: 'table' }));
expect(model.alert).toBe(undefined);
});
});
describe('when changing to react panel from angular panel', () => {
let panelQueryRunner: PanelQueryRunner;
const onPanelTypeChanged = jest.fn();
const reactPlugin = getPanelPlugin({ id: 'react' }).setPanelChangeHandler(
onPanelTypeChanged as PanelTypeChangedHandler
);
beforeEach(() => {
model.changePlugin(reactPlugin);
panelQueryRunner = model.getQueryRunner();
});
it('should call react onPanelTypeChanged', () => {
expect(onPanelTypeChanged.mock.calls.length).toBe(1);
expect(onPanelTypeChanged.mock.calls[0][1]).toBe('table');
expect(onPanelTypeChanged.mock.calls[0][2].angular).toBeDefined();
});
it('getQueryRunner() should return same instance after changing to another react panel', () => {
model.changePlugin(getPanelPlugin({ id: 'react2' }));
const sameQueryRunner = model.getQueryRunner();
expect(panelQueryRunner).toBe(sameQueryRunner);
});
});
describe('when autoMigrateFrom angular to react', () => {
const onPanelTypeChanged: PanelTypeChangedHandler = (panel, prevPluginId, prevOptions) => {
panel.fieldConfig = { defaults: { unit: 'bytes' }, overrides: [] };
return { name: prevOptions.angular.oldName };
};
const reactPlugin = getPanelPlugin({ id: 'timeseries' })
.setPanelChangeHandler(onPanelTypeChanged)
.useFieldConfig({
disableStandardOptions: [FieldConfigProperty.Thresholds],
})
.setPanelOptions((builder) => {
builder.addTextInput({
name: 'Name',
path: 'name',
});
});
beforeEach(() => {
model = new PanelModel({
autoMigrateFrom: 'graph',
oldName: 'old name',
type: 'timeseries',
});
model.pluginLoaded(reactPlugin);
});
it('should run panel changed handler and remove old model props', () => {
expect(model.options).toEqual({ name: 'old name' });
expect(model.fieldConfig).toEqual({ defaults: { unit: 'bytes' }, overrides: [] });
expect(model.autoMigrateFrom).toBe(undefined);
expect(model.oldName).toBe(undefined);
expect(model.plugin).toBe(reactPlugin);
expect(model.type).toBe('timeseries');
});
});
describe('variables interpolation', () => {
let panelQueryRunner: PanelQueryRunner;
const onPanelTypeChanged = jest.fn();
const reactPlugin = getPanelPlugin({ id: 'react' }).setPanelChangeHandler(
onPanelTypeChanged as PanelTypeChangedHandler
);
beforeEach(() => {
model.changePlugin(reactPlugin);
panelQueryRunner = model.getQueryRunner();
});
it('should call react onPanelTypeChanged', () => {
expect(onPanelTypeChanged.mock.calls.length).toBe(1);
expect(onPanelTypeChanged.mock.calls[0][1]).toBe('table');
expect(onPanelTypeChanged.mock.calls[0][2].angular).toBeDefined();
});
it('getQueryRunner() should return same instance after changing to another react panel', () => {
model.changePlugin(getPanelPlugin({ id: 'react2' }));
const sameQueryRunner = model.getQueryRunner();
expect(panelQueryRunner).toBe(sameQueryRunner);
});
});
describe('restoreModel', () => {
it('Should clean state and set properties from model', () => {
model.restoreModel({
title: 'New title',
options: { new: true },
});
expect(model.title).toBe('New title');
expect(model.options.new).toBe(true);
});
it('Should delete properties that are now gone on new model', () => {
model.someProperty = 'value';
model.restoreModel({
title: 'New title',
options: {},
});
expect(model.someProperty).toBeUndefined();
});
it('Should remove old angular panel specific props', () => {
model.axes = [{ prop: 1 }];
model.thresholds = [];
model.restoreModel({
title: 'New title',
options: {},
});
expect(model.axes).toBeUndefined();
expect(model.thresholds).toBeUndefined();
});
it('Should be able to set defaults back to default', () => {
model.transparent = true;
model.restoreModel({});
expect(model.transparent).toBe(false);
});
});
describe('updateGridPos', () => {
it('Should not have changes if no change', () => {
model.gridPos = { w: 1, h: 1, x: 1, y: 2 };
model.updateGridPos({ w: 1, h: 1, x: 1, y: 2 });
expect(model.hasChanged).toBe(false);
});
it('Should have changes if gridPos is different', () => {
model.gridPos = { w: 1, h: 1, x: 1, y: 2 };
model.updateGridPos({ w: 10, h: 1, x: 1, y: 2 });
expect(model.hasChanged).toBe(true);
});
it('Should not have changes if not manually updated', () => {
model.gridPos = { w: 1, h: 1, x: 1, y: 2 };
model.updateGridPos({ w: 10, h: 1, x: 1, y: 2 }, false);
expect(model.hasChanged).toBe(false);
});
});
describe('destroy', () => {
it('Should still preserve last query result', () => {
model.getQueryRunner().useLastResultFrom({
getLastResult: () => ({}) as PanelData,
} as PanelQueryRunner);
model.destroy();
expect(model.getQueryRunner().getLastResult()).toBeDefined();
});
});
describe('getDisplayTitle', () => {
it('when called then it should interpolate singe value variables in title', () => {
const model = new PanelModel({
title: 'Single value variable [[test3]] ${test3} ${test3:percentencode}',
});
const title = model.getDisplayTitle();
expect(title).toEqual('Single value variable Value 3 Value 3 Value%203');
});
it('when called then it should interpolate multi value variables in title', () => {
const model = new PanelModel({
title: 'Multi value variable [[test4]] ${test4} ${test4:percentencode}',
});
const title = model.getDisplayTitle();
expect(title).toEqual('Multi value variable A + B A + B %7BA%2CB%7D');
});
});
describe('runAllPanelQueries', () => {
it('when called then it should call all pending queries', () => {
model.getQueryRunner = jest.fn().mockReturnValue({
run: jest.fn(),
});
const dashboardId = 123;
const dashboardUID = 'ggHbN42mk';
const dashboardTimezone = 'browser';
const width = 860;
const timeData = {
timeInfo: '',
timeRange: {
from: dateTime([2019, 1, 11, 12, 0]),
to: dateTime([2019, 1, 11, 18, 0]),
raw: {
from: 'now-6h',
to: 'now',
},
} as TimeRange,
} as TimeOverrideResult;
model.runAllPanelQueries({ dashboardId, dashboardUID, dashboardTimezone, timeData, width });
expect(model.getQueryRunner).toBeCalled();
});
});
});
});
const variablesMock = [
queryBuilder().withId('test1').withName('test1').withCurrent('val1').build(),
queryBuilder().withId('test2').withName('test2').withCurrent('val2').build(),
queryBuilder().withId('test3').withName('test3').withCurrent('Value 3').build(),
queryBuilder().withId('test4').withName('test4').withCurrent(['A', 'B']).build(),
];