mirror of
https://github.com/grafana/grafana.git
synced 2024-12-01 21:19:28 -06:00
0b4af38bfa
* passes id and uid to PublicDashboardDatasource * betterer results * If for a public dashboard, return the PublicDashboardDataSource first or else getDatasourceSrv.get() will fail bc of no authed user. Added some unit tests for resolving the uid from the many possible datasource types. * updates betterer * Exports DashboardService. Adds method to DashboardService to build anonymous user for use with public dashboards where there is no authed user. Adds method on dashboard_queries to get all dashboard uids from a dashboard. * refactors to get unique datasource uids * Adds tests for getting all unique datasource uids off a dashboard * adds test for building anonymous user with read and query actions that are scoped to each datasource uid in the dashboard * updates casing of DashboardService * updates test case to have additional panel with a different datasource * gives default interval to public dashboard data source
150 lines
4.5 KiB
Go
150 lines
4.5 KiB
Go
package api
|
|
|
|
import (
|
|
"errors"
|
|
"net/http"
|
|
"time"
|
|
|
|
"github.com/grafana/grafana/pkg/api/apierrors"
|
|
"github.com/grafana/grafana/pkg/api/dtos"
|
|
"github.com/grafana/grafana/pkg/api/response"
|
|
"github.com/grafana/grafana/pkg/models"
|
|
"github.com/grafana/grafana/pkg/services/dashboards"
|
|
"github.com/grafana/grafana/pkg/services/guardian"
|
|
"github.com/grafana/grafana/pkg/util"
|
|
"github.com/grafana/grafana/pkg/web"
|
|
)
|
|
|
|
func (hs *HTTPServer) GetFolderPermissionList(c *models.ReqContext) response.Response {
|
|
folder, err := hs.folderService.GetFolderByUID(c.Req.Context(), c.SignedInUser, c.OrgId, web.Params(c.Req)[":uid"])
|
|
|
|
if err != nil {
|
|
return apierrors.ToFolderErrorResponse(err)
|
|
}
|
|
|
|
g := guardian.New(c.Req.Context(), folder.Id, c.OrgId, c.SignedInUser)
|
|
|
|
if canAdmin, err := g.CanAdmin(); err != nil || !canAdmin {
|
|
return apierrors.ToFolderErrorResponse(dashboards.ErrFolderAccessDenied)
|
|
}
|
|
|
|
acl, err := g.GetAcl()
|
|
if err != nil {
|
|
return response.Error(500, "Failed to get folder permissions", err)
|
|
}
|
|
|
|
filteredAcls := make([]*models.DashboardAclInfoDTO, 0, len(acl))
|
|
for _, perm := range acl {
|
|
if perm.UserId > 0 && dtos.IsHiddenUser(perm.UserLogin, c.SignedInUser, hs.Cfg) {
|
|
continue
|
|
}
|
|
|
|
perm.FolderId = folder.Id
|
|
perm.DashboardId = 0
|
|
|
|
perm.UserAvatarUrl = dtos.GetGravatarUrl(perm.UserEmail)
|
|
|
|
if perm.TeamId > 0 {
|
|
perm.TeamAvatarUrl = dtos.GetGravatarUrlWithDefault(perm.TeamEmail, perm.Team)
|
|
}
|
|
|
|
if perm.Slug != "" {
|
|
perm.Url = models.GetDashboardFolderUrl(perm.IsFolder, perm.Uid, perm.Slug)
|
|
}
|
|
|
|
filteredAcls = append(filteredAcls, perm)
|
|
}
|
|
|
|
return response.JSON(http.StatusOK, filteredAcls)
|
|
}
|
|
|
|
func (hs *HTTPServer) UpdateFolderPermissions(c *models.ReqContext) response.Response {
|
|
apiCmd := dtos.UpdateDashboardAclCommand{}
|
|
if err := web.Bind(c.Req, &apiCmd); err != nil {
|
|
return response.Error(http.StatusBadRequest, "bad request data", err)
|
|
}
|
|
if err := validatePermissionsUpdate(apiCmd); err != nil {
|
|
return response.Error(400, err.Error(), err)
|
|
}
|
|
|
|
folder, err := hs.folderService.GetFolderByUID(c.Req.Context(), c.SignedInUser, c.OrgId, web.Params(c.Req)[":uid"])
|
|
if err != nil {
|
|
return apierrors.ToFolderErrorResponse(err)
|
|
}
|
|
|
|
g := guardian.New(c.Req.Context(), folder.Id, c.OrgId, c.SignedInUser)
|
|
canAdmin, err := g.CanAdmin()
|
|
if err != nil {
|
|
return apierrors.ToFolderErrorResponse(err)
|
|
}
|
|
|
|
if !canAdmin {
|
|
return apierrors.ToFolderErrorResponse(dashboards.ErrFolderAccessDenied)
|
|
}
|
|
|
|
var items []*models.DashboardAcl
|
|
for _, item := range apiCmd.Items {
|
|
items = append(items, &models.DashboardAcl{
|
|
OrgID: c.OrgId,
|
|
DashboardID: folder.Id,
|
|
UserID: item.UserID,
|
|
TeamID: item.TeamID,
|
|
Role: item.Role,
|
|
Permission: item.Permission,
|
|
Created: time.Now(),
|
|
Updated: time.Now(),
|
|
})
|
|
}
|
|
|
|
hiddenACL, err := g.GetHiddenACL(hs.Cfg)
|
|
if err != nil {
|
|
return response.Error(500, "Error while retrieving hidden permissions", err)
|
|
}
|
|
items = append(items, hiddenACL...)
|
|
|
|
if okToUpdate, err := g.CheckPermissionBeforeUpdate(models.PERMISSION_ADMIN, items); err != nil || !okToUpdate {
|
|
if err != nil {
|
|
if errors.Is(err, guardian.ErrGuardianPermissionExists) ||
|
|
errors.Is(err, guardian.ErrGuardianOverride) {
|
|
return response.Error(400, err.Error(), err)
|
|
}
|
|
|
|
return response.Error(500, "Error while checking folder permissions", err)
|
|
}
|
|
|
|
return response.Error(403, "Cannot remove own admin permission for a folder", nil)
|
|
}
|
|
|
|
if !hs.AccessControl.IsDisabled() {
|
|
old, err := g.GetAcl()
|
|
if err != nil {
|
|
return response.Error(500, "Error while checking dashboard permissions", err)
|
|
}
|
|
if err := hs.updateDashboardAccessControl(c.Req.Context(), c.OrgId, folder.Uid, true, items, old); err != nil {
|
|
return response.Error(500, "Failed to create permission", err)
|
|
}
|
|
return response.Success("Dashboard permissions updated")
|
|
}
|
|
|
|
if err := hs.DashboardService.UpdateDashboardACL(c.Req.Context(), folder.Id, items); err != nil {
|
|
if errors.Is(err, models.ErrDashboardAclInfoMissing) {
|
|
err = models.ErrFolderAclInfoMissing
|
|
}
|
|
if errors.Is(err, models.ErrDashboardPermissionDashboardEmpty) {
|
|
err = models.ErrFolderPermissionFolderEmpty
|
|
}
|
|
|
|
if errors.Is(err, models.ErrFolderAclInfoMissing) || errors.Is(err, models.ErrFolderPermissionFolderEmpty) {
|
|
return response.Error(409, err.Error(), err)
|
|
}
|
|
|
|
return response.Error(500, "Failed to create permission", err)
|
|
}
|
|
|
|
return response.JSON(http.StatusOK, util.DynMap{
|
|
"message": "Folder permissions updated",
|
|
"id": folder.Id,
|
|
"title": folder.Title,
|
|
})
|
|
}
|