mirror of
https://github.com/grafana/grafana.git
synced 2025-02-15 01:53:33 -06:00
5dca9fd4d8
* wip * wip: * ui work for resource picker * disable rows when others are selected * resource picker open button * Azure Monitor: Connect to backend with real data (#34024) * Connect to backend with real data * Fixes from code review. * WIP:Begin thinking about how to make queries with scope determined by the resource picker * More fixes post code review. * Fixes after rebasing * Remove outdated todo * AzureMonitor: Support any resource for Logs queries (#33762) * Apply button for resource picker * scroll table body * secondary cancel button * loading state for nested rows * Display resource components in picker button * fix tests * fix icons * move route function * Migrate from workspace to resource uri for log analytics (#34337) * reword backwards compat comment * remove base url suffix * fix lint error * move migrations to seperate file * cleanup * update regex * cleanup * update plugin routes to use new azure auth type * use AzureDataSourceInstanceSettings alias Co-authored-by: Sarah Zinger <sarahzinger@users.noreply.github.com>
227 lines
8.5 KiB
Go
227 lines
8.5 KiB
Go
package azuremonitor
|
|
|
|
import (
|
|
"fmt"
|
|
"net/url"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/google/go-cmp/cmp"
|
|
"github.com/google/go-cmp/cmp/cmpopts"
|
|
"github.com/grafana/grafana/pkg/components/simplejson"
|
|
"github.com/grafana/grafana/pkg/models"
|
|
"github.com/grafana/grafana/pkg/plugins"
|
|
"github.com/grafana/grafana/pkg/setting"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestBuildingAzureLogAnalyticsQueries(t *testing.T) {
|
|
datasource := &AzureLogAnalyticsDatasource{}
|
|
fromStart := time.Date(2018, 3, 15, 13, 0, 0, 0, time.UTC).In(time.Local)
|
|
|
|
tests := []struct {
|
|
name string
|
|
queryModel []plugins.DataSubQuery
|
|
timeRange plugins.DataTimeRange
|
|
azureLogAnalyticsQueries []*AzureLogAnalyticsQuery
|
|
Err require.ErrorAssertionFunc
|
|
}{
|
|
{
|
|
name: "Query with macros should be interpolated",
|
|
timeRange: plugins.DataTimeRange{
|
|
From: fmt.Sprintf("%v", fromStart.Unix()*1000),
|
|
To: fmt.Sprintf("%v", fromStart.Add(34*time.Minute).Unix()*1000),
|
|
},
|
|
queryModel: []plugins.DataSubQuery{
|
|
{
|
|
DataSource: &models.DataSource{
|
|
JsonData: simplejson.NewFromAny(map[string]interface{}{}),
|
|
},
|
|
Model: simplejson.NewFromAny(map[string]interface{}{
|
|
"queryType": "Azure Log Analytics",
|
|
"azureLogAnalytics": map[string]interface{}{
|
|
"resource": "/subscriptions/aaaaaaaa-bbbb-cccc-dddd-eeeeeeeeeeee/resourceGroups/cloud-datasources/providers/Microsoft.OperationalInsights/workspaces/AppInsightsTestDataWorkspace",
|
|
"query": "query=Perf | where $__timeFilter() | where $__contains(Computer, 'comp1','comp2') | summarize avg(CounterValue) by bin(TimeGenerated, $__interval), Computer",
|
|
"resultFormat": timeSeries,
|
|
},
|
|
}),
|
|
RefID: "A",
|
|
},
|
|
},
|
|
azureLogAnalyticsQueries: []*AzureLogAnalyticsQuery{
|
|
{
|
|
RefID: "A",
|
|
ResultFormat: timeSeries,
|
|
URL: "v1/subscriptions/aaaaaaaa-bbbb-cccc-dddd-eeeeeeeeeeee/resourceGroups/cloud-datasources/providers/Microsoft.OperationalInsights/workspaces/AppInsightsTestDataWorkspace/query",
|
|
Model: simplejson.NewFromAny(map[string]interface{}{
|
|
"azureLogAnalytics": map[string]interface{}{
|
|
"query": "query=Perf | where $__timeFilter() | where $__contains(Computer, 'comp1','comp2') | summarize avg(CounterValue) by bin(TimeGenerated, $__interval), Computer",
|
|
"resultFormat": timeSeries,
|
|
"workspace": "aaaaaaaa-bbbb-cccc-dddd-eeeeeeeeeeee",
|
|
},
|
|
}),
|
|
Params: url.Values{"query": {"query=Perf | where ['TimeGenerated'] >= datetime('2018-03-15T13:00:00Z') and ['TimeGenerated'] <= datetime('2018-03-15T13:34:00Z') | where ['Computer'] in ('comp1','comp2') | summarize avg(CounterValue) by bin(TimeGenerated, 34000ms), Computer"}},
|
|
Target: "query=query%3DPerf+%7C+where+%5B%27TimeGenerated%27%5D+%3E%3D+datetime%28%272018-03-15T13%3A00%3A00Z%27%29+and+%5B%27TimeGenerated%27%5D+%3C%3D+datetime%28%272018-03-15T13%3A34%3A00Z%27%29+%7C+where+%5B%27Computer%27%5D+in+%28%27comp1%27%2C%27comp2%27%29+%7C+summarize+avg%28CounterValue%29+by+bin%28TimeGenerated%2C+34000ms%29%2C+Computer",
|
|
},
|
|
},
|
|
Err: require.NoError,
|
|
}, {
|
|
name: "Legacy workspace queries should use workspace query endpoint",
|
|
timeRange: plugins.DataTimeRange{
|
|
From: fmt.Sprintf("%v", fromStart.Unix()*1000),
|
|
To: fmt.Sprintf("%v", fromStart.Add(34*time.Minute).Unix()*1000),
|
|
},
|
|
queryModel: []plugins.DataSubQuery{
|
|
{
|
|
DataSource: &models.DataSource{
|
|
JsonData: simplejson.NewFromAny(map[string]interface{}{}),
|
|
},
|
|
Model: simplejson.NewFromAny(map[string]interface{}{
|
|
"queryType": "Azure Log Analytics",
|
|
"azureLogAnalytics": map[string]interface{}{
|
|
"workspace": "aaaaaaaa-bbbb-cccc-dddd-eeeeeeeeeeee",
|
|
"query": "query=Perf | where $__timeFilter() | where $__contains(Computer, 'comp1','comp2') | summarize avg(CounterValue) by bin(TimeGenerated, $__interval), Computer",
|
|
"resultFormat": timeSeries,
|
|
},
|
|
}),
|
|
RefID: "A",
|
|
},
|
|
},
|
|
azureLogAnalyticsQueries: []*AzureLogAnalyticsQuery{
|
|
{
|
|
RefID: "A",
|
|
ResultFormat: timeSeries,
|
|
URL: "v1/workspaces/aaaaaaaa-bbbb-cccc-dddd-eeeeeeeeeeee/query",
|
|
Model: simplejson.NewFromAny(map[string]interface{}{
|
|
"azureLogAnalytics": map[string]interface{}{
|
|
"query": "query=Perf | where $__timeFilter() | where $__contains(Computer, 'comp1','comp2') | summarize avg(CounterValue) by bin(TimeGenerated, $__interval), Computer",
|
|
"resultFormat": timeSeries,
|
|
"workspace": "aaaaaaaa-bbbb-cccc-dddd-eeeeeeeeeeee",
|
|
},
|
|
}),
|
|
Params: url.Values{"query": {"query=Perf | where ['TimeGenerated'] >= datetime('2018-03-15T13:00:00Z') and ['TimeGenerated'] <= datetime('2018-03-15T13:34:00Z') | where ['Computer'] in ('comp1','comp2') | summarize avg(CounterValue) by bin(TimeGenerated, 34000ms), Computer"}},
|
|
Target: "query=query%3DPerf+%7C+where+%5B%27TimeGenerated%27%5D+%3E%3D+datetime%28%272018-03-15T13%3A00%3A00Z%27%29+and+%5B%27TimeGenerated%27%5D+%3C%3D+datetime%28%272018-03-15T13%3A34%3A00Z%27%29+%7C+where+%5B%27Computer%27%5D+in+%28%27comp1%27%2C%27comp2%27%29+%7C+summarize+avg%28CounterValue%29+by+bin%28TimeGenerated%2C+34000ms%29%2C+Computer",
|
|
},
|
|
},
|
|
Err: require.NoError,
|
|
},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
queries, err := datasource.buildQueries(tt.queryModel, tt.timeRange)
|
|
tt.Err(t, err)
|
|
if diff := cmp.Diff(tt.azureLogAnalyticsQueries, queries, cmpopts.IgnoreUnexported(simplejson.Json{})); diff != "" {
|
|
t.Errorf("Result mismatch (-want +got):\n%s", diff)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestPluginRoutes(t *testing.T) {
|
|
cfg := &setting.Cfg{
|
|
Azure: setting.AzureSettings{
|
|
Cloud: setting.AzurePublic,
|
|
ManagedIdentityEnabled: true,
|
|
},
|
|
}
|
|
|
|
plugin := &plugins.DataSourcePlugin{
|
|
Routes: []*plugins.AppPluginRoute{
|
|
{
|
|
Path: "loganalyticsazure",
|
|
Method: "GET",
|
|
URL: "https://api.loganalytics.io/",
|
|
Headers: []plugins.AppPluginRouteHeader{
|
|
{Name: "x-ms-app", Content: "Grafana"},
|
|
},
|
|
},
|
|
{
|
|
Path: "chinaloganalyticsazure",
|
|
Method: "GET",
|
|
URL: "https://api.loganalytics.azure.cn/",
|
|
Headers: []plugins.AppPluginRouteHeader{
|
|
{Name: "x-ms-app", Content: "Grafana"},
|
|
},
|
|
},
|
|
{
|
|
Path: "govloganalyticsazure",
|
|
Method: "GET",
|
|
URL: "https://api.loganalytics.us/",
|
|
Headers: []plugins.AppPluginRouteHeader{
|
|
{Name: "x-ms-app", Content: "Grafana"},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
|
|
tests := []struct {
|
|
name string
|
|
datasource *AzureLogAnalyticsDatasource
|
|
expectedProxypass string
|
|
expectedRouteURL string
|
|
Err require.ErrorAssertionFunc
|
|
}{
|
|
{
|
|
name: "plugin proxy route for the Azure public cloud",
|
|
datasource: &AzureLogAnalyticsDatasource{
|
|
cfg: cfg,
|
|
dsInfo: &models.DataSource{
|
|
JsonData: simplejson.NewFromAny(map[string]interface{}{
|
|
"azureAuthType": AzureAuthClientSecret,
|
|
"cloudName": "azuremonitor",
|
|
}),
|
|
},
|
|
},
|
|
expectedProxypass: "loganalyticsazure",
|
|
expectedRouteURL: "https://api.loganalytics.io/",
|
|
Err: require.NoError,
|
|
},
|
|
{
|
|
name: "plugin proxy route for the Azure China cloud",
|
|
datasource: &AzureLogAnalyticsDatasource{
|
|
cfg: cfg,
|
|
dsInfo: &models.DataSource{
|
|
JsonData: simplejson.NewFromAny(map[string]interface{}{
|
|
"azureAuthType": AzureAuthClientSecret,
|
|
"cloudName": "chinaazuremonitor",
|
|
}),
|
|
},
|
|
},
|
|
expectedProxypass: "chinaloganalyticsazure",
|
|
expectedRouteURL: "https://api.loganalytics.azure.cn/",
|
|
Err: require.NoError,
|
|
},
|
|
{
|
|
name: "plugin proxy route for the Azure Gov cloud",
|
|
datasource: &AzureLogAnalyticsDatasource{
|
|
cfg: cfg,
|
|
dsInfo: &models.DataSource{
|
|
JsonData: simplejson.NewFromAny(map[string]interface{}{
|
|
"azureAuthType": AzureAuthClientSecret,
|
|
"cloudName": "govazuremonitor",
|
|
}),
|
|
},
|
|
},
|
|
expectedProxypass: "govloganalyticsazure",
|
|
expectedRouteURL: "https://api.loganalytics.us/",
|
|
Err: require.NoError,
|
|
},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
route, proxypass, err := tt.datasource.getPluginRoute(plugin)
|
|
tt.Err(t, err)
|
|
|
|
if diff := cmp.Diff(tt.expectedRouteURL, route.URL, cmpopts.EquateNaNs()); diff != "" {
|
|
t.Errorf("Result mismatch (-want +got):\n%s", diff)
|
|
}
|
|
|
|
if diff := cmp.Diff(tt.expectedProxypass, proxypass, cmpopts.EquateNaNs()); diff != "" {
|
|
t.Errorf("Result mismatch (-want +got):\n%s", diff)
|
|
}
|
|
})
|
|
}
|
|
}
|