mirror of
https://github.com/grafana/grafana.git
synced 2025-02-25 18:55:37 -06:00
* Add router packages * Get react app root work instead of Angular one * Logger util * Patch Angular routing ($routeProvider, $routeParamsProvider) * Use react-router-dom history instead of separate dependency * Add test routes * Sidemenu - use Link instead of anchors * Patch Angular $location service (stub) * WIP: geting rid of $location provider from TimeSrv * Intercept anchor clicks to use history under the hood * Sync Redux location slice with history state * Make login/logout work * Debug routes for testing * Make force login work * Make sure query param change does not recreate page components * Hide side menu in specified locations * Make the dashboar route query parameters work, make panel edit menu work * Enable more routes * Fix side menu * Handle view modes * Disable playlist routes * Make SafeDynamicImport work again * Bring back router-debug * Separate redux location sync from route rendering * Refactor updateLocation to thunk and move force refresh(login) to it * Fixing init dashboard issue * Support switching between dashboards without an unmount of DashboardPage * More fixes for init dashboard and panel edit * More type fixes * Moving angular location wrapper out of main LocationService, and fixing typescript issues * Fixed last typescript errors * LocationService: Move to runtime and remove getLocationService and export singleston const instead (#31523) * Moving location service implementation to runtime and removing get function and making it a package const singleton * Added test that used locationService directly * removed unused import * AngularApp: Moving angular dependencies and the app boot out of the main app into it's own file (#31525) * Fixes angular panels by calling the monkey patch * Moving angular stuff to to it's own files * udpated * Fixing clicking on divs and spans inside anchor * Moving app notifications out of angular app and removing angular directive wrapper * Moving search from angular to react and removing angular search wrapper * Clean up, tried to remove the redux location wrapper but requires a big update for DashboardPage, so adding it back * Moving AppWrapper to root to limit circular dependencies (app/core -> app/routing and back) * Open and close search now works * Hide sidemenu when in kiosk mode * Restoring some keybindings like ESC key * Removed kiosk events and simplified it, just handled through updating URL * Fixing typescript errors * Simplified GrafanaRouteComponentProps and renamed to ContainerProps * renamed back * Changed AlertRuleList to use GrafanaRouteComponentProps and location.search passed to it * Removing the reloadOnSearch property, this is not needed now for react as react by default does not unmount components when only url match or query parmas change * SafeDynamicImport causing unmount un every search update, not sure how to fix yet * Fix signature for SafeDynamicImport so we do not create new route components on every route render * Removing the redux location wrapper as it was causing errors, and making dashboard page work with RouteProps (location, match) etc * Updating DashboardPage and SoloPanelPage to use match params and history location * Fixed DashboardPage tests * Fixing solo route tests * LocationService: Rename getCurrentLocation to just getLocation * do not intercept link clicks with target blank or self * Experimental useUrlParams hook * Update DataSourceSettingsPage to use router match params * fix links with urls that have no starting / to work like before * Fix forceLogin * Add queryParams to GrafanaRouteComponentProps * PanelEditor get rid of updateLocation and location state * Improve grafana route query params typing * Add getSearchObject to LocationService * Use DashboardPAge queryParams instead of location.search parsing * Fix DashboardPage typing * Fix some tests weirdness * Bring back KeyboardSrv * Fixes typescript issues * Team pages now use router match params * Get rid of from GrafanaRouteComponent props * Removed unnessary calls to getSearchObject when calling locationService.partial * Updated DashboardPage tests after queryParams was added * Fixing dashboard settings back * GrafanaRoute: Adding tests and remove use of global locationService * Fixing tests and typescript errors * Bring back kiosk modes and add tests * Fix TimeSrv tests * Fix typecheck errors * Fixing tests * Updated SideMenu test to react-testing and wrapped component in Router, and fixed issue importing createMemoryHistory * Get rid of routeChange event from TimeSrv from * Fixed TopSectionItem test * Trying to make basename work but failing * Update TopSectionItem snapshot * Fix TopSectionItem snapshot test * Fix API keys creation * Remove Angular dependencies from KeybindingSrv (#31617) * Remove Angular dependency from KeybindingsSrv * Fix tests and typecheck issues * basename is starting to work * Make dashboard save work * KeybindingSrv: Remove as angular service and no usage angular scope * So long bridge_srv, we won't miss you * Update snapshots * Dashboard: Refactoring ChangeTracker to use History api and no angular (#31653) * Dashboard: Refactoring ChangeTracker to use History api and no angular * Updated * Removed logging * fixed unit tests * updated snapshots * Mechanism for force reloading routes (#31683) * e2e: Fixes various things in e2e scenarios after router migration (#31685) * Explore: Update reading query params from router props and updating location via locationService (ReactRouter) (#31688) * RoutingNG: Initial explore redux location to router location migration * Updated explore Wrapper tests * Fixing more tests * remove loggin * rename back to make naming consistent * Fixing return to dashboard button * fixing navigation to explore from dashboard * updated routeProps * Updated tests * Make DashboardListPage work * Fixing navigation after add new data source, and fixes explore e2e * Fixing solo panel page * PluginsPage now works * RoutingNG: When parsing and rendering url search/query params preseve old logic of handling booleans and arrays (#31725) * RoutingNG: When parsing and rendering url search/query params preserve old logic of handling booleans and arrays * Fixed test * Make snapshots list work * fixed alert notification channel edit page * Simplify LocationService, did not need special handling for login or forceLogin as target _self on link already handles that * fixed UserAdminPage * fixed edit orgs page * Fixing LdapPage * fixing dashboard import * Fixed new folder page * Fixed data source dashboards page * fixing Folder permissions and folder settings page * fixing snapshot list page nav model * remove unused file * Added placeholder page for playlist * Moved browser compatability to index-template * Restored 404/default page * Fixed reset password page * Fixed SignUpInvited page * Fixing CreateTeam, Create user page, add panel widget * Restore browwser file to make tests happy * Fixed unit tests * Removed unused import * Replacing usage of updateLocation * Fixed test * Updating search filters to use history / location service for filters * remove unused file * AppRootPage fixed * Fixing test and search issue * Changes to support enterprise extensions * remove console.log * Removing more use of redux location * Fixed signup page * removed unused old angular controllers * Fixing bugs * one final bugfix * Removed location from redux state * Fixing ts issues and tests * Fixing test issue * fixing tests * Fixing tests * removed unused stuff * Fixed search test * Adding some doc comments * Routing NG: Angular location provider patch (#31773) * Patch Angulars $location provider * Update public/app/angular/bridgeReactAngularRouting.ts * Remove only test * Update tests, disable loggers in test env * Routing NG: remove $location provider usage (#31816) * Remove dashboard_loaders * Remove $location from Analytics service, track page views form GrafanaRoute * Remove NotificationsEditCtrl * Remove Angular dependencies from uploadDashboardDirective * Update public/app/features/dashboard/containers/DashboardPage.tsx Co-authored-by: Alex Khomenko <Clarity-89@users.noreply.github.com> * Update public/app/features/dashboard/containers/DashboardPage.tsx Co-authored-by: Alex Khomenko <Clarity-89@users.noreply.github.com> * Remove unused test helpers (#31831) * Playlist react (#31829) * playlist list in react * Playlist start * Things started to work * Updated * Handle empty list * Fix ts * Fixes and kiosk mode stuff * Removed unused events * fixing ts issue * Another ts issue * Fixing tests Co-authored-by: Dominik Prokop <dominik.prokop@grafana.com> * fixed test * Update public/app/AppWrapper.tsx Co-authored-by: Alex Khomenko <Clarity-89@users.noreply.github.com> * Update public/app/AppWrapper.tsx Co-authored-by: Alex Khomenko <Clarity-89@users.noreply.github.com> * Remove Angular dependency from DashboardLoaderSrv (#31863) Co-authored-by: Torkel Ödegaard <torkel@grafana.com> Co-authored-by: Torkel Ödegaard <torkel@grafana.org> Co-authored-by: Hugo Häggmark <hugo.haggmark@grafana.com> Co-authored-by: Alex Khomenko <Clarity-89@users.noreply.github.com>
316 lines
9.2 KiB
TypeScript
316 lines
9.2 KiB
TypeScript
import React from 'react';
|
|
import { shallow, ShallowWrapper } from 'enzyme';
|
|
import { DashboardPage, mapStateToProps, Props, State } from './DashboardPage';
|
|
import { DashboardModel } from '../state';
|
|
import { mockToolkitActionCreator } from 'test/core/redux/mocks';
|
|
import { DashboardInitPhase, DashboardRoutes } from 'app/types';
|
|
import { notifyApp } from 'app/core/actions';
|
|
import { cleanUpDashboardAndVariables } from '../state/actions';
|
|
import { selectors } from '@grafana/e2e-selectors';
|
|
import { getRouteComponentProps } from 'app/core/navigation/__mocks__/routeProps';
|
|
|
|
jest.mock('app/features/dashboard/components/DashboardSettings/GeneralSettings', () => ({}));
|
|
|
|
interface ScenarioContext {
|
|
cleanUpDashboardAndVariablesMock: typeof cleanUpDashboardAndVariables;
|
|
dashboard?: DashboardModel | null;
|
|
setDashboardProp: (overrides?: any, metaOverrides?: any) => void;
|
|
wrapper?: ShallowWrapper<Props, State, DashboardPage>;
|
|
mount: (propOverrides?: Partial<Props>) => void;
|
|
setup: (fn: () => void) => void;
|
|
}
|
|
|
|
function getTestDashboard(overrides?: any, metaOverrides?: any): DashboardModel {
|
|
const data = Object.assign(
|
|
{
|
|
title: 'My dashboard',
|
|
panels: [
|
|
{
|
|
id: 1,
|
|
type: 'graph',
|
|
title: 'My graph',
|
|
gridPos: { x: 0, y: 0, w: 1, h: 1 },
|
|
},
|
|
],
|
|
},
|
|
overrides
|
|
);
|
|
|
|
const meta = Object.assign({ canSave: true, canEdit: true }, metaOverrides);
|
|
return new DashboardModel(data, meta);
|
|
}
|
|
|
|
function dashboardPageScenario(description: string, scenarioFn: (ctx: ScenarioContext) => void) {
|
|
describe(description, () => {
|
|
let setupFn: () => void;
|
|
|
|
const ctx: ScenarioContext = {
|
|
cleanUpDashboardAndVariablesMock: jest.fn(),
|
|
setup: (fn) => {
|
|
setupFn = fn;
|
|
},
|
|
setDashboardProp: (overrides?: any, metaOverrides?: any) => {
|
|
ctx.dashboard = getTestDashboard(overrides, metaOverrides);
|
|
ctx.wrapper?.setProps({ dashboard: ctx.dashboard });
|
|
},
|
|
mount: (propOverrides?: Partial<Props>) => {
|
|
const props: Props = {
|
|
...getRouteComponentProps({
|
|
match: { params: { slug: 'my-dash', uid: '11' } } as any,
|
|
route: { routeName: DashboardRoutes.Normal } as any,
|
|
}),
|
|
initPhase: DashboardInitPhase.NotStarted,
|
|
isInitSlow: false,
|
|
initDashboard: jest.fn(),
|
|
notifyApp: mockToolkitActionCreator(notifyApp),
|
|
cleanUpDashboardAndVariables: ctx.cleanUpDashboardAndVariablesMock,
|
|
cancelVariables: jest.fn(),
|
|
templateVarsChangedInUrl: jest.fn(),
|
|
dashboard: null,
|
|
};
|
|
|
|
Object.assign(props, propOverrides);
|
|
|
|
ctx.dashboard = props.dashboard;
|
|
ctx.wrapper = shallow(<DashboardPage {...props} />);
|
|
},
|
|
};
|
|
|
|
beforeEach(() => {
|
|
setupFn();
|
|
});
|
|
|
|
scenarioFn(ctx);
|
|
});
|
|
}
|
|
|
|
describe('DashboardPage', () => {
|
|
dashboardPageScenario('Given initial state', (ctx) => {
|
|
ctx.setup(() => {
|
|
ctx.mount();
|
|
});
|
|
|
|
it('Should render nothing', () => {
|
|
expect(ctx.wrapper).toMatchSnapshot();
|
|
});
|
|
});
|
|
|
|
dashboardPageScenario('Dashboard is fetching slowly', (ctx) => {
|
|
ctx.setup(() => {
|
|
ctx.mount();
|
|
ctx.wrapper?.setProps({
|
|
isInitSlow: true,
|
|
initPhase: DashboardInitPhase.Fetching,
|
|
});
|
|
});
|
|
|
|
it('Should render slow init state', () => {
|
|
expect(ctx.wrapper).toMatchSnapshot();
|
|
});
|
|
});
|
|
|
|
dashboardPageScenario('Dashboard init completed ', (ctx) => {
|
|
ctx.setup(() => {
|
|
ctx.mount();
|
|
ctx.setDashboardProp();
|
|
});
|
|
|
|
it('Should update title', () => {
|
|
expect(document.title).toBe('My dashboard - Grafana');
|
|
});
|
|
|
|
it('Should render dashboard grid', () => {
|
|
expect(ctx.wrapper).toMatchSnapshot();
|
|
});
|
|
});
|
|
|
|
dashboardPageScenario('When user goes into panel edit', (ctx) => {
|
|
ctx.setup(() => {
|
|
ctx.mount();
|
|
ctx.setDashboardProp();
|
|
ctx.wrapper?.setProps({
|
|
queryParams: { editPanel: '1' },
|
|
});
|
|
});
|
|
|
|
it('Should update component state to fullscreen and edit', () => {
|
|
const state = ctx.wrapper?.state();
|
|
expect(state).not.toBe(null);
|
|
expect(state?.editPanel).toBeDefined();
|
|
});
|
|
});
|
|
|
|
dashboardPageScenario('When user goes into panel edit but has no edit permissions', (ctx) => {
|
|
ctx.setup(() => {
|
|
ctx.mount();
|
|
ctx.setDashboardProp({}, { canEdit: false });
|
|
ctx.wrapper?.setProps({
|
|
queryParams: { editPanel: '1' },
|
|
});
|
|
});
|
|
|
|
it('Should update component state to fullscreen and edit', () => {
|
|
const state = ctx.wrapper?.state();
|
|
expect(state?.editPanel).toBe(null);
|
|
});
|
|
});
|
|
dashboardPageScenario('When user goes back to dashboard from edit panel', (ctx) => {
|
|
ctx.setup(() => {
|
|
ctx.mount();
|
|
ctx.setDashboardProp();
|
|
ctx.wrapper?.setState({ scrollTop: 100 });
|
|
ctx.wrapper?.setProps({
|
|
queryParams: { editPanel: '1' },
|
|
});
|
|
ctx.wrapper?.setProps({
|
|
queryParams: {},
|
|
});
|
|
});
|
|
|
|
it('Should update model state normal state', () => {
|
|
expect(ctx.dashboard).toBeDefined();
|
|
// @ts-ignore typescript doesn't understand that dashboard must be defined to reach the row below
|
|
expect(ctx.dashboard.panelInEdit).toBeUndefined();
|
|
});
|
|
|
|
it('Should update component state to normal and restore scrollTop', () => {
|
|
const state = ctx.wrapper?.state();
|
|
expect(ctx.wrapper).not.toBe(null);
|
|
expect(state).not.toBe(null);
|
|
expect(state?.editPanel).toBe(null);
|
|
expect(state?.scrollTop).toBe(100);
|
|
});
|
|
});
|
|
|
|
dashboardPageScenario('When dashboard has editview url state', (ctx) => {
|
|
ctx.setup(() => {
|
|
ctx.mount();
|
|
ctx.setDashboardProp();
|
|
ctx.wrapper?.setProps({
|
|
queryParams: { editview: 'settings' },
|
|
});
|
|
});
|
|
|
|
it('should render settings view', () => {
|
|
expect(ctx.wrapper).toMatchSnapshot();
|
|
});
|
|
});
|
|
|
|
dashboardPageScenario('When adding panel', (ctx) => {
|
|
ctx.setup(() => {
|
|
ctx.mount();
|
|
ctx.setDashboardProp();
|
|
ctx.wrapper?.setState({ scrollTop: 100 });
|
|
ctx.wrapper?.instance().onAddPanel();
|
|
});
|
|
|
|
it('should set scrollTop to 0', () => {
|
|
expect(ctx.wrapper).not.toBe(null);
|
|
expect(ctx.wrapper?.state()).not.toBe(null);
|
|
expect(ctx.wrapper?.state().updateScrollTop).toBe(0);
|
|
});
|
|
|
|
it('should add panel widget to dashboard panels', () => {
|
|
expect(ctx.dashboard).not.toBe(null);
|
|
expect(ctx.dashboard?.panels[0].type).toBe('add-panel');
|
|
});
|
|
});
|
|
|
|
dashboardPageScenario('Given panel with id 0', (ctx) => {
|
|
ctx.setup(() => {
|
|
ctx.mount();
|
|
ctx.setDashboardProp({
|
|
panels: [{ id: 0, type: 'graph' }],
|
|
schemaVersion: 17,
|
|
});
|
|
ctx.wrapper?.setProps({
|
|
queryParams: { editPanel: '0' },
|
|
});
|
|
});
|
|
|
|
it('Should go into edit mode', () => {
|
|
const state = ctx.wrapper?.state();
|
|
expect(ctx.wrapper).not.toBe(null);
|
|
expect(state).not.toBe(null);
|
|
expect(state?.editPanel).not.toBe(null);
|
|
});
|
|
});
|
|
|
|
dashboardPageScenario('When dashboard unmounts', (ctx) => {
|
|
ctx.setup(() => {
|
|
ctx.mount();
|
|
ctx.setDashboardProp({
|
|
panels: [{ id: 0, type: 'graph' }],
|
|
schemaVersion: 17,
|
|
});
|
|
ctx.wrapper?.unmount();
|
|
});
|
|
|
|
it('Should call clean up action', () => {
|
|
expect(ctx.cleanUpDashboardAndVariablesMock).toHaveBeenCalledTimes(1);
|
|
});
|
|
});
|
|
|
|
dashboardPageScenario('Kiosk mode none', (ctx) => {
|
|
ctx.setup(() => {
|
|
ctx.mount({
|
|
queryParams: {},
|
|
});
|
|
ctx.setDashboardProp({
|
|
panels: [{ id: 0, type: 'graph' }],
|
|
schemaVersion: 17,
|
|
});
|
|
});
|
|
|
|
it('should not render dashboard navigation ', () => {
|
|
expect(ctx.wrapper?.find(`[aria-label="${selectors.pages.Dashboard.DashNav.nav}"]`)).toHaveLength(1);
|
|
expect(ctx.wrapper?.find(`[aria-label="${selectors.pages.Dashboard.SubMenu.submenu}"]`)).toHaveLength(1);
|
|
});
|
|
});
|
|
|
|
dashboardPageScenario('Kiosk mode tv', (ctx) => {
|
|
ctx.setup(() => {
|
|
ctx.mount({
|
|
queryParams: { kiosk: 'tv' },
|
|
});
|
|
ctx.setDashboardProp({
|
|
panels: [{ id: 0, type: 'graph' }],
|
|
schemaVersion: 17,
|
|
});
|
|
});
|
|
|
|
it('should not render dashboard navigation ', () => {
|
|
expect(ctx.wrapper?.find(`[aria-label="${selectors.pages.Dashboard.DashNav.nav}"]`)).toHaveLength(1);
|
|
expect(ctx.wrapper?.find(`[aria-label="${selectors.pages.Dashboard.SubMenu.submenu}"]`)).toHaveLength(0);
|
|
});
|
|
});
|
|
|
|
dashboardPageScenario('Kiosk mode full', (ctx) => {
|
|
ctx.setup(() => {
|
|
ctx.mount({
|
|
queryParams: { kiosk: true },
|
|
});
|
|
ctx.setDashboardProp({
|
|
panels: [{ id: 0, type: 'graph' }],
|
|
schemaVersion: 17,
|
|
});
|
|
});
|
|
|
|
it('should not render dashboard navigation and submenu', () => {
|
|
expect(ctx.wrapper?.find(`[aria-label="${selectors.pages.Dashboard.DashNav.nav}"]`)).toHaveLength(0);
|
|
expect(ctx.wrapper?.find(`[aria-label="${selectors.pages.Dashboard.SubMenu.submenu}"]`)).toHaveLength(0);
|
|
});
|
|
});
|
|
|
|
describe('mapStateToProps', () => {
|
|
const props = mapStateToProps({
|
|
panelEditor: {},
|
|
dashboard: {
|
|
getModel: () => ({} as DashboardModel),
|
|
},
|
|
} as any);
|
|
|
|
expect(props.dashboard).toBeDefined();
|
|
});
|
|
});
|