mirror of
https://github.com/grafana/grafana.git
synced 2025-02-25 18:55:37 -06:00
* add special handling on the plugin gathering side to check whether secrets manager plugins are enabled or not * show disabled badge in front end if the plugin is not enabled * Only show error in disabled badge hover if one is present (otherwise it shows "undefined") * refactor to make use of fields already available in the DTO * fix typo * if there is no error returned for the plugin, just show 'disabled' * fix typo * Update public/app/features/plugins/admin/components/Badges/PluginDisabledBadge.tsx Co-authored-by: Levente Balogh <balogh.levente.hu@gmail.com> * Update frontendsettings.go add clarifying comment * fix unit test * rework task to use new frontend property combined with plugin type to determine if the plugin should be disabled * Update helpers.test.ts revert test change * fix unit test * show custom uninstall message if the plugin is a secrets manager * bogus commit to trigger precommit * undo commit * run precommit manually * add some consts * refactor a bit to pull plugin error management up a level * re-add code squashed in merge * fix compile issues * add code to set plugin error fatal flag after secret migration * refactor to move plugin startup out of Should Check func * re-add important check * make plugin startup errors fatal the first time we set a secret on the plugin * rename func to make intent clearler * remove unnecessary duplicate code from plugin mig * fix compile error * fix more compile errors * add some extra logging to secrets migration * have remote_plugin secret service managed plugin error fatal flag directly * add blank file for eventual unit tests * fix linting issues * changes from PR review * quick bit of cleanup * add comment explaining design decision * move more common test helpers to file * slightly update to first time Get secret call * add unit tests * remove override func from provider * fix linting issues * add test cleanup step * add some comments about refactoring to hacky test function Co-authored-by: Levente Balogh <balogh.levente.hu@gmail.com>
166 lines
5.0 KiB
Go
166 lines
5.0 KiB
Go
package kvstore
|
|
|
|
import (
|
|
"context"
|
|
"sync"
|
|
|
|
"github.com/grafana/grafana/pkg/infra/kvstore"
|
|
"github.com/grafana/grafana/pkg/infra/log"
|
|
smp "github.com/grafana/grafana/pkg/plugins/backendplugin/secretsmanagerplugin"
|
|
"github.com/grafana/grafana/pkg/services/datasources"
|
|
"github.com/grafana/grafana/pkg/services/secrets"
|
|
)
|
|
|
|
var (
|
|
fatalFlagOnce sync.Once
|
|
)
|
|
|
|
// secretsKVStorePlugin provides a key/value store backed by the Grafana plugin gRPC interface
|
|
type secretsKVStorePlugin struct {
|
|
log log.Logger
|
|
secretsPlugin smp.SecretsManagerPlugin
|
|
secretsService secrets.Service
|
|
kvstore *kvstore.NamespacedKVStore
|
|
backwardsCompatibilityDisabled bool
|
|
}
|
|
|
|
// Get an item from the store
|
|
// If it is the first time a secret has been retrieved and backwards compatibility is disabled, mark plugin startup errors fatal
|
|
func (kv *secretsKVStorePlugin) Get(ctx context.Context, orgId int64, namespace string, typ string) (string, bool, error) {
|
|
req := &smp.GetSecretRequest{
|
|
KeyDescriptor: &smp.Key{
|
|
OrgId: orgId,
|
|
Namespace: namespace,
|
|
Type: typ,
|
|
},
|
|
}
|
|
res, err := kv.secretsPlugin.GetSecret(ctx, req)
|
|
if err != nil {
|
|
return "", false, err
|
|
} else if res.UserFriendlyError != "" {
|
|
err = wrapUserFriendlySecretError(res.UserFriendlyError)
|
|
}
|
|
|
|
if res.Exists {
|
|
updateFatalFlag(ctx, *kv)
|
|
}
|
|
|
|
return res.DecryptedValue, res.Exists, err
|
|
}
|
|
|
|
// Set an item in the store
|
|
// If it is the first time a secret has been set and backwards compatibility is disabled, mark plugin startup errors fatal
|
|
func (kv *secretsKVStorePlugin) Set(ctx context.Context, orgId int64, namespace string, typ string, value string) error {
|
|
req := &smp.SetSecretRequest{
|
|
KeyDescriptor: &smp.Key{
|
|
OrgId: orgId,
|
|
Namespace: namespace,
|
|
Type: typ,
|
|
},
|
|
Value: value,
|
|
}
|
|
|
|
res, err := kv.secretsPlugin.SetSecret(ctx, req)
|
|
if err == nil && res.UserFriendlyError != "" {
|
|
err = wrapUserFriendlySecretError(res.UserFriendlyError)
|
|
}
|
|
|
|
updateFatalFlag(ctx, *kv)
|
|
|
|
return err
|
|
}
|
|
|
|
// Del deletes an item from the store.
|
|
func (kv *secretsKVStorePlugin) Del(ctx context.Context, orgId int64, namespace string, typ string) error {
|
|
req := &smp.DeleteSecretRequest{
|
|
KeyDescriptor: &smp.Key{
|
|
OrgId: orgId,
|
|
Namespace: namespace,
|
|
Type: typ,
|
|
},
|
|
}
|
|
|
|
res, err := kv.secretsPlugin.DeleteSecret(ctx, req)
|
|
if err == nil && res.UserFriendlyError != "" {
|
|
err = wrapUserFriendlySecretError(res.UserFriendlyError)
|
|
}
|
|
|
|
return err
|
|
}
|
|
|
|
// Keys get all keys for a given namespace. To query for all
|
|
// organizations the constant 'kvstore.AllOrganizations' can be passed as orgId.
|
|
func (kv *secretsKVStorePlugin) Keys(ctx context.Context, orgId int64, namespace string, typ string) ([]Key, error) {
|
|
req := &smp.ListSecretsRequest{
|
|
KeyDescriptor: &smp.Key{
|
|
OrgId: orgId,
|
|
Namespace: namespace,
|
|
Type: typ,
|
|
},
|
|
AllOrganizations: orgId == AllOrganizations,
|
|
}
|
|
|
|
res, err := kv.secretsPlugin.ListSecrets(ctx, req)
|
|
if err != nil {
|
|
return nil, err
|
|
} else if res.UserFriendlyError != "" {
|
|
err = wrapUserFriendlySecretError(res.UserFriendlyError)
|
|
}
|
|
|
|
return parseKeys(res.Keys), err
|
|
}
|
|
|
|
// Rename an item in the store
|
|
func (kv *secretsKVStorePlugin) Rename(ctx context.Context, orgId int64, namespace string, typ string, newNamespace string) error {
|
|
req := &smp.RenameSecretRequest{
|
|
KeyDescriptor: &smp.Key{
|
|
OrgId: orgId,
|
|
Namespace: namespace,
|
|
Type: typ,
|
|
},
|
|
NewNamespace: newNamespace,
|
|
}
|
|
|
|
res, err := kv.secretsPlugin.RenameSecret(ctx, req)
|
|
if err == nil && res.UserFriendlyError != "" {
|
|
err = wrapUserFriendlySecretError(res.UserFriendlyError)
|
|
}
|
|
|
|
return err
|
|
}
|
|
|
|
func parseKeys(keys []*smp.Key) []Key {
|
|
var newKeys []Key
|
|
|
|
for _, k := range keys {
|
|
newKey := Key{OrgId: k.OrgId, Namespace: k.Namespace, Type: k.Type}
|
|
newKeys = append(newKeys, newKey)
|
|
}
|
|
|
|
return newKeys
|
|
}
|
|
|
|
func updateFatalFlag(ctx context.Context, skv secretsKVStorePlugin) {
|
|
// This function makes the most sense in here because it handles all possible scenarios:
|
|
// - User changed backwards compatibility flag, so we have to migrate secrets either to or from the plugin (get or set)
|
|
// - Migration is on, so we migrate secrets to the plugin (set)
|
|
// - User doesn't migrate, but stores a new secret in the plugin (set)
|
|
// Rather than updating the flag in several places, it is cleaner to just do this check once
|
|
// Very early on. Once backwards compatibility to legacy secrets is gone in Grafana 10, this can go away as well
|
|
fatalFlagOnce.Do(func() {
|
|
var err error
|
|
if isFatal, _ := isPluginStartupErrorFatal(ctx, skv.kvstore); !isFatal && skv.backwardsCompatibilityDisabled {
|
|
err = setPluginStartupErrorFatal(ctx, skv.kvstore, true)
|
|
} else if isFatal && !skv.backwardsCompatibilityDisabled {
|
|
err = setPluginStartupErrorFatal(ctx, skv.kvstore, false)
|
|
}
|
|
if err != nil {
|
|
skv.log.Error("failed to set plugin error fatal flag", err.Error())
|
|
}
|
|
})
|
|
}
|
|
|
|
func wrapUserFriendlySecretError(ufe string) datasources.ErrDatasourceSecretsPluginUserFriendly {
|
|
return datasources.ErrDatasourceSecretsPluginUserFriendly{Err: ufe}
|
|
}
|