mirror of
https://github.com/grafana/grafana.git
synced 2024-11-29 12:14:08 -06:00
7e6db1ee7e
In the case permissions has been added on dashboard(s). Later permissions for the parent folder of the dashboard is edited in such a way that dashboard in that folder has a permission that is a duplicate of an inherited one. This PR changes so that duplicate permissions are now filtered out from /api/dashboards/id/<dashboard id>/permissions. Duplicate permission are not filtered out if the permission on dashboard is higher than on the inherited folder. Fixes #33296 Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com>
121 lines
3.4 KiB
Go
121 lines
3.4 KiB
Go
package api
|
|
|
|
import (
|
|
"errors"
|
|
"time"
|
|
|
|
"github.com/grafana/grafana/pkg/api/dtos"
|
|
"github.com/grafana/grafana/pkg/api/response"
|
|
"github.com/grafana/grafana/pkg/models"
|
|
"github.com/grafana/grafana/pkg/services/guardian"
|
|
)
|
|
|
|
func (hs *HTTPServer) GetDashboardPermissionList(c *models.ReqContext) response.Response {
|
|
dashID := c.ParamsInt64(":dashboardId")
|
|
|
|
_, rsp := getDashboardHelper(c.OrgId, "", dashID, "")
|
|
if rsp != nil {
|
|
return rsp
|
|
}
|
|
|
|
g := guardian.New(dashID, c.OrgId, c.SignedInUser)
|
|
|
|
if canAdmin, err := g.CanAdmin(); err != nil || !canAdmin {
|
|
return dashboardGuardianResponse(err)
|
|
}
|
|
|
|
acl, err := g.GetACLWithoutDuplicates()
|
|
if err != nil {
|
|
return response.Error(500, "Failed to get dashboard permissions", err)
|
|
}
|
|
|
|
filteredAcls := make([]*models.DashboardAclInfoDTO, 0, len(acl))
|
|
for _, perm := range acl {
|
|
if perm.UserId > 0 && dtos.IsHiddenUser(perm.UserLogin, c.SignedInUser, hs.Cfg) {
|
|
continue
|
|
}
|
|
|
|
perm.UserAvatarUrl = dtos.GetGravatarUrl(perm.UserEmail)
|
|
|
|
if perm.TeamId > 0 {
|
|
perm.TeamAvatarUrl = dtos.GetGravatarUrlWithDefault(perm.TeamEmail, perm.Team)
|
|
}
|
|
if perm.Slug != "" {
|
|
perm.Url = models.GetDashboardFolderUrl(perm.IsFolder, perm.Uid, perm.Slug)
|
|
}
|
|
|
|
filteredAcls = append(filteredAcls, perm)
|
|
}
|
|
|
|
return response.JSON(200, filteredAcls)
|
|
}
|
|
|
|
func (hs *HTTPServer) UpdateDashboardPermissions(c *models.ReqContext, apiCmd dtos.UpdateDashboardAclCommand) response.Response {
|
|
if err := validatePermissionsUpdate(apiCmd); err != nil {
|
|
return response.Error(400, err.Error(), err)
|
|
}
|
|
|
|
dashID := c.ParamsInt64(":dashboardId")
|
|
|
|
_, rsp := getDashboardHelper(c.OrgId, "", dashID, "")
|
|
if rsp != nil {
|
|
return rsp
|
|
}
|
|
|
|
g := guardian.New(dashID, c.OrgId, c.SignedInUser)
|
|
if canAdmin, err := g.CanAdmin(); err != nil || !canAdmin {
|
|
return dashboardGuardianResponse(err)
|
|
}
|
|
|
|
var items []*models.DashboardAcl
|
|
for _, item := range apiCmd.Items {
|
|
items = append(items, &models.DashboardAcl{
|
|
OrgID: c.OrgId,
|
|
DashboardID: dashID,
|
|
UserID: item.UserID,
|
|
TeamID: item.TeamID,
|
|
Role: item.Role,
|
|
Permission: item.Permission,
|
|
Created: time.Now(),
|
|
Updated: time.Now(),
|
|
})
|
|
}
|
|
|
|
hiddenACL, err := g.GetHiddenACL(hs.Cfg)
|
|
if err != nil {
|
|
return response.Error(500, "Error while retrieving hidden permissions", err)
|
|
}
|
|
items = append(items, hiddenACL...)
|
|
|
|
if okToUpdate, err := g.CheckPermissionBeforeUpdate(models.PERMISSION_ADMIN, items); err != nil || !okToUpdate {
|
|
if err != nil {
|
|
if errors.Is(err, guardian.ErrGuardianPermissionExists) || errors.Is(err, guardian.ErrGuardianOverride) {
|
|
return response.Error(400, err.Error(), err)
|
|
}
|
|
|
|
return response.Error(500, "Error while checking dashboard permissions", err)
|
|
}
|
|
|
|
return response.Error(403, "Cannot remove own admin permission for a folder", nil)
|
|
}
|
|
|
|
if err := updateDashboardACL(hs, dashID, items); err != nil {
|
|
if errors.Is(err, models.ErrDashboardAclInfoMissing) ||
|
|
errors.Is(err, models.ErrDashboardPermissionDashboardEmpty) {
|
|
return response.Error(409, err.Error(), err)
|
|
}
|
|
return response.Error(500, "Failed to create permission", err)
|
|
}
|
|
|
|
return response.Success("Dashboard permissions updated")
|
|
}
|
|
|
|
func validatePermissionsUpdate(apiCmd dtos.UpdateDashboardAclCommand) error {
|
|
for _, item := range apiCmd.Items {
|
|
if (item.UserID > 0 || item.TeamID > 0) && item.Role != nil {
|
|
return models.ErrPermissionsWithRoleNotAllowed
|
|
}
|
|
}
|
|
return nil
|
|
}
|