mirror of
https://github.com/grafana/grafana.git
synced 2024-11-29 20:24:18 -06:00
492 lines
15 KiB
Go
492 lines
15 KiB
Go
package alerting
|
|
|
|
import (
|
|
"context"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/stretchr/testify/require"
|
|
|
|
"github.com/grafana/grafana/pkg/components/simplejson"
|
|
"github.com/grafana/grafana/pkg/infra/db"
|
|
"github.com/grafana/grafana/pkg/infra/log"
|
|
"github.com/grafana/grafana/pkg/services/alerting/models"
|
|
"github.com/grafana/grafana/pkg/services/dashboards"
|
|
dashver "github.com/grafana/grafana/pkg/services/dashboardversion"
|
|
"github.com/grafana/grafana/pkg/services/featuremgmt"
|
|
"github.com/grafana/grafana/pkg/services/org"
|
|
"github.com/grafana/grafana/pkg/services/tag/tagimpl"
|
|
"github.com/grafana/grafana/pkg/services/user"
|
|
"github.com/grafana/grafana/pkg/setting"
|
|
"github.com/grafana/grafana/pkg/util"
|
|
)
|
|
|
|
func mockTimeNow() {
|
|
var timeSeed int64
|
|
timeNow = func() time.Time {
|
|
loc := time.FixedZone("MockZoneUTC-5", -5*60*60)
|
|
fakeNow := time.Unix(timeSeed, 0).In(loc)
|
|
timeSeed++
|
|
return fakeNow
|
|
}
|
|
}
|
|
|
|
func resetTimeNow() {
|
|
timeNow = time.Now
|
|
}
|
|
|
|
func TestIntegrationAlertingDataAccess(t *testing.T) {
|
|
if testing.Short() {
|
|
t.Skip("skipping integration test")
|
|
}
|
|
mockTimeNow()
|
|
defer resetTimeNow()
|
|
|
|
var store *sqlStore
|
|
var testDash *dashboards.Dashboard
|
|
var items []*models.Alert
|
|
|
|
setup := func(t *testing.T) {
|
|
ss := db.InitTestDB(t)
|
|
tagService := tagimpl.ProvideService(ss, ss.Cfg)
|
|
cfg := setting.NewCfg()
|
|
store = &sqlStore{
|
|
db: ss,
|
|
log: log.New(),
|
|
cfg: cfg,
|
|
tagService: tagService,
|
|
features: featuremgmt.WithFeatures(),
|
|
}
|
|
|
|
testDash = insertTestDashboard(t, store.db, "dashboard with alerts", 1, 0, false, "alert")
|
|
evalData, err := simplejson.NewJson([]byte(`{"test": "test"}`))
|
|
require.Nil(t, err)
|
|
items = []*models.Alert{
|
|
{
|
|
PanelID: 1,
|
|
DashboardID: testDash.ID,
|
|
OrgID: testDash.OrgID,
|
|
Name: "Alerting title",
|
|
Message: "Alerting message",
|
|
Settings: simplejson.New(),
|
|
Frequency: 1,
|
|
EvalData: evalData,
|
|
},
|
|
}
|
|
|
|
err = store.SaveAlerts(context.Background(), testDash.ID, items)
|
|
require.Nil(t, err)
|
|
}
|
|
|
|
t.Run("Can set new states", func(t *testing.T) {
|
|
setup(t)
|
|
|
|
// Get alert so we can use its ID in tests
|
|
signedInUser := &user.SignedInUser{
|
|
OrgRole: org.RoleAdmin,
|
|
OrgID: 1,
|
|
Permissions: map[int64]map[string][]string{
|
|
1: {
|
|
dashboards.ActionFoldersRead: {dashboards.ScopeDashboardsAll, dashboards.ScopeFoldersAll},
|
|
dashboards.ActionDashboardsRead: {dashboards.ScopeDashboardsAll, dashboards.ScopeFoldersAll},
|
|
},
|
|
},
|
|
}
|
|
alertQuery := models.GetAlertsQuery{DashboardIDs: []int64{testDash.ID}, PanelID: 1, OrgID: 1, User: signedInUser}
|
|
result, err2 := store.HandleAlertsQuery(context.Background(), &alertQuery)
|
|
require.Nil(t, err2)
|
|
|
|
insertedAlert := result[0]
|
|
|
|
t.Run("new state ok", func(t *testing.T) {
|
|
cmd := &models.SetAlertStateCommand{
|
|
AlertID: insertedAlert.ID,
|
|
State: models.AlertStateOK,
|
|
}
|
|
|
|
_, err := store.SetAlertState(context.Background(), cmd)
|
|
require.Nil(t, err)
|
|
})
|
|
|
|
alert, _ := getAlertById(t, insertedAlert.ID, store)
|
|
stateDateBeforePause := alert.NewStateDate
|
|
|
|
t.Run("can pause all alerts", func(t *testing.T) {
|
|
err := store.pauseAllAlerts(t, true)
|
|
require.Nil(t, err)
|
|
|
|
t.Run("cannot updated paused alert", func(t *testing.T) {
|
|
cmd := &models.SetAlertStateCommand{
|
|
AlertID: insertedAlert.ID,
|
|
State: models.AlertStateOK,
|
|
}
|
|
|
|
_, err = store.SetAlertState(context.Background(), cmd)
|
|
require.Error(t, err)
|
|
})
|
|
|
|
t.Run("alert is paused", func(t *testing.T) {
|
|
alert, _ = getAlertById(t, insertedAlert.ID, store)
|
|
currentState := alert.State
|
|
require.Equal(t, models.AlertStatePaused, currentState)
|
|
})
|
|
|
|
t.Run("pausing alerts should update their NewStateDate", func(t *testing.T) {
|
|
alert, _ = getAlertById(t, insertedAlert.ID, store)
|
|
stateDateAfterPause := alert.NewStateDate
|
|
require.True(t, stateDateBeforePause.Before(stateDateAfterPause))
|
|
})
|
|
|
|
t.Run("unpausing alerts should update their NewStateDate again", func(t *testing.T) {
|
|
err := store.pauseAllAlerts(t, false)
|
|
require.Nil(t, err)
|
|
alert, _ = getAlertById(t, insertedAlert.ID, store)
|
|
stateDateAfterUnpause := alert.NewStateDate
|
|
require.True(t, stateDateBeforePause.Before(stateDateAfterUnpause))
|
|
})
|
|
})
|
|
})
|
|
|
|
t.Run("Can read properties", func(t *testing.T) {
|
|
setup(t)
|
|
signedInUser := &user.SignedInUser{
|
|
OrgRole: org.RoleAdmin,
|
|
OrgID: 1,
|
|
Permissions: map[int64]map[string][]string{
|
|
1: {
|
|
dashboards.ActionFoldersRead: {dashboards.ScopeDashboardsAll, dashboards.ScopeFoldersAll},
|
|
dashboards.ActionDashboardsRead: {dashboards.ScopeDashboardsAll, dashboards.ScopeFoldersAll},
|
|
},
|
|
}}
|
|
alertQuery := models.GetAlertsQuery{DashboardIDs: []int64{testDash.ID}, PanelID: 1, OrgID: 1, User: signedInUser}
|
|
result, err2 := store.HandleAlertsQuery(context.Background(), &alertQuery)
|
|
|
|
alert := result[0]
|
|
require.Nil(t, err2)
|
|
require.Greater(t, alert.ID, int64(0))
|
|
require.Equal(t, testDash.ID, alert.DashboardID)
|
|
require.Equal(t, int64(1), alert.PanelID)
|
|
require.Equal(t, "Alerting title", alert.Name)
|
|
require.Equal(t, models.AlertStateUnknown, alert.State)
|
|
require.NotNil(t, alert.NewStateDate)
|
|
require.NotNil(t, alert.EvalData)
|
|
require.Equal(t, "test", alert.EvalData.Get("test").MustString())
|
|
require.NotNil(t, alert.EvalDate)
|
|
require.Equal(t, "", alert.ExecutionError)
|
|
require.NotNil(t, alert.DashboardUID)
|
|
require.Equal(t, "dashboard-with-alerts", alert.DashboardSlug)
|
|
})
|
|
|
|
t.Run("Viewer can read alerts", func(t *testing.T) {
|
|
setup(t)
|
|
viewerUser := &user.SignedInUser{
|
|
OrgRole: org.RoleViewer,
|
|
OrgID: 1,
|
|
Permissions: map[int64]map[string][]string{
|
|
1: {dashboards.ActionFoldersRead: {dashboards.ScopeFoldersAll}, dashboards.ActionDashboardsRead: {dashboards.ScopeDashboardsAll}},
|
|
},
|
|
}
|
|
alertQuery := models.GetAlertsQuery{DashboardIDs: []int64{testDash.ID}, PanelID: 1, OrgID: 1, User: viewerUser}
|
|
res, err2 := store.HandleAlertsQuery(context.Background(), &alertQuery)
|
|
|
|
require.Nil(t, err2)
|
|
require.Equal(t, 1, len(res))
|
|
})
|
|
|
|
t.Run("Alerts with same dashboard id and panel id should update", func(t *testing.T) {
|
|
setup(t)
|
|
modifiedItems := items
|
|
modifiedItems[0].Name = "Name"
|
|
|
|
err := store.SaveAlerts(context.Background(), testDash.ID, items)
|
|
|
|
t.Run("Can save alerts with same dashboard and panel id", func(t *testing.T) {
|
|
require.Nil(t, err)
|
|
})
|
|
|
|
t.Run("Alerts should be updated", func(t *testing.T) {
|
|
signedInUser := &user.SignedInUser{
|
|
OrgRole: org.RoleAdmin,
|
|
OrgID: 1,
|
|
Permissions: map[int64]map[string][]string{
|
|
1: {
|
|
dashboards.ActionFoldersRead: {dashboards.ScopeDashboardsAll, dashboards.ScopeFoldersAll},
|
|
dashboards.ActionDashboardsRead: {dashboards.ScopeDashboardsAll, dashboards.ScopeFoldersAll},
|
|
},
|
|
}}
|
|
query := models.GetAlertsQuery{DashboardIDs: []int64{testDash.ID}, OrgID: 1, User: signedInUser}
|
|
res, err2 := store.HandleAlertsQuery(context.Background(), &query)
|
|
|
|
require.Nil(t, err2)
|
|
require.Equal(t, 1, len(res))
|
|
require.Equal(t, "Name", res[0].Name)
|
|
|
|
t.Run("Alert state should not be updated", func(t *testing.T) {
|
|
require.Equal(t, models.AlertStateUnknown, res[0].State)
|
|
})
|
|
})
|
|
|
|
t.Run("Updates without changes should be ignored", func(t *testing.T) {
|
|
err3 := store.SaveAlerts(context.Background(), testDash.ID, items)
|
|
require.Nil(t, err3)
|
|
})
|
|
})
|
|
|
|
t.Run("Multiple alerts per dashboard", func(t *testing.T) {
|
|
setup(t)
|
|
signedInUser := &user.SignedInUser{
|
|
OrgRole: org.RoleAdmin,
|
|
OrgID: 1,
|
|
Permissions: map[int64]map[string][]string{
|
|
1: {
|
|
dashboards.ActionFoldersRead: {dashboards.ScopeDashboardsAll, dashboards.ScopeFoldersAll},
|
|
dashboards.ActionDashboardsRead: {dashboards.ScopeDashboardsAll, dashboards.ScopeFoldersAll},
|
|
},
|
|
},
|
|
}
|
|
multipleItems := []*models.Alert{
|
|
{
|
|
DashboardID: testDash.ID,
|
|
PanelID: 1,
|
|
Name: "1",
|
|
OrgID: 1,
|
|
Settings: simplejson.New(),
|
|
},
|
|
{
|
|
DashboardID: testDash.ID,
|
|
PanelID: 2,
|
|
Name: "2",
|
|
OrgID: 1,
|
|
Settings: simplejson.New(),
|
|
},
|
|
{
|
|
DashboardID: testDash.ID,
|
|
PanelID: 3,
|
|
Name: "3",
|
|
OrgID: 1,
|
|
Settings: simplejson.New(),
|
|
},
|
|
}
|
|
|
|
err := store.SaveAlerts(context.Background(), testDash.ID, multipleItems)
|
|
|
|
t.Run("Should save 3 dashboards", func(t *testing.T) {
|
|
require.Nil(t, err)
|
|
|
|
queryForDashboard := models.GetAlertsQuery{DashboardIDs: []int64{testDash.ID}, OrgID: 1, User: signedInUser}
|
|
res, err2 := store.HandleAlertsQuery(context.Background(), &queryForDashboard)
|
|
|
|
require.Nil(t, err2)
|
|
require.Equal(t, 3, len(res))
|
|
})
|
|
|
|
t.Run("should updated two dashboards and delete one", func(t *testing.T) {
|
|
missingOneAlert := multipleItems[:2]
|
|
|
|
err = store.SaveAlerts(context.Background(), testDash.ID, missingOneAlert)
|
|
|
|
t.Run("should delete the missing alert", func(t *testing.T) {
|
|
query := models.GetAlertsQuery{DashboardIDs: []int64{testDash.ID}, OrgID: 1, User: signedInUser}
|
|
res, err2 := store.HandleAlertsQuery(context.Background(), &query)
|
|
require.Nil(t, err2)
|
|
require.Equal(t, 2, len(res))
|
|
})
|
|
})
|
|
})
|
|
|
|
t.Run("When dashboard is removed", func(t *testing.T) {
|
|
setup(t)
|
|
items := []*models.Alert{
|
|
{
|
|
PanelID: 1,
|
|
DashboardID: testDash.ID,
|
|
Name: "Alerting title",
|
|
Message: "Alerting message",
|
|
},
|
|
}
|
|
|
|
err := store.SaveAlerts(context.Background(), testDash.ID, items)
|
|
require.Nil(t, err)
|
|
|
|
err = store.db.WithDbSession(context.Background(), func(sess *db.Session) error {
|
|
dash := dashboards.Dashboard{ID: testDash.ID, OrgID: 1}
|
|
_, err := sess.Delete(dash)
|
|
return err
|
|
})
|
|
require.Nil(t, err)
|
|
|
|
t.Run("Alerts should be removed", func(t *testing.T) {
|
|
query := models.GetAlertsQuery{DashboardIDs: []int64{testDash.ID}, OrgID: 1, User: &user.SignedInUser{OrgRole: org.RoleAdmin}}
|
|
res, err2 := store.HandleAlertsQuery(context.Background(), &query)
|
|
|
|
require.Nil(t, err2)
|
|
require.Equal(t, 0, len(res))
|
|
})
|
|
})
|
|
}
|
|
|
|
func TestIntegrationPausingAlerts(t *testing.T) {
|
|
if testing.Short() {
|
|
t.Skip("skipping integration test")
|
|
}
|
|
mockTimeNow()
|
|
defer resetTimeNow()
|
|
|
|
t.Run("Given an alert", func(t *testing.T) {
|
|
ss := db.InitTestDB(t)
|
|
cfg := setting.NewCfg()
|
|
sqlStore := sqlStore{db: ss, cfg: cfg, log: log.New(), tagService: tagimpl.ProvideService(ss, ss.Cfg)}
|
|
|
|
testDash := insertTestDashboard(t, sqlStore.db, "dashboard with alerts", 1, 0, false, "alert")
|
|
alert, err := insertTestAlert("Alerting title", "Alerting message", testDash.OrgID, testDash.ID, simplejson.New(), sqlStore)
|
|
require.Nil(t, err)
|
|
|
|
stateDateBeforePause := alert.NewStateDate
|
|
stateDateAfterPause := stateDateBeforePause
|
|
signedInUser := &user.SignedInUser{
|
|
OrgRole: org.RoleAdmin,
|
|
OrgID: testDash.OrgID,
|
|
Permissions: map[int64]map[string][]string{
|
|
testDash.OrgID: {
|
|
dashboards.ActionFoldersRead: {dashboards.ScopeDashboardsAll, dashboards.ScopeFoldersAll},
|
|
dashboards.ActionDashboardsRead: {dashboards.ScopeDashboardsAll, dashboards.ScopeFoldersAll},
|
|
},
|
|
},
|
|
}
|
|
// Get alert so we can use its ID in tests
|
|
alertQuery := models.GetAlertsQuery{DashboardIDs: []int64{testDash.ID}, PanelID: 1, OrgID: 1, User: signedInUser}
|
|
res, err2 := sqlStore.HandleAlertsQuery(context.Background(), &alertQuery)
|
|
require.Nil(t, err2)
|
|
|
|
insertedAlert := res[0]
|
|
|
|
t.Run("when paused", func(t *testing.T) {
|
|
_, err := sqlStore.pauseAlert(t, testDash.OrgID, insertedAlert.ID, true)
|
|
require.Nil(t, err)
|
|
|
|
t.Run("the NewStateDate should be updated", func(t *testing.T) {
|
|
alert, err := getAlertById(t, insertedAlert.ID, &sqlStore)
|
|
require.Nil(t, err)
|
|
|
|
stateDateAfterPause = alert.NewStateDate
|
|
require.True(t, stateDateBeforePause.Before(stateDateAfterPause))
|
|
})
|
|
})
|
|
|
|
t.Run("when unpaused", func(t *testing.T) {
|
|
_, err := sqlStore.pauseAlert(t, testDash.OrgID, insertedAlert.ID, false)
|
|
require.Nil(t, err)
|
|
|
|
t.Run("the NewStateDate should be updated again", func(t *testing.T) {
|
|
alert, err := getAlertById(t, insertedAlert.ID, &sqlStore)
|
|
require.Nil(t, err)
|
|
|
|
stateDateAfterUnpause := alert.NewStateDate
|
|
require.True(t, stateDateAfterPause.Before(stateDateAfterUnpause))
|
|
})
|
|
})
|
|
})
|
|
}
|
|
|
|
func (ss *sqlStore) pauseAlert(t *testing.T, orgId int64, alertId int64, pauseState bool) (int64, error) {
|
|
cmd := &models.PauseAlertCommand{
|
|
OrgID: orgId,
|
|
AlertIDs: []int64{alertId},
|
|
Paused: pauseState,
|
|
}
|
|
err := ss.PauseAlert(context.Background(), cmd)
|
|
require.Nil(t, err)
|
|
return cmd.ResultCount, err
|
|
}
|
|
|
|
func insertTestAlert(title string, message string, orgId int64, dashId int64, settings *simplejson.Json, ss sqlStore) (*models.Alert, error) {
|
|
items := []*models.Alert{
|
|
{
|
|
PanelID: 1,
|
|
DashboardID: dashId,
|
|
OrgID: orgId,
|
|
Name: title,
|
|
Message: message,
|
|
Settings: settings,
|
|
Frequency: 1,
|
|
},
|
|
}
|
|
|
|
err := ss.SaveAlerts(context.Background(), dashId, items)
|
|
return items[0], err
|
|
}
|
|
|
|
func getAlertById(t *testing.T, id int64, ss *sqlStore) (*models.Alert, error) {
|
|
q := &models.GetAlertByIdQuery{
|
|
ID: id,
|
|
}
|
|
res, err := ss.GetAlertById(context.Background(), q)
|
|
require.Nil(t, err)
|
|
return res, err
|
|
}
|
|
|
|
func (ss *sqlStore) pauseAllAlerts(t *testing.T, pauseState bool) error {
|
|
cmd := &models.PauseAllAlertCommand{
|
|
Paused: pauseState,
|
|
}
|
|
err := ss.PauseAllAlerts(context.Background(), cmd)
|
|
require.Nil(t, err)
|
|
return err
|
|
}
|
|
|
|
func insertTestDashboard(t *testing.T, store db.DB, title string, orgId int64,
|
|
folderId int64, isFolder bool, tags ...interface{}) *dashboards.Dashboard {
|
|
t.Helper()
|
|
cmd := dashboards.SaveDashboardCommand{
|
|
OrgID: orgId,
|
|
FolderID: folderId,
|
|
IsFolder: isFolder,
|
|
Dashboard: simplejson.NewFromAny(map[string]interface{}{
|
|
"id": nil,
|
|
"title": title,
|
|
"tags": tags,
|
|
}),
|
|
}
|
|
|
|
var dash *dashboards.Dashboard
|
|
err := store.WithDbSession(context.Background(), func(sess *db.Session) error {
|
|
dash = cmd.GetDashboardModel()
|
|
dash.SetVersion(1)
|
|
dash.Created = time.Now()
|
|
dash.Updated = time.Now()
|
|
dash.UID = util.GenerateShortUID()
|
|
_, err := sess.Insert(dash)
|
|
return err
|
|
})
|
|
|
|
require.NoError(t, err)
|
|
require.NotNil(t, dash)
|
|
dash.Data.Set("id", dash.ID)
|
|
dash.Data.Set("uid", dash.UID)
|
|
|
|
err = store.WithDbSession(context.Background(), func(sess *db.Session) error {
|
|
dashVersion := &dashver.DashboardVersion{
|
|
DashboardID: dash.ID,
|
|
ParentVersion: dash.Version,
|
|
RestoredFrom: cmd.RestoredFrom,
|
|
Version: dash.Version,
|
|
Created: time.Now(),
|
|
CreatedBy: dash.UpdatedBy,
|
|
Message: cmd.Message,
|
|
Data: dash.Data,
|
|
}
|
|
require.NoError(t, err)
|
|
|
|
if affectedRows, err := sess.Insert(dashVersion); err != nil {
|
|
return err
|
|
} else if affectedRows == 0 {
|
|
return dashboards.ErrDashboardNotFound
|
|
}
|
|
|
|
return nil
|
|
})
|
|
require.NoError(t, err)
|
|
|
|
return dash
|
|
}
|