Files
grafana/public/app/features/plugins/loader/systemjsHooks.test.ts
Jack Westbrook 0d1845f857 Plugins: Fix applying default extension and AMD detection (#74471)
* fix(plugins): support edge cases where default extension was not added

* fix(plugins): only apply AMD wrapper to AMD format plugins

* refactor(plugins): update regex for codeql warnings

* refactor(plugins): remove check for commented out dependency strings in AMD regex

* test(plugins): add tests for systemjs hook amd detection
2023-09-07 14:30:35 +02:00

226 lines
9.3 KiB
TypeScript

// mock fetch for SystemJS
import 'whatwg-fetch';
import { SystemJS, config } from '@grafana/runtime';
jest.mock('./cache', () => ({
resolveWithCache: (url: string) => `${url}?_cache=1234`,
}));
import {
server,
mockAmdModule,
mockSystemModule,
mockAmdModuleNamedNoDeps,
mockAmdModuleNamedWithDeps,
mockAmdModuleNamedWithDeps2,
mockAmdModuleNamedWithDeps3,
mockAmdModuleOnlyFunction,
mockAmdModuleWithComments,
mockModuleWithDefineMethod,
mockAmdModuleWithComments2,
} from './pluginLoader.mock';
import { decorateSystemJSFetch, decorateSystemJSResolve } from './systemjsHooks';
import { SystemJSWithLoaderHooks } from './types';
describe('SystemJS Loader Hooks', () => {
const systemJSPrototype: SystemJSWithLoaderHooks = SystemJS.constructor.prototype;
const originalFetch = systemJSPrototype.fetch;
const originalResolve = systemJSPrototype.resolve;
systemJSPrototype.resolve = (moduleId: string) => moduleId;
systemJSPrototype.shouldFetch = () => true;
beforeAll(() => {
server.listen();
});
afterEach(() => server.resetHandlers());
afterAll(() => {
SystemJS.constructor.prototype.resolve = originalResolve;
SystemJS.constructor.prototype.fetch = originalFetch;
server.close();
});
describe('decorateSystemJSFetch', () => {
it('wraps AMD modules in an AMD iife', async () => {
const basicResult = await decorateSystemJSFetch(originalFetch, '/public/plugins/mockAmdModule/module.js', {});
const basicSource = await basicResult.text();
const basicExpected = `(function(define) {
${mockAmdModule}
})(window.__grafana_amd_define);`;
expect(basicSource).toBe(basicExpected);
const mockAmdModuleNamedNoDepsResult = await decorateSystemJSFetch(
originalFetch,
'/public/plugins/mockAmdModuleNamedNoDeps/module.js',
{}
);
const mockAmdModuleNamedNoDepsSource = await mockAmdModuleNamedNoDepsResult.text();
const mockAmdModuleNamedNoDepsExpected = `(function(define) {
${mockAmdModuleNamedNoDeps}
})(window.__grafana_amd_define);`;
expect(mockAmdModuleNamedNoDepsSource).toBe(mockAmdModuleNamedNoDepsExpected);
const mockAmdModuleNamedWithDepsResult = await decorateSystemJSFetch(
originalFetch,
'/public/plugins/mockAmdModuleNamedWithDeps/module.js',
{}
);
const mockAmdModuleNamedWithDepsSource = await mockAmdModuleNamedWithDepsResult.text();
const mockAmdModuleNamedWithDepsExpected = `(function(define) {
${mockAmdModuleNamedWithDeps}
})(window.__grafana_amd_define);`;
expect(mockAmdModuleNamedWithDepsSource).toBe(mockAmdModuleNamedWithDepsExpected);
const mockAmdModuleNamedWithDeps2Result = await decorateSystemJSFetch(
originalFetch,
'/public/plugins/mockAmdModuleNamedWithDeps2/module.js',
{}
);
const mockAmdModuleNamedWithDeps2Source = await mockAmdModuleNamedWithDeps2Result.text();
const mockAmdModuleNamedWithDeps2Expected = `(function(define) {
${mockAmdModuleNamedWithDeps2}
})(window.__grafana_amd_define);`;
expect(mockAmdModuleNamedWithDeps2Source).toBe(mockAmdModuleNamedWithDeps2Expected);
const mockAmdModuleNamedWithDeps3Result = await decorateSystemJSFetch(
originalFetch,
'/public/plugins/mockAmdModuleNamedWithDeps3/module.js',
{}
);
const mockAmdModuleNamedWithDeps3Source = await mockAmdModuleNamedWithDeps3Result.text();
const mockAmdModuleNamedWithDeps3Expected = `(function(define) {
${mockAmdModuleNamedWithDeps3}
})(window.__grafana_amd_define);`;
expect(mockAmdModuleNamedWithDeps3Source).toBe(mockAmdModuleNamedWithDeps3Expected);
const mockAmdModuleOnlyFunctionResult = await decorateSystemJSFetch(
originalFetch,
'/public/plugins/mockAmdModuleOnlyFunction/module.js',
{}
);
const mockAmdModuleOnlyFunctionSource = await mockAmdModuleOnlyFunctionResult.text();
const mockAmdModuleOnlyFunctionExpected = `(function(define) {
${mockAmdModuleOnlyFunction}
})(window.__grafana_amd_define);`;
expect(mockAmdModuleOnlyFunctionSource).toBe(mockAmdModuleOnlyFunctionExpected);
const mockAmdModuleWithCommentsResult = await decorateSystemJSFetch(
originalFetch,
'/public/plugins/mockAmdModuleWithComments/module.js',
{}
);
const mockAmdModuleWithCommentsSource = await mockAmdModuleWithCommentsResult.text();
const mockAmdModuleWithCommentsExpected = `(function(define) {
${mockAmdModuleWithComments}
})(window.__grafana_amd_define);`;
expect(mockAmdModuleWithCommentsSource).toBe(mockAmdModuleWithCommentsExpected);
const mockAmdModuleWithComments2Result = await decorateSystemJSFetch(
originalFetch,
'/public/plugins/mockAmdModuleWithComments2/module.js',
{}
);
const mockAmdModuleWithComments2Source = await mockAmdModuleWithComments2Result.text();
const mockAmdModuleWithComments2Expected = `(function(define) {
${mockAmdModuleWithComments2}
})(window.__grafana_amd_define);`;
expect(mockAmdModuleWithComments2Source).toBe(mockAmdModuleWithComments2Expected);
});
it("doesn't wrap system modules in an AMD iife", async () => {
const url = '/public/plugins/mockSystemModule/module.js';
const result = await decorateSystemJSFetch(originalFetch, url, {});
const source = await result.text();
expect(source).toBe(mockSystemModule);
});
it("doesn't wrap modules with a define method in an AMD iife", async () => {
const url = '/public/plugins/mockModuleWithDefineMethod/module.js';
const result = await decorateSystemJSFetch(originalFetch, url, {});
const source = await result.text();
expect(source).toBe(mockModuleWithDefineMethod);
});
it('only transforms plugin source code hosted on cdn with cdn paths', async () => {
config.pluginsCDNBaseURL = 'http://my-cdn.com/plugins';
const cdnUrl = 'http://my-cdn.com/plugins/my-plugin/v1.0.0/public/plugins/my-plugin/module.js';
const cdnResult = await decorateSystemJSFetch(originalFetch, cdnUrl, {});
const cdnSource = await cdnResult.text();
expect(cdnSource).toContain('var pluginPath = "http://my-cdn.com/plugins/my-plugin/v1.0.0/public/plugins/";');
const url = '/public/plugins/mockAmdModule/module.js';
const result = await decorateSystemJSFetch(originalFetch, url, {});
const source = await result.text();
expect(source).toContain('var pluginPath = "/public/plugins/";');
});
});
describe('decorateSystemJSResolve', () => {
it('removes legacy wildcard from resolved url', () => {
const id = '/public/plugins/my-datasource/styles.css!';
const result = decorateSystemJSResolve.bind(systemJSPrototype)(originalResolve, id);
expect(result).toBe('http://localhost/public/plugins/my-datasource/styles.css');
});
it('adds default js extension to resolved url', () => {
// test against missing extension
const id = '/public/plugins/my-plugin/traffic_light';
const result = decorateSystemJSResolve.bind(systemJSPrototype)(originalResolve, id);
expect(result).toBe('http://localhost/public/plugins/my-plugin/traffic_light.js');
// test against missing extension with periods in filename
const id2 = '/public/plugins/my-plugin/lib/flot/jquery.flot.gauge';
const result2 = decorateSystemJSResolve.bind(systemJSPrototype)(originalResolve, id2);
expect(result2).toBe('http://localhost/public/plugins/my-plugin/lib/flot/jquery.flot.gauge.js');
// test against bare specifiers
const id3 = 'package:lodash';
const result3 = decorateSystemJSResolve.bind(systemJSPrototype)(originalResolve, id3);
expect(result3).toBe('package:lodash');
// test against file extensions systemjs can load
const id4 = '/public/plugins/my-plugin/traffic_light.js';
const result4 = decorateSystemJSResolve.bind(systemJSPrototype)(originalResolve, id4);
expect(result4).toBe('http://localhost/public/plugins/my-plugin/traffic_light.js');
const id5 = '/public/plugins/my-plugin/traffic_light.css';
const result5 = decorateSystemJSResolve.bind(systemJSPrototype)(originalResolve, id5);
expect(result5).toBe('http://localhost/public/plugins/my-plugin/traffic_light.css');
const id6 = '/public/plugins/my-plugin/traffic_light.json';
const result6 = decorateSystemJSResolve.bind(systemJSPrototype)(originalResolve, id6);
expect(result6).toBe('http://localhost/public/plugins/my-plugin/traffic_light.json');
const id7 = '/public/plugins/my-plugin/traffic_light.wasm';
const result7 = decorateSystemJSResolve.bind(systemJSPrototype)(originalResolve, id7);
expect(result7).toBe('http://localhost/public/plugins/my-plugin/traffic_light.wasm');
});
it('resolves loadPluginCSS urls correctly', () => {
const id = 'plugins/my-plugin/dark.css';
const result = decorateSystemJSResolve.bind(systemJSPrototype)(originalResolve, id);
expect(result).toBe('/public/plugins/my-plugin/dark.css');
});
it('adds cache query param to resolved module.js url', () => {
const id = '/public/plugins/my-plugin/module.js';
const result = decorateSystemJSResolve.bind(systemJSPrototype)(originalResolve, id);
expect(result).toBe('http://localhost/public/plugins/my-plugin/module.js?_cache=1234');
});
});
});