mirror of
https://github.com/grafana/grafana.git
synced 2024-11-26 19:00:54 -06:00
489b302c03
* add correlation config type, CorrelationConfig validator & default values * make config required when creating correlations * make targetUID optional, add validation for createCommand & configType * fix tests * update remaining tests * fix lint error * Update pkg/services/correlations/models.go Co-authored-by: Piotr Jamróz <pm.jamroz@gmail.com> * update docs Co-authored-by: Piotr Jamróz <pm.jamroz@gmail.com>
92 lines
2.1 KiB
Go
92 lines
2.1 KiB
Go
package correlations
|
|
|
|
import (
|
|
"encoding/json"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestCorrelationModels(t *testing.T) {
|
|
t.Run("CreateCorrelationCommand Validate", func(t *testing.T) {
|
|
t.Run("Successfully validates a correct create command", func(t *testing.T) {
|
|
targetUid := "targetUid"
|
|
config := &CorrelationConfig{
|
|
Field: "field",
|
|
Target: map[string]interface{}{},
|
|
Type: ConfigTypeQuery,
|
|
}
|
|
cmd := &CreateCorrelationCommand{
|
|
SourceUID: "some-uid",
|
|
OrgId: 1,
|
|
TargetUID: &targetUid,
|
|
Config: *config,
|
|
}
|
|
|
|
require.NoError(t, cmd.Validate())
|
|
})
|
|
|
|
t.Run("Fails if target UID is not set and config type = query", func(t *testing.T) {
|
|
config := &CorrelationConfig{
|
|
Field: "field",
|
|
Target: map[string]interface{}{},
|
|
Type: ConfigTypeQuery,
|
|
}
|
|
cmd := &CreateCorrelationCommand{
|
|
SourceUID: "some-uid",
|
|
OrgId: 1,
|
|
Config: *config,
|
|
}
|
|
|
|
require.Error(t, cmd.Validate())
|
|
})
|
|
|
|
t.Run("Fails if config type is unknown", func(t *testing.T) {
|
|
config := &CorrelationConfig{
|
|
Field: "field",
|
|
Target: map[string]interface{}{},
|
|
Type: "unknown config type",
|
|
}
|
|
cmd := &CreateCorrelationCommand{
|
|
SourceUID: "some-uid",
|
|
OrgId: 1,
|
|
Config: *config,
|
|
}
|
|
|
|
require.Error(t, cmd.Validate())
|
|
})
|
|
})
|
|
|
|
t.Run("CorrelationConfigType Validate", func(t *testing.T) {
|
|
t.Run("Successfully validates a correct type", func(t *testing.T) {
|
|
type test struct {
|
|
input CorrelationConfigType
|
|
assertion require.ErrorAssertionFunc
|
|
}
|
|
|
|
tests := []test{
|
|
{input: "query", assertion: require.NoError},
|
|
{input: "link", assertion: require.Error},
|
|
}
|
|
|
|
for _, tc := range tests {
|
|
tc.assertion(t, tc.input.Validate())
|
|
}
|
|
})
|
|
})
|
|
|
|
t.Run("CorrelationConfig JSON Marshaling", func(t *testing.T) {
|
|
t.Run("Applies a default empty object if target is not defined", func(t *testing.T) {
|
|
config := CorrelationConfig{
|
|
Field: "field",
|
|
Type: ConfigTypeQuery,
|
|
}
|
|
|
|
data, err := json.Marshal(config)
|
|
require.NoError(t, err)
|
|
|
|
require.Equal(t, `{"type":"query","field":"field","target":{}}`, string(data))
|
|
})
|
|
})
|
|
}
|