mirror of
https://github.com/grafana/grafana.git
synced 2024-11-27 19:30:36 -06:00
30aa24a183
* Separate Tracer interface to TracerService and Tracer * Fix lint * Fix:Make it possible to start spans for both opentracing and opentelemetry in ds proxy * Add span methods, use span interface for rest of tracing * Fix logs in tracing * Fix tests that are related to tracing * Fix resourcepermissions test * Fix some tests * Fix more tests * Add TracingService to wire cli runner * Remove GlobalTracer from bus * Renaming test function * Remove GlobalTracer from TSDB * Replace GlobalTracer in api * Adjust tests to the InitializeForTests func * Remove GlobalTracer from services * Remove GlobalTracer * Remove bus.NewTest * Remove Tracer interface * Add InitializeForBus * Simplify tests * Clean up tests * Rename TracerService to Tracer * Update pkg/middleware/request_tracing.go Co-authored-by: Marcus Efraimsson <marcus.efraimsson@gmail.com> * Initialize tracer before passing it to SQLStore initialization in commands * Remove tests for opentracing * Set span attributes correctly, remove unnecessary trace initiliazation form test * Add tracer instance to newSQLStore * Fix changes due to rebase * Add modified tracing middleware test * Fix opentracing implementation tags Co-authored-by: Marcus Efraimsson <marcus.efraimsson@gmail.com>
146 lines
4.8 KiB
Go
146 lines
4.8 KiB
Go
package middleware
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"testing"
|
|
|
|
"github.com/grafana/grafana/pkg/bus"
|
|
"github.com/grafana/grafana/pkg/models"
|
|
"github.com/grafana/grafana/pkg/setting"
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestMiddlewareAuth(t *testing.T) {
|
|
reqSignIn := Auth(&AuthOptions{ReqSignedIn: true})
|
|
|
|
middlewareScenario(t, "ReqSignIn true and unauthenticated request", func(t *testing.T, sc *scenarioContext) {
|
|
sc.m.Get("/secure", reqSignIn, sc.defaultHandler)
|
|
sc.fakeReq("GET", "/secure").exec()
|
|
|
|
assert.Equal(t, 302, sc.resp.Code)
|
|
})
|
|
|
|
middlewareScenario(t, "ReqSignIn true and unauthenticated API request", func(t *testing.T, sc *scenarioContext) {
|
|
sc.m.Get("/api/secure", reqSignIn, sc.defaultHandler)
|
|
|
|
sc.fakeReq("GET", "/api/secure").exec()
|
|
|
|
assert.Equal(t, 401, sc.resp.Code)
|
|
})
|
|
|
|
t.Run("Anonymous auth enabled", func(t *testing.T) {
|
|
const orgID int64 = 1
|
|
|
|
configure := func(cfg *setting.Cfg) {
|
|
cfg.AnonymousEnabled = true
|
|
cfg.AnonymousOrgName = "test"
|
|
}
|
|
|
|
middlewareScenario(t, "ReqSignIn true and NoAnonynmous true", func(
|
|
t *testing.T, sc *scenarioContext) {
|
|
bus.AddHandler("test", func(ctx context.Context, query *models.GetOrgByNameQuery) error {
|
|
query.Result = &models.Org{Id: orgID, Name: "test"}
|
|
return nil
|
|
})
|
|
|
|
sc.m.Get("/api/secure", ReqSignedInNoAnonymous, sc.defaultHandler)
|
|
sc.fakeReq("GET", "/api/secure").exec()
|
|
|
|
assert.Equal(t, 401, sc.resp.Code)
|
|
}, configure)
|
|
|
|
middlewareScenario(t, "ReqSignIn true and request with forceLogin in query string", func(
|
|
t *testing.T, sc *scenarioContext) {
|
|
bus.AddHandler("test", func(ctx context.Context, query *models.GetOrgByNameQuery) error {
|
|
query.Result = &models.Org{Id: orgID, Name: "test"}
|
|
return nil
|
|
})
|
|
|
|
sc.m.Get("/secure", reqSignIn, sc.defaultHandler)
|
|
|
|
sc.fakeReq("GET", "/secure?forceLogin=true").exec()
|
|
|
|
assert.Equal(t, 302, sc.resp.Code)
|
|
location, ok := sc.resp.Header()["Location"]
|
|
assert.True(t, ok)
|
|
assert.Equal(t, "/login", location[0])
|
|
}, configure)
|
|
|
|
middlewareScenario(t, "ReqSignIn true and request with same org provided in query string", func(
|
|
t *testing.T, sc *scenarioContext) {
|
|
org, err := sc.sqlStore.CreateOrgWithMember(sc.cfg.AnonymousOrgName, 1)
|
|
require.NoError(t, err)
|
|
|
|
sc.m.Get("/secure", reqSignIn, sc.defaultHandler)
|
|
|
|
sc.fakeReq("GET", fmt.Sprintf("/secure?orgId=%d", org.Id)).exec()
|
|
|
|
assert.Equal(t, 200, sc.resp.Code)
|
|
}, configure)
|
|
|
|
middlewareScenario(t, "ReqSignIn true and request with different org provided in query string", func(
|
|
t *testing.T, sc *scenarioContext) {
|
|
bus.AddHandler("test", func(ctx context.Context, query *models.GetOrgByNameQuery) error {
|
|
query.Result = &models.Org{Id: orgID, Name: "test"}
|
|
return nil
|
|
})
|
|
|
|
sc.m.Get("/secure", reqSignIn, sc.defaultHandler)
|
|
|
|
sc.fakeReq("GET", "/secure?orgId=2").exec()
|
|
|
|
assert.Equal(t, 302, sc.resp.Code)
|
|
location, ok := sc.resp.Header()["Location"]
|
|
assert.True(t, ok)
|
|
assert.Equal(t, "/login", location[0])
|
|
}, configure)
|
|
})
|
|
|
|
middlewareScenario(t, "Snapshot public mode disabled and unauthenticated request should return 401", func(
|
|
t *testing.T, sc *scenarioContext) {
|
|
sc.m.Get("/api/snapshot", func(c *models.ReqContext) {
|
|
c.IsSignedIn = false
|
|
}, SnapshotPublicModeOrSignedIn(sc.cfg), sc.defaultHandler)
|
|
sc.fakeReq("GET", "/api/snapshot").exec()
|
|
assert.Equal(t, 401, sc.resp.Code)
|
|
})
|
|
|
|
middlewareScenario(t, "Snapshot public mode disabled and authenticated request should return 200", func(
|
|
t *testing.T, sc *scenarioContext) {
|
|
sc.m.Get("/api/snapshot", func(c *models.ReqContext) {
|
|
c.IsSignedIn = true
|
|
}, SnapshotPublicModeOrSignedIn(sc.cfg), sc.defaultHandler)
|
|
sc.fakeReq("GET", "/api/snapshot").exec()
|
|
assert.Equal(t, 200, sc.resp.Code)
|
|
})
|
|
|
|
middlewareScenario(t, "Snapshot public mode enabled and unauthenticated request should return 200", func(
|
|
t *testing.T, sc *scenarioContext) {
|
|
sc.cfg.SnapshotPublicMode = true
|
|
sc.m.Get("/api/snapshot", SnapshotPublicModeOrSignedIn(sc.cfg), sc.defaultHandler)
|
|
sc.fakeReq("GET", "/api/snapshot").exec()
|
|
assert.Equal(t, 200, sc.resp.Code)
|
|
})
|
|
}
|
|
|
|
func TestRemoveForceLoginparams(t *testing.T) {
|
|
tcs := []struct {
|
|
inp string
|
|
exp string
|
|
}{
|
|
{inp: "/?forceLogin=true", exp: "/?"},
|
|
{inp: "/d/dash/dash-title?ordId=1&forceLogin=true", exp: "/d/dash/dash-title?ordId=1"},
|
|
{inp: "/?kiosk&forceLogin=true", exp: "/?kiosk"},
|
|
{inp: "/d/dash/dash-title?ordId=1&kiosk&forceLogin=true", exp: "/d/dash/dash-title?ordId=1&kiosk"},
|
|
{inp: "/d/dash/dash-title?ordId=1&forceLogin=true&kiosk", exp: "/d/dash/dash-title?ordId=1&kiosk"},
|
|
{inp: "/d/dash/dash-title?forceLogin=true&kiosk", exp: "/d/dash/dash-title?&kiosk"},
|
|
}
|
|
for i, tc := range tcs {
|
|
t.Run(fmt.Sprintf("testcase %d", i), func(t *testing.T) {
|
|
require.Equal(t, tc.exp, removeForceLoginParams(tc.inp))
|
|
})
|
|
}
|
|
}
|