mirror of
https://github.com/grafana/grafana.git
synced 2024-12-30 10:47:30 -06:00
b287047052
* WIP * Set public_suffix to a pre Ruby 2.6 version * we don't need to install python * Stretch->Buster * Bump versions in lib.star * Manually update linter Sort of messy, but the .mod-file need to contain all dependencies that use 1.16+ features, otherwise they're assumed to be compiled with -lang=go1.16 and cannot access generics et al. Bingo doesn't seem to understand that, but it's possible to manually update things to get Bingo happy. * undo reformatting * Various lint improvements * More from the linter * goimports -w ./pkg/ * Disable gocritic * Add/modify linter exceptions * lint + flatten nested list Go 1.19 doesn't support nested lists, and there wasn't an obvious workaround. https://go.dev/doc/comment#lists
146 lines
3.0 KiB
TOML
146 lines
3.0 KiB
TOML
[run]
|
|
timeout = "10m"
|
|
|
|
[linters-settings.goconst]
|
|
min-len = 5
|
|
min-occurrences = 5
|
|
|
|
[linters-settings.exhaustive]
|
|
default-signifies-exhaustive = true
|
|
|
|
[linters-settings.revive]
|
|
ignore-generated-header = false
|
|
severity = "warning"
|
|
confidence = 3
|
|
|
|
[linters-settings.depguard]
|
|
list-type = "blacklist"
|
|
include-go-root = true
|
|
packages = ["io/ioutil"]
|
|
[[linters-settings.depguard.packages-with-error-message]]
|
|
"io/ioutil" = "Deprecated: As of Go 1.16, the same functionality is now provided by package io or package os, and those implementations should be preferred in new code. See the specific function documentation for details."
|
|
|
|
[linters-settings.gocritic]
|
|
enabled-checks = ["ruleguard"]
|
|
[linters-settings.gocritic.settings.ruleguard]
|
|
rules = "pkg/ruleguard.rules.go"
|
|
|
|
[linters]
|
|
disable-all = true
|
|
enable = [
|
|
"bodyclose",
|
|
"depguard",
|
|
"dogsled",
|
|
"errcheck",
|
|
# "gochecknoinits",
|
|
"goconst",
|
|
# "gocritic", # Temporarily disabled on 2022-09-09, running into weird bug "ruleguard: execution error: used Run() with an empty rule set; forgot to call Load() first?"
|
|
"goimports",
|
|
"goprintffuncname",
|
|
"gosec",
|
|
"gosimple",
|
|
"govet",
|
|
"ineffassign",
|
|
"misspell",
|
|
"nakedret",
|
|
"rowserrcheck",
|
|
"exportloopref",
|
|
"staticcheck",
|
|
"stylecheck",
|
|
"typecheck",
|
|
"unconvert",
|
|
"unused",
|
|
"whitespace",
|
|
"gocyclo",
|
|
"exhaustive",
|
|
"typecheck",
|
|
"asciicheck",
|
|
"errorlint",
|
|
"sqlclosecheck",
|
|
"revive",
|
|
]
|
|
|
|
# Disabled linters (might want them later)
|
|
# "unparam"
|
|
|
|
[issues]
|
|
exclude-use-default = false
|
|
|
|
# Enable when appropriate
|
|
# Poorly chosen identifier
|
|
[[issues.exclude-rules]]
|
|
linters = ["stylecheck"]
|
|
text = "ST1003"
|
|
|
|
# Enable when appropriate
|
|
# Dot imports that aren't in external test packages are discouraged.
|
|
[[issues.exclude-rules]]
|
|
linters = ["stylecheck"]
|
|
text = "ST1001"
|
|
|
|
# Enable when appropriate
|
|
# strings.Title has been deprecated since Go 1.18 and an alternative has been available since Go 1.0: The rule Title uses for word boundaries does not handle Unicode punctuation properly.
|
|
# Use golang.org/x/text/cases instead.
|
|
[[issues.exclude-rules]]
|
|
linters = ["staticcheck"]
|
|
text = "SA1019"
|
|
|
|
[[issues.exclude-rules]]
|
|
linters = ["gosec"]
|
|
text = "G108"
|
|
|
|
[[issues.exclude-rules]]
|
|
linters = ["gosec"]
|
|
text = "G110"
|
|
|
|
[[issues.exclude-rules]]
|
|
linters = ["gosec"]
|
|
text = "G201"
|
|
|
|
[[issues.exclude-rules]]
|
|
linters = ["gosec"]
|
|
text = "G202"
|
|
|
|
[[issues.exclude-rules]]
|
|
linters = ["gosec"]
|
|
text = "G306"
|
|
|
|
[[issues.exclude-rules]]
|
|
linters = ["gosec"]
|
|
text = "401"
|
|
|
|
[[issues.exclude-rules]]
|
|
linters = ["gosec"]
|
|
text = "402"
|
|
|
|
[[issues.exclude-rules]]
|
|
linters = ["gosec"]
|
|
text = "501"
|
|
|
|
[[issues.exclude-rules]]
|
|
linters = ["gosec"]
|
|
text = "404"
|
|
|
|
[[issues.exclude-rules]]
|
|
linters = ["misspell"]
|
|
text = "Unknwon` is a misspelling of `Unknown"
|
|
|
|
[[issues.exclude-rules]]
|
|
linters = ["errorlint"]
|
|
text = "non-wrapping format verb for fmt.Errorf"
|
|
|
|
# TODO: Enable
|
|
[[issues.exclude-rules]]
|
|
linters = ["stylecheck"]
|
|
text = "ST1000"
|
|
|
|
# TODO: Enable
|
|
[[issues.exclude-rules]]
|
|
linters = ["stylecheck"]
|
|
text = "ST1020"
|
|
|
|
# TODO: Enable
|
|
[[issues.exclude-rules]]
|
|
linters = ["stylecheck"]
|
|
text = "ST1021"
|