mirror of
https://github.com/grafana/grafana.git
synced 2025-02-25 18:55:37 -06:00
41ac8d4cd5
Fix problem with adhoc variable filters not handled. Fix problem with saving variables and time per default when saving a dashboard as/first time. Fix updating dashboard model after save with saving time/variables enabled so that next time you save you won't get checkboxes for save time/variables unless any values changed. Tests validating correctness if time/variable values has changed.
58 lines
2.2 KiB
TypeScript
58 lines
2.2 KiB
TypeScript
import { SaveDashboardModalCtrl } from '../save_modal';
|
|
|
|
const setup = (timeChanged, variableValuesChanged, cb) => {
|
|
const dash = {
|
|
hasTimeChanged: jest.fn().mockReturnValue(timeChanged),
|
|
hasVariableValuesChanged: jest.fn().mockReturnValue(variableValuesChanged),
|
|
resetOriginalTime: jest.fn(),
|
|
resetOriginalVariables: jest.fn(),
|
|
getSaveModelClone: jest.fn().mockReturnValue({}),
|
|
};
|
|
const dashboardSrvMock = {
|
|
getCurrent: jest.fn().mockReturnValue(dash),
|
|
save: jest.fn().mockReturnValue(Promise.resolve()),
|
|
};
|
|
const ctrl = new SaveDashboardModalCtrl(dashboardSrvMock);
|
|
ctrl.saveForm = {
|
|
$valid: true,
|
|
};
|
|
ctrl.dismiss = () => Promise.resolve();
|
|
cb(dash, ctrl, dashboardSrvMock);
|
|
};
|
|
|
|
describe('SaveDashboardModal', () => {
|
|
describe('Given time and template variable values have not changed', () => {
|
|
setup(false, false, (dash, ctrl: SaveDashboardModalCtrl) => {
|
|
it('When creating ctrl should set time and template variable values changed', () => {
|
|
expect(ctrl.timeChange).toBeFalsy();
|
|
expect(ctrl.variableValueChange).toBeFalsy();
|
|
});
|
|
});
|
|
});
|
|
|
|
describe('Given time and template variable values have changed', () => {
|
|
setup(true, true, (dash, ctrl: SaveDashboardModalCtrl) => {
|
|
it('When creating ctrl should set time and template variable values changed', () => {
|
|
expect(ctrl.timeChange).toBeTruthy();
|
|
expect(ctrl.variableValueChange).toBeTruthy();
|
|
});
|
|
|
|
it('When save time and variable value changes disabled and saving should reset original time and template variable values', async () => {
|
|
ctrl.saveTimerange = false;
|
|
ctrl.saveVariables = false;
|
|
await ctrl.save();
|
|
expect(dash.resetOriginalTime).toHaveBeenCalledTimes(0);
|
|
expect(dash.resetOriginalVariables).toHaveBeenCalledTimes(0);
|
|
});
|
|
|
|
it('When save time and variable value changes enabled and saving should reset original time and template variable values', async () => {
|
|
ctrl.saveTimerange = true;
|
|
ctrl.saveVariables = true;
|
|
await ctrl.save();
|
|
expect(dash.resetOriginalTime).toHaveBeenCalledTimes(1);
|
|
expect(dash.resetOriginalVariables).toHaveBeenCalledTimes(1);
|
|
});
|
|
});
|
|
});
|
|
});
|