mirror of
https://github.com/grafana/grafana.git
synced 2025-02-25 18:55:37 -06:00
* POC: Plugins CDN reverse proxy * CDN proxy POC: changed env var names * Add authorization: false for /public path in frontend plugin loader * Moved CDN settings to Cfg, add some comments * Fix error 500 in asset fetch if plugin is not using CDN * Fix EnterpriseLicensePath declared twice * Fix linter complaining about whitespaces * Plugins CDN: Skip signature verification for CDN plugins * Plugins CDN: Skip manifest and signature check for cdn plugins * Plugins: use IsValid() and IsInternal() rather than equality checks * Plugins CDN: remove comment * Plugins CDN: Fix seeker can't seek when serving plugins from local fs * Plugins CDN: add back error codes in getLocalPluginAssets * Plugins CDN: call asset.Close() rather than asset.readSeekCloser.Close() * Plugins CDN: Fix panic in JsonApiErr when errorMessageCoder wraps a nil error * Plugins CDN: Add error handling to proxyCDNPluginAsset * Plugins CDN: replace errorMessageCoder with errutil * Plugins CDN POC: expose cdn plugin paths to frontend for system.js * Plugins CDN: Fix cdn plugins showing as unsigned in frontend * WIP: Add support for formatted URL * Fix missing cdnPluginsBaseURLs in GrafanaConfig * Plugins CDN: Remove reverse proxy mode and reverse proxy references * Plugins CDN: Simplify asset serving logic * Plugins CDN: sanitize redirect path * Plugins CDN: Removed unused pluginAsset type * Plugins CDN: Removed system.js changes * Plugins CDN: Return different system.js baseURL and module for cdn plugins * Plugins CDN: Ensure CDN is disabled for non-external plugins * lint * Plugins CDN: serve images and screenshots from CDN, refactoring * Lint * Plugins CDN: Fix URLs for system.js (baseUrl and module) * Plugins CDN: Add more tests for RelativeURLForSystemJS * Plugins CDN: Iterate only on apps when preloading * Plugins CDN: Refactoring * Plugins CDN: Add comments to url_constructor.go * Plugins CDN: Update defaultHGPluginsCDNBaseURL * Plugins CDN: undo extract meta from system js config * refactor(plugins): migrate systemjs css plugin to typescript * feat(plugins): introduce systemjs cdn loader plugin * feat(plugins): add systemjs load type * Plugins CDN: Removed RelativeURLForSystemJS * Plugins CDN: Log backend redirect hits along with plugin info * Plugins CDN: Add pluginsCDNBasePath to getFrontendSettingsMap * feat(plugins): introduce cdn loading for angular plugins * refactor(plugins): move systemjs cache buster into systemjsplugins directory * Plugins CDN: Rename pluginsCDNBasePath to pluginsCDNBaseURL * refactor(plugins): introduce pluginsCDNBaseURL to the frontend * Plugins CDN: Renamed "cdn base path" to "cdn url template" in backend * Plugins CDN: lint * merge with main * Instrumentation: Add prometheus counter for backend hits, log from Info to Warn * Config: Changed key from plugins_cdn.url to plugins.plugins_cdn_base_url * CDN: Add backend tests * Lint: goimports * Default CDN URL to empty string, * Do not use CDN in setImages and module if the url template is empty * CDN: Backend: Add test for frontend settings * CDN: Do not log missing module.js warn if plugin is being loaded from CDN * CDN: Add backend test for CDN plugin loader * Removed 'cdn' signature level, switch to 'valid' * Fix pfs.TestParseTreeTestdata for cdn plugin testdata dir * Fix TestLoader_Load * Fix gocyclo complexity of loadPlugins * Plugins CDN: Moved prometheus metric to api package, removed asset_path label * Fix missing in config * Changes after review * Add pluginscdn.Service * Fix tests * Refactoring * Moved all remaining CDN checks inside pluginscdn.Service * CDN url constructor: Renamed stringURLFor to stringPath * CDN: Moved asset URL functionality to assetpath service * CDN: Renamed HasCDN() to IsEnabled() * CDN: Replace assert with require * CDN: Changes after review * Assetpath: Handle url.Parse error * Fix plugin_resource_test * CDN: Change fallback redirect from 302 to 307 * goimports * Fix tests * Switch to contextmodel.ReqContext in plugins.go Co-authored-by: Will Browne <will.browne@grafana.com> Co-authored-by: Jack Westbrook <jack.westbrook@gmail.com>
79 lines
2.5 KiB
Go
79 lines
2.5 KiB
Go
package signature
|
|
|
|
import (
|
|
"github.com/grafana/grafana/pkg/infra/log"
|
|
"github.com/grafana/grafana/pkg/plugins"
|
|
)
|
|
|
|
type Validator struct {
|
|
authorizer plugins.PluginLoaderAuthorizer
|
|
log log.Logger
|
|
}
|
|
|
|
func NewValidator(authorizer plugins.PluginLoaderAuthorizer) Validator {
|
|
return Validator{
|
|
authorizer: authorizer,
|
|
log: log.New("plugin.signature.validator"),
|
|
}
|
|
}
|
|
|
|
func (s *Validator) Validate(plugin *plugins.Plugin) *plugins.SignatureError {
|
|
if plugin.Signature.IsValid() {
|
|
s.log.Debug("Plugin has valid signature", "id", plugin.ID)
|
|
return nil
|
|
}
|
|
|
|
// If a plugin is nested within another, create links to each other to inherit signature details
|
|
if plugin.Parent != nil {
|
|
if plugin.IsCorePlugin() || plugin.Signature.IsInternal() {
|
|
s.log.Debug("Not setting descendant plugin's signature to that of root since it's core or internal",
|
|
"plugin", plugin.ID, "signature", plugin.Signature, "isCore", plugin.IsCorePlugin())
|
|
} else {
|
|
s.log.Debug("Setting descendant plugin's signature to that of root", "plugin", plugin.ID,
|
|
"root", plugin.Parent.ID, "signature", plugin.Signature, "rootSignature", plugin.Parent.Signature)
|
|
plugin.Signature = plugin.Parent.Signature
|
|
plugin.SignatureType = plugin.Parent.SignatureType
|
|
plugin.SignatureOrg = plugin.Parent.SignatureOrg
|
|
if plugin.Signature.IsValid() {
|
|
s.log.Debug("Plugin has valid signature (inherited from root)", "id", plugin.ID)
|
|
return nil
|
|
}
|
|
}
|
|
}
|
|
|
|
if plugin.IsCorePlugin() || plugin.IsBundledPlugin() {
|
|
return nil
|
|
}
|
|
|
|
switch plugin.Signature {
|
|
case plugins.SignatureUnsigned:
|
|
if authorized := s.authorizer.CanLoadPlugin(plugin); !authorized {
|
|
s.log.Debug("Plugin is unsigned", "pluginID", plugin.ID)
|
|
return &plugins.SignatureError{
|
|
PluginID: plugin.ID,
|
|
SignatureStatus: plugins.SignatureUnsigned,
|
|
}
|
|
}
|
|
s.log.Warn("Permitting unsigned plugin. This is not recommended", "pluginID", plugin.ID)
|
|
return nil
|
|
case plugins.SignatureInvalid:
|
|
s.log.Debug("Plugin has an invalid signature", "pluginID", plugin.ID)
|
|
return &plugins.SignatureError{
|
|
PluginID: plugin.ID,
|
|
SignatureStatus: plugins.SignatureInvalid,
|
|
}
|
|
case plugins.SignatureModified:
|
|
s.log.Debug("Plugin has a modified signature", "pluginID", plugin.ID)
|
|
return &plugins.SignatureError{
|
|
PluginID: plugin.ID,
|
|
SignatureStatus: plugins.SignatureModified,
|
|
}
|
|
default:
|
|
s.log.Debug("Plugin has an unrecognized plugin signature state", "pluginID", plugin.ID, "signature",
|
|
plugin.Signature)
|
|
return &plugins.SignatureError{
|
|
PluginID: plugin.ID,
|
|
}
|
|
}
|
|
}
|