mirror of
https://github.com/grafana/grafana.git
synced 2024-12-01 21:19:28 -06:00
8808de0b45
* Improve error handling and update tests * Assert errors are nil * Refactor away redundant code
150 lines
5.3 KiB
Go
150 lines
5.3 KiB
Go
package metrics
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestBuildResourceURI(t *testing.T) {
|
|
t.Run("AzureMonitor Resource URI Builder", func(t *testing.T) {
|
|
t.Run("when there is no resource uri", func(t *testing.T) {
|
|
ub := &urlBuilder{
|
|
DefaultSubscription: strPtr("default-sub"),
|
|
MetricDefinition: strPtr("Microsoft.Web/serverFarms"),
|
|
ResourceGroup: strPtr("rg"),
|
|
ResourceName: strPtr("rn1"),
|
|
}
|
|
|
|
result, err := ub.buildResourceURI()
|
|
if err != nil {
|
|
return
|
|
}
|
|
url := *result
|
|
assert.Equal(t, "/subscriptions/default-sub/resourceGroups/rg/providers/Microsoft.Web/serverFarms/rn1", url)
|
|
})
|
|
|
|
t.Run("when only resource uri is provided it returns the resource URI", func(t *testing.T) {
|
|
ub := &urlBuilder{
|
|
ResourceURI: strPtr("/subscriptions/sub/resource/uri"),
|
|
}
|
|
|
|
url, err := ub.buildResourceURI()
|
|
assert.Nil(t, err)
|
|
assert.Equal(t, "/subscriptions/sub/resource/uri", *url)
|
|
})
|
|
|
|
t.Run("when resource uri and legacy fields are provided the legacy fields are ignored", func(t *testing.T) {
|
|
ub := &urlBuilder{
|
|
ResourceURI: strPtr("/subscriptions/sub/resource/uri"),
|
|
DefaultSubscription: strPtr("default-sub"),
|
|
ResourceGroup: strPtr("rg"),
|
|
MetricNamespace: strPtr("Microsoft.NetApp/netAppAccounts/capacityPools/volumes"),
|
|
ResourceName: strPtr("rn1/rn2/rn3"),
|
|
}
|
|
|
|
url, err := ub.buildResourceURI()
|
|
assert.Nil(t, err)
|
|
assert.Equal(t, "/subscriptions/sub/resource/uri", *url)
|
|
})
|
|
|
|
t.Run("Legacy URL Builder params", func(t *testing.T) {
|
|
t.Run("when metric definition is in the short form", func(t *testing.T) {
|
|
ub := &urlBuilder{
|
|
DefaultSubscription: strPtr("default-sub"),
|
|
ResourceGroup: strPtr("rg"),
|
|
MetricNamespace: strPtr("Microsoft.Compute/virtualMachines"),
|
|
ResourceName: strPtr("rn"),
|
|
}
|
|
|
|
url, err := ub.buildResourceURI()
|
|
assert.Nil(t, err)
|
|
assert.Equal(t, "/subscriptions/default-sub/resourceGroups/rg/providers/Microsoft.Compute/virtualMachines/rn", *url)
|
|
})
|
|
})
|
|
|
|
t.Run("when metric definition is in the short form and a subscription is defined", func(t *testing.T) {
|
|
ub := &urlBuilder{
|
|
DefaultSubscription: strPtr("default-sub"),
|
|
Subscription: strPtr("specified-sub"),
|
|
ResourceGroup: strPtr("rg"),
|
|
MetricNamespace: strPtr("Microsoft.Compute/virtualMachines"),
|
|
ResourceName: strPtr("rn"),
|
|
}
|
|
|
|
url, err := ub.buildResourceURI()
|
|
assert.Nil(t, err)
|
|
assert.Equal(t, "/subscriptions/specified-sub/resourceGroups/rg/providers/Microsoft.Compute/virtualMachines/rn", *url)
|
|
})
|
|
|
|
t.Run("when metric definition is Microsoft.Storage/storageAccounts/blobServices", func(t *testing.T) {
|
|
ub := &urlBuilder{
|
|
DefaultSubscription: strPtr("default-sub"),
|
|
ResourceGroup: strPtr("rg"),
|
|
MetricNamespace: strPtr("Microsoft.Storage/storageAccounts/blobServices"),
|
|
ResourceName: strPtr("rn1"),
|
|
}
|
|
|
|
result, err := ub.buildResourceURI()
|
|
if err != nil {
|
|
return
|
|
}
|
|
url := *result
|
|
assert.Equal(t, "/subscriptions/default-sub/resourceGroups/rg/providers/Microsoft.Storage/storageAccounts/rn1/blobServices/default", url)
|
|
})
|
|
|
|
t.Run("when metric definition is Microsoft.Storage/storageAccounts/tableServices", func(t *testing.T) {
|
|
ub := &urlBuilder{
|
|
DefaultSubscription: strPtr("default-sub"),
|
|
ResourceGroup: strPtr("rg"),
|
|
MetricNamespace: strPtr("Microsoft.Storage/storageAccounts/tableServices"),
|
|
ResourceName: strPtr("rn1/default"),
|
|
}
|
|
|
|
url, err := ub.buildResourceURI()
|
|
assert.Nil(t, err)
|
|
assert.Equal(t, "/subscriptions/default-sub/resourceGroups/rg/providers/Microsoft.Storage/storageAccounts/rn1/tableServices/default", *url)
|
|
})
|
|
|
|
t.Run("when metric definition is Microsoft.Storage/storageAccounts/fileServices", func(t *testing.T) {
|
|
ub := &urlBuilder{
|
|
DefaultSubscription: strPtr("default-sub"),
|
|
ResourceGroup: strPtr("rg"),
|
|
MetricNamespace: strPtr("Microsoft.Storage/storageAccounts/fileServices"),
|
|
ResourceName: strPtr("rn1/default"),
|
|
}
|
|
|
|
url, err := ub.buildResourceURI()
|
|
assert.Nil(t, err)
|
|
assert.Equal(t, "/subscriptions/default-sub/resourceGroups/rg/providers/Microsoft.Storage/storageAccounts/rn1/fileServices/default", *url)
|
|
})
|
|
|
|
t.Run("when metric definition is Microsoft.NetApp/netAppAccounts/capacityPools/volumes", func(t *testing.T) {
|
|
ub := &urlBuilder{
|
|
DefaultSubscription: strPtr("default-sub"),
|
|
ResourceGroup: strPtr("rg"),
|
|
MetricNamespace: strPtr("Microsoft.NetApp/netAppAccounts/capacityPools/volumes"),
|
|
ResourceName: strPtr("rn1/rn2/rn3"),
|
|
}
|
|
|
|
url, err := ub.buildResourceURI()
|
|
assert.Nil(t, err)
|
|
assert.Equal(t, "/subscriptions/default-sub/resourceGroups/rg/providers/Microsoft.NetApp/netAppAccounts/rn1/capacityPools/rn2/volumes/rn3", *url)
|
|
})
|
|
|
|
t.Run("when metricDefinition or metricNamespace is not defined an error is thrown", func(t *testing.T) {
|
|
ub := &urlBuilder{}
|
|
|
|
_, err := ub.buildResourceURI()
|
|
if err == nil {
|
|
t.Errorf("Expected an error, but got nil")
|
|
} else {
|
|
expectedErrorMessage := "no metricNamespace or metricDefiniton value provided"
|
|
if err.Error() != expectedErrorMessage {
|
|
t.Errorf("Expected error message %s, but got %s", expectedErrorMessage, err.Error())
|
|
}
|
|
}
|
|
})
|
|
})
|
|
}
|